Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
6c9ef6b4ef | ||
|
|
6a56e39fa3 |
57
docs/issue-693-verification.md
Normal file
57
docs/issue-693-verification.md
Normal file
@@ -0,0 +1,57 @@
|
||||
# Issue #693 Verification
|
||||
|
||||
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #693 asked for an encrypted backup pipeline for fleet state with three acceptance criteria:
|
||||
- Nightly backup of ~/.hermes to encrypted archive
|
||||
- Upload to S3-compatible storage (or local NAS)
|
||||
- Restore playbook tested end-to-end
|
||||
|
||||
All three are already satisfied on `main` in a fresh clone of `timmy-home`.
|
||||
|
||||
## Mainline evidence
|
||||
|
||||
Repo artifacts already present on `main`:
|
||||
- `scripts/backup_pipeline.sh`
|
||||
- `scripts/restore_backup.sh`
|
||||
- `tests/test_backup_pipeline.py`
|
||||
|
||||
What those artifacts already prove:
|
||||
- `scripts/backup_pipeline.sh` archives `~/.hermes` by default via `BACKUP_SOURCE_DIR="${BACKUP_SOURCE_DIR:-${HOME}/.hermes}"`
|
||||
- the backup archive is encrypted with `openssl enc -aes-256-cbc -salt -pbkdf2 -iter 200000`
|
||||
- uploads are supported to either `BACKUP_S3_URI` or `BACKUP_NAS_TARGET`
|
||||
- the script refuses to run without a remote target, preventing fake-local-only success
|
||||
- `scripts/restore_backup.sh` verifies the archive SHA256 against the manifest when present, decrypts the archive, and restores it to a caller-provided root
|
||||
- `tests/test_backup_pipeline.py` exercises the backup + restore round-trip and asserts plaintext tarballs do not leak into backup destinations
|
||||
|
||||
## Acceptance criteria check
|
||||
|
||||
1. ✅ Nightly backup of ~/.hermes to encrypted archive
|
||||
- the pipeline targets `~/.hermes` by default and is explicitly described as a nightly encrypted Hermes backup pipeline
|
||||
2. ✅ Upload to S3-compatible storage (or local NAS)
|
||||
- the script supports `BACKUP_S3_URI` and `BACKUP_NAS_TARGET`
|
||||
3. ✅ Restore playbook tested end-to-end
|
||||
- `tests/test_backup_pipeline.py` performs a full encrypted backup then restore round-trip and compares restored contents byte-for-byte
|
||||
|
||||
## Historical trail
|
||||
|
||||
- PR #707 first shipped the encrypted backup pipeline on branch `fix/693`
|
||||
- PR #768 later re-shipped the same feature on branch `fix/693-backup-pipeline`
|
||||
- both PRs are now closed unmerged, but the requested backup pipeline is present on `main` today and passes targeted verification from a fresh clone
|
||||
- issue comment history already contains a pointer to PR #707
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m unittest discover -s tests -p 'test_backup_pipeline.py' -v`
|
||||
- `bash -n scripts/backup_pipeline.sh scripts/restore_backup.sh`
|
||||
|
||||
Observed result:
|
||||
- both backup pipeline unit/integration tests pass
|
||||
- both shell scripts parse cleanly
|
||||
- the repo already contains the encrypted backup pipeline, restore script, and tested round-trip coverage requested by issue #693
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #693 as already implemented on `main`.
|
||||
This verification PR exists only to preserve the evidence trail cleanly and close the stale issue without rebuilding the backup pipeline again.
|
||||
23
tests/test_issue_693_verification.py
Normal file
23
tests/test_issue_693_verification.py
Normal file
@@ -0,0 +1,23 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_693_verification_doc_exists_with_mainline_backup_evidence() -> None:
|
||||
text = Path("docs/issue-693-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #693 Verification",
|
||||
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
|
||||
"scripts/backup_pipeline.sh",
|
||||
"scripts/restore_backup.sh",
|
||||
"tests/test_backup_pipeline.py",
|
||||
"Nightly backup of ~/.hermes to encrypted archive",
|
||||
"Upload to S3-compatible storage (or local NAS)",
|
||||
"Restore playbook tested end-to-end",
|
||||
"PR #707",
|
||||
"PR #768",
|
||||
"python3 -m unittest discover -s tests -p 'test_backup_pipeline.py' -v",
|
||||
"bash -n scripts/backup_pipeline.sh scripts/restore_backup.sh",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
Reference in New Issue
Block a user