Compare commits
1 Commits
fix/567
...
sprint/iss
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5e2ced8812 |
@@ -1,47 +0,0 @@
|
||||
# Issue #567 Verification
|
||||
|
||||
## Status: ✅ ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #567 asked for four things:
|
||||
1. an architecture doc at `evennia-mind-palace.md`
|
||||
2. a mapping of the 16 tracked Evennia issues to the mind-palace layers
|
||||
3. Milestone 1 proof: one room, one object, one mutable fact wired to Timmy's burn cycle
|
||||
4. a comment on the issue with proof of room entry injecting context
|
||||
|
||||
All four are already present on `main` in a fresh clone of `timmy-home`.
|
||||
|
||||
## Mainline Evidence
|
||||
|
||||
### Repo artifacts already on main
|
||||
- `evennia-mind-palace.md`
|
||||
- `evennia_tools/mind_palace.py`
|
||||
- `scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
- `tests/test_evennia_mind_palace.py`
|
||||
- `tests/test_evennia_mind_palace_doc.py`
|
||||
|
||||
### Acceptance criteria check
|
||||
- Architecture doc exists at `evennia-mind-palace.md`
|
||||
- The 16 tracked Evennia issues are mapped in the issue-to-layer table inside `evennia-mind-palace.md`
|
||||
- Milestone 1 is implemented in `evennia_tools/mind_palace.py` with `Hall of Knowledge`, `The Ledger`, `MutableFact`, `BurnCycleSnapshot`, and deterministic room-entry rendering
|
||||
- The proof comment already exists on the issue as issue comment #56965
|
||||
|
||||
## Historical trail
|
||||
- PR #711 attempted the issue and posted the room-entry proof comment
|
||||
- PR #711 was later closed unmerged, but the requested deliverables are present on `main` today and pass targeted verification from a fresh clone
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q`
|
||||
- `python3 -m py_compile evennia_tools/mind_palace.py scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
- `python3 scripts/evennia/render_mind_palace_entry_proof.py`
|
||||
|
||||
Observed result:
|
||||
- all targeted Evennia mind-palace tests passed
|
||||
- the Python modules compiled cleanly
|
||||
- the proof script emitted the expected `ENTER Hall of Knowledge` packet with room context, ledger fact, and Timmy burn-cycle focus
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #567 as already implemented on `main`.
|
||||
This verification PR exists only to document the evidence trail cleanly and close the stale issue without re-implementing the already-landed architecture.
|
||||
35
docs/issue-648-verification.md
Normal file
35
docs/issue-648-verification.md
Normal file
@@ -0,0 +1,35 @@
|
||||
# Issue #648 Verification — Session Harvest Report
|
||||
|
||||
**Date:** 2026-04-14
|
||||
**Verified by:** Timmy-Sprint
|
||||
**Issue:** timmy-home #648 — session harvest report
|
||||
|
||||
## Conclusion
|
||||
|
||||
Issue #648 deliverables already exist on `main`. No re-implementation needed.
|
||||
|
||||
## What exists on `main`
|
||||
|
||||
1. **Session harvest report artifact**
|
||||
`reports/production/2026-04-14-session-harvest-report.md` — present and complete with all required sections.
|
||||
|
||||
2. **Regression test**
|
||||
`tests/test_session_harvest_report_2026_04_14.py` — present, covers:
|
||||
- report file existence
|
||||
- required heading sections
|
||||
- verified PR references and state-drift notes
|
||||
- follow-up issue state changes
|
||||
|
||||
## Fresh verification run
|
||||
|
||||
Cloned `main` from scratch, ran:
|
||||
|
||||
```
|
||||
python3 -m pytest tests/test_session_harvest_report_2026_04_14.py -q
|
||||
```
|
||||
|
||||
All tests pass. The artifact and its regression test are in place.
|
||||
|
||||
## Action
|
||||
|
||||
Issue #648 is a zombie — the work was completed but the issue was never closed. This verification note ties the existing artifact back to the original issue so it can be closed without re-doing work.
|
||||
@@ -1,21 +0,0 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_567_verification_doc_exists_with_mainline_evidence() -> None:
|
||||
text = Path("docs/issue-567-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #567 Verification",
|
||||
"## Status: ✅ ALREADY IMPLEMENTED ON MAIN",
|
||||
"evennia-mind-palace.md",
|
||||
"evennia_tools/mind_palace.py",
|
||||
"scripts/evennia/render_mind_palace_entry_proof.py",
|
||||
"tests/test_evennia_mind_palace.py",
|
||||
"tests/test_evennia_mind_palace_doc.py",
|
||||
"PR #711",
|
||||
"issue comment #56965",
|
||||
"python3 -m pytest tests/test_evennia_layout.py tests/test_evennia_telemetry.py tests/test_evennia_training.py tests/test_evennia_mind_palace.py tests/test_evennia_mind_palace_doc.py -q",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
31
tests/test_issue_648_verification.py
Normal file
31
tests/test_issue_648_verification.py
Normal file
@@ -0,0 +1,31 @@
|
||||
"""Regression test: verify issue #648 deliverables exist on main."""
|
||||
|
||||
from pathlib import Path
|
||||
|
||||
DOCS = Path('docs/issue-648-verification.md')
|
||||
REPORT = Path('reports/production/2026-04-14-session-harvest-report.md')
|
||||
TEST = Path('tests/test_session_harvest_report_2026_04_14.py')
|
||||
|
||||
|
||||
def test_verification_doc_exists():
|
||||
assert DOCS.exists(), 'docs/issue-648-verification.md must exist'
|
||||
|
||||
|
||||
def test_verification_doc_has_required_content():
|
||||
text = DOCS.read_text(encoding='utf-8')
|
||||
for token in [
|
||||
'#648',
|
||||
'session harvest report',
|
||||
'main',
|
||||
'zombie',
|
||||
'already exist',
|
||||
]:
|
||||
assert token in text, f'Missing token: {token}'
|
||||
|
||||
|
||||
def test_session_harvest_report_exists():
|
||||
assert REPORT.exists(), 'Session harvest report artifact must exist'
|
||||
|
||||
|
||||
def test_session_harvest_test_exists():
|
||||
assert TEST.exists(), 'Session harvest regression test must exist'
|
||||
Reference in New Issue
Block a user