Compare commits
2 Commits
sprint/iss
...
fix/582
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
08ceb99cac | ||
|
|
6a8d8d8392 |
@@ -1,40 +0,0 @@
|
||||
# Issue #545 Verification — Grounded Slice Already on Main
|
||||
|
||||
**Date:** 2025-01-16
|
||||
**Refs:** #545, #719, #57028
|
||||
**Purpose:** Prevent duplicate reimplementation of the unreachable-horizon grounded slice.
|
||||
|
||||
## What is already on main
|
||||
|
||||
| Artifact | Path | Status |
|
||||
|----------|------|--------|
|
||||
| Unreachable horizon report | `docs/UNREACHABLE_HORIZON_1M_MEN.md` | Committed |
|
||||
| Horizon computation script | `scripts/unreachable_horizon.py` | Committed |
|
||||
| Existing test coverage | `tests/test_unreachable_horizon.py` | Committed |
|
||||
|
||||
## Evidence trail
|
||||
|
||||
- **PR #719** — introduced the grounded unreachable-horizon slice (script, doc, tests)
|
||||
- **Issue comment #57028** — documented the verification steps and confirmed the slice landed on `main`
|
||||
|
||||
## Why this issue uses Refs, not Closes
|
||||
|
||||
Issue #545 is a *horizon issue* — a compass toward greater sovereignty, not a bugfix with a fully reachable completion state.
|
||||
|
||||
The grounded slice already exists on `main`:
|
||||
|
||||
1. `scripts/unreachable_horizon.py` computes whether the 1M-men-in-crisis horizon is reachable on the current machine.
|
||||
2. `docs/UNREACHABLE_HORIZON_1M_MEN.md` renders the result as a grounded report.
|
||||
3. `tests/test_unreachable_horizon.py` keeps the evidence trail durable in-repo.
|
||||
|
||||
This PR adds a verification document and a dedicated test so future workers do not rebuild the same report from scratch.
|
||||
|
||||
The horizon itself remains open by design.
|
||||
|
||||
## Verification commands
|
||||
|
||||
```bash
|
||||
python3 -m pytest tests/test_issue_545_verification.py tests/test_unreachable_horizon.py -q
|
||||
python3 -m py_compile scripts/unreachable_horizon.py
|
||||
python3 scripts/unreachable_horizon.py
|
||||
```
|
||||
57
docs/issue-582-verification.md
Normal file
57
docs/issue-582-verification.md
Normal file
@@ -0,0 +1,57 @@
|
||||
# Issue #582 Verification
|
||||
|
||||
## Status: ✅ EPIC SLICE ALREADY IMPLEMENTED ON MAIN
|
||||
|
||||
Issue #582 is a parent epic, not a single atomic feature. The repo already contains the epic-level operational slice that ties the merged Know Thy Father phases together, but the epic remains open because fully consuming the local archive and wiring every downstream memory path is a larger horizon than this one slice.
|
||||
|
||||
## Mainline evidence
|
||||
|
||||
The parent-epic operational slice is already present on `main` in a fresh clone:
|
||||
- `scripts/know_thy_father/epic_pipeline.py`
|
||||
- `docs/KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md`
|
||||
- `tests/test_know_thy_father_pipeline.py`
|
||||
|
||||
What that slice already does:
|
||||
- enumerates the current source-of-truth scripts for all Know Thy Father phases
|
||||
- provides one operational runner/status view for the epic
|
||||
- preserves the split implementation truth across `scripts/know_thy_father/`, `scripts/twitter_archive/analyze_media.py`, and `twitter-archive/know-thy-father/tracker.py`
|
||||
- gives the epic a single orchestration spine without falsely claiming the full archive is already processed end-to-end
|
||||
|
||||
## Phase evidence already merged on main
|
||||
|
||||
The four decomposed phase lanes named by the epic already have merged implementation coverage on `main`:
|
||||
- PR #639 — Phase 1 media indexing
|
||||
- PR #630 — Phase 2 multimodal analysis pipeline
|
||||
- PR #631 — Phase 3 holographic synthesis
|
||||
- PR #637 — Phase 4 cross-reference audit
|
||||
- PR #641 — additional Phase 2 multimodal analysis coverage
|
||||
|
||||
## Historical trail for the epic-level slice
|
||||
|
||||
- PR #738 shipped the parent-epic orchestrator/status slice on branch `fix/582`
|
||||
- issue comment #57259 already points to that orchestrator/status slice and explains why it used `Refs #582`
|
||||
- PR #738 is now closed unmerged, but the epic-level runner/doc/test trio is present on `main` today and passes targeted verification from a fresh clone
|
||||
|
||||
## Verification run from fresh clone
|
||||
|
||||
Commands executed:
|
||||
- `python3 -m pytest tests/test_know_thy_father_pipeline.py tests/test_know_thy_father_index.py tests/test_know_thy_father_synthesis.py tests/test_know_thy_father_crossref.py tests/twitter_archive/test_ktf_tracker.py tests/twitter_archive/test_analyze_media.py -q`
|
||||
|
||||
Observed result:
|
||||
- the orchestrator/doc tests pass
|
||||
- the phase-level index, synthesis, cross-reference, tracker, and media-analysis tests pass
|
||||
- the repo already contains a working parent-epic operational spine plus merged phase implementations
|
||||
|
||||
## Why the epic remains open
|
||||
|
||||
The epic remains open because this verification only proves the current repo-side operational slice is already implemented on main. It does not claim:
|
||||
- the full local archive has been consumed
|
||||
- all pending media has been processed
|
||||
- every extracted kernel has been ingested into downstream memory systems
|
||||
- the broader multimodal consumption mission is complete
|
||||
|
||||
## Recommendation
|
||||
|
||||
Do not rebuild the same epic-level orchestrator again.
|
||||
Use the existing mainline slice (`scripts/know_thy_father/epic_pipeline.py` + `docs/KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md`) as the parent-epic operational entrypoint.
|
||||
This verification PR exists to preserve the evidence trail cleanly while making it explicit that the epic remains open for future end-to-end progress.
|
||||
@@ -1,42 +0,0 @@
|
||||
"""Durable evidence trail: grounded unreachable-horizon slice is on main.
|
||||
|
||||
Refs #545, #719, #57028.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
|
||||
EXPECTED_ARTIFACTS = (
|
||||
ROOT / "docs" / "UNREACHABLE_HORIZON_1M_MEN.md",
|
||||
ROOT / "scripts" / "unreachable_horizon.py",
|
||||
ROOT / "tests" / "test_unreachable_horizon.py",
|
||||
ROOT / "docs" / "issue-545-verification.md",
|
||||
)
|
||||
|
||||
|
||||
def test_all_grounding_artifacts_exist() -> None:
|
||||
"""Every artifact that grounds #545 must be present on disk."""
|
||||
missing = [str(p.relative_to(ROOT)) for p in EXPECTED_ARTIFACTS if not p.exists()]
|
||||
assert not missing, f"missing grounding artifacts: {missing}"
|
||||
|
||||
|
||||
def test_unreachable_horizon_script_is_syntactically_valid() -> None:
|
||||
"""The horizon script must compile without errors."""
|
||||
import py_compile
|
||||
|
||||
script = ROOT / "scripts" / "unreachable_horizon.py"
|
||||
assert script.exists(), "scripts/unreachable_horizon.py is missing"
|
||||
py_compile.compile(str(script), doraise=True)
|
||||
|
||||
|
||||
def test_verification_doc_references_prior_evidence() -> None:
|
||||
"""The verification doc must cite PR #719 and issue comment #57028."""
|
||||
doc = ROOT / "docs" / "issue-545-verification.md"
|
||||
assert doc.exists(), "docs/issue-545-verification.md is missing"
|
||||
text = doc.read_text(encoding="utf-8")
|
||||
assert "#719" in text, "verification doc must reference PR #719"
|
||||
assert "#57028" in text, "verification doc must reference issue comment #57028"
|
||||
25
tests/test_issue_582_verification.py
Normal file
25
tests/test_issue_582_verification.py
Normal file
@@ -0,0 +1,25 @@
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
def test_issue_582_verification_doc_exists_with_epic_slice_evidence() -> None:
|
||||
text = Path("docs/issue-582-verification.md").read_text(encoding="utf-8")
|
||||
|
||||
required_snippets = [
|
||||
"# Issue #582 Verification",
|
||||
"## Status: ✅ EPIC SLICE ALREADY IMPLEMENTED ON MAIN",
|
||||
"scripts/know_thy_father/epic_pipeline.py",
|
||||
"docs/KNOW_THY_FATHER_MULTIMODAL_PIPELINE.md",
|
||||
"tests/test_know_thy_father_pipeline.py",
|
||||
"PR #639",
|
||||
"PR #630",
|
||||
"PR #631",
|
||||
"PR #637",
|
||||
"PR #641",
|
||||
"PR #738",
|
||||
"issue comment #57259",
|
||||
"python3 -m pytest tests/test_know_thy_father_pipeline.py tests/test_know_thy_father_index.py tests/test_know_thy_father_synthesis.py tests/test_know_thy_father_crossref.py tests/twitter_archive/test_ktf_tracker.py tests/twitter_archive/test_analyze_media.py -q",
|
||||
"epic remains open",
|
||||
]
|
||||
|
||||
missing = [snippet for snippet in required_snippets if snippet not in text]
|
||||
assert not missing, missing
|
||||
Reference in New Issue
Block a user