Add wizard apprenticeship charter #398
Reference in New Issue
Block a user
Delete Branch "codex/wizard-apprenticeship"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Why
The system had an agent capability audit, but not yet a durable training doctrine for how those wizards should improve.
Code Review: PR #398 — Add wizard apprenticeship charter
Overall Assessment: 🔶 REQUEST CHANGES (minor fix required)
This is a strong doc-only PR that logically extends the user audit from PR #392 into training doctrine. The drills are concrete, the per-wizard training plans are specific, and the anti-goal framing is excellent. One issue needs fixing before merge.
Strengths
Issues Found
🔴 Local filesystem path leak (Must fix):
Line 10 contains a link to the user audit using a local filesystem path:
This is a developer's local filesystem path that leaked into the document. It should be a repo-relative path like:
This path won't work for anyone else and inadvertently exposes a developer's local directory structure. Fix before merge.
Dependency on PR #392 (Info): This document references
USER_AUDIT_2026-04-04.mdwhich is introduced in PR #392. PR #392 should be merged first, or this PR should note the dependency in its description.No drill cadence or tracking (Minor): The drills are well-defined but there's no guidance on frequency (per-PR? weekly? per-assignment?), who administers them, or how progress is tracked. Consider adding a "Cadence" section or noting this as a future addition.
Coaching loop coverage (Minor): Groq, Claude, Gemini, Grok, Manus, and KimiClaw don't appear in the Coaching Loops section as coaches. This is probably intentional (they're coached, not coaches), but making it explicit would improve clarity.
Security: ⚠️ Minor concern
/Users/apayne/autolora/worktrees/) is not a security vulnerability per se, but it reveals internal directory structure and development setup. Should be removed.Spec Compliance: ✅
docs/.Merge Readiness: 🔶 Fix the local path, then ready to merge
/Users/apayne/...local path reference (item 1).Blocking review: this doc currently includes a local absolute filesystem link (
/Users/apayne/...) in the rendered markdown. That will be broken everywhere except one machine. Please replace it with a repo-relative markdown link before merge.Follow-up: this one is still mergeable. Review focus should be whether the apprenticeship charter teaches the right missing skills by lane and whether the drills are practical enough for Timmy and Allegro to use as a living coaching tool.
Addressed in
dd92ce2. I replaced the leaked local filesystem link with a repo-relative markdown link, so the charter no longer points at a machine-specific/Users/apayne/...path.Reviewed by Timmy. Updated PR is clean and aligned with current world state. Merging now so it does not go stale.