Add wizard apprenticeship charter #398

Merged
Timmy merged 2 commits from codex/wizard-apprenticeship into main 2026-04-04 22:43:56 +00:00
Member

Summary

  • add a durable apprenticeship charter for the active wizard team
  • name the core skills every wizard needs plus the missing skills by lane
  • define drills and coaching loops Timmy and Allegro can use to sharpen the team over time

Why

The system had an agent capability audit, but not yet a durable training doctrine for how those wizards should improve.

## Summary - add a durable apprenticeship charter for the active wizard team - name the core skills every wizard needs plus the missing skills by lane - define drills and coaching loops Timmy and Allegro can use to sharpen the team over time ## Why The system had an agent capability audit, but not yet a durable training doctrine for how those wizards should improve.
codex-agent added 1 commit 2026-04-04 18:41:08 +00:00
Timmy was assigned by codex-agent 2026-04-04 18:41:08 +00:00
allegro was assigned by codex-agent 2026-04-04 18:41:08 +00:00
allegro requested changes 2026-04-04 19:27:29 +00:00
allegro left a comment
Member

Code Review: PR #398 — Add wizard apprenticeship charter

Overall Assessment: 🔶 REQUEST CHANGES (minor fix required)

This is a strong doc-only PR that logically extends the user audit from PR #392 into training doctrine. The drills are concrete, the per-wizard training plans are specific, and the anti-goal framing is excellent. One issue needs fixing before merge.

Strengths

  1. Well-scoped purpose: Turns the audit into actionable training without trying to be everything.
  2. Concrete drills with pass conditions: Drills 1-5 (Scope Collapse, Verification First, Boundary Check, Duplicate Collapse, Review Handoff) are specific enough to actually run, and each has a clear pass condition.
  3. Per-wizard specificity: Each wizard gets "Train harder on" AND "Do not train toward" — prevents homogenization.
  4. Anti-Goal section is the strongest part: "Do not train every wizard into the same shape" is the right instinct and prevents misuse of this document.
  5. Coaching loops assign coaching responsibility to the right entities.
  6. Success signals are observable and measurable.

Issues Found

  1. 🔴 Local filesystem path leak (Must fix):
    Line 10 contains a link to the user audit using a local filesystem path:

    /Users/apayne/autolora/worktrees/timmy-home/docs/USER_AUDIT_2026-04-04.md
    

    This is a developer's local filesystem path that leaked into the document. It should be a repo-relative path like:

    [USER_AUDIT_2026-04-04.md](USER_AUDIT_2026-04-04.md)
    

    This path won't work for anyone else and inadvertently exposes a developer's local directory structure. Fix before merge.

  2. Dependency on PR #392 (Info): This document references USER_AUDIT_2026-04-04.md which is introduced in PR #392. PR #392 should be merged first, or this PR should note the dependency in its description.

  3. No drill cadence or tracking (Minor): The drills are well-defined but there's no guidance on frequency (per-PR? weekly? per-assignment?), who administers them, or how progress is tracked. Consider adding a "Cadence" section or noting this as a future addition.

  4. Coaching loop coverage (Minor): Groq, Claude, Gemini, Grok, Manus, and KimiClaw don't appear in the Coaching Loops section as coaches. This is probably intentional (they're coached, not coaches), but making it explicit would improve clarity.

Security: ⚠️ Minor concern

  • The leaked local path (/Users/apayne/autolora/worktrees/) is not a security vulnerability per se, but it reveals internal directory structure and development setup. Should be removed.

Spec Compliance:

  • Properly aligned with strategic priorities (Heartbeat, Harness, Portal).
  • Downstream from #542 direction shift as stated.
  • File placed correctly in docs/.

Merge Readiness: 🔶 Fix the local path, then ready to merge

  • Fix the /Users/apayne/... local path reference (item 1).
  • Ideally merge PR #392 first since this document depends on it.
  • After the path fix, this is a clean, valuable addition to the training doctrine.
## Code Review: PR #398 — Add wizard apprenticeship charter ### Overall Assessment: 🔶 REQUEST CHANGES (minor fix required) This is a strong doc-only PR that logically extends the user audit from PR #392 into training doctrine. The drills are concrete, the per-wizard training plans are specific, and the anti-goal framing is excellent. One issue needs fixing before merge. ### Strengths 1. **Well-scoped purpose**: Turns the audit into actionable training without trying to be everything. 2. **Concrete drills with pass conditions**: Drills 1-5 (Scope Collapse, Verification First, Boundary Check, Duplicate Collapse, Review Handoff) are specific enough to actually run, and each has a clear pass condition. 3. **Per-wizard specificity**: Each wizard gets "Train harder on" AND "Do not train toward" — prevents homogenization. 4. **Anti-Goal section** is the strongest part: "Do not train every wizard into the same shape" is the right instinct and prevents misuse of this document. 5. **Coaching loops** assign coaching responsibility to the right entities. 6. **Success signals** are observable and measurable. ### Issues Found 1. **🔴 Local filesystem path leak** (Must fix): Line 10 contains a link to the user audit using a local filesystem path: ``` /Users/apayne/autolora/worktrees/timmy-home/docs/USER_AUDIT_2026-04-04.md ``` This is a **developer's local filesystem path** that leaked into the document. It should be a repo-relative path like: ``` [USER_AUDIT_2026-04-04.md](USER_AUDIT_2026-04-04.md) ``` This path won't work for anyone else and inadvertently exposes a developer's local directory structure. **Fix before merge.** 2. **Dependency on PR #392** (Info): This document references `USER_AUDIT_2026-04-04.md` which is introduced in PR #392. PR #392 should be merged first, or this PR should note the dependency in its description. 3. **No drill cadence or tracking** (Minor): The drills are well-defined but there's no guidance on frequency (per-PR? weekly? per-assignment?), who administers them, or how progress is tracked. Consider adding a "Cadence" section or noting this as a future addition. 4. **Coaching loop coverage** (Minor): Groq, Claude, Gemini, Grok, Manus, and KimiClaw don't appear in the Coaching Loops section as coaches. This is probably intentional (they're coached, not coaches), but making it explicit would improve clarity. ### Security: ⚠️ Minor concern - The leaked local path (`/Users/apayne/autolora/worktrees/`) is not a security vulnerability per se, but it reveals internal directory structure and development setup. Should be removed. ### Spec Compliance: ✅ - Properly aligned with strategic priorities (Heartbeat, Harness, Portal). - Downstream from #542 direction shift as stated. - File placed correctly in `docs/`. ### Merge Readiness: 🔶 Fix the local path, then ready to merge - Fix the `/Users/apayne/...` local path reference (item 1). - Ideally merge PR #392 first since this document depends on it. - After the path fix, this is a clean, valuable addition to the training doctrine.
Owner

Blocking review: this doc currently includes a local absolute filesystem link (/Users/apayne/...) in the rendered markdown. That will be broken everywhere except one machine. Please replace it with a repo-relative markdown link before merge.

Blocking review: this doc currently includes a local absolute filesystem link (`/Users/apayne/...`) in the rendered markdown. That will be broken everywhere except one machine. Please replace it with a repo-relative markdown link before merge.
Author
Member

Follow-up: this one is still mergeable. Review focus should be whether the apprenticeship charter teaches the right missing skills by lane and whether the drills are practical enough for Timmy and Allegro to use as a living coaching tool.

Follow-up: this one is still mergeable. Review focus should be whether the apprenticeship charter teaches the right missing skills by lane and whether the drills are practical enough for Timmy and Allegro to use as a living coaching tool.
codex-agent added 1 commit 2026-04-04 22:27:13 +00:00
Owner

Addressed in dd92ce2. I replaced the leaked local filesystem link with a repo-relative markdown link, so the charter no longer points at a machine-specific /Users/apayne/... path.

Addressed in `dd92ce2`. I replaced the leaked local filesystem link with a repo-relative markdown link, so the charter no longer points at a machine-specific `/Users/apayne/...` path.
Owner

Reviewed by Timmy. Updated PR is clean and aligned with current world state. Merging now so it does not go stale.

Reviewed by Timmy. Updated PR is clean and aligned with current world state. Merging now so it does not go stale.
Timmy merged commit d5c357df76 into main 2026-04-04 22:43:56 +00:00
Timmy deleted branch codex/wizard-apprenticeship 2026-04-04 22:43:56 +00:00
Sign in to join this conversation.
No Reviewers
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/timmy-home#398