Timmy_Foundation/timmy-home
15
0
Fork 0
Code Issues 224 Pull Requests 120 Actions Packages Projects Releases Wiki Activity

feat: add tower npc-npc relationships (#515) #854

Open
Rockachopa wants to merge 2 commits from fix/515 into main
pull from: fix/515
merge into: Timmy_Foundation:main
Conversation 3 Commits 2 Files Changed 2 +174
Rockachopa commented 2026-04-22 06:15:26 +00:00
Owner
Copy Link

Closes #515

Summary:

  • seed each Tower-world NPC with trust values for every other NPC
  • add offscreen NPC-NPC relationship scenes when Timmy is not present
  • let Marcus/Kimi friendship and Bezalel/ClawCode tension cross visible thresholds in-world
  • expose those relationship milestones in room descriptions so the social graph is inspectable by proximity

Verification:

  • python3 -m pytest tests/test_tower_game_npc_relationships.py tests/test_evennia_local_world_game.py -q
  • python3 -m py_compile evennia/timmy_world/game.py tests/test_tower_game_npc_relationships.py

Acceptance criteria checked:

  • each NPC now carries trust entries for all other NPCs
  • NPCs converse when Timmy is absent
  • at least one friendship emerges
  • at least one tension emerges
Closes #515 Summary: - seed each Tower-world NPC with trust values for every other NPC - add offscreen NPC-NPC relationship scenes when Timmy is not present - let Marcus/Kimi friendship and Bezalel/ClawCode tension cross visible thresholds in-world - expose those relationship milestones in room descriptions so the social graph is inspectable by proximity Verification: - `python3 -m pytest tests/test_tower_game_npc_relationships.py tests/test_evennia_local_world_game.py -q` - `python3 -m py_compile evennia/timmy_world/game.py tests/test_tower_game_npc_relationships.py` Acceptance criteria checked: - each NPC now carries trust entries for all other NPCs - NPCs converse when Timmy is absent - at least one friendship emerges - at least one tension emerges
Rockachopa added 2 commits 2026-04-22 06:15:26 +00:00
test: define tower npc relationships for #515 289f0410aa
feat: add tower npc relationship graph for #515
Some checks failed
Agent PR Gate / gate (pull_request) Failing after 13s
Details
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 17s
Details
Smoke Test / smoke (pull_request) Failing after 18s
Details
Agent PR Gate / report (pull_request) Successful in 15s
Details
f68f110d0e
gitea-actionsbot commented 2026-04-22 06:27:34 +00:00
Copy Link

Agent PR Gate

Check Status
Syntax / parse skipped
Test suite skipped
PR criteria skipped
Risk level

Failure details

  • syntax reported failure. Inspect the workflow logs for that step.
  • tests reported failure. Inspect the workflow logs for that step.
  • criteria reported failure. Inspect the workflow logs for that step.

Recommendation: human review.
Low-risk documentation/test-only PRs may be auto-merged. Operational changes stay in human review.

## Agent PR Gate | Check | Status | |-------|--------| | Syntax / parse | skipped | | Test suite | skipped | | PR criteria | skipped | | Risk level | | ### Failure details - syntax reported failure. Inspect the workflow logs for that step. - tests reported failure. Inspect the workflow logs for that step. - criteria reported failure. Inspect the workflow logs for that step. Recommendation: human review. Low-risk documentation/test-only PRs may be auto-merged. Operational changes stay in human review.
Rockachopa reviewed 2026-04-22 13:48:34 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Review: APPROVED (with note)

NPC-NPC relationship system is well-designed: trust maps, friendship/tension thresholds, offscreen conversations, milestone recording, and room-description hints.

Note: same hardcoded WORLD_DIR path issue as PR #861 — /Users/apayne/.timmy/evennia/timmy_world. Merge #843 first.

The test properly validates that relationships form and appear in room descriptions. The seed-based initialization with threshold-based milestone triggering is a clean pattern.

**Review: APPROVED (with note)** NPC-NPC relationship system is well-designed: trust maps, friendship/tension thresholds, offscreen conversations, milestone recording, and room-description hints. Note: same hardcoded WORLD_DIR path issue as PR #861 — `/Users/apayne/.timmy/evennia/timmy_world`. Merge #843 first. The test properly validates that relationships form and appear in room descriptions. The seed-based initialization with threshold-based milestone triggering is a clean pattern.
Rockachopa reviewed 2026-04-22 14:13:07 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

VERDICT: APPROVE with note

Adds NPC-to-NPC relationship mechanics to the Evennia game world. The system includes friendship/tension thresholds, seeded relationship pairs (Kimi-Marcus friendship, Bezalel-ClawCode tension), mutual trust adjustment, milestone tracking, and room-aware relationship hints. The implementation is clean: _adjust_mutual_trust clamps to [-1, 1], _record_relationship_milestone deduplicates, and relationship_hint_for_room only shows hints for NPCs currently in the same room. The relationship seeds with their conversation/milestone/hint text add narrative depth.

Same note as PR 861: the hardcoded WORLD_DIR = Path("/Users/apayne/.timmy/evennia/timmy_world") on line 12 should eventually use an env var. Not blocking.

VERDICT: APPROVE with note Adds NPC-to-NPC relationship mechanics to the Evennia game world. The system includes friendship/tension thresholds, seeded relationship pairs (Kimi-Marcus friendship, Bezalel-ClawCode tension), mutual trust adjustment, milestone tracking, and room-aware relationship hints. The implementation is clean: _adjust_mutual_trust clamps to [-1, 1], _record_relationship_milestone deduplicates, and relationship_hint_for_room only shows hints for NPCs currently in the same room. The relationship seeds with their conversation/milestone/hint text add narrative depth. Same note as PR 861: the hardcoded WORLD_DIR = Path("/Users/apayne/.timmy/evennia/timmy_world") on line 12 should eventually use an env var. Not blocking.
Some checks failed
Agent PR Gate / gate (pull_request) Failing after 13s
Details
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 17s
Details
Smoke Test / smoke (pull_request) Failing after 18s
Details
Agent PR Gate / report (pull_request) Successful in 15s
Details
Checking for merge conflicts…
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/515:fix/515
git checkout fix/515
Sign in to join this conversation.
Reviewers
No Reviewers
Rockachopa
Labels
Clear labels
alembic
The Alchemical Vessel - Kimi-powered transformation
 architecture
Auto-created architecture label
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Dispatched to Kimi via OpenClaw
 assigned-sonnet
auth-needed
auth-needed
 batch-pipeline
Token masterplan batch pipeline
 bizzalo
bizzalo
 blocker
blocker
 building
business-dev
AUTO: business-dev label for fleet epics
 claw
Claw Code runtime (Rust)
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 deadline-7am
deadline-7am
 documentation
AUTO: documentation label for fleet epics
 epic
Parent tracking issue
 fleet
formal-methods
golden_bilbo
Bilbo at peak performance - max churn, fast responses
 gtm
AUTO: gtm label for fleet epics
 harness-engineering
Auto-created harness-engineering label
 hiring
AUTO: hiring label for fleet epics
 human-review
incentives
AUTO: incentives label for fleet epics
 intel
Competitive intelligence
 kimi-done
Kimi completed this task
 kimi-in-progress
Kimi is actively working on this
 marketing
AUTO: marketing label for fleet epics
 mathematics
milestone
morning-report
morning-report
 onboarding
AUTO: onboarding label for fleet epics
 partner-program
AUTO: partner-program label for fleet epics
 phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
pricing
AUTO: pricing label for fleet epics
 progression
project
proof
publication
research
resource
runtime
Runtime abstraction layer
 saiyah
Auto-created saiyah label
 sales
AUTO: sales label for fleet epics
 sonnet-ready
study
Learning from external source code
 substratum
The dissolution engine - runtime layer
 substratum:invoke
Trigger Substratum execution
 tension
throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 urgent
urgent
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KimiClaw Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/timmy-home#854
Delete Branch "fix/515"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?