Timmy_Foundation/timmy-home
15
0
Fork 0
Code Issues 224 Pull Requests 120 Actions Packages Projects Releases Wiki Activity

fix: remove hardcoded /Users/apayne path from game engines (#831) #843

Open
Timmy wants to merge 1 commits from sprint/issue-836 into main
pull from: sprint/issue-836
merge into: Timmy_Foundation:main
Conversation 5 Commits 1 Files Changed 2 +2 -2
Timmy commented 2026-04-22 02:23:08 +00:00
Owner
Copy Link
No description provided.
Timmy added 1 commit 2026-04-22 02:23:09 +00:00
fix: remove hardcoded /Users/apayne path from game engines (closes #836)
Some checks failed
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 24s
Details
Smoke Test / smoke (pull_request) Failing after 28s
Details
Agent PR Gate / gate (pull_request) Failing after 54s
Details
Agent PR Gate / report (pull_request) Successful in 24s
Details
07ff716329 
Replace hardcoded WORLD_DIR with environment-variable-configurable path.
Default: ~/.timmy/evennia/timmy_world (uses Path.home(), works on any user)
Override: TIMMY_WORLD_DIR=/custom/path python3 game.py

Files changed:
- evennia/timmy_world/game.py
- evennia/timmy_world/world/game.py
gitea-actionsbot commented 2026-04-22 02:42:15 +00:00
Copy Link

Agent PR Gate

Check Status
Syntax / parse failure
Test suite failure
PR criteria failure
Risk level high

Failure details

  • syntax reported failure. Inspect the workflow logs for that step.
  • tests reported failure. Inspect the workflow logs for that step.
  • criteria reported failure. Inspect the workflow logs for that step.

Recommendation: human review.
Low-risk documentation/test-only PRs may be auto-merged. Operational changes stay in human review.

## Agent PR Gate | Check | Status | |-------|--------| | Syntax / parse | failure | | Test suite | failure | | PR criteria | failure | | Risk level | high | ### Failure details - syntax reported failure. Inspect the workflow logs for that step. - tests reported failure. Inspect the workflow logs for that step. - criteria reported failure. Inspect the workflow logs for that step. Recommendation: human review. Low-risk documentation/test-only PRs may be auto-merged. Operational changes stay in human review.
Rockachopa commented 2026-04-22 02:42:56 +00:00
Owner
Copy Link

🔎 Merge sweep 2026-04-21: not merging this PR in the current sweep. Blocked by failing status checks on head 07ff7163: Agent PR Gate / report (pull_request): pending (Blocked by required conditions); Self-Healing Smoke / self-healing-smoke (pull_request): failure (Failing after 24s); Smoke Test / smoke (pull_request): failure (Failing after 28s); Agent PR Gate / gate (pull_request): failure (Failing after 54s).

🔎 Merge sweep 2026-04-21: not merging this PR in the current sweep. Blocked by failing status checks on head `07ff7163`: Agent PR Gate / report (pull_request): pending (Blocked by required conditions); Self-Healing Smoke / self-healing-smoke (pull_request): failure (Failing after 24s); Smoke Test / smoke (pull_request): failure (Failing after 28s); Agent PR Gate / gate (pull_request): failure (Failing after 54s).
Rockachopa approved these changes 2026-04-22 13:49:06 +00:00
Dismissed
Rockachopa left a comment
Owner
Copy Link

Approved — 2 file(s) changed, +2/-2 lines.
Fix looks targeted and appropriate.

**Approved** — 2 file(s) changed, +2/-2 lines. Fix looks targeted and appropriate.
Rockachopa reviewed 2026-04-22 13:49:40 +00:00
Rockachopa left a comment
Owner
Copy Link

Review: APPROVED

This is the foundational fix that multiple other PRs depend on. Replacing the hardcoded /Users/apayne/.timmy/evennia/timmy_world path with os.environ.get("TIMMY_WORLD_DIR", Path.home() / ".timmy" / "evennia" / "timmy_world") in both evennia/timmy_world/game.py and evennia/timmy_world/world/game.py is correct.

Merge this PR first — PRs #854 and #861 both touch game.py and depend on this fix being in place to avoid reintroducing the hardcoded path.

**Review: APPROVED** This is the foundational fix that multiple other PRs depend on. Replacing the hardcoded `/Users/apayne/.timmy/evennia/timmy_world` path with `os.environ.get("TIMMY_WORLD_DIR", Path.home() / ".timmy" / "evennia" / "timmy_world")` in both `evennia/timmy_world/game.py` and `evennia/timmy_world/world/game.py` is correct. **Merge this PR first** — PRs #854 and #861 both touch game.py and depend on this fix being in place to avoid reintroducing the hardcoded path.
Rockachopa approved these changes 2026-04-22 14:10:13 +00:00
Rockachopa left a comment
Owner
Copy Link

Important fix. Replaces hardcoded /Users/apayne/.timmy/evennia/timmy_world path with os.environ.get("TIMMY_WORLD_DIR", Path.home() / ".timmy" / "evennia" / "timmy_world") in both evennia/timmy_world/game.py and evennia/timmy_world/world/game.py. The environment variable override with sensible default is the correct pattern. This makes the code portable across machines. Both files get the same fix, which is good. Simple, correct, and addresses a real portability issue.

Important fix. Replaces hardcoded /Users/apayne/.timmy/evennia/timmy_world path with os.environ.get("TIMMY_WORLD_DIR", Path.home() / ".timmy" / "evennia" / "timmy_world") in both evennia/timmy_world/game.py and evennia/timmy_world/world/game.py. The environment variable override with sensible default is the correct pattern. This makes the code portable across machines. Both files get the same fix, which is good. Simple, correct, and addresses a real portability issue.
Some checks failed
Self-Healing Smoke / self-healing-smoke (pull_request) Failing after 24s
Details
Smoke Test / smoke (pull_request) Failing after 28s
Details
Agent PR Gate / gate (pull_request) Failing after 54s
Details
Agent PR Gate / report (pull_request) Successful in 24s
Details
Checking for merge conflicts…
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin sprint/issue-836:sprint/issue-836
git checkout sprint/issue-836
Sign in to join this conversation.
Reviewers
No Reviewers
Rockachopa
Labels
Clear labels
alembic
The Alchemical Vessel - Kimi-powered transformation
 architecture
Auto-created architecture label
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Dispatched to Kimi via OpenClaw
 assigned-sonnet
auth-needed
auth-needed
 batch-pipeline
Token masterplan batch pipeline
 bizzalo
bizzalo
 blocker
blocker
 building
business-dev
AUTO: business-dev label for fleet epics
 claw
Claw Code runtime (Rust)
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 deadline-7am
deadline-7am
 documentation
AUTO: documentation label for fleet epics
 epic
Parent tracking issue
 fleet
formal-methods
golden_bilbo
Bilbo at peak performance - max churn, fast responses
 gtm
AUTO: gtm label for fleet epics
 harness-engineering
Auto-created harness-engineering label
 hiring
AUTO: hiring label for fleet epics
 human-review
incentives
AUTO: incentives label for fleet epics
 intel
Competitive intelligence
 kimi-done
Kimi completed this task
 kimi-in-progress
Kimi is actively working on this
 marketing
AUTO: marketing label for fleet epics
 mathematics
milestone
morning-report
morning-report
 onboarding
AUTO: onboarding label for fleet epics
 partner-program
AUTO: partner-program label for fleet epics
 phase-1
phase-2
phase-3
phase-4
phase-5
phase-6
pricing
AUTO: pricing label for fleet epics
 progression
project
proof
publication
research
resource
runtime
Runtime abstraction layer
 saiyah
Auto-created saiyah label
 sales
AUTO: sales label for fleet epics
 sonnet-ready
study
Learning from external source code
 substratum
The dissolution engine - runtime layer
 substratum:invoke
Trigger Substratum execution
 tension
throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 urgent
urgent
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
KimiClaw Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/timmy-home#843
Delete Branch "sprint/issue-836"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?