feat: queue offline pull request reviews (#419)

frontend/authored-outbox.js

@@ -4,7 +4,26 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     globalThis.crypto?.randomUUID?.() || String(Date.now()) + '-' + Math.random().toString(16).slice(2)
   );
   const pending = new Map();
-  const supportedKinds = new Set(['issue-comment', 'pull-comment', 'update-reply']);
+  const supportedKinds = new Set(['issue-comment', 'pull-comment', 'update-reply', 'pull-review']);
+
+  function reviewFingerprint(message) {
+    return JSON.stringify({
+      body: String(message.body || ''),
+      decision: String(message.decision || 'comment'),
+      expectedHeadSha: String(message.expectedHeadSha || ''),
+      comments: Array.isArray(message.comments) ? message.comments : [],
+    });
+  }
+
+  function clearConfirmedReviewState(item) {
+    if (item.kind !== 'pull-review') return;
+    try {
+      if (item.draftKey && item.draftFingerprint &&
+          storage?.getItem(item.draftKey) === item.draftFingerprint) storage.removeItem(item.draftKey);
+      if (item.progressKey && item.progressFingerprint &&
+          storage?.getItem(item.progressKey) === item.progressFingerprint) storage.removeItem(item.progressKey);
+    } catch (_error) { /* Delivery is confirmed even when local cleanup is unavailable. */ }
+  }
 
   function read() {
     try {
@@ -32,6 +51,16 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     const requestedOperationId = String(message.operationId || '').slice(0, 128);
     const existing = requestedOperationId && items.find(item => item.operationId === requestedOperationId);
     if (existing) return { ...existing };
+    if (message.kind === 'pull-review') {
+      const queuedReview = items.find(item => item.kind === 'pull-review' &&
+        item.repository === String(message.repository || '') &&
+        item.number === Number(message.number || 0) &&
+        item.expectedHeadSha === String(message.expectedHeadSha || ''));
+      if (queuedReview) {
+        if (reviewFingerprint(queuedReview) === reviewFingerprint(message)) return { ...queuedReview };
+        throw new Error('A review for this saved head is already queued. Open Drafts to inspect or discard it first.');
+      }
+    }
     if (items.length >= maxItems) throw new Error('Message outbox is full. Send or discard a queued message first.');
     const id = String(requestedOperationId || makeId()).slice(0, 128);
     const item = {
@@ -45,6 +74,15 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
       ownerLogin,
       status: 'queued',
       queuedAt: Number(now()),
+      ...(message.kind === 'pull-review' ? {
+        decision: String(message.decision || 'comment'),
+        expectedHeadSha: String(message.expectedHeadSha || ''),
+        comments: Array.isArray(message.comments) ? message.comments.map(comment => ({ ...comment })) : [],
+        draftKey: String(message.draftKey || ''),
+        progressKey: String(message.progressKey || ''),
+        draftFingerprint: String(message.draftFingerprint || ''),
+        progressFingerprint: String(message.progressFingerprint || ''),
+      } : {}),
     };
     items.push(item);
     write(items, mirror);
@@ -95,6 +133,9 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
       return 'api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/reply';
     }
     const repository = item.repository.split('/').map(encodeURIComponent).join('/');
+    if (item.kind === 'pull-review') {
+      return 'api/v1/repos/' + repository + '/pulls/' + encodeURIComponent(item.number) + '/review';
+    }
     const resource = item.kind === 'pull-comment' ? 'pulls' : 'issues';
     return 'api/v1/repos/' + repository + '/' + resource + '/' + encodeURIComponent(item.number) + '/comments';
   }
@@ -114,6 +155,12 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
           }
           result = delivery.message;
         } else {
+          const body = item.kind === 'pull-review' ? {
+            body: item.body,
+            decision: item.decision,
+            expected_head_sha: item.expectedHeadSha,
+            comments: item.comments,
+          } : { body: item.body };
           result = await fetchJson(endpoint(item), {
             method: 'POST',
             headers: {
@@ -121,10 +168,11 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
               'Content-Type': 'application/json',
               'Idempotency-Key': item.operationId,
             },
-            body: JSON.stringify({ body: item.body }),
+            body: JSON.stringify(body),
           });
         }
         if (!result) return { blocked: true };
+        clearConfirmedReviewState(item);
         discard(item.id);
         return { result };
       } catch (error) {
@@ -196,7 +244,10 @@ function createAuthoredOutbox({ storage, fetchJson, coordinator, backgroundSync,
     const statuses = new Map((records || []).map(item => [item.id, item]));
     const items = read().flatMap(item => {
       const background = statuses.get(item.id);
-      if (background?.status === 'sent') return [];
+      if (background?.status === 'sent') {
+        clearConfirmedReviewState(item);
+        return [];
+      }
       if (background?.status === 'attention') return [{
         ...item,
         status: 'attention',

frontend/background-issue-sync.js

@@ -242,6 +242,12 @@ function createBackgroundIssueSync({
       return { id: item.id, status, kind: 'message', route: '#/my-work/update/' + encodeURIComponent(item.notificationId) };
     }
     const repository = String(item.repository || '').split('/').map(encodeURIComponent).join('/');
+    if (item.kind === 'pull-review') {
+      return {
+        id: item.id, status, kind: 'message',
+        route: '#/my-work/review/' + repository + '/' + encodeURIComponent(item.number),
+      };
+    }
     if (item.kind === 'issue-comment' || item.kind === 'pull-comment') {
       const resource = item.kind === 'pull-comment' ? 'pull' : 'issue';
       return { id: item.id, status, kind: 'message', route: '#/my-work/' + resource + '/' + repository + '/' + encodeURIComponent(item.number) };
@@ -260,6 +266,25 @@ function createBackgroundIssueSync({
       return authoredRequest('api/v1/notifications/' + encodeURIComponent(item.notificationId) + '/reply', item);
     }
     const repository = String(item.repository || '').split('/').map(encodeURIComponent).join('/');
+    if (item.kind === 'pull-review') {
+      return {
+        url: base + 'api/v1/repos/' + repository + '/pulls/' + encodeURIComponent(item.number) + '/review',
+        options: {
+          method: 'POST',
+          headers: {
+            Accept: 'application/json',
+            'Content-Type': 'application/json',
+            'Idempotency-Key': item.operationId,
+          },
+          body: JSON.stringify({
+            body: item.body,
+            decision: item.decision,
+            expected_head_sha: item.expectedHeadSha,
+            comments: item.comments || [],
+          }),
+        },
+      };
+    }
     if (item.kind === 'issue-comment' || item.kind === 'pull-comment') {
       const resource = item.kind === 'pull-comment' ? 'pulls' : 'issues';
       return authoredRequest(

frontend/dashboard.js

@@ -1227,6 +1227,7 @@
     list.innerHTML = lastDrafts.length ? lastDrafts.map((item, index) => {
       const isOutbox = item.kind === 'issue-outbox' || item.kind === 'authored-outbox';
       const isUnfiled = item.kind === 'unfiled-issue';
+      const reviewOutbox = item.outbox_kind === 'pull-review';
       const sendLabel = item.delivery_state === 'uncertain' ? 'Verified not posted — retry' : 'Send now';
       const outboxActions = item.quarantined ?
         '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy content</button>' +
@@ -1238,10 +1239,17 @@
         '<button class="draft-edit" data-draft-index="' + index + '" type="button">Edit</button>' +
         '<button class="draft-send" data-draft-index="' + index + '" type="button">' + sendLabel + '</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard</button>' :
-        item.kind === 'authored-outbox' ?
+        reviewOutbox && item.status === 'attention' ?
+        '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open current review</button>' +
+        '<button class="draft-copy" data-draft-index="' + index + '" type="button">Copy feedback</button>' +
+        '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard queued review</button>' :
+        item.kind === 'authored-outbox' && !reviewOutbox ?
         '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open message</button>' +
         '<button class="draft-send" data-draft-index="' + index + '" type="button">' + sendLabel + '</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard</button>' :
+        reviewOutbox ?
+        '<button class="draft-resume" data-draft-index="' + index + '" type="button">Open review</button>' +
+        '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard queued review</button>' :
         '<button class="draft-resume" data-draft-index="' + index + '" type="button">' +
           (isUnfiled ? 'Choose repository' : 'Resume draft') + '</button>' +
         '<button class="draft-discard" data-draft-index="' + index + '" type="button">Discard draft</button>';
@@ -2355,7 +2363,7 @@
     qs('#review-submit-status').textContent = '';
     qs('#continue-review-to-merge').hidden = true;
     qs('#submit-review').disabled = true;
-    qs('#submit-review').textContent = offlineReview ? 'Reconnect to validate & submit' : 'Submit review';
+    qs('#submit-review').textContent = offlineReview ? 'Queue review for reconnect' : 'Submit review';
     closeInlineComposer();
     draft = null;
     reviewFiles = [];
@@ -2422,7 +2430,7 @@
       qs('#review-sheet-status').textContent = offlineReview ?
         'Offline review · saved ' + fmt(detail.saved_at) + ' · draft feedback stays on this device.' :
         'Ready to review · by ' + (detail.author || 'unknown author');
-      qs('#submit-review').disabled = offlineReview;
+      qs('#submit-review').disabled = false;
     } catch (error) {
       if (selectedReview !== item) return;
       qs('#review-sheet-status').textContent = error.message + ' Retry here or use Open in Gitea.';
@@ -3633,6 +3641,30 @@
     )) return;
     const button = qs('#submit-review');
     button.disabled = true;
+    if (offlineReview) {
+      qs('#review-submit-status').textContent = 'Queueing review safely…';
+      try {
+        await authoredOutbox.enqueueDurably({
+          kind: 'pull-review',
+          repository: selectedReview.repository,
+          number: selectedReview.number,
+          body: createReviewController.formatFeedback(snapshot, reviewFiles),
+          decision: snapshot.decision,
+          expectedHeadSha: selectedReviewHead,
+          comments: snapshot.comments,
+          draftKey: draft.storageKey,
+          progressKey: progress?.storageKey || '',
+          draftFingerprint: localStorage.getItem(draft.storageKey) || '',
+          progressFingerprint: localStorage.getItem(progress?.storageKey) || '',
+        });
+        qs('#review-submit-status').textContent = 'Review queued · it will submit after reconnect.';
+      } catch (error) {
+        qs('#review-submit-status').textContent = error.message + ' Your draft is safe; retry when ready.';
+        button.disabled = false;
+        button.focus();
+      }
+      return;
+    }
     qs('#review-submit-status').textContent = 'Submitting review…';
     try {
       const item = selectedReview;

frontend/drafts.js

@@ -139,22 +139,33 @@ function createDraftInbox({ storage, getCurrentLogin = () => '', now = () => Dat
       return record.items.filter(item => item && typeof item.id === 'string' && typeof item.body === 'string')
         .map(item => {
           const isUpdate = item.kind === 'update-reply';
-          const routeKind = item.kind === 'pull-comment' ? 'pull' : 'issue';
+          const isReview = item.kind === 'pull-review';
+          const routeKind = isReview ? 'review' : (item.kind === 'pull-comment' ? 'pull' : 'issue');
           const target = isUpdate ? 'Update #' + item.notificationId : item.repository + '#' + item.number;
+          const inlineFeedback = isReview && Array.isArray(item.comments) ? item.comments.map(comment =>
+            String(comment.path || 'File') + ' · ' +
+              (comment.new_position ? 'new line ' + comment.new_position : 'old line ' + comment.old_position) +
+              ': ' + String(comment.body || '')
+          ).filter(Boolean) : [];
+          const copyText = [item.body, inlineFeedback.length ? 'Inline feedback\n' + inlineFeedback.join('\n') : '']
+            .filter(Boolean).join('\n\n');
           const ownerLogin = String(item.ownerLogin || '').trim();
           const quarantined = !ownerLogin || !currentLogin || ownerLogin !== currentLogin;
           return {
             id: 'stackchain.authored-outbox.v1:' + item.id,
             outbox_id: item.id,
+            outbox_kind: item.kind,
             kind: 'authored-outbox',
             status: item.status === 'attention' ? 'attention' : 'queued',
             label: item.deliveryState === 'uncertain' ? 'Verify delivery' :
-              (item.status === 'attention' ? 'Needs attention' : 'Queued message'),
+              (item.status === 'attention' ? 'Needs attention' :
+                (isReview ? 'Queued review' : 'Queued message')),
             delivery_state: item.deliveryState,
             repository: isUpdate ? '' : item.repository,
             title: target,
             preview: textPreview([item.error, item.body].filter(Boolean).join(' — ')),
-            copy_text: item.body,
+            copy_text: copyText,
+            ...(isReview ? { head_sha: item.expectedHeadSha } : {}),
             quarantined,
             ownership: quarantined ? 'Queued by ' + (ownerLogin || 'an unknown account') +
               (currentLogin ? ' — current account is ' + currentLogin : ' — account confirmation unavailable') : '',

frontend/review-sheet.js

@@ -169,7 +169,7 @@ function createProgress({ storage, repository, number, headSha, files }) {
     return snapshot();
   }
 
-  return { snapshot, markReviewed, clear };
+  return { snapshot, markReviewed, clear, storageKey: key };
 }
 
 function createDraft({ storage, repository, number, headSha, files }) {
@@ -267,7 +267,10 @@ function createDraft({ storage, repository, number, headSha, files }) {
     return snapshot();
   }
 
-  return { snapshot, setNote, setInlineComment, removeInlineComment, setSummary, setDecision, clear };
+  return {
+    snapshot, setNote, setInlineComment, removeInlineComment, setSummary, setDecision, clear,
+    storageKey: key,
+  };
 }
 
 function formatFeedback(draft, files) {