stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Queue completed pull request reviews for reconnect delivery #419

New Issue
Closed
opened 2026-08-09 18:48:34 +00:00 by timmy · 0 comments
timmy commented 2026-08-09 18:48:34 +00:00
Owner
Copy Link

Evidence

Offline review work already persists SHA-scoped decisions and feedback (frontend/review-sheet.js), while final submission is disabled offline (frontend/dashboard.js). The authored outbox/background sync supports comments and replies but excludes completed reviews (frontend/authored-outbox.js, frontend/background-issue-sync.js). The review API already accepts idempotency keys and distinguishes stale-head conflicts. No historical issue title or recent commit implements deferred review submission.

User impact

A mobile operator can complete a cached pull-request review during an outage, explicitly queue it, and rely on bounded exactly-once delivery after reconnect without losing feedback or posting against a stale head.

Acceptance tests

  • Offline confirmation durably queues the full review payload with a stable idempotency key.
  • Reload and background sync retain and submit the account-bound operation exactly once.
  • Success removes the operation and its SHA-scoped draft.
  • Transient failures retry; stale-head or invalid-comment responses move to a needs-attention state and preserve feedback.
  • Another account cannot deliver the queued review; sign-out/revocation cleanup continues to purge private data.
  • Existing bounded background draining and online submission remain green.
## Evidence Offline review work already persists SHA-scoped decisions and feedback (`frontend/review-sheet.js`), while final submission is disabled offline (`frontend/dashboard.js`). The authored outbox/background sync supports comments and replies but excludes completed reviews (`frontend/authored-outbox.js`, `frontend/background-issue-sync.js`). The review API already accepts idempotency keys and distinguishes stale-head conflicts. No historical issue title or recent commit implements deferred review submission. ## User impact A mobile operator can complete a cached pull-request review during an outage, explicitly queue it, and rely on bounded exactly-once delivery after reconnect without losing feedback or posting against a stale head. ## Acceptance tests - Offline confirmation durably queues the full review payload with a stable idempotency key. - Reload and background sync retain and submit the account-bound operation exactly once. - Success removes the operation and its SHA-scoped draft. - Transient failures retry; stale-head or invalid-comment responses move to a needs-attention state and preserve feedback. - Another account cannot deliver the queued review; sign-out/revocation cleanup continues to purge private data. - Existing bounded background draining and online submission remain green.
timmy self-assigned this 2026-08-09 18:48:34 +00:00
timmy closed this issue 2026-08-09 19:06:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#419
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?