stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Merge pull request 'Open assigned pull requests from mobile Search' (#786) from timmy/785-open-assigned-pulls-from-search into main
All checks were successful
CI / lint (push) Successful in 1m31s
Details
CI / build-release (push) Successful in 5s
Details
CI / release-candidate (push) Successful in 6s
Details

Browse Source
This commit is contained in:
timmy 2026-08-14 00:27:40 +00:00
commit 66a2b78860
2 changed files with 26 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/dashboard.js
View File

@ -4358,7 +4358,7 @@
(detail.assignees?.length ? ' · assigned to ' + detail.assignees.join(', ') : ''); (detail.assignees?.length ? ' · assigned to ' + detail.assignees.join(', ') : '');
qs('#search-preview-body').innerHTML = renderMarkdown(detail.body || 'No description provided.'); qs('#search-preview-body').innerHTML = renderMarkdown(detail.body || 'No description provided.');
qs('#open-search-result-gitea').href = safeSearchUrl(detail.url) || '#'; qs('#open-search-result-gitea').href = safeSearchUrl(detail.url) || '#';
claimButton.hidden = !(detail.claimable || (detail.assigned_to_me && detail.kind === 'issue')); claimButton.hidden = !(detail.claimable || detail.assigned_to_me);
claimButton.textContent = detail.assigned_to_me ? 'Open in My Work' : 'Assign to me'; claimButton.textContent = detail.assigned_to_me ? 'Open in My Work' : 'Assign to me';
claimButton.disabled = state.status === 'claiming'; claimButton.disabled = state.status === 'claiming';
startButton.hidden = !(detail.kind === 'issue' && (detail.reopenable || startButton.hidden = !(detail.kind === 'issue' && (detail.reopenable ||
@ -4370,7 +4370,7 @@
(state.status === 'claiming' ? 'Assigning this issue to you…' : (state.status === 'claiming' ? 'Assigning this issue to you…' :
(state.status === 'claimed' ? 'Assignment confirmed. Opening My Work…' : (state.status === 'claimed' ? 'Assignment confirmed. Opening My Work…' :
(detail.claimable ? 'This issue is open and unassigned.' : (detail.claimable ? 'This issue is open and unassigned.' :
(detail.assigned_to_me ? 'This issue is already in My Work.' : (detail.assigned_to_me ? 'This item is already in My Work.' :
(detail.reopenable ? 'Closed—reopen to resume.' : 'Read-only preview.'))))); (detail.reopenable ? 'Closed—reopen to resume.' : 'Read-only preview.')))));
} }
const searchPreview = createSearchPreview({ const searchPreview = createSearchPreview({
@ -4424,10 +4424,10 @@
renderCommands(qs('#cmd-input').value); renderCommands(qs('#cmd-input').value);
qs('#cmd-input').focus(); qs('#cmd-input').focus();
} }
async function openPreviewIssueInMyWork(detail) { async function openPreviewWorkInMyWork(detail) {
await load(); await load();
const item = lastMyWork.find(candidate => const item = lastMyWork.find(candidate =>
candidate.kind === 'issue' && candidate.key === detail.repository + '#' + detail.number candidate.kind === detail.kind && candidate.key === detail.repository + '#' + detail.number
); );
if (!item) return false; if (!item) return false;
taskOverlayHistory.leave(); taskOverlayHistory.leave();
@ -4629,10 +4629,9 @@
try { try {
const claimed = searchPreviewDetail; const claimed = searchPreviewDetail;
if (claimed.claimable) await searchPreview.claim(claimed); if (claimed.claimable) await searchPreview.claim(claimed);
const opened = await openPreviewIssueInMyWork(claimed); const opened = await openPreviewWorkInMyWork(claimed);
if (!opened) { if (!opened) {
qs('#search-preview-status').textContent = qs('#search-preview-status').textContent = 'Refresh My Work to open this item.';
'Assignment confirmed. Refresh My Work to open the issue.';
} }
} catch (error) { } catch (error) {
qs('#search-preview-status').textContent = error.message + ' Retry assignment.'; qs('#search-preview-status').textContent = error.message + ' Retry assignment.';

22
tests/test_command_palette.py
View File

@ -297,9 +297,27 @@ def test_remote_search_selection_opens_native_preview_without_navigation():
def test_assigned_issue_preview_hands_off_to_existing_my_work_sheet(): def test_assigned_issue_preview_hands_off_to_existing_my_work_sheet():
html = dashboard_bundle_text() html = dashboard_bundle_text()
assert "detail.claimable || (detail.assigned_to_me && detail.kind === 'issue')" in html assert "claimButton.hidden = !(detail.claimable || detail.assigned_to_me)" in html
assert "claimButton.textContent = detail.assigned_to_me ? 'Open in My Work' : 'Assign to me'" in html assert "claimButton.textContent = detail.assigned_to_me ? 'Open in My Work' : 'Assign to me'" in html
assert "openPreviewIssueInMyWork" in html assert "openPreviewWorkInMyWork" in html
def test_assigned_pull_preview_hands_off_to_existing_my_work_sheet_without_claiming():
html = dashboard_bundle_text()
assert "claimButton.hidden = !(detail.claimable || detail.assigned_to_me)" in html
assert "async function openPreviewWorkInMyWork(detail)" in html
handoff = html.split("async function openPreviewWorkInMyWork(detail)", 1)[1].split(
"function runCommandItem", 1
)[0]
assert "candidate.kind === detail.kind" in handoff
assert "candidate.key === detail.repository + '#' + detail.number" in handoff
click_handler = html.split(
"qs('#claim-search-result').addEventListener('click'", 1
)[1].split("qs('#start-search-result')", 1)[0]
assert "if (claimed.claimable) await searchPreview.claim(claimed)" in click_handler
assert "await openPreviewWorkInMyWork(claimed)" in click_handler
def test_search_preview_offers_assign_and_start_for_eligible_issues(): def test_search_preview_offers_assign_and_start_for_eligible_issues():