fix: hide readiness exception details (#113)

tests/test_health.py

@@ -29,17 +29,21 @@ async def test_readiness_endpoint_reports_connected_gitea_user(monkeypatch):
 
 
 @pytest.mark.anyio
-async def test_readiness_endpoint_returns_503_when_gitea_is_unavailable(monkeypatch):
+async def test_readiness_endpoint_hides_unexpected_upstream_error_details(monkeypatch):
     async def unavailable_user():
-        raise RuntimeError("connection refused")
+        raise RuntimeError("secret internal upstream detail")
 
     monkeypatch.setattr(main, "current_user", unavailable_user)
 
     response = await main.readiness()
 
     assert response.status_code == 503
-    assert b'"status":"not_ready"' in response.body
-    assert b'"error":"connection refused"' in response.body
+    assert json.loads(response.body) == {
+        "status": "not_ready",
+        "service": "stackchain-dashboard",
+        "error": "Gitea readiness check is temporarily unavailable",
+    }
+    assert b"secret internal upstream detail" not in response.body
 
 
 @pytest.mark.anyio