stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

fix: keep mobile filing navigation selected
All checks were successful
CI / lint (pull_request) Successful in 2m12s
Details
CI / build-release (pull_request) Successful in 6s
Details
CI / browser-journey (pull_request) Successful in 1m1s
Details
CI / release-candidate (pull_request) Has been skipped
Details

Browse Source
This commit is contained in:
timmy 2026-08-16 15:12:02 +00:00
parent 2b671d91fd
commit fe95b4e32a
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
frontend/mobile-create-issue-nav.js
View File

@ -6,6 +6,7 @@ function createMobileCreateIssueNavigation(options) {
const targetNames = new Map(Object.entries(targets).map(([name, target]) => [target, name])); const targetNames = new Map(Object.entries(targets).map(([name, target]) => [target, name]));
let filingAvailable = !options.filing?.hidden; let filingAvailable = !options.filing?.hidden;
let observer = null; let observer = null;
let navigationLockUntil = 0;
function select(name) { function select(name) {
Object.entries(buttons).forEach(([key, button]) => { Object.entries(buttons).forEach(([key, button]) => {
@ -32,6 +33,7 @@ function createMobileCreateIssueNavigation(options) {
block: 'start', block: 'start',
behavior: prefersReducedMotion() ? 'auto' : 'smooth', behavior: prefersReducedMotion() ? 'auto' : 'smooth',
}); });
navigationLockUntil = Date.now() + 500;
select(name); select(name);
return true; return true;
} }
@ -64,6 +66,7 @@ function createMobileCreateIssueNavigation(options) {
return instance; return instance;
}); });
observer = observe(entries => { observer = observe(entries => {
if (Date.now() < navigationLockUntil) return;
const visible = entries const visible = entries
.filter(entry => entry.isIntersecting && targetNames.has(entry.target)) .filter(entry => entry.isIntersecting && targetNames.has(entry.target))
.filter(entry => targetNames.get(entry.target) !== 'file' || filingAvailable) .filter(entry => targetNames.get(entry.target) !== 'file' || filingAvailable)
@ -86,26 +89,30 @@ function createMobileCreateIssueNavigation(options) {
function attachMobileCreateIssueNavigation({ document, window }) { function attachMobileCreateIssueNavigation({ document, window }) {
const bySection = name => document.querySelector('[data-create-issue-section="' + name + '"]'); const bySection = name => document.querySelector('[data-create-issue-section="' + name + '"]');
const filing = document.getElementById('create-issue-filing');
const sheet = document.getElementById('create-issue-sheet');
const navigation = createMobileCreateIssueNavigation({ const navigation = createMobileCreateIssueNavigation({
root:document.querySelector('.create-issue-panel'), root:document.querySelector('.create-issue-panel'),
buttons:{describe:bySection('describe'), evidence:bySection('evidence'), file:bySection('file')}, buttons:{describe:bySection('describe'), evidence:bySection('evidence'), file:bySection('file')},
targets:{ targets:{
describe:document.getElementById('create-issue-describe'), describe:document.getElementById('create-issue-describe'),
evidence:document.getElementById('create-issue-evidence'), evidence:document.getElementById('create-issue-evidence'),
file:document.getElementById('create-issue-filing'), file:filing,
}, },
filing:document.getElementById('create-issue-filing'), filing,
prefersReducedMotion:() => window.matchMedia('(prefers-reduced-motion: reduce)').matches, prefersReducedMotion:() => window.matchMedia('(prefers-reduced-motion: reduce)').matches,
}); });
navigation.start(); navigation.start();
document.getElementById('file-new-issue').addEventListener('click', () => { document.getElementById('file-new-issue').addEventListener('click', () => {
navigation.navigate('file'); setTimeout(() => navigation.navigate('file'), 0);
}); });
new MutationObserver(() => { new MutationObserver(() => {
if (document.getElementById('create-issue-sheet').classList.contains('open')) { navigation.setFilingAvailable(!filing.hidden);
navigation.reset(!document.getElementById('create-issue-filing').hidden); if (!filing.hidden && sheet.classList.contains('open')) navigation.navigate('file');
} }).observe(filing, {attributes:true, attributeFilter:['hidden']});
}).observe(document.getElementById('create-issue-sheet'), { new MutationObserver(() => {
if (sheet.classList.contains('open')) navigation.reset(!filing.hidden);
}).observe(sheet, {
attributes:true, attributeFilter:['class'], attributes:true, attributeFilter:['class'],
}); });
return navigation; return navigation;

3
tests/test_mobile_create_issue_navigation.py
View File

@ -95,7 +95,8 @@ def test_new_issue_sheet_ships_mobile_navigation_in_lazy_offline_feature():
assert '"static/mobile-create-issue-nav.js"' in bundle assert '"static/mobile-create-issue-nav.js"' in bundle
assert "attachMobileCreateIssueNavigation({document, window})" in navigation_js assert "attachMobileCreateIssueNavigation({document, window})" in navigation_js
assert "attachMobileCreateIssueNavigation({document, window})" not in dashboard_js assert "attachMobileCreateIssueNavigation({document, window})" not in dashboard_js
assert "document.getElementById('file-new-issue').addEventListener" in navigation_js assert "attributeFilter:['hidden']" in navigation_js
assert "setTimeout(() => navigation.navigate('file'), 0)" in navigation_js
assert "navigation.navigate('file')" in navigation_js assert "navigation.navigate('file')" in navigation_js
assert "navigation.reset(" in navigation_js assert "navigation.reset(" in navigation_js
assert ".mobile-create-issue-nav" in css assert ".mobile-create-issue-nav" in css