feat: add mobile new issue navigation (Closes #971)
This commit is contained in:
parent
dcc3348c12
commit
2b671d91fd
|
|
@ -701,7 +701,9 @@ textarea { resize: vertical; min-height: 120px; }
|
|||
.create-issue-panel { width:min(560px,100%); height:100dvh; overflow:auto; overflow-x:hidden; display:grid; align-content:start; gap:12px; padding:18px; padding-bottom:calc(18px + env(safe-area-inset-bottom)); background:#0b1526; border-left:1px solid #2a496e; }
|
||||
.create-issue-header { display:flex; align-items:center; justify-content:space-between; gap:10px; }
|
||||
.create-issue-header button, .create-issue-actions button, .create-issue-capture-actions button { min-height:44px; }
|
||||
.mobile-create-issue-nav { display:none; }
|
||||
.create-issue-form { display:grid; gap:12px; }
|
||||
.create-issue-describe { display:grid; gap:12px; min-width:0; }
|
||||
.voice-issue-capture { display:grid; gap:8px; min-width:0; padding:12px; border:1px solid #31577f; border-radius:12px; background:#101d31; }
|
||||
.voice-issue-capture[hidden], .voice-issue-review[hidden], .voice-issue-controls button[hidden] { display:none; }
|
||||
.voice-issue-heading, .voice-issue-review { display:grid; gap:6px; }
|
||||
|
|
@ -908,6 +910,20 @@ textarea { resize: vertical; min-height: 120px; }
|
|||
.saved-search-row { align-items:stretch; }
|
||||
#cmd-results { flex:1; min-height:0; overflow-y:auto; max-height:none; overscroll-behavior:contain; padding-bottom:env(safe-area-inset-bottom); }
|
||||
.create-issue-panel { width:100%; border-left:0; padding:14px; }
|
||||
.mobile-create-issue-nav {
|
||||
position:sticky; top:env(safe-area-inset-top); z-index:6;
|
||||
display:grid; grid-template-columns:repeat(3,minmax(0,1fr)); gap:4px;
|
||||
margin-inline:-14px; padding:4px 14px;
|
||||
background:rgba(11,21,38,.98); border-block:1px solid #2a496e;
|
||||
}
|
||||
.mobile-create-issue-nav button {
|
||||
min-width:0; min-height:44px; padding:4px; border-color:transparent; font-size:12px;
|
||||
}
|
||||
.mobile-create-issue-nav button[aria-current="location"] {
|
||||
border-color:#60a5fa; background:#17365a; color:#fff;
|
||||
}
|
||||
.mobile-create-issue-nav button[aria-disabled="true"] { opacity:.55; }
|
||||
#create-issue-describe, #create-issue-evidence, #create-issue-filing { scroll-margin-top:72px; }
|
||||
.pull-sheet-panel { width:100%; border-left:0; padding:14px; }
|
||||
.create-issue-panel.composer-keyboard-active,
|
||||
.issue-sheet-panel.composer-keyboard-active,
|
||||
|
|
|
|||
|
|
@ -873,6 +873,11 @@
|
|||
<h3 id="create-issue-heading">Capture work</h3>
|
||||
<button id="cancel-new-issue" type="button">Cancel</button>
|
||||
</div>
|
||||
<nav class="mobile-create-issue-nav" aria-label="New issue sections">
|
||||
<button type="button" data-create-issue-section="describe">Describe</button>
|
||||
<button type="button" data-create-issue-section="evidence">Evidence</button>
|
||||
<button type="button" data-create-issue-section="file">File</button>
|
||||
</nav>
|
||||
<aside class="shared-content-conflict" id="shared-content-conflict" aria-live="assertive" hidden>
|
||||
<strong>You already have an unfinished issue draft.</strong>
|
||||
<span class="small">Resume it, or replace its title and description with the content shared to Stackchain.</span>
|
||||
|
|
@ -882,6 +887,7 @@
|
|||
</div>
|
||||
</aside>
|
||||
<form class="create-issue-form" id="create-issue-form">
|
||||
<section class="create-issue-describe" id="create-issue-describe">
|
||||
<label for="create-issue-title">Title
|
||||
<input id="create-issue-title" type="text" maxlength="255" required autocomplete="off" />
|
||||
</label>
|
||||
|
|
@ -913,7 +919,8 @@
|
|||
<button id="save-unfiled-issue" type="button">Save to Drafts</button>
|
||||
<button id="file-new-issue" type="button">File now</button>
|
||||
</div>
|
||||
<section class="create-issue-attachment" aria-labelledby="create-issue-attachment-label">
|
||||
</section>
|
||||
<section class="create-issue-attachment" id="create-issue-evidence" aria-labelledby="create-issue-attachment-label">
|
||||
<strong id="create-issue-attachment-label">Photo evidence <span class="small">Optional · Up to 5 · PNG, JPEG, or WebP · 2 MB each</span></strong>
|
||||
<div class="issue-attachment-controls photo-evidence-actions">
|
||||
<label class="issue-attachment-trigger" for="take-create-issue-photo">Take photo</label>
|
||||
|
|
@ -1537,6 +1544,7 @@
|
|||
<script src="static/voice-issue-capture.js"></script>
|
||||
<script src="static/voice-conversation-capture.js"></script>
|
||||
<script src="static/create-issue-sheet.js"></script>
|
||||
<script src="static/mobile-create-issue-nav.js"></script>
|
||||
<script src="static/create-and-start.js"></script>
|
||||
<script src="static/assign-and-start.js"></script>
|
||||
<script src="static/filed-claim.js"></script>
|
||||
|
|
|
|||
115
frontend/mobile-create-issue-nav.js
Normal file
115
frontend/mobile-create-issue-nav.js
Normal file
|
|
@ -0,0 +1,115 @@
|
|||
function createMobileCreateIssueNavigation(options) {
|
||||
const buttons = options.buttons || {};
|
||||
const targets = options.targets || {};
|
||||
const listeners = new Map();
|
||||
const prefersReducedMotion = options.prefersReducedMotion || (() => false);
|
||||
const targetNames = new Map(Object.entries(targets).map(([name, target]) => [target, name]));
|
||||
let filingAvailable = !options.filing?.hidden;
|
||||
let observer = null;
|
||||
|
||||
function select(name) {
|
||||
Object.entries(buttons).forEach(([key, button]) => {
|
||||
if (!button) return;
|
||||
if (key === name) button.setAttribute('aria-current', 'location');
|
||||
else button.removeAttribute('aria-current');
|
||||
});
|
||||
}
|
||||
|
||||
function setFilingAvailable(available) {
|
||||
filingAvailable = Boolean(available);
|
||||
const button = buttons.file;
|
||||
if (!button) return;
|
||||
if (filingAvailable) button.removeAttribute('aria-disabled');
|
||||
else button.setAttribute('aria-disabled', 'true');
|
||||
}
|
||||
|
||||
function navigate(name) {
|
||||
if (name === 'file') setFilingAvailable(!options.filing?.hidden);
|
||||
if (name === 'file' && !filingAvailable) return false;
|
||||
const target = targets[name];
|
||||
if (!target) return false;
|
||||
target.scrollIntoView({
|
||||
block: 'start',
|
||||
behavior: prefersReducedMotion() ? 'auto' : 'smooth',
|
||||
});
|
||||
select(name);
|
||||
return true;
|
||||
}
|
||||
|
||||
function reset(available = !options.filing?.hidden) {
|
||||
setFilingAvailable(available);
|
||||
select('describe');
|
||||
}
|
||||
|
||||
return {
|
||||
start() {
|
||||
Object.entries(buttons).forEach(([name, button]) => {
|
||||
if (!button || listeners.has(button)) return;
|
||||
const listener = event => {
|
||||
event.preventDefault();
|
||||
navigate(name);
|
||||
};
|
||||
listeners.set(button, listener);
|
||||
button.addEventListener('click', listener);
|
||||
});
|
||||
reset();
|
||||
const observe = options.observe || ((handler, observedTargets, root) => {
|
||||
if (typeof IntersectionObserver === 'undefined') return null;
|
||||
const instance = new IntersectionObserver(handler, {
|
||||
root,
|
||||
rootMargin: '-20% 0px -60% 0px',
|
||||
threshold: [0, 0.25, 0.5, 0.75, 1],
|
||||
});
|
||||
observedTargets.forEach(target => instance.observe(target));
|
||||
return instance;
|
||||
});
|
||||
observer = observe(entries => {
|
||||
const visible = entries
|
||||
.filter(entry => entry.isIntersecting && targetNames.has(entry.target))
|
||||
.filter(entry => targetNames.get(entry.target) !== 'file' || filingAvailable)
|
||||
.sort((left, right) => right.intersectionRatio - left.intersectionRatio)[0];
|
||||
if (visible) select(targetNames.get(visible.target));
|
||||
}, Array.from(targetNames.keys()).filter(Boolean), options.root || null);
|
||||
},
|
||||
stop() {
|
||||
listeners.forEach((listener, button) => button.removeEventListener('click', listener));
|
||||
listeners.clear();
|
||||
if (observer) observer.disconnect();
|
||||
observer = null;
|
||||
},
|
||||
navigate,
|
||||
reset,
|
||||
select,
|
||||
setFilingAvailable,
|
||||
};
|
||||
}
|
||||
|
||||
function attachMobileCreateIssueNavigation({ document, window }) {
|
||||
const bySection = name => document.querySelector('[data-create-issue-section="' + name + '"]');
|
||||
const navigation = createMobileCreateIssueNavigation({
|
||||
root:document.querySelector('.create-issue-panel'),
|
||||
buttons:{describe:bySection('describe'), evidence:bySection('evidence'), file:bySection('file')},
|
||||
targets:{
|
||||
describe:document.getElementById('create-issue-describe'),
|
||||
evidence:document.getElementById('create-issue-evidence'),
|
||||
file:document.getElementById('create-issue-filing'),
|
||||
},
|
||||
filing:document.getElementById('create-issue-filing'),
|
||||
prefersReducedMotion:() => window.matchMedia('(prefers-reduced-motion: reduce)').matches,
|
||||
});
|
||||
navigation.start();
|
||||
document.getElementById('file-new-issue').addEventListener('click', () => {
|
||||
navigation.navigate('file');
|
||||
});
|
||||
new MutationObserver(() => {
|
||||
if (document.getElementById('create-issue-sheet').classList.contains('open')) {
|
||||
navigation.reset(!document.getElementById('create-issue-filing').hidden);
|
||||
}
|
||||
}).observe(document.getElementById('create-issue-sheet'), {
|
||||
attributes:true, attributeFilter:['class'],
|
||||
});
|
||||
return navigation;
|
||||
}
|
||||
|
||||
if (typeof module !== 'undefined') module.exports = createMobileCreateIssueNavigation;
|
||||
else attachMobileCreateIssueNavigation({document, window});
|
||||
|
|
@ -85,6 +85,7 @@ const SHELL = [
|
|||
BASE + 'static/voice-issue-capture.js',
|
||||
BASE + 'static/voice-conversation-capture.js',
|
||||
BASE + 'static/create-issue-sheet.js',
|
||||
BASE + 'static/mobile-create-issue-nav.js',
|
||||
BASE + 'static/create-and-start.js',
|
||||
BASE + 'static/assign-and-start.js',
|
||||
BASE + 'static/filed-claim.js',
|
||||
|
|
|
|||
|
|
@ -23,7 +23,7 @@ WORKER_RUNTIME_SOURCE = "static/background-issue-sync.js"
|
|||
FEATURE_SOURCES = {
|
||||
"comment-actions": ("static/conversation.js", "static/comment-actions.js"),
|
||||
"issue-capture": (
|
||||
"static/voice-transcript-store.js", "static/voice-issue-capture.js", "static/create-issue-sheet.js", "static/update-follow-up.js", "static/shared-image-capture.js",
|
||||
"static/voice-transcript-store.js", "static/voice-issue-capture.js", "static/create-issue-sheet.js", "static/mobile-create-issue-nav.js", "static/update-follow-up.js", "static/shared-image-capture.js",
|
||||
),
|
||||
"pull-workflow": ("static/pull-sheet.js", "static/review-sheet.js"),
|
||||
"push-notifications": ("static/push-notifications.js",),
|
||||
|
|
|
|||
|
|
@ -188,6 +188,23 @@ def test_release_artifact_files_one_mobile_issue_exactly_once_after_offline_relo
|
|||
new_action.click()
|
||||
expect(page.locator("#create-issue-sheet")).to_have_class("create-issue-sheet open")
|
||||
assert page.evaluate("document.activeElement?.id") != "create-issue-title"
|
||||
create_navigation = page.locator(".mobile-create-issue-nav")
|
||||
expect(create_navigation).to_be_visible()
|
||||
create_navigation_buttons = create_navigation.locator("button")
|
||||
assert create_navigation_buttons.count() == 3
|
||||
for control in create_navigation_buttons.all():
|
||||
bounds = control.bounding_box()
|
||||
assert bounds and bounds["height"] >= 44
|
||||
expect(create_navigation.locator('[data-create-issue-section="describe"]')).to_have_attribute(
|
||||
"aria-current", "location"
|
||||
)
|
||||
expect(create_navigation.locator('[data-create-issue-section="file"]')).to_have_attribute(
|
||||
"aria-disabled", "true"
|
||||
)
|
||||
create_navigation.locator('[data-create-issue-section="evidence"]').click()
|
||||
expect(create_navigation.locator('[data-create-issue-section="evidence"]')).to_have_attribute(
|
||||
"aria-current", "location"
|
||||
)
|
||||
for control in page.locator(".photo-evidence-actions .issue-attachment-trigger").all():
|
||||
bounds = control.bounding_box()
|
||||
assert bounds and bounds["height"] >= 44
|
||||
|
|
@ -206,6 +223,12 @@ def test_release_artifact_files_one_mobile_issue_exactly_once_after_offline_relo
|
|||
expect(page.locator("#create-issue-body")).to_have_value(BODY)
|
||||
page.locator("#file-new-issue").click()
|
||||
expect(page.locator("#create-issue-filing")).to_be_visible()
|
||||
expect(create_navigation.locator('[data-create-issue-section="file"]')).to_have_attribute(
|
||||
"aria-current", "location"
|
||||
)
|
||||
expect(create_navigation.locator('[data-create-issue-section="file"]')).not_to_have_attribute(
|
||||
"aria-disabled", "true"
|
||||
)
|
||||
page.locator("#create-issue-repository").select_option("acme/mobile")
|
||||
expect(page.locator("#submit-new-issue")).to_be_enabled()
|
||||
|
||||
|
|
|
|||
105
tests/test_mobile_create_issue_navigation.py
Normal file
105
tests/test_mobile_create_issue_navigation.py
Normal file
|
|
@ -0,0 +1,105 @@
|
|||
import json
|
||||
import subprocess
|
||||
from pathlib import Path
|
||||
|
||||
|
||||
CONTROLLER = Path(__file__).resolve().parents[1] / "frontend" / "mobile-create-issue-nav.js"
|
||||
FRONTEND = CONTROLLER.parent
|
||||
|
||||
|
||||
def run_navigation(scenario: str) -> dict:
|
||||
script = f"""
|
||||
const createNavigation = require({json.dumps(str(CONTROLLER))});
|
||||
class FakeElement {{
|
||||
constructor(name) {{ this.name=name; this.listeners={{}}; this.attributes={{}}; this.scrolls=[]; this.hidden=false; }}
|
||||
addEventListener(name, callback) {{ this.listeners[name]=callback; }}
|
||||
removeEventListener(name) {{ delete this.listeners[name]; }}
|
||||
click() {{ this.listeners.click?.({{preventDefault() {{}}}}); }}
|
||||
setAttribute(name,value) {{ this.attributes[name]=value; }}
|
||||
removeAttribute(name) {{ delete this.attributes[name]; }}
|
||||
scrollIntoView(options) {{ this.scrolls.push(options); }}
|
||||
}}
|
||||
{scenario}
|
||||
"""
|
||||
result = subprocess.run(["node", "-e", script], capture_output=True, text=True)
|
||||
assert result.returncode == 0, result.stderr
|
||||
return json.loads(result.stdout)
|
||||
|
||||
|
||||
def test_mobile_create_issue_navigation_gates_file_and_navigates_with_reduced_motion():
|
||||
result = run_navigation("""
|
||||
const buttons=Object.fromEntries(['describe','evidence','file'].map(name=>[name,new FakeElement(name)]));
|
||||
const targets=Object.fromEntries(['describe','evidence','file'].map(name=>[name,new FakeElement(name)]));
|
||||
targets.file.hidden=true;
|
||||
const navigation=createNavigation({buttons,targets,filing:targets.file,prefersReducedMotion:()=>true});
|
||||
navigation.start();
|
||||
const initiallyDisabled=buttons.file.attributes['aria-disabled'];
|
||||
buttons.file.click();
|
||||
const beforeReveal=targets.file.scrolls.length;
|
||||
targets.file.hidden=false;
|
||||
navigation.setFilingAvailable(true);
|
||||
buttons.file.click();
|
||||
const selected=Object.fromEntries(Object.entries(buttons).map(([name,button])=>[name,button.attributes['aria-current']||null]));
|
||||
navigation.stop();
|
||||
process.stdout.write(JSON.stringify({initiallyDisabled,beforeReveal,scrolls:targets.file.scrolls,selected,listeners:Object.values(buttons).map(button=>Object.keys(button.listeners).length)}));
|
||||
""")
|
||||
|
||||
assert result == {
|
||||
"initiallyDisabled": "true",
|
||||
"beforeReveal": 0,
|
||||
"scrolls": [{"block": "start", "behavior": "auto"}],
|
||||
"selected": {"describe": None, "evidence": None, "file": "location"},
|
||||
"listeners": [0, 0, 0],
|
||||
}
|
||||
|
||||
|
||||
def test_mobile_create_issue_navigation_tracks_visible_panel_sections_and_resets():
|
||||
result = run_navigation("""
|
||||
const buttons=Object.fromEntries(['describe','evidence','file'].map(name=>[name,new FakeElement(name)]));
|
||||
const targets=Object.fromEntries(['describe','evidence','file'].map(name=>[name,new FakeElement(name)]));
|
||||
let callback; let observedRoot; let disconnected=0;
|
||||
const root=new FakeElement('panel');
|
||||
const navigation=createNavigation({buttons,targets,root,filing:targets.file,observe(handler,observed,rootOption){callback=handler; observedRoot=rootOption; return {disconnect(){disconnected++;}};}});
|
||||
navigation.start();
|
||||
callback([{target:targets.describe,isIntersecting:true,intersectionRatio:.2},{target:targets.evidence,isIntersecting:true,intersectionRatio:.8}]);
|
||||
navigation.reset(false);
|
||||
const selected=Object.fromEntries(Object.entries(buttons).map(([name,button])=>[name,button.attributes['aria-current']||null]));
|
||||
navigation.stop();
|
||||
process.stdout.write(JSON.stringify({selected,fileDisabled:buttons.file.attributes['aria-disabled'],observedRoot:observedRoot.name,disconnected}));
|
||||
""")
|
||||
|
||||
assert result == {
|
||||
"selected": {"describe": "location", "evidence": None, "file": None},
|
||||
"fileDisabled": "true",
|
||||
"observedRoot": "panel",
|
||||
"disconnected": 1,
|
||||
}
|
||||
|
||||
|
||||
def test_new_issue_sheet_ships_mobile_navigation_in_lazy_offline_feature():
|
||||
html = (FRONTEND / "index.html").read_text()
|
||||
css = (FRONTEND / "dashboard.css").read_text()
|
||||
dashboard_js = (FRONTEND / "dashboard.js").read_text()
|
||||
navigation_js = CONTROLLER.read_text()
|
||||
bundle = (FRONTEND.parent / "src" / "frontend_bundle.py").read_text()
|
||||
|
||||
assert '<nav class="mobile-create-issue-nav"' in html
|
||||
assert 'aria-label="New issue sections"' in html
|
||||
for name, label in (("describe", "Describe"), ("evidence", "Evidence"), ("file", "File")):
|
||||
assert f'data-create-issue-section="{name}"' in html
|
||||
assert f">{label}</button>" in html
|
||||
assert 'id="create-issue-describe"' in html
|
||||
assert 'id="create-issue-attachment"' in html
|
||||
assert 'id="create-issue-filing"' in html
|
||||
assert '<script src="static/mobile-create-issue-nav.js"></script>' in html
|
||||
assert '"static/mobile-create-issue-nav.js"' in bundle
|
||||
assert "attachMobileCreateIssueNavigation({document, window})" in navigation_js
|
||||
assert "attachMobileCreateIssueNavigation({document, window})" not in dashboard_js
|
||||
assert "document.getElementById('file-new-issue').addEventListener" in navigation_js
|
||||
assert "navigation.navigate('file')" in navigation_js
|
||||
assert "navigation.reset(" in navigation_js
|
||||
assert ".mobile-create-issue-nav" in css
|
||||
assert "position:sticky" in css
|
||||
assert "min-height:44px" in css
|
||||
assert "grid-template-columns:repeat(3,minmax(0,1fr))" in css
|
||||
assert "env(safe-area-inset-top)" in css
|
||||
|
|
@ -1006,6 +1006,7 @@ def test_install_precaches_complete_subpath_scoped_app_shell():
|
|||
"/dashboard/static/voice-issue-capture.js",
|
||||
"/dashboard/static/voice-conversation-capture.js",
|
||||
"/dashboard/static/create-issue-sheet.js",
|
||||
"/dashboard/static/mobile-create-issue-nav.js",
|
||||
"/dashboard/static/create-and-start.js",
|
||||
"/dashboard/static/assign-and-start.js",
|
||||
"/dashboard/static/filed-claim.js",
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user