stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Cancel and replace pending pull review requests from mobile #1340

New Issue
Closed
opened 2026-08-24 07:51:07 +00:00 by rockachopa · 0 comments
rockachopa commented 2026-08-24 07:51:07 +00:00
Member
Copy Link

User problem

An assigned pull author can request a reviewer from mobile, but a mistaken or unavailable reviewer leaves the merge flow blocked with no recovery except leaving the dashboard.

Scope

  • Show a touch-safe cancel action only for pending reviewer requests.
  • Validate assignment, open state, current head, and pending reviewer before deletion.
  • Confirm authoritative upstream removal before updating reviewer and merge state.
  • Keep the pull detail open and hand off directly to the existing reviewer picker for replacement.
  • Preserve the reviewer row with a clear refresh instruction on conflict or ambiguous failure.

Acceptance tests

  • A pending reviewer can be removed with one confirmed, head-scoped request.
  • Approved/commented/completed reviews cannot be cancelled.
  • Head/assignment/reviewer drift returns 409 without deletion.
  • Double tap coalesces to one upstream deletion.
  • UI updates only from confirmed server state and offers Choose replacement reviewer.
  • Mobile controls are at least 44px and do not overflow 320px.
## User problem An assigned pull author can request a reviewer from mobile, but a mistaken or unavailable reviewer leaves the merge flow blocked with no recovery except leaving the dashboard. ## Scope - Show a touch-safe cancel action only for pending reviewer requests. - Validate assignment, open state, current head, and pending reviewer before deletion. - Confirm authoritative upstream removal before updating reviewer and merge state. - Keep the pull detail open and hand off directly to the existing reviewer picker for replacement. - Preserve the reviewer row with a clear refresh instruction on conflict or ambiguous failure. ## Acceptance tests - A pending reviewer can be removed with one confirmed, head-scoped request. - Approved/commented/completed reviews cannot be cancelled. - Head/assignment/reviewer drift returns 409 without deletion. - Double tap coalesces to one upstream deletion. - UI updates only from confirmed server state and offers Choose replacement reviewer. - Mobile controls are at least 44px and do not overflow 320px.
timmy was assigned by rockachopa 2026-08-24 07:51:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1340
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?