stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Cancel and replace pending pull review requests from mobile #1341

Merged
rockachopa merged 2 commits from timmy/1340-cancel-pending-review into main 2026-08-24 08:25:56 +00:00
Conversation 0 Commits 2 Files Changed 9 +381 -2
rockachopa commented 2026-08-24 08:01:36 +00:00
Member
Copy Link

Closes #1340

Adds an authoritative, head-scoped cancellation flow for pending pull review requests. Mobile authors can cancel a mistaken/unavailable reviewer, see merge eligibility recomputed only after Gitea confirms removal, and continue directly into the existing replacement picker.

Validation:

  • python3 -m pytest tests/ -q — 2522 passed, 14 skipped
  • Playwright at 320x568 and 390x844 — no overflow, 44px cancel target, confirmed DELETE, replacement picker focused
Closes #1340 Adds an authoritative, head-scoped cancellation flow for pending pull review requests. Mobile authors can cancel a mistaken/unavailable reviewer, see merge eligibility recomputed only after Gitea confirms removal, and continue directly into the existing replacement picker. Validation: - `python3 -m pytest tests/ -q` — 2522 passed, 14 skipped - Playwright at 320x568 and 390x844 — no overflow, 44px cancel target, confirmed DELETE, replacement picker focused
rockachopa added 1 commit 2026-08-24 08:01:37 +00:00
feat: cancel pending pull review requests (Closes #1340)
Some checks failed
CI / lint (pull_request) Successful in 3m17s
Details
CI / build-release (pull_request) Successful in 7s
Details
CI / browser-journey (pull_request) Failing after 5m18s
Details
CI / release-candidate (pull_request) Has been skipped
Details
d776a2b003
rockachopa added 1 commit 2026-08-24 08:16:25 +00:00
test: gate mobile review cancellation journey
All checks were successful
CI / lint (pull_request) Successful in 3m20s
Details
CI / build-release (pull_request) Successful in 6s
Details
CI / browser-journey (pull_request) Successful in 5m24s
Details
CI / release-candidate (pull_request) Has been skipped
Details
1f9f0f5c22
rockachopa merged commit 50817bed9a into main 2026-08-24 08:25:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1341
No description provided.
Delete Branch "timmy/1340-cancel-pending-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?