stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Load pull review feedback on demand without blocking mobile review #1342

New Issue
Closed
opened 2026-08-24 09:03:45 +00:00 by timmy · 0 comments
timmy commented 2026-08-24 09:03:45 +00:00
Owner
Copy Link

User problem

Opening Review & merge currently fans out up to ten inline-comment requests. One unavailable optional comments endpoint turns otherwise healthy files, diff, CI, and reviewer decisions into a total 503, blocking mobile review.

Evidence

  • src/gitea_proxy.py eagerly gathers each latest review comments endpoint after core review data.
  • src/main.py maps any fan-out failure to a complete review-data 503.
  • Existing feedback tests cover only successful eager loading.
  • No open/closed issue title or recent commit implements lazy, retryable inline feedback.

Acceptance

  • Core review data loads without requesting inline review comments and preserves blocking reviewer decisions.
  • An assigned-pull endpoint loads one bounded review's comments with current head/review identity checks.
  • Mobile feedback expands on demand, coalesces/caches by pull, head, and review, and exposes an explicit retry state.
  • A stale response cannot replace current feedback; Address feedback stays unavailable until comments load.
  • Focused tests and full suite pass.
## User problem Opening Review & merge currently fans out up to ten inline-comment requests. One unavailable optional comments endpoint turns otherwise healthy files, diff, CI, and reviewer decisions into a total 503, blocking mobile review. ## Evidence - `src/gitea_proxy.py` eagerly gathers each latest review comments endpoint after core review data. - `src/main.py` maps any fan-out failure to a complete review-data 503. - Existing feedback tests cover only successful eager loading. - No open/closed issue title or recent commit implements lazy, retryable inline feedback. ## Acceptance - Core review data loads without requesting inline review comments and preserves blocking reviewer decisions. - An assigned-pull endpoint loads one bounded review's comments with current head/review identity checks. - Mobile feedback expands on demand, coalesces/caches by pull, head, and review, and exposes an explicit retry state. - A stale response cannot replace current feedback; Address feedback stays unavailable until comments load. - Focused tests and full suite pass.
timmy self-assigned this 2026-08-24 09:03:45 +00:00
timmy closed this issue 2026-08-24 09:26:54 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1342
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?