stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Load pull review feedback on demand without blocking mobile review #1343

Merged
timmy merged 1 commits from timmy/1342-lazy-review-feedback into main 2026-08-24 09:26:53 +00:00
Conversation 0 Commits 1 Files Changed 7 +364 -28
timmy commented 2026-08-24 09:17:09 +00:00
Owner
Copy Link

Summary

  • keep files, diff, CI, and blocking reviewer decisions on the core mobile review path
  • load bounded inline feedback through an authorized, head-guarded endpoint
  • coalesce/cache feedback by pull head and review; preserve expanded state and expose retry without losing merge blockers
  • validate the retry journey at 320×568 and 390×844

Verification

  • .venv/bin/pytest -q — 2530 passed, 15 skipped
  • tests/e2e/test_mobile_pull_reviewer_feedback_release.py — 4 passed

Closes #1342

## Summary - keep files, diff, CI, and blocking reviewer decisions on the core mobile review path - load bounded inline feedback through an authorized, head-guarded endpoint - coalesce/cache feedback by pull head and review; preserve expanded state and expose retry without losing merge blockers - validate the retry journey at 320×568 and 390×844 ## Verification - `.venv/bin/pytest -q` — 2530 passed, 15 skipped - `tests/e2e/test_mobile_pull_reviewer_feedback_release.py` — 4 passed Closes #1342
timmy added 1 commit 2026-08-24 09:17:10 +00:00
feat: load pull review feedback on demand (Closes #1342)
All checks were successful
CI / lint (pull_request) Successful in 3m25s
Details
CI / build-release (pull_request) Successful in 7s
Details
CI / browser-journey (pull_request) Successful in 5m34s
Details
CI / release-candidate (pull_request) Has been skipped
Details
611e79fc1e
timmy merged commit 1a2297e943 into main 2026-08-24 09:26:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1343
No description provided.
Delete Branch "timmy/1342-lazy-review-feedback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?