stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Apply reviewer code suggestions from mobile #1382

New Issue
Closed
opened 2026-08-25 05:55:18 +00:00 by timmy · 0 comments
timmy commented 2026-08-25 05:55:18 +00:00
Owner
Copy Link

User problem

On a phone, an authored pull request can show inline reviewer feedback, but applying a fenced suggestion requires loading and editing the entire file. This is slow and error-prone on narrow screens.

Vertical slice

Expose one valid inline suggestion as a bounded before/after change, let the pull author explicitly confirm it, and commit it through the existing expected-head/expected-blob guarded path. Unsupported or stale suggestions keep the full-file editor fallback.

Acceptance

  • Parse exactly one bounded fenced suggestion with path, current head, and source range.
  • Offer a compact review action only for the signed-in author on an open same-repository pull at the current head.
  • Preview escaped before/after content and require explicit confirmation.
  • Reject stale head/blob with no write; verify the advanced head and exact resulting content before success.
  • Preserve manual edit fallback, explicit feedback disposition, offline read-only behavior, single-flight actions, and mobile accessibility.
  • Behavioral backend/frontend tests and rendered Playwright checks at 320x568 and 390x844 pass.

Discovered by the 2026-08-25 autonomous architecture/mobile/reliability audit. Historical issue, PR, release, and recent commit scans found no equivalent shipped behavior.

## User problem On a phone, an authored pull request can show inline reviewer feedback, but applying a fenced `suggestion` requires loading and editing the entire file. This is slow and error-prone on narrow screens. ## Vertical slice Expose one valid inline suggestion as a bounded before/after change, let the pull author explicitly confirm it, and commit it through the existing expected-head/expected-blob guarded path. Unsupported or stale suggestions keep the full-file editor fallback. ## Acceptance - Parse exactly one bounded fenced suggestion with path, current head, and source range. - Offer a compact review action only for the signed-in author on an open same-repository pull at the current head. - Preview escaped before/after content and require explicit confirmation. - Reject stale head/blob with no write; verify the advanced head and exact resulting content before success. - Preserve manual edit fallback, explicit feedback disposition, offline read-only behavior, single-flight actions, and mobile accessibility. - Behavioral backend/frontend tests and rendered Playwright checks at 320x568 and 390x844 pass. Discovered by the 2026-08-25 autonomous architecture/mobile/reliability audit. Historical issue, PR, release, and recent commit scans found no equivalent shipped behavior.
timmy closed this issue 2026-08-25 06:19:22 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1382
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?