stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Apply reviewer code suggestions from mobile #1383

Merged
timmy merged 1 commits from timmy/1382-mobile-review-suggestions into main 2026-08-25 06:19:22 +00:00
Conversation 0 Commits 1 Files Changed 6 +267 -1
timmy commented 2026-08-25 06:08:46 +00:00
Owner
Copy Link

Closes #1382

What changed

  • recognize one bounded fenced suggestion on current inline review feedback
  • preview the exact current line and proposed replacement before committing
  • apply through existing head/blob conflict guards while keeping full-file fallback
  • clear stale previews on comment navigation and keep the flow read-only offline

Verification

  • RED: backend suggestion normalization failed with missing suggestion
  • RED: mobile journey failed with missing suggestion action; stale preview navigation test then failed
  • focused: 80 passed
  • full: 2628 passed, 22 skipped
  • rendered at 320x568 and 390x844 with no overflow and 44px controls
Closes #1382 ## What changed - recognize one bounded fenced suggestion on current inline review feedback - preview the exact current line and proposed replacement before committing - apply through existing head/blob conflict guards while keeping full-file fallback - clear stale previews on comment navigation and keep the flow read-only offline ## Verification - RED: backend suggestion normalization failed with missing `suggestion` - RED: mobile journey failed with missing suggestion action; stale preview navigation test then failed - focused: 80 passed - full: 2628 passed, 22 skipped - rendered at 320x568 and 390x844 with no overflow and 44px controls
timmy added 1 commit 2026-08-25 06:08:47 +00:00
feat: apply mobile review suggestions (Closes #1382)
All checks were successful
CI / lint (pull_request) Successful in 3m40s
Details
CI / build-release (pull_request) Successful in 7s
Details
CI / browser-journey (pull_request) Successful in 5m59s
Details
CI / release-candidate (pull_request) Has been skipped
Details
ed662c3a3a
timmy merged commit c8ffde7d96 into main 2026-08-25 06:19:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#1383
No description provided.
Delete Branch "timmy/1382-mobile-review-suggestions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?