stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Add draft-safe inline comments to mobile pull request reviews #165

New Issue
Closed
opened 2026-08-07 04:18:36 +00:00 by timmy · 0 comments
timmy commented 2026-08-07 04:18:36 +00:00
Owner
Copy Link

User problem

Mobile reviewers can inspect diffs and submit a review, but feedback can only be attached to a whole file or summary. They must leave the dashboard to point at a specific changed line.

Vertical slice

  • Make commentable diff lines touch-friendly and track old/new line coordinates.
  • Add, edit, and remove draft comments anchored to changed lines.
  • Persist drafts by repository, pull request, and expected head SHA.
  • Submit inline comments with the existing review decision in one Gitea review mutation.
  • Preserve drafts on timeout or stale-head conflict.

Acceptance tests

  • Multi-hunk additions, deletions, and context lines map to correct old/new coordinates; headers and no-newline markers are not commentable.
  • At mobile width, tapping a line opens an anchored composer and drafts survive reload.
  • The API rejects unknown paths, impossible coordinates, empty/oversized comments, and excessive counts without an upstream mutation.
  • A successful submission sends one review request with body, event, commit ID, and inline comments; failures preserve drafts.
  • Existing review-without-inline-comments behavior and the full suite remain green.

This behavior is absent from all historical issue titles and recent review commits through origin/main 4b7405a.

## User problem Mobile reviewers can inspect diffs and submit a review, but feedback can only be attached to a whole file or summary. They must leave the dashboard to point at a specific changed line. ## Vertical slice - Make commentable diff lines touch-friendly and track old/new line coordinates. - Add, edit, and remove draft comments anchored to changed lines. - Persist drafts by repository, pull request, and expected head SHA. - Submit inline comments with the existing review decision in one Gitea review mutation. - Preserve drafts on timeout or stale-head conflict. ## Acceptance tests - Multi-hunk additions, deletions, and context lines map to correct old/new coordinates; headers and no-newline markers are not commentable. - At mobile width, tapping a line opens an anchored composer and drafts survive reload. - The API rejects unknown paths, impossible coordinates, empty/oversized comments, and excessive counts without an upstream mutation. - A successful submission sends one review request with body, event, commit ID, and inline comments; failures preserve drafts. - Existing review-without-inline-comments behavior and the full suite remain green. This behavior is absent from all historical issue titles and recent review commits through origin/main 4b7405a.
timmy self-assigned this 2026-08-07 04:18:36 +00:00
timmy closed this issue 2026-08-07 04:29:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#165
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?