stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Keep inline pull-request review visible above the mobile keyboard #643

New Issue
Closed
opened 2026-08-12 10:49:50 +00:00 by timmy · 0 comments
timmy commented 2026-08-12 10:49:50 +00:00
Owner
Copy Link

Problem

On phone widths, tapping a diff line focuses the inline review textarea, but the review sheet is not registered with the shared visual-viewport controller. The software keyboard can therefore cover the feedback field and Save/Delete/Cancel actions.

Scope

  • Register the review inline composer with mobile viewport management.
  • Restore review-sheet geometry and scroll on cancel, sheet close, and route changes.
  • Extend keyboard-active mobile styling to the review panel and inline workspace.
  • Roll the offline shell cache for updated runtime assets.

Acceptance criteria

  • At mobile width, focusing inline review feedback applies visualViewport top/height and reveals the composer/actions.
  • Closing inline feedback or the review sheet clears temporary geometry/listeners while retaining existing draft behavior.
  • Desktop and missing-visualViewport behavior remain unchanged.
  • Behavioral focused tests and full suite pass.

Non-duplication evidence

Historical issue/PR title review found related completed work for inline reviews (#165), wrapped mobile diffs (#445), and keyboard-safe conversation/new-issue composers (#323/#489), but no review-inline visualViewport integration. Current open issues are assigned to other humans and do not cover this flow.

## Problem On phone widths, tapping a diff line focuses the inline review textarea, but the review sheet is not registered with the shared visual-viewport controller. The software keyboard can therefore cover the feedback field and Save/Delete/Cancel actions. ## Scope - Register the review inline composer with mobile viewport management. - Restore review-sheet geometry and scroll on cancel, sheet close, and route changes. - Extend keyboard-active mobile styling to the review panel and inline workspace. - Roll the offline shell cache for updated runtime assets. ## Acceptance criteria - At mobile width, focusing inline review feedback applies visualViewport top/height and reveals the composer/actions. - Closing inline feedback or the review sheet clears temporary geometry/listeners while retaining existing draft behavior. - Desktop and missing-visualViewport behavior remain unchanged. - Behavioral focused tests and full suite pass. ## Non-duplication evidence Historical issue/PR title review found related completed work for inline reviews (#165), wrapped mobile diffs (#445), and keyboard-safe conversation/new-issue composers (#323/#489), but no review-inline visualViewport integration. Current open issues are assigned to other humans and do not cover this flow.
timmy self-assigned this 2026-08-12 10:49:50 +00:00
timmy closed this issue 2026-08-12 10:56:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#643
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?