stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Open requested pull reviews from mobile Search #791

New Issue
Closed
opened 2026-08-14 01:33:52 +00:00 by timmy · 0 comments
timmy commented 2026-08-14 01:33:52 +00:00
Owner
Copy Link

Problem

Search preview treats an open pull request as read-only unless it is assigned to the operator, even when Gitea explicitly requests that operator's review. The native mobile review workspace already supports the complete review flow, but Search cannot hand off to it.

Product slice

  • Derive review-request eligibility from the authoritative pull request response, not the client-supplied result kind.
  • Show a touch-safe Review now action for open pull requests requesting the current operator.
  • Open the canonical in-app review route without mutating assignment.
  • Preserve Search state so Back returns to the same query and preview.
  • Fail closed for closed, unrelated, malformed, or withdrawn requests.

Acceptance tests

  • Requested, unassigned open pull shows Review now.
  • Assigned-only pull retains Open in My Work.
  • Closed/unrelated/malformed pull never shows Review now.
  • Review now opens the canonical review workspace and performs no assignment request.
  • Mobile action remains at least 44px with no horizontal overflow.

Implementation must use strict RED-GREEN TDD and include focused plus full-suite verification.

## Problem Search preview treats an open pull request as read-only unless it is assigned to the operator, even when Gitea explicitly requests that operator's review. The native mobile review workspace already supports the complete review flow, but Search cannot hand off to it. ## Product slice - Derive review-request eligibility from the authoritative pull request response, not the client-supplied result kind. - Show a touch-safe **Review now** action for open pull requests requesting the current operator. - Open the canonical in-app review route without mutating assignment. - Preserve Search state so Back returns to the same query and preview. - Fail closed for closed, unrelated, malformed, or withdrawn requests. ## Acceptance tests - Requested, unassigned open pull shows Review now. - Assigned-only pull retains Open in My Work. - Closed/unrelated/malformed pull never shows Review now. - Review now opens the canonical review workspace and performs no assignment request. - Mobile action remains at least 44px with no horizontal overflow. Implementation must use strict RED-GREEN TDD and include focused plus full-suite verification.
timmy self-assigned this 2026-08-14 01:33:52 +00:00
timmy closed this issue 2026-08-14 01:47:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
timmy
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#791
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?