stackchain/stackchain-dashboard
1
0
Fork 0
Code Issues 9 Pull Requests 1 Actions Packages Projects Releases 713 Wiki Activity

Keep mobile review handoff working when popups are blocked #144

Merged
timmy merged 1 commits from timmy/143-popup-safe-review-handoff into main 2026-08-06 22:26:13 +00:00
Conversation 0 Commits 1 Files Changed 3 +99 -34
timmy commented 2026-08-06 22:25:32 +00:00
Owner
Copy Link

Closes #143

What changed

  • reserve the Gitea tab synchronously before clipboard access
  • navigate only after a successful copy and close the reservation on copy failure
  • truthfully handle blocked popups with a touch-sized direct Gitea fallback
  • guard repeated taps while a handoff is pending

Verification

  • RED: focused handoff tests failed against the old copy-then-open behavior
  • GREEN: python3 -m pytest tests/ -q → 127 passed
Closes #143 ## What changed - reserve the Gitea tab synchronously before clipboard access - navigate only after a successful copy and close the reservation on copy failure - truthfully handle blocked popups with a touch-sized direct Gitea fallback - guard repeated taps while a handoff is pending ## Verification - RED: focused handoff tests failed against the old copy-then-open behavior - GREEN: `python3 -m pytest tests/ -q` → 127 passed
timmy added 1 commit 2026-08-06 22:25:32 +00:00
fix: keep mobile review handoff popup-safe (#143)
All checks were successful
CI / lint (pull_request) Successful in 10s
Details
CI / build-frontend (pull_request) Successful in 4s
Details
b51542363c
timmy merged commit 955343a428 into main 2026-08-06 22:26:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Drop everything

  
P1

High priority

  
P2

Medium priority

  
agent:nightprowl

Assignments routed to the LongCat NightProwl evaluation worker

  
backend

Backend service

  
ci

Continuous integration / actions

  
frontend

Frontend / UI

  
meta

Meta / planning

  
pages

Gitea Pages

  
template

Repo template / standards

No Label
P0
P1
P2
agent:nightprowl
backend
ci
frontend
meta
pages
template
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-dashboard#144
No description provided.
Delete Branch "timmy/143-popup-safe-review-handoff"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?