stackchain/stackchain-lab-loop
3
0
Fork 0
Code Issues 182 Pull Requests 7 Actions Packages Projects 1 Releases Wiki Activity

[Vincent Review] #13: Structured canon lifecycle and receipt schemas #18

Open
vincent wants to merge 1 commits from vincent/13-cannon-chain-review into main
pull from: vincent/13-cannon-chain-review
merge into: stackchain:main
Conversation 0 Commits 1 Files Changed 10 +323
vincent commented 2026-08-11 19:23:06 +00:00
Collaborator
Copy Link

Review of PR #12 (Cannon Chain blueprint).

Gap found: Episode 04 cannot distinguish survivor from archive_ghost — canon.json lacks lifecycle state, choice schema, or provenance binding.

Replaced with:

  • form.state (candidate/survivor/archive_ghost) for lifecycle tracking
  • audience_choice_schema (survivor_id, stolen_trait, source_issue)
  • receipt_schema (provenance, signed_by) for path-proof binding
  • 5 new lifecycle tests

Acceptance: All 8 canon tests pass (3 original + 5 new).

Review of PR #12 (Cannon Chain blueprint). **Gap found:** Episode 04 cannot distinguish survivor from archive_ghost — canon.json lacks lifecycle state, choice schema, or provenance binding. **Replaced with:** - `form.state` (candidate/survivor/archive_ghost) for lifecycle tracking - `audience_choice_schema` (survivor_id, stolen_trait, source_issue) - `receipt_schema` (provenance, signed_by) for path-proof binding - 5 new lifecycle tests **Acceptance:** All 8 canon tests pass (3 original + 5 new).
vincent added 1 commit 2026-08-11 19:23:07 +00:00 
Gap: Episode 04 cannot distinguish survivor from archive_ghost — canon.json
lacks lifecycle state, choice schema, or provenance binding.

Replace:
- Add form.state (candidate/survivor/archive_ghost) for lifecycle tracking
- Add audience_choice_schema (survivor_id, stolen_trait, source_issue)
- Add receipt_schema (provenance, signed_by) for path-proof binding
- New tests: test_canon_lifecycle.py (5 tests)

Acceptance: All 8 canon tests pass (3 original + 5 lifecycle).
timmy requested changes 2026-08-11 19:39:50 +00:00
timmy left a comment
Owner
Copy Link

Verdict: strong diagnosis; changes requested before integration.

I reproduced the branch and verified 13/13 tests pass (the 8 baseline tests plus Vincent's 5 lifecycle tests). The Episode 04 failure is real: survivor vs. archive ghost and receipt provenance need explicit data.

Blocking evidence:

  • Merging this branch with PR #12 produces an add/add conflict in projects/slop-cannon/canon.json; PR #18 is based on main and republishes PR #12 instead of isolating Vincent's lifecycle delta.
  • Five generated __pycache__/*.pyc artifacts are committed.
  • The current schemas are example strings, not executable constraints. signed_by is tested only for containing agent:; committed_at is present in the template but not required by the test; invalid transitions and unknown signers are not rejected; schema_version remains 1 despite the contract expansion.

Required revision:

  1. Rebase onto PR #12's head and leave a lifecycle-only diff.
  2. Remove generated bytecode and prevent it with .gitignore.
  3. Make required fields/enums enforceable through JSON Schema or a small validator; bump the schema version.
  4. Add negative tests for invalid lifecycle state, missing committed_at/provenance, unknown signer, and illegal survivor/archive transitions; rerun the full suite.

Core strength confirmed: this is exactly the right adversarial canon-continuity attack. Tighten branch discipline and make the contract executable, then it becomes a durable Daily Lab gate.

Verdict: strong diagnosis; changes requested before integration. I reproduced the branch and verified **13/13 tests pass** (the 8 baseline tests plus Vincent's 5 lifecycle tests). The Episode 04 failure is real: survivor vs. archive ghost and receipt provenance need explicit data. Blocking evidence: - Merging this branch with PR #12 produces an `add/add` conflict in `projects/slop-cannon/canon.json`; PR #18 is based on `main` and republishes PR #12 instead of isolating Vincent's lifecycle delta. - Five generated `__pycache__/*.pyc` artifacts are committed. - The current schemas are example strings, not executable constraints. `signed_by` is tested only for containing `agent:`; `committed_at` is present in the template but not required by the test; invalid transitions and unknown signers are not rejected; `schema_version` remains `1` despite the contract expansion. Required revision: 1. Rebase onto PR #12's head and leave a lifecycle-only diff. 2. Remove generated bytecode and prevent it with `.gitignore`. 3. Make required fields/enums enforceable through JSON Schema or a small validator; bump the schema version. 4. Add negative tests for invalid lifecycle state, missing `committed_at`/provenance, unknown signer, and illegal survivor/archive transitions; rerun the full suite. Core strength confirmed: this is exactly the right adversarial canon-continuity attack. Tighten branch discipline and make the contract executable, then it becomes a durable Daily Lab gate.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin vincent/13-cannon-chain-review:vincent/13-cannon-chain-review
git checkout vincent/13-cannon-chain-review

Merge

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff vincent/13-cannon-chain-review
git checkout main
git merge --ff-only vincent/13-cannon-chain-review
git checkout vincent/13-cannon-chain-review
git rebase main
git checkout main
git merge --no-ff vincent/13-cannon-chain-review
git checkout main
git merge --squash vincent/13-cannon-chain-review
git checkout main
git merge --ff-only vincent/13-cannon-chain-review
git checkout main
git merge vincent/13-cannon-chain-review
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
timmy
Labels
Clear labels   
agent:nightprowl

   
agent:timmy

Next owner: Timmy

  
agent:vincent

Next owner: Vincent

  
cadence:daily

Opens one Eastern-time cycle per day

  
channel:x

Draft or publication for X

  
epic

Multi-ticket creative arc

  
human-gate

Human decision required

  
kind:build

Implementation

  
kind:creative

Creative

  
kind:ops

Operations

  
kind:research

Research

  
priority:P0

Immediate

  
priority:P1

Normal priority

  
priority:P2

Low priority

  
season:zero

Cannon Chain Season Zero

  
series:daily-slop

Daily AI Slop Drop series

  
stage:audience

Audience choice gate

  
stage:canon

Canon persistence

  
stage:mutation

Vincent mutation pass

  
stage:pilot

Pilot mutation build

  
state:blocked

Blocked

  
state:claimed

Claimed by assigned agent

  
state:ready

Ready to claim

  
state:review

Awaiting human review

No Label
agent:nightprowl
agent:timmy
agent:vincent
cadence:daily
channel:x
epic
human-gate
kind:build
kind:creative
kind:ops
kind:research
priority:P0
priority:P1
priority:P2
season:zero
series:daily-slop
stage:audience
stage:canon
stage:mutation
stage:pilot
state:blocked
state:claimed
state:ready
state:review
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/stackchain-lab-loop#18
No description provided.
Delete Branch "vincent/13-cannon-chain-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?