Compare commits
14
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
9f69730780 | ||
|
|
fa5f4232dd | ||
|
|
1d338ed35b | ||
|
|
6aacefca65 | ||
|
|
578cc9f129 | ||
|
|
860c84f0fe | ||
|
|
3565ce87a4 | ||
|
|
4ac71915fb | ||
|
|
5a15fa660e | ||
|
|
2094a07d9f | ||
|
|
baabeb0f4f | ||
|
|
11c63a8d25 | ||
|
|
ef22ea8970 | ||
|
|
d0b3c10aea |
No files matched your search
@@ -33,6 +33,7 @@ jobs:
|
||||
run: |
|
||||
npm test
|
||||
python3 tests/staging-deploy.test.py -v
|
||||
python3 tests/corpus-manifest.test.py -v
|
||||
- name: Mobile browser acceptance
|
||||
run: |
|
||||
npm start > /tmp/timmy-server.log 2>&1 &
|
||||
@@ -59,6 +60,8 @@ jobs:
|
||||
npm run test:worker-readiness
|
||||
npm run test:pattern-summary
|
||||
npm run test:photo-lifecycle
|
||||
npm run test:training-contribution
|
||||
npm run test:portability
|
||||
- name: Dependency audit
|
||||
run: npm audit --audit-level=high
|
||||
- name: Syntax checks
|
||||
|
||||
@@ -122,7 +122,7 @@ npm audit --audit-level=high
|
||||
- A committed CC0 synthetic vision corpus that continuously proves every reply is schema-valid or fails closed. A schema-valid reply with no readable form or colour now **abstains** ("No confident match") instead of surfacing as a worker failure, and unparsable or out-of-range replies return plain copy — "No suggestion was applied. Continue manually, or try a clearer photo." — with no provider text, image bytes, or credentials echoed. See [tests/fixtures/vision-corpus](tests/fixtures/vision-corpus/README.md)
|
||||
- Unsaved logging drafts are retained in the session with an explicit start over, and the service worker never caches analysis requests or image bodies
|
||||
- Private photo lifecycle: a confirmed log reports a saved photo as a label rather than a thumbnail, showing the image is an explicit request, removing the photo keeps every confirmed field, deleting a log is a separate two-step decision, and delete-all removes the ledger and every stored photo together
|
||||
- Local browser ledger, calendar, pattern summary, JSON portability, and delete-all
|
||||
- Local browser ledger, calendar, pattern summary, versioned JSON backup (logs, training receipts, and per-log AI provenance) with safe upgrade/refusal on import, and delete-all
|
||||
- Explainable pattern summaries: the home insight card reports the confirmed-log count and form groupings for the last 28 days, every line names the exact confirmed records behind it, following a citation opens those records, and a window below the minimum says it is too sparse instead of describing a trend. No line explains a cause, rules on food, or offers a health verdict
|
||||
- Installable/offline PWA shell for the manual and saved-ledger paths
|
||||
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { bucketForBristolType, detectUrgentFlags, detectUrgentText, exportLedger, hasUrgentLedgerContext, importLedger, photoQualityMessage, sanitizeEntry, urgentChatMessage } from './src/domain.js';
|
||||
import { bucketForBristolType, detectUrgentFlags, detectUrgentText, exportLedgerBackup, LEDGER_EXPORT_VERSION, hasUrgentLedgerContext, importLedgerBackup, photoQualityMessage, sanitizeEntry, urgentChatMessage } from './src/domain.js';
|
||||
import { mergeVisualSuggestion } from './src/analysis.js';
|
||||
import { createDraft, draftNotice, isDraftDirty } from './src/draft.js';
|
||||
import { changeVisualField, confirmSuggestion, createSuggestionState, provenanceCopy } from './src/suggestion.js';
|
||||
@@ -7,6 +7,7 @@ import { visionReadiness } from './src/vision-readiness.js';
|
||||
import { buildPatternSummary } from './src/summary.js';
|
||||
import { answerFromLedger, buildChatLedger, resolveAgentReply } from './src/grounded-chat.js';
|
||||
import { photoState, withoutEntry, withoutPhoto } from './src/photo-lifecycle.js';
|
||||
import { addContribution, consentTerms, contributionEligibility, contributionForEntry, receiptPreview, withdrawContribution } from './src/training-contribution.js';
|
||||
|
||||
const runtimeConfig = {
|
||||
basePath: document.querySelector('meta[name="timmy-base-path"]')?.content || '/',
|
||||
@@ -16,6 +17,7 @@ const BASE_PATH = runtimeConfig.basePath || '/';
|
||||
const APP_ROOT = BASE_PATH === '/' ? '/' : `${BASE_PATH}/`;
|
||||
function appPath(path='') { return `${APP_ROOT}${String(path).replace(/^\/+/, '')}`; }
|
||||
const STORE = `timmy:${BASE_PATH}:ledger-v1`;
|
||||
const TRAINING_STORE = `timmy:${BASE_PATH}:training-contributions-v1`;
|
||||
const LEGACY_STORE = 'timmy-ledger-v1';
|
||||
if (BASE_PATH === '/') {
|
||||
const legacyEntries = localStorage.getItem(LEGACY_STORE);
|
||||
@@ -28,6 +30,7 @@ if (BASE_PATH === '/') {
|
||||
}
|
||||
const app = document.querySelector('#app');
|
||||
let entries = loadEntries();
|
||||
let contributions = loadContributions();
|
||||
let view = 'home';
|
||||
let photoHint = '';
|
||||
let aiSuggestion = null;
|
||||
@@ -39,6 +42,10 @@ let chatBusy = false;
|
||||
let chatError = '';
|
||||
let chatMessages = [{ role: 'timmy', text: 'Ask me about your confirmed logs, visible patterns, privacy, or how Timmy works.' }];
|
||||
let draftResumed = false;
|
||||
// Issue #35 — importing a backup reports which version the file came from and what changed, and a
|
||||
// refused file leaves the ledger exactly as it was. The notice is state, not a toast, because a
|
||||
// message that disappears in two seconds cannot tell anyone whether their records were replaced.
|
||||
let portabilityNotice = null;
|
||||
let form = createDraft();
|
||||
let followUpAnswers = createFollowUpAnswers();
|
||||
|
||||
@@ -86,6 +93,10 @@ function refreshFollowUp(){
|
||||
function esc(value='') { return String(value).replace(/[&<>'"]/g, c => ({'&':'&','<':'<','>':'>',"'":''','"':'"'}[c])); }
|
||||
function loadEntries() { try { return JSON.parse(localStorage.getItem(STORE) || '[]'); } catch { return []; } }
|
||||
function saveEntries() { localStorage.setItem(STORE, JSON.stringify(entries)); }
|
||||
// Training contribution receipts are their own store: a journal save never writes here, and a
|
||||
// withdrawal keeps a tombstone instead of quietly erasing the audit trail.
|
||||
function loadContributions() { try { return JSON.parse(localStorage.getItem(TRAINING_STORE) || '[]'); } catch { return []; } }
|
||||
function saveContributions() { localStorage.setItem(TRAINING_STORE, JSON.stringify(contributions)); }
|
||||
function formatDate(value) { return new Intl.DateTimeFormat(undefined,{month:'short',day:'numeric',hour:'numeric',minute:'2-digit'}).format(new Date(value)); }
|
||||
function toast(message) { const node=document.createElement('div');node.className='toast';node.textContent=message;document.body.append(node);setTimeout(()=>node.remove(),2400); }
|
||||
|
||||
@@ -101,6 +112,8 @@ function bindGlobal(){
|
||||
document.querySelectorAll('[data-scan]').forEach(btn=>btn.onclick=openPhotoFirst);
|
||||
document.querySelectorAll('[data-statement-link]').forEach(btn=>btn.onclick=()=>showPatternRecords(btn.dataset.statementLink));
|
||||
document.querySelectorAll('[data-entry-open]').forEach(btn=>btn.onclick=()=>showEntrySheet(btn.dataset.entryOpen));
|
||||
document.querySelectorAll('[data-contribute-entry]').forEach(btn=>btn.onclick=()=>showContributionConsent(btn.dataset.contributeEntry));
|
||||
document.querySelectorAll('[data-withdraw]').forEach(btn=>btn.onclick=()=>withdrawTrainingContribution(btn.dataset.withdraw));
|
||||
}
|
||||
|
||||
function recentList(limit=5){
|
||||
@@ -122,7 +135,7 @@ function showEntrySheet(id, armed=false){
|
||||
const urgent=detectUrgentFlags(entry.symptoms);
|
||||
document.querySelector('.sheet-backdrop')?.remove();
|
||||
const wrap=document.createElement('div');wrap.className='sheet-backdrop';
|
||||
wrap.innerHTML=`<section class="sheet" role="dialog" aria-modal="true" aria-labelledby="entry-sheet-title"><div class="sheet-handle"></div><div class="sheet-header"><div><span class="eyebrow">Confirmed log</span><h2 id="entry-sheet-title">${formatDate(entry.occurredAt)}</h2></div><button class="icon-btn" id="entry-sheet-close" aria-label="Close">×</button></div><div class="entry-facts"><div><span>Form</span><strong>Type ${entry.bristolType}</strong></div><div><span>Color</span><strong>${esc(entry.color)}</strong></div><div><span>Urgency</span><strong>${entry.urgency}/4</strong></div><div><span>Discomfort</span><strong>${entry.discomfort}/4</strong></div></div>${entry.note?`<p class="fine entry-note">${esc(entry.note)}</p>`:''}${urgent.urgent?alertHtml(urgent.message):''}${photo.hasPhoto?`<section class="photo-lifecycle" data-photo-lifecycle="present"><strong>Photo saved with this log</strong><p class="fine">The image stays in this browser. The journal never shows it as a thumbnail until you ask.</p><div id="entry-photo-slot"></div><div class="row"><button class="btn btn-secondary" id="show-entry-photo">Show photo</button><button class="btn btn-ghost" id="remove-entry-photo">Remove photo, keep log</button></div></section>`:`<section class="photo-lifecycle" data-photo-lifecycle="absent"><strong>No photo saved</strong><p class="fine">This confirmed log is text only. Its record does not depend on an image.</p></section>`}<div class="entry-actions">${armed?`<button class="btn btn-danger btn-wide" id="delete-entry-confirm">Tap again to delete this log and its photo</button><p class="fine">This removes the confirmed log and its saved photo from this browser. It cannot be undone.</p>`:`<button class="btn btn-ghost btn-wide" id="delete-entry">Delete this log and its photo</button>`}</div></section>`;
|
||||
wrap.innerHTML=`<section class="sheet" role="dialog" aria-modal="true" aria-labelledby="entry-sheet-title"><div class="sheet-handle"></div><div class="sheet-header"><div><span class="eyebrow">Confirmed log</span><h2 id="entry-sheet-title">${formatDate(entry.occurredAt)}</h2></div><button class="icon-btn" id="entry-sheet-close" aria-label="Close">×</button></div><div class="entry-facts"><div><span>Form</span><strong>Type ${entry.bristolType}</strong></div><div><span>Color</span><strong>${esc(entry.color)}</strong></div><div><span>Urgency</span><strong>${entry.urgency}/4</strong></div><div><span>Discomfort</span><strong>${entry.discomfort}/4</strong></div></div>${entry.note?`<p class="fine entry-note">${esc(entry.note)}</p>`:''}${entry.provenance?`<p class="fine entry-provenance" data-entry-provenance="${esc(entry.provenance.source)}">${esc(entry.provenance.source==='ai-corrected'?'Saved from an AI suggestion you corrected. Your values are stored, not the model’s.':'Saved from an AI suggestion you confirmed: visible form and color only, never a diagnosis.')}${entry.provenance.model?` Model: ${esc(entry.provenance.model)}.`:''}</p>`:''}${urgent.urgent?alertHtml(urgent.message):''}${photo.hasPhoto?`<section class="photo-lifecycle" data-photo-lifecycle="present"><strong>Photo saved with this log</strong><p class="fine">The image stays in this browser. The journal never shows it as a thumbnail until you ask.</p><div id="entry-photo-slot"></div><div class="row"><button class="btn btn-secondary" id="show-entry-photo">Show photo</button><button class="btn btn-ghost" id="remove-entry-photo">Remove photo, keep log</button></div></section>`:`<section class="photo-lifecycle" data-photo-lifecycle="absent"><strong>No photo saved</strong><p class="fine">This confirmed log is text only. Its record does not depend on an image.</p></section>`}<div class="entry-actions">${armed?`<button class="btn btn-danger btn-wide" id="delete-entry-confirm">Tap again to delete this log and its photo</button><p class="fine">This removes the confirmed log and its saved photo from this browser. It cannot be undone.</p>`:`<button class="btn btn-ghost btn-wide" id="delete-entry">Delete this log and its photo</button>`}</div></section>`;
|
||||
document.body.append(wrap);
|
||||
if(entrySheetKeyHandler)document.removeEventListener('keydown',entrySheetKeyHandler);
|
||||
const close=()=>{wrap.remove();document.removeEventListener('keydown',onKey);if(entrySheetKeyHandler===onKey)entrySheetKeyHandler=null};
|
||||
@@ -245,13 +258,68 @@ async function sendChat(event){
|
||||
finally{chatBusy=false;timmy()}
|
||||
}
|
||||
|
||||
// Issue #24 — contributing a confirmed photo to training is a second, separate consent. A journal
|
||||
// save writes nothing here, the consent version and the receipt are on screen before the confirm
|
||||
// control can be pressed, and a withdrawal keeps a tombstone naming every derived artifact by
|
||||
// contribution id. Nothing is transmitted in this build: the receipt is queued on the device.
|
||||
function newContributionId(){
|
||||
const raw=globalThis.crypto?.randomUUID?.()||`${Date.now().toString(16)}${Math.random().toString(16).slice(2)}`;
|
||||
return `contrib-${String(raw).replace(/[^a-z0-9]/gi,'').slice(0,12)}`;
|
||||
}
|
||||
function trainingConsentSection(){
|
||||
const terms=consentTerms();
|
||||
const queued=contributions.filter(receipt=>receipt.state!=='withdrawn').length;
|
||||
const active=contributions.filter(receipt=>receipt.state!=='withdrawn').map(receipt=>`<div class="contribution-row" data-contribution-state="${esc(receipt.state)}"><div><strong>Type ${receipt.labels.bristolType} · ${esc(receipt.labels.color)}</strong><span>Receipt ${esc(receipt.contributionId)} · consent ${esc(receipt.consentVersion)}</span></div><button class="btn btn-ghost" data-withdraw="${esc(receipt.contributionId)}">Withdraw</button></div>`);
|
||||
const offerable=entries.filter(entry=>contributionEligibility(entry).eligible&&!contributions.some(receipt=>receipt.entryId===entry.id)).map(entry=>`<div class="contribution-row"><div><strong>${formatDate(entry.occurredAt)}</strong><span>Type ${entry.bristolType} · photo saved</span></div><button class="btn btn-secondary" data-contribute-entry="${esc(entry.id)}">Review opt-in</button></div>`);
|
||||
const tombstones=contributions.filter(receipt=>receipt.state==='withdrawn').map(receipt=>`<div class="contribution-row withdrawn" data-contribution-state="withdrawn"><div><strong>Withdrawn ${esc(formatDate(receipt.withdrawnAt))}</strong><span data-withdrawn-artifacts>raw image, confirmed label · receipt ${esc(receipt.contributionId)}</span></div></div>`);
|
||||
const rows=[...active,...offerable].join('');
|
||||
return `<section class="section card training-consent" data-training-consent><h2>Training contribution</h2><p class="fine">Off by default. Saving a log never contributes it, and nothing is uploaded in this build — a receipt is queued on this device.</p><p class="fine">Consent version <code data-contribution-consent-version>${esc(terms.version)}</code> · <span data-contribution-queued-count>${queued}</span> queued</p>${rows?`<div class="contribution-list">${rows}</div>`:'<p class="fine">No saved photos are available to contribute yet.</p>'}${tombstones.length?`<h3>Withdrawn receipts</h3>${tombstones.join('')}`:''}<p class="fine">Deleting all local data below also clears these receipts.</p></section>`;
|
||||
}
|
||||
let contributionSheetKeyHandler=null;
|
||||
function showContributionConsent(entryId){
|
||||
const entry=entries.find(item=>item.id===entryId);
|
||||
const eligibility=contributionEligibility(entry);
|
||||
if(!eligibility.eligible){toast(eligibility.reason||'This log cannot be contributed.');return}
|
||||
if(contributionForEntry(contributions,entryId)){toast('This log already has an active contribution receipt.');return}
|
||||
const terms=consentTerms();
|
||||
const contributionId=newContributionId();
|
||||
const consentedAt=new Date().toISOString();
|
||||
document.querySelector('.sheet-backdrop')?.remove();
|
||||
const wrap=document.createElement('div');wrap.className='sheet-backdrop';
|
||||
wrap.innerHTML=`<section class="sheet" role="dialog" aria-modal="true" aria-labelledby="contribution-title" data-contribution-sheet><div class="sheet-handle"></div><div class="sheet-header"><div><span class="eyebrow">Separate consent</span><h2 id="contribution-title">Contribute one photo?</h2></div><button class="icon-btn" id="contribution-cancel" aria-label="Close">×</button></div><div class="consent-card"><p class="fine">Consent version <code data-contribution-version>${esc(terms.version)}</code></p><p class="fine">Receipt <code data-receipt-id>${esc(contributionId)}</code> · ${esc(formatDate(consentedAt))}</p><p class="fine"><strong>Included:</strong> ${esc(terms.includes.join('; '))}.</p><p class="fine"><strong>Never included:</strong> ${esc(terms.excludes.join('; '))}.</p><p class="fine">${esc(terms.transport)}</p></div><label class="check"><input id="training-consent-check" type="checkbox"><span>I have read consent ${esc(terms.version)} and want this one log contributed.</span></label><button class="btn btn-primary btn-wide" id="contribute-confirm" disabled>Contribute this photo and label</button><button class="btn btn-ghost btn-wide section" id="contribution-cancel-bottom">Not now</button></section>`;
|
||||
document.body.append(wrap);
|
||||
if(contributionSheetKeyHandler)document.removeEventListener('keydown',contributionSheetKeyHandler);
|
||||
const close=()=>{wrap.remove();document.removeEventListener('keydown',onKey);if(contributionSheetKeyHandler===onKey)contributionSheetKeyHandler=null};
|
||||
const onKey=event=>{if(event.key==='Escape')close()};
|
||||
contributionSheetKeyHandler=onKey;
|
||||
document.addEventListener('keydown',onKey);
|
||||
document.querySelector('#contribution-cancel').onclick=close;
|
||||
document.querySelector('#contribution-cancel-bottom').onclick=close;
|
||||
wrap.onclick=event=>{if(event.target===wrap)close()};
|
||||
const check=document.querySelector('#training-consent-check'),confirm=document.querySelector('#contribute-confirm');
|
||||
check.onchange=()=>{confirm.disabled=!check.checked};
|
||||
confirm.onclick=()=>{
|
||||
try{
|
||||
contributions=addContribution(contributions,receiptPreview(entry,{contributionId,consentedAt}));
|
||||
saveContributions();close();render();toast('Queued on this device. Nothing was uploaded.');
|
||||
}catch(error){toast(error.message||'That receipt could not be recorded.')}
|
||||
};
|
||||
}
|
||||
function withdrawTrainingContribution(contributionId){
|
||||
const result=withdrawContribution(contributions,contributionId,new Date().toISOString());
|
||||
if(!result.tombstone){toast('That contribution receipt was not found.');return}
|
||||
contributions=result.contributions;saveContributions();render();toast('Contribution withdrawn. The receipt is kept as a tombstone.');
|
||||
return result.tombstone;
|
||||
}
|
||||
|
||||
function privacy(){
|
||||
shell(`<main><div class="page-title"><span class="eyebrow">Private by design</span><h1>Your poop. Your phone.</h1><p>This prototype has no account, analytics, ad tracker, or server database.</p></div><section class="card privacy-list"><div class="privacy-item"><b>⌂</b><div><h3>Stored locally</h3><p>Saved entries and optional photos live in this browser’s local storage. You can remove one photo without deleting its confirmed log.</p></div></div><div class="privacy-item"><b>⇩</b><div><h3>Portable</h3><p>Export a readable JSON file. Import it in another copy of Timmy.</p></div></div><div class="privacy-item"><b>◎</b><div><h3>AI only when you ask</h3><p>Manual logging never uploads. Analyze a photo sends one compressed copy after consent. Hermes chat may receive up to 20 confirmed text-only entries after you connect; photos and backend credentials never enter chat.</p></div></div></section><section class="section card"><h2>Data controls</h2><div class="row"><button class="btn btn-primary" id="export">Export JSON</button><label class="btn btn-secondary" for="import">Import JSON</label><input class="hidden" type="file" id="import" accept="application/json"></div><p class="fine section">Exports can contain sensitive health notes and photos. Store them somewhere you trust.</p></section><section class="section card source-list"><h2>Health sources</h2><p class="fine">The Bristol groupings and urgent-symptom copy are grounded in public clinical guidance.</p><p><a target="_blank" rel="noreferrer" href="https://www.continence.org.au/about-incontinence/bowel-incontinence/bristol-stool-chart/">Continence Health Australia</a></p><p><a target="_blank" rel="noreferrer" href="https://www.nhs.uk/conditions/bleeding-from-the-bottom-rectal-bleeding/">NHS rectal bleeding guidance</a></p><p><a target="_blank" rel="noreferrer" href="https://www.niddk.nih.gov/health-information/digestive-diseases/constipation/symptoms-causes">NIDDK constipation guidance</a></p></section><section class="section card danger-zone"><h2>Delete everything</h2><p class="fine">Permanently removes Timmy’s local ledger and every saved photo from this browser.</p><button class="btn btn-danger" id="delete-all">Delete all local data</button></section></main>`);
|
||||
shell(`<main><div class="page-title"><span class="eyebrow">Private by design</span><h1>Your poop. Your phone.</h1><p>This prototype has no account, analytics, ad tracker, or server database.</p></div><section class="card privacy-list"><div class="privacy-item"><b>⌂</b><div><h3>Stored locally</h3><p>Saved entries and optional photos live in this browser’s local storage. You can remove one photo without deleting its confirmed log.</p></div></div><div class="privacy-item"><b>⇩</b><div><h3>Portable</h3><p>Export a readable JSON file. Import it in another copy of Timmy.</p></div></div><div class="privacy-item"><b>◎</b><div><h3>AI only when you ask</h3><p>Manual logging never uploads. Analyze a photo sends one compressed copy after consent. Hermes chat may receive up to 20 confirmed text-only entries after you connect; photos and backend credentials never enter chat.</p></div></div></section><section class="section card"><h2>Data controls</h2><div class="row"><button class="btn btn-primary" id="export">Export JSON</button><label class="btn btn-secondary" for="import">Import JSON</label><input class="hidden" type="file" id="import" accept="application/json"></div><p class="fine section">Exports can contain sensitive health notes and photos. Store them somewhere you trust.</p></section>${portabilityNoticeBlock()}${trainingConsentSection()}<section class="section card source-list"><h2>Health sources</h2><p class="fine">The Bristol groupings and urgent-symptom copy are grounded in public clinical guidance.</p><p><a target="_blank" rel="noreferrer" href="https://www.continence.org.au/about-incontinence/bowel-incontinence/bristol-stool-chart/">Continence Health Australia</a></p><p><a target="_blank" rel="noreferrer" href="https://www.nhs.uk/conditions/bleeding-from-the-bottom-rectal-bleeding/">NHS rectal bleeding guidance</a></p><p><a target="_blank" rel="noreferrer" href="https://www.niddk.nih.gov/health-information/digestive-diseases/constipation/symptoms-causes">NIDDK constipation guidance</a></p></section><section class="section card danger-zone"><h2>Delete everything</h2><p class="fine">Permanently removes Timmy’s local ledger and every saved photo from this browser.</p><button class="btn btn-danger" id="delete-all">Delete all local data</button></section></main>`);
|
||||
document.querySelector('#export').onclick=exportData;document.querySelector('#import').onchange=importData;document.querySelector('#delete-all').onclick=deleteData;
|
||||
}
|
||||
function exportData(){const blob=new Blob([exportLedger(entries)],{type:'application/json'}),a=document.createElement('a');a.href=URL.createObjectURL(blob);a.download='timmy-ledger.json';a.click();URL.revokeObjectURL(a.href);toast('Export created');}
|
||||
async function importData(e){try{const text=await e.target.files[0].text();entries=importLedger(text);saveEntries();render();toast('Ledger imported')}catch(err){toast(err.message)}}
|
||||
function deleteData(){if(confirm('Delete every local Timmy entry and photo? This cannot be undone.')){entries=[];localStorage.removeItem(STORE);localStorage.removeItem(LEGACY_STORE);render();toast('Local ledger and photos deleted')}}
|
||||
function exportData(){const blob=new Blob([exportLedgerBackup({entries,contributions})],{type:'application/json'}),a=document.createElement('a');a.href=URL.createObjectURL(blob);a.download=`timmy-backup-v${LEDGER_EXPORT_VERSION}.json`;a.click();URL.revokeObjectURL(a.href);portabilityNotice={kind:'ok',version:LEDGER_EXPORT_VERSION,text:`Backup written as version ${LEDGER_EXPORT_VERSION}: ${entries.length} log${entries.length===1?'':'s'} and ${contributions.length} training receipt${contributions.length===1?'':'s'}.`};render();toast('Backup exported');}
|
||||
async function importData(e){const file=e.target.files?.[0];if(!file)return;try{const result=importLedgerBackup(await file.text());entries=result.entries;contributions=result.contributions;saveEntries();saveContributions();portabilityNotice={kind:'ok',version:result.fromVersion,text:[`Restored ${result.entries.length} log${result.entries.length===1?'':'s'} and ${result.contributions.length} training receipt${result.contributions.length===1?'':'s'} from a version ${result.fromVersion} backup.`,...result.notices].join(' ')};e.target.value='';render();toast('Backup imported')}catch(err){portabilityNotice={kind:'error',text:`${err.message||'That backup could not be read.'} Your ledger is unchanged.`};e.target.value='';render();toast('Nothing was imported')}}
|
||||
function portabilityNoticeBlock(){if(!portabilityNotice)return '';if(portabilityNotice.kind==='error')return `<p class="portability-notice error" role="alert" data-portability-error>${esc(portabilityNotice.text)}</p>`;return `<p class="portability-notice" role="status" data-portability-notice data-portability-version="${esc(String(portabilityNotice.version))}">${esc(portabilityNotice.text)}</p>`}
|
||||
function deleteData(){if(confirm('Delete every local Timmy entry and photo? This cannot be undone.')){entries=[];contributions=[];portabilityNotice=null;localStorage.removeItem(STORE);localStorage.removeItem(LEGACY_STORE);localStorage.removeItem(TRAINING_STORE);render();toast('Local ledger and photos deleted')}}
|
||||
|
||||
function openPhotoFirst(){beginDraft();photoHint='';resetSuggestion();visionStatus=null;showPhotoFirst('pick');loadVisionStatus()}
|
||||
async function loadVisionStatus(){
|
||||
@@ -308,7 +376,21 @@ function bindStep(step){
|
||||
}
|
||||
async function handlePhoto(e){const file=e.target.files[0];if(!file)return;try{const result=await compressPhoto(file);form.photoDataUrl=result.dataUrl;photoHint=photoQualityMessage(result);showLogStep(2)}catch{photoHint='That image could not be read. Try another photo.';showLogStep(2)}}
|
||||
function compressPhoto(file){return new Promise((resolve,reject)=>{const img=new Image(),url=URL.createObjectURL(file);img.onload=()=>{const scale=Math.min(1,1200/Math.max(img.width,img.height)),canvas=document.createElement('canvas');canvas.width=Math.round(img.width*scale);canvas.height=Math.round(img.height*scale);const ctx=canvas.getContext('2d');ctx.drawImage(img,0,0,canvas.width,canvas.height);const sample=ctx.getImageData(0,0,Math.min(canvas.width,120),Math.min(canvas.height,120)).data;let total=0;for(let i=0;i<sample.length;i+=4)total+=(sample[i]+sample[i+1]+sample[i+2])/3;URL.revokeObjectURL(url);resolve({dataUrl:canvas.toDataURL('image/jpeg',.7),width:img.width,height:img.height,brightness:total/(sample.length/4)/255})};img.onerror=()=>{URL.revokeObjectURL(url);reject()};img.src=url})}
|
||||
function saveLog(){const result=detectUrgentFlags(form.symptoms);const entry=sanitizeEntry({...form});try{entries.push(entry);saveEntries()}catch{entry.photoDataUrl='';entries[entries.length-1]=entry;saveEntries();toast('Log saved, but the photo was too large for browser storage')}clearDraft();document.querySelector('.sheet-backdrop')?.remove();view='home';render();toast(result.urgent?'Saved. Please follow the medical-care alert.':'Private log saved')}
|
||||
// Issue #35 — if this log began as an AI suggestion, the saved record says so. The fields are
|
||||
// limited to what the app actually knows (which visible fields were suggested, whether they were
|
||||
// confirmed or corrected, and which model answered), so a backup cannot be read as a diagnosis or a
|
||||
// broader claim than the visual suggestion the person accepted.
|
||||
function provenanceForSave(){
|
||||
const status=suggestionState?.status;
|
||||
if(status!=='confirmed'&&status!=='corrected')return null;
|
||||
const suggestion=suggestionState.suggestion;
|
||||
if(!suggestion)return null;
|
||||
const provenance={source:status==='confirmed'?'ai-confirmed':'ai-corrected',suggestedBristolType:suggestion.bristolType,suggestedColor:suggestion.color,confirmedAt:new Date().toISOString()};
|
||||
const model=typeof visionStatus?.model==='string'?visionStatus.model.trim():'';
|
||||
if(model)provenance.model=model.slice(0,80);
|
||||
return provenance;
|
||||
}
|
||||
function saveLog(){const result=detectUrgentFlags(form.symptoms);const entry=sanitizeEntry({...form,provenance:provenanceForSave()});try{entries.push(entry);saveEntries()}catch{entry.photoDataUrl='';entries[entries.length-1]=entry;saveEntries();toast('Log saved, but the photo was too large for browser storage')}clearDraft();document.querySelector('.sheet-backdrop')?.remove();view='home';render();toast(result.urgent?'Saved. Please follow the medical-care alert.':'Private log saved')}
|
||||
function render(){({home,calendar,timmy,privacy}[view]||home)()}
|
||||
|
||||
render();
|
||||
|
||||
@@ -0,0 +1,61 @@
|
||||
# Corpus manifest contract
|
||||
|
||||
The training corpus is described by an **append-only** `manifest.jsonl`. One line is one event;
|
||||
nothing is ever rewritten in place, so the trail can be audited after a withdrawal. The
|
||||
implementation lives in [`scripts/corpus_manifest.py`](../scripts/corpus_manifest.py) and is
|
||||
driven by [`scripts/ingest_training_photo.py`](../scripts/ingest_training_photo.py).
|
||||
|
||||
## Sample record (`recordType: "sample"`, schema version 2)
|
||||
|
||||
| Field | Meaning |
|
||||
|---|---|
|
||||
| `contributionId` | Opaque id minted by the app's contribution receipt. The same id addresses every derived artifact and every later tombstone. |
|
||||
| `consent.version`, `consent.recordedAt` | The consent version the contributor accepted, and when. Duplicated as `consentVersion` for older readers. |
|
||||
| `source.kind`, `source.inputSha256` | How the bytes arrived (`cli-ingest`) and the digest of the caller's input. The caller's path is never recorded. |
|
||||
| `hashes.rawInput`, `hashes.derived` | Digest of the supplied bytes and of the re-encoded image that is actually stored. |
|
||||
| `derivation` | `format`, `maxDimension`, `metadataStripped`, and the `pipeline` version that produced the derived image. |
|
||||
| `review.status`, `review.reviewedAt` | `user-confirmed` or `clinician-reviewed`. A label set is never unlabelled-by-default. |
|
||||
| `split` | `train`, `validation`, or `test`, derived from the salted subject key so one contributor never straddles splits. |
|
||||
| `subjectKey` | 16-hex pseudonym derived from a salted subject id. Never a name, email, or account. |
|
||||
| `lifecycle.state`, `lifecycle.updatedAt` | `active` while the sample is usable for training. |
|
||||
| `imageId`, `relativePath` | Derived image digest and its dataset-relative path. |
|
||||
|
||||
## Tombstone record (`recordType: "tombstone"`)
|
||||
|
||||
A withdrawal never deletes history; it appends a tombstone that:
|
||||
|
||||
- keeps `contributionId` and `imageId` so the withdrawal can be matched to the original sample,
|
||||
- records `lifecycle.state: "revoked"`, the timestamp, and the reason,
|
||||
- lists `deletedArtifacts` — every derived copy it removed, addressed by contribution id with the
|
||||
digest that identifies the bytes,
|
||||
- deliberately drops `labels`, `subjectKey`, and `relativePath`: a deletion receipt keeps
|
||||
identifiers and hashes, not the health label or the person.
|
||||
|
||||
`revoke()` removes the derived image and any raw pre-derivation copy from the active dataset
|
||||
before appending the tombstone, and refuses any path that resolves outside the dataset root.
|
||||
|
||||
## Lifecycle rules (all covered by `tests/corpus-manifest.test.py`)
|
||||
|
||||
- `active` → `revoked` only, and only with a recorded reason.
|
||||
- `revoked` → `active` is refused: a revoked contribution cannot return to the active dataset.
|
||||
- Revoking an unknown contribution, or revoking twice, is refused and appends nothing.
|
||||
- A contribution id can be ingested once; the same derived image cannot carry two label sets.
|
||||
- `active_records()` returns only samples that are still `active` and were never tombstoned, so a
|
||||
trainer that reads through it cannot silently train on withdrawn data.
|
||||
|
||||
## Usage
|
||||
|
||||
```bash
|
||||
export TIMMY_DATASET_SALT=... # >= 8 chars, never committed
|
||||
python3 scripts/ingest_training_photo.py \
|
||||
--input photo.jpg --output-dir /srv/timmy-corpus \
|
||||
--subject-id subject-123 --consent-version research-v1 \
|
||||
--contribution-id "$CONTRIBUTION_ID" \
|
||||
--bristol-type 4 --color brown --quality good --reviewer user-confirmed
|
||||
|
||||
python3 scripts/ingest_training_photo.py --revoke "$CONTRIBUTION_ID" \
|
||||
--output-dir /srv/timmy-corpus --reason "subject withdrawal"
|
||||
```
|
||||
|
||||
`npm run test:corpus` runs the contract suite. Every fixture is synthetic; no real medical image
|
||||
is read, written, or committed.
|
||||
@@ -34,6 +34,14 @@ The application’s deterministic urgent-symptom guidance runs before chat and r
|
||||
|
||||
Logging must never depend on AI availability. When the vision worker is offline, disabled, or still unknown, the photo-first flow offers no AI action and no analysis-consent prompt, and manual Bristol entry remains one action away from every photo step. A chosen photo and any entered context are retained as an in-session draft with a visible summary and an explicit start over; drafts are deliberately not persisted to storage, so a photo awaiting consent is never written to disk. The service worker never caches analysis requests or image bodies.
|
||||
|
||||
### Training contribution consent
|
||||
|
||||
Contributing a confirmed photo to training is a second consent, not a side effect of logging. A journal save is never a training contribution; a contribution exists only after the person reads the current consent version and its receipt (contribution id, what is included, what is never included) and accepts it explicitly. The receipt carries the consent version it was accepted under, the confirmed Bristol form and broad color, and no note text, symptom answers, urgency/discomfort ratings, identity, or photo bytes.
|
||||
|
||||
Withdrawal is first-class: withdrawal keeps a tombstone naming every derived artifact by contribution id (raw image and confirmed label), so a deletion request can be addressed against the corpus rather than trusted to a promise. Delete-all clears the ledger, saved photos, and contribution receipts together.
|
||||
|
||||
This build acknowledges that records the intent and does not transmit a contribution until the corpus pipeline and privacy copy are reviewed in #22 and #25; the section says so in the app rather than implying an upload that does not exist.
|
||||
|
||||
### Release authority
|
||||
|
||||
Hermes/Timmy is the release authority for routine engineering, test, build, deployment, and release-candidate preparation. Automated evidence must remain reproducible and must not overstate model accuracy or safety.
|
||||
@@ -48,6 +56,16 @@ Human gates are limited to:
|
||||
|
||||
Routine provisioning, deployment, label sweeps, and release-candidate assembly are not human-operated gates.
|
||||
|
||||
### Backup portability and entry provenance
|
||||
|
||||
A backup is the person's own record and must keep working as the AI fields evolve.
|
||||
|
||||
- Every export stamps a schema version (currently version 2). The same file carries the confirmed logs and the training contribution receipts, including withdrawn tombstones.
|
||||
- An older backup is upgraded on import, and the app says which version the file came from. Fields that did not exist when the file was written are left empty rather than invented.
|
||||
- A backup from a newer version is refused with an instruction to update Timmy, and a refused import leaves the ledger unchanged.
|
||||
- Malformed, oversized, and over-limit files fail before anything is replaced.
|
||||
- Provenance is stored on the confirmed log when a saved entry began as a confirmed or corrected AI suggestion: source, suggested visible fields, the model that answered, and when it was confirmed. It never records a diagnosis, a symptom, or provider credentials, and backups are written through an allowlist so unknown keys never leave the device.
|
||||
|
||||
## Consequences
|
||||
|
||||
- Model output is assistive and fail-closed, never authoritative.
|
||||
|
||||
+6
-3
@@ -4,7 +4,7 @@
|
||||
"private": true,
|
||||
"type": "module",
|
||||
"scripts": {
|
||||
"test": "node --test tests/domain.test.js tests/analysis.test.js tests/vision-service.test.js tests/vision-config.test.js tests/draft.test.js tests/suggestion.test.js tests/followup.test.js tests/vision-readiness.test.js tests/hermes-agent-service.test.js tests/agent-gateway.acceptance.test.js tests/staging-health.test.js tests/service-worker-runtime.test.js tests/training-ingest.test.js tests/ci-workflow.test.js tests/product-decisions.test.js tests/release-demo.test.js tests/selfhost-bootstrap.test.js tests/staging-config.test.js tests/threat-model.test.js tests/vision-corpus.test.js tests/vision-boundary.test.js tests/worker-benchmark.test.js tests/worker-ready.test.js tests/worker-container.test.js tests/summary.test.js tests/escalation-regression.test.js tests/grounded-chat.test.js tests/photo-lifecycle.test.js",
|
||||
"test": "node --test tests/domain.test.js tests/analysis.test.js tests/vision-service.test.js tests/vision-config.test.js tests/draft.test.js tests/suggestion.test.js tests/followup.test.js tests/vision-readiness.test.js tests/hermes-agent-service.test.js tests/agent-gateway.acceptance.test.js tests/staging-health.test.js tests/service-worker-runtime.test.js tests/training-ingest.test.js tests/ci-workflow.test.js tests/product-decisions.test.js tests/release-demo.test.js tests/selfhost-bootstrap.test.js tests/staging-config.test.js tests/threat-model.test.js tests/vision-corpus.test.js tests/vision-boundary.test.js tests/worker-benchmark.test.js tests/worker-ready.test.js tests/worker-container.test.js tests/summary.test.js tests/escalation-regression.test.js tests/grounded-chat.test.js tests/photo-lifecycle.test.js tests/training-contribution.test.js tests/portability.test.js",
|
||||
"test:ui": "node tests/ui.acceptance.mjs",
|
||||
"test:photo": "node tests/photo-first.acceptance.mjs",
|
||||
"test:mobile-capture": "node tests/mobile-capture.acceptance.mjs",
|
||||
@@ -17,10 +17,13 @@
|
||||
"test:pattern-summary": "node tests/pattern-summary.acceptance.mjs",
|
||||
"test:grounded-chat": "node tests/grounded-chat.acceptance.mjs",
|
||||
"test:photo-lifecycle": "node tests/photo-lifecycle.acceptance.mjs",
|
||||
"check:syntax": "node --check app.js && node --check server.mjs && node --check service-worker.js && node --check src/analysis.js && node --check src/domain.js && node --check src/draft.js && node --check src/suggestion.js && node --check src/followup.js && node --check src/vision-readiness.js && node --check src/hermes-agent-service.js && node --check src/vision-config.js && node --check src/vision-service.js && node --check src/vision-corpus.js && node --check src/summary.js && node --check src/photo-lifecycle.js && node --check src/grounded-chat.js && node --check scripts/record_release_demo.mjs && node --check tests/staging.acceptance.mjs && node --check tests/manual-fallback.acceptance.mjs && node --check tests/provisional-suggestion.acceptance.mjs && node --check tests/followup.acceptance.mjs && node --check tests/vision-refusal.acceptance.mjs && bash -n scripts/bootstrap_selfhost_smolvlm.sh && bash -n scripts/run_selfhost_smolvlm.sh && python3 -m py_compile scripts/ingest_training_photo.py scripts/build_release.py scripts/deploy_staging.py scripts/build_vision_corpus.py && node --check scripts/record_worker_benchmark.mjs && node --check tests/worker-readiness.acceptance.mjs && node --check tests/pattern-summary.acceptance.mjs && node --check tests/photo-lifecycle.acceptance.mjs && node --check tests/grounded-chat.acceptance.mjs && bash -n scripts/worker_ready.sh && bash -n deploy/worker/entrypoint.sh && bash -n deploy/worker/build_image.sh && bash -n deploy/worker/run_worker_container.sh",
|
||||
"test:training-contribution": "node tests/training-contribution.acceptance.mjs",
|
||||
"check:syntax": "node --check app.js && node --check server.mjs && node --check service-worker.js && node --check src/analysis.js && node --check src/domain.js && node --check src/draft.js && node --check src/suggestion.js && node --check src/followup.js && node --check src/vision-readiness.js && node --check src/hermes-agent-service.js && node --check src/vision-config.js && node --check src/vision-service.js && node --check src/vision-corpus.js && node --check src/summary.js && node --check src/photo-lifecycle.js && node --check src/grounded-chat.js && node --check src/training-contribution.js && node --check scripts/record_release_demo.mjs && node --check tests/staging.acceptance.mjs && node --check tests/manual-fallback.acceptance.mjs && node --check tests/provisional-suggestion.acceptance.mjs && node --check tests/followup.acceptance.mjs && node --check tests/vision-refusal.acceptance.mjs && bash -n scripts/bootstrap_selfhost_smolvlm.sh && bash -n scripts/run_selfhost_smolvlm.sh && python3 -m py_compile scripts/corpus_manifest.py scripts/ingest_training_photo.py scripts/build_release.py scripts/deploy_staging.py scripts/build_vision_corpus.py && node --check scripts/record_worker_benchmark.mjs && node --check tests/worker-readiness.acceptance.mjs && node --check tests/pattern-summary.acceptance.mjs && node --check tests/photo-lifecycle.acceptance.mjs && node --check tests/training-contribution.acceptance.mjs && node --check tests/portability.acceptance.mjs && node --check tests/grounded-chat.acceptance.mjs && bash -n scripts/worker_ready.sh && bash -n deploy/worker/entrypoint.sh && bash -n deploy/worker/build_image.sh && bash -n deploy/worker/run_worker_container.sh",
|
||||
"check:diff": "bash scripts/check_diff.sh",
|
||||
"start": "node server.mjs",
|
||||
"test:worker-readiness": "node tests/worker-readiness.acceptance.mjs"
|
||||
"test:worker-readiness": "node tests/worker-readiness.acceptance.mjs",
|
||||
"test:portability": "node tests/portability.acceptance.mjs",
|
||||
"test:corpus": "python3 tests/corpus-manifest.test.py"
|
||||
},
|
||||
"devDependencies": {
|
||||
"playwright": "^1.62.1"
|
||||
|
||||
@@ -9,6 +9,7 @@ import os
|
||||
from pathlib import Path
|
||||
import re
|
||||
import shutil
|
||||
import socket
|
||||
import subprocess
|
||||
import sys
|
||||
import tarfile
|
||||
@@ -51,6 +52,17 @@ DEMO_REQUIRED_CAPTIONS = (
|
||||
"The answer states the count and cites the four confirmed logs it counted",
|
||||
"Following a citation opens exactly the confirmed log behind that answer",
|
||||
"Ask something the journal cannot answer and Timmy refuses instead of reassuring",
|
||||
"Training contribution is off by default: a saved log is never training data",
|
||||
"The consent version and the receipt are on screen before the contribute button works",
|
||||
"Withdrawing keeps a tombstone naming every derived artifact by contribution ID",
|
||||
"The corpus pipeline is a command-line tool, not a screen in the app — this runs the real ingest against the committed synthetic fixture",
|
||||
"Every ingested sample records consent, source digest, both hashes, derivation, review, and lifecycle — the caller file path is never stored",
|
||||
"Withdrawing deletes the derived image and any raw copy, keeps the original record, and appends a tombstone — the trainer sees zero active samples",
|
||||
"Revoking the same contribution twice is refused and appends nothing: the manifest only ever grows",
|
||||
"A backup is versioned, and it carries the withdrawn receipt as a tombstone rather than silence",
|
||||
"An older backup is upgraded on import, and the notice says which version the file came from",
|
||||
"A file from a newer Timmy is refused with an instruction, and the ledger it would have replaced is untouched",
|
||||
"A restored log still says it began as an AI suggestion you corrected — provenance is part of the record",
|
||||
)
|
||||
|
||||
|
||||
@@ -69,6 +81,29 @@ def sha256(path: Path) -> str:
|
||||
return digest.hexdigest()
|
||||
|
||||
|
||||
def assert_port_free(host: str, port: int) -> None:
|
||||
"""Fail closed when something is already listening where the acceptance server must bind."""
|
||||
with socket.socket() as sock:
|
||||
sock.settimeout(1.0)
|
||||
if sock.connect_ex((host, port)) == 0:
|
||||
raise SystemExit(
|
||||
f"Port {port} is already served by another process; refusing to gate or record this "
|
||||
"release against a tree that is not the one under test."
|
||||
)
|
||||
|
||||
|
||||
def assert_served_tree(tree: Path, host: str, port: int) -> None:
|
||||
"""Prove the responding server is the clone under test, not a stale checkout on the same port."""
|
||||
for relative in ("src/domain.js", "app.js"):
|
||||
served = urllib.request.urlopen(f"http://{host}:{port}/{relative}", timeout=5).read()
|
||||
expected = (tree / relative).read_bytes()
|
||||
if hashlib.sha256(served).hexdigest() != hashlib.sha256(expected).hexdigest():
|
||||
raise SystemExit(
|
||||
f"The acceptance server is serving {relative} from a different tree; "
|
||||
"every gate and the demo would describe a release that is not this commit."
|
||||
)
|
||||
|
||||
|
||||
def tracked_files(tree: Path) -> list[str]:
|
||||
names = run(["git", "ls-files"], tree, capture=True).splitlines()
|
||||
return sorted(name for name in names if name and not name.startswith(EXCLUDED_PREFIXES)
|
||||
@@ -124,8 +159,14 @@ def main() -> int:
|
||||
run(["npm", "test"], tree)
|
||||
# The committed corpus hashes are an integrity receipt: verify them before anything is built.
|
||||
run(["python3", "scripts/build_vision_corpus.py", "--verify"], tree)
|
||||
# Issue #25's corpus pipeline is a CLI, so its own suite is a release gate, not just CI.
|
||||
run(["python3", "tests/corpus-manifest.test.py", "-v"], tree)
|
||||
server_env = dict(os.environ)
|
||||
server_env.update({"HOST": "127.0.0.1", "PORT": "4173", "TIMMY_VISION_ENABLED": "false"})
|
||||
# A leftover server from another checkout answers on this port and the readiness probe cannot
|
||||
# tell it apart from ours, so every gate and the recorded demo would silently describe a
|
||||
# different tree. Refuse to build over a live listener, and verify the served bytes afterwards.
|
||||
assert_port_free("127.0.0.1", 4173)
|
||||
server_log = (release_dir / "acceptance-server.log").open("w", encoding="utf-8")
|
||||
server = subprocess.Popen(["node", "server.mjs"], cwd=tree, env=server_env,
|
||||
stdout=server_log, stderr=subprocess.STDOUT, text=True)
|
||||
@@ -140,6 +181,9 @@ def main() -> int:
|
||||
time.sleep(0.1)
|
||||
else:
|
||||
raise SystemExit("Acceptance server did not become ready")
|
||||
if server.poll() is not None:
|
||||
raise SystemExit("Acceptance server exited after reporting ready")
|
||||
assert_served_tree(tree, "127.0.0.1", 4173)
|
||||
run(["npm", "run", "test:ui"], tree)
|
||||
run(["npm", "run", "test:photo"], tree)
|
||||
run(["npm", "run", "test:mobile-capture"], tree)
|
||||
@@ -152,6 +196,8 @@ def main() -> int:
|
||||
run(["npm", "run", "test:pattern-summary"], tree)
|
||||
run(["npm", "run", "test:grounded-chat"], tree)
|
||||
run(["npm", "run", "test:photo-lifecycle"], tree)
|
||||
run(["npm", "run", "test:training-contribution"], tree)
|
||||
run(["npm", "run", "test:portability"], tree)
|
||||
demo_raw = release_dir / f"timmy-talking-turd-{version}-demo.raw.webm"
|
||||
caption_receipt = release_dir / f"timmy-talking-turd-{version}-demo-captions.json"
|
||||
demo_env = dict(server_env)
|
||||
@@ -199,7 +245,7 @@ def main() -> int:
|
||||
if not contact_sheet.exists() or contact_sheet.stat().st_size == 0:
|
||||
raise SystemExit("Release demo contact sheet was not produced")
|
||||
run(["npm", "audit", "--audit-level=high"], tree)
|
||||
for file in ("app.js", "server.mjs", "service-worker.js", "src/analysis.js", "src/domain.js", "src/draft.js", "src/suggestion.js", "src/followup.js", "src/vision-readiness.js", "src/hermes-agent-service.js", "src/vision-config.js", "src/vision-service.js", "src/vision-corpus.js", "src/summary.js", "src/photo-lifecycle.js", "scripts/record_worker_benchmark.mjs", "tests/staging.acceptance.mjs", "tests/vision-refusal.acceptance.mjs", "tests/worker-readiness.acceptance.mjs", "tests/pattern-summary.acceptance.mjs", "tests/photo-lifecycle.acceptance.mjs"):
|
||||
for file in ("app.js", "server.mjs", "service-worker.js", "src/analysis.js", "src/domain.js", "src/draft.js", "src/suggestion.js", "src/followup.js", "src/vision-readiness.js", "src/hermes-agent-service.js", "src/vision-config.js", "src/vision-service.js", "src/vision-corpus.js", "src/summary.js", "src/photo-lifecycle.js", "src/training-contribution.js", "scripts/record_worker_benchmark.mjs", "tests/staging.acceptance.mjs", "tests/vision-refusal.acceptance.mjs", "tests/worker-readiness.acceptance.mjs", "tests/pattern-summary.acceptance.mjs", "tests/photo-lifecycle.acceptance.mjs", "tests/training-contribution.acceptance.mjs"):
|
||||
run(["node", "--check", file], tree)
|
||||
run(["bash", "-n", "scripts/bootstrap_selfhost_smolvlm.sh"], tree)
|
||||
run(["bash", "-n", "scripts/run_selfhost_smolvlm.sh"], tree)
|
||||
@@ -207,7 +253,7 @@ def main() -> int:
|
||||
run(["bash", "-n", "deploy/worker/entrypoint.sh"], tree)
|
||||
run(["bash", "-n", "deploy/worker/build_image.sh"], tree)
|
||||
run(["bash", "-n", "deploy/worker/run_worker_container.sh"], tree)
|
||||
run(["python3", "-m", "py_compile", "scripts/ingest_training_photo.py", "scripts/build_release.py", "scripts/build_vision_corpus.py"], tree)
|
||||
run(["python3", "-m", "py_compile", "scripts/ingest_training_photo.py", "scripts/build_release.py", "scripts/build_vision_corpus.py", "scripts/corpus_manifest.py"], tree)
|
||||
run(["git", "diff", "--check", commit], tree)
|
||||
|
||||
names = tracked_files(tree)
|
||||
@@ -240,7 +286,9 @@ def main() -> int:
|
||||
"- Target-GPU benchmark: scripts/record_worker_benchmark.mjs records cold start, warm latency, and VRAM on the target GPU and refuses to write a receipt it did not measure; no GPU measurement is bundled with this release\n"
|
||||
"- Explainable pattern summaries (issue #34): the home insight card reports confirmed-log counts and form groupings per window, every line names the exact confirmed records behind it, following a citation opens those records, and a window below the minimum says it is too sparse instead of describing a trend; no line explains a cause, rules on food, or offers a health verdict\n"
|
||||
"- Private photo lifecycle (issue #36): the journal marks a log that holds a saved photo without rendering a thumbnail, showing the image is an explicit request, removing it keeps every confirmed field, deleting a log is a separate two-step decision that takes its photo, and delete-all removes the ledger and every stored photo together\n"
|
||||
"- Safety: suggestions are observable-field assistance, never diagnosis; user confirmation is required\n"
|
||||
"- Training contribution is a separate opt-in (issue #24): a journal save records no contribution, the consent version and the receipt are on screen before the control can be pressed, the receipt is queued on this device only (this build transmits nothing) and carries no note text, symptom answers, or photo bytes, and a withdrawal keeps a tombstone naming every derived artifact by contribution id\n"
|
||||
"- Auditable corpus pipeline (issue #25): every ingested training sample now records its consent version and timestamp, source kind and the raw-input digest (the caller's file path is never stored), both the raw and derived hashes, the derivation pipeline, the human review status, the split, and its lifecycle state in an append-only manifest; withdrawing a contribution deletes the derived image and any raw pre-derivation copy from the active dataset, keeps the original record as its own history, and appends a tombstone that names every removed artifact by contribution id and digest while dropping labels and the subject key; illegal lifecycle moves (re-ingesting a contribution, re-labelling a derived image, revoking twice, revoking an unknown contribution, reviving a revoked one, revoking without a reason) are refused before any byte is written\n"
|
||||
"- Scope note: the corpus pipeline is a command-line tool. There is no corpus screen in the app, and this release does not imply one — the recorded demo runs the real ingest and revoke commands against the committed synthetic fixture and shows their actual output\n"
|
||||
"- Known limitation: open-weight VLM acceptance is proven, Bristol accuracy is not clinically validated\n"
|
||||
"- Package excludes model weights, medical-image corpora, raw research pages, generated screenshots, and video production assets\n"
|
||||
)
|
||||
@@ -285,7 +333,7 @@ def main() -> int:
|
||||
"codec": "h264",
|
||||
"pixel_format": "yuv420p",
|
||||
"recorded_from_working_app": True,
|
||||
"fixture_data": "synthetic-Type-4, deterministic vision suggestion reviewed, confirmed, and corrected to Type 2, user-reported hard-stool follow-up with non-diagnostic self-care and a confirmed black/tarry red flag, the CC0 synthetic vision corpus replaying a non-stool refusal, an unreadable-fields abstention, an out-of-range fail-closed reply, and a blank-plus-out-of-range fail-closed reply, offline vision status, fictional multi-day sample logs driving the explainable pattern summary and its citation sheet, a sparse fictional window showing the insufficient-data copy, a grounded local chat answer citing each counted log and opening the cited record, a refusal that borrows no journal evidence, and a deterministic Hermes chat reply whose positional refs render as sources",
|
||||
"fixture_data": "synthetic-Type-4, deterministic vision suggestion reviewed, confirmed, and corrected to Type 2, user-reported hard-stool follow-up with non-diagnostic self-care and a confirmed black/tarry red flag, the CC0 synthetic vision corpus replaying a non-stool refusal, an unreadable-fields abstention, an out-of-range fail-closed reply, and a blank-plus-out-of-range fail-closed reply, offline vision status, fictional multi-day sample logs driving the explainable pattern summary and its citation sheet, a sparse fictional window showing the insufficient-data copy, a grounded local chat answer citing each counted log and opening the cited record, a refusal that borrows no journal evidence, and a deterministic Hermes chat reply whose positional refs render as sources, plus the opt-in training contribution path where nothing is queued after ordinary saves, the consent version and receipt precede the confirm control, one receipt is queued on the device only, and withdrawal leaves a tombstone naming each derived artifact, plus a versioned backup that carries the logs and the withdrawn receipt, an older version 1 file upgraded with the version named on screen, a file from a newer Timmy refused without changing the ledger, and a restored log still showing it began as a corrected AI suggestion, plus the corpus audit card, where the real ingest and revoke commands run against the committed synthetic fixture and the card shows their actual output: the provenance record with consent, source digest, both hashes, derivation, review and lifecycle; the derived image deleted from disk; the original record kept as history beside a tombstone that drops labels and the subject key; zero active samples for a trainer; and a second revocation refused without appending anything",
|
||||
},
|
||||
"gates": {
|
||||
"unit_security": "passed",
|
||||
@@ -300,6 +348,9 @@ def main() -> int:
|
||||
"worker_post_load_readiness": "passed",
|
||||
"longitudinal_pattern_summary": "passed",
|
||||
"grounded_chat_citations": "passed",
|
||||
"training_contribution_consent": "passed",
|
||||
"corpus_manifest_provenance": "passed",
|
||||
"portable_backup_restore": "passed",
|
||||
"dependency_audit_high": "passed",
|
||||
"syntax": "passed",
|
||||
"secret_scan": "passed",
|
||||
|
||||
@@ -0,0 +1,241 @@
|
||||
#!/usr/bin/env python3
|
||||
"""Immutable, auditable corpus manifest for Timmy training contributions.
|
||||
|
||||
Every ingested sample is described by one append-only manifest record: who consented, under
|
||||
which consent version, where the bytes came from, the hashes of the raw input and the derived
|
||||
image, how the derived image was produced, who reviewed the labels, which split it belongs to,
|
||||
and where it sits in its lifecycle. Nothing in this module rewrites history: records are only
|
||||
ever appended, and a withdrawal is a tombstone, not a deletion of the trail.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import hashlib
|
||||
import json
|
||||
import re
|
||||
from pathlib import Path
|
||||
|
||||
SCHEMA_VERSION = 2
|
||||
PIPELINE = "timmy-ingest/2"
|
||||
|
||||
SAMPLE = "sample"
|
||||
TOMBSTONE = "tombstone"
|
||||
RECORD_TYPES = frozenset({SAMPLE, TOMBSTONE})
|
||||
|
||||
ACTIVE = "active"
|
||||
REVOKED = "revoked"
|
||||
STATES = frozenset({ACTIVE, REVOKED})
|
||||
|
||||
SPLITS = ("train", "validation", "test")
|
||||
REVIEWERS = ("user-confirmed", "clinician-reviewed")
|
||||
COLORS = ("brown", "green", "yellow", "pale", "red", "black")
|
||||
QUALITIES = ("good", "fair", "poor")
|
||||
|
||||
_SHA256 = re.compile(r"^[0-9a-f]{64}$")
|
||||
_CONTRIBUTION_ID = re.compile(r"^[A-Za-z0-9][A-Za-z0-9._:-]{7,127}$")
|
||||
|
||||
|
||||
class CorpusError(Exception):
|
||||
"""A record cannot be built or written as asked."""
|
||||
|
||||
|
||||
class IllegalTransition(CorpusError):
|
||||
"""A lifecycle change that must never happen is being attempted."""
|
||||
|
||||
|
||||
def sha256_hex(data: bytes) -> str:
|
||||
return hashlib.sha256(data).hexdigest()
|
||||
|
||||
|
||||
def _require_sha256(value: object, field: str) -> str:
|
||||
if not isinstance(value, str) or not _SHA256.match(value):
|
||||
raise CorpusError(f"{field} must be a lowercase hex sha256 digest")
|
||||
return value
|
||||
|
||||
|
||||
def _require_iso(value: object, field: str) -> str:
|
||||
if not isinstance(value, str) or not re.match(r"^\d{4}-\d{2}-\d{2}T", value):
|
||||
raise CorpusError(f"{field} must be an ISO-8601 timestamp")
|
||||
return value
|
||||
|
||||
|
||||
def build_record(
|
||||
*,
|
||||
contribution_id: str,
|
||||
consent_version: str,
|
||||
subject_key: str,
|
||||
split: str,
|
||||
labels: dict,
|
||||
review_status: str,
|
||||
derived_sha256: str,
|
||||
raw_sha256: str,
|
||||
ingested_at: str,
|
||||
source_kind: str = "cli-ingest",
|
||||
) -> dict:
|
||||
"""Build one active sample record carrying its full provenance."""
|
||||
if not isinstance(contribution_id, str) or not _CONTRIBUTION_ID.match(contribution_id):
|
||||
raise CorpusError("contribution id is required and must be a stable opaque identifier")
|
||||
if not isinstance(consent_version, str) or not consent_version.strip():
|
||||
raise CorpusError("consent version is required")
|
||||
if not isinstance(subject_key, str) or not re.match(r"^[0-9a-f]{16}$", subject_key):
|
||||
raise CorpusError("subject key must be the 16-character pseudonymous digest")
|
||||
if split not in SPLITS:
|
||||
raise CorpusError(f"split must be one of {', '.join(SPLITS)}")
|
||||
if review_status not in REVIEWERS:
|
||||
raise CorpusError(f"review status must be one of {', '.join(REVIEWERS)}")
|
||||
if not isinstance(source_kind, str) or not source_kind.strip():
|
||||
raise CorpusError("source kind is required")
|
||||
if not isinstance(labels, dict) or set(labels) != {"bristolType", "color", "quality"}:
|
||||
raise CorpusError("labels must carry bristolType, color, and quality")
|
||||
if labels["bristolType"] not in range(1, 8):
|
||||
raise CorpusError("bristolType must be 1-7")
|
||||
if labels["color"] not in COLORS or labels["quality"] not in QUALITIES:
|
||||
raise CorpusError("color and quality must be from the documented vocabularies")
|
||||
derived = _require_sha256(derived_sha256, "derived sha256")
|
||||
raw = _require_sha256(raw_sha256, "raw input sha256")
|
||||
stamped = _require_iso(ingested_at, "ingestedAt")
|
||||
|
||||
return {
|
||||
"schemaVersion": SCHEMA_VERSION,
|
||||
"recordType": SAMPLE,
|
||||
"contributionId": contribution_id,
|
||||
"imageId": derived,
|
||||
"relativePath": f"images/{derived}.jpg",
|
||||
"subjectKey": subject_key,
|
||||
"split": split,
|
||||
"consentVersion": consent_version.strip(),
|
||||
"consent": {"version": consent_version.strip(), "recordedAt": stamped},
|
||||
"source": {"kind": source_kind, "inputSha256": raw},
|
||||
"hashes": {"rawInput": raw, "derived": derived},
|
||||
"derivation": {
|
||||
"format": "jpeg",
|
||||
"maxDimension": 1200,
|
||||
"metadataStripped": True,
|
||||
"pipeline": PIPELINE,
|
||||
},
|
||||
"labels": {
|
||||
"bristolType": labels["bristolType"],
|
||||
"color": labels["color"],
|
||||
"quality": labels["quality"],
|
||||
},
|
||||
"review": {"status": review_status, "reviewedAt": stamped},
|
||||
"lifecycle": {"state": ACTIVE, "updatedAt": stamped},
|
||||
"ingestedAt": stamped,
|
||||
}
|
||||
|
||||
|
||||
def assert_admissible(manifest_path: Path, record: dict) -> None:
|
||||
"""Refuse a sample that duplicates a contribution or re-labels the same derived image."""
|
||||
if record.get("recordType", SAMPLE) != SAMPLE:
|
||||
return
|
||||
for prior in load_manifest(manifest_path):
|
||||
if prior.get("recordType", SAMPLE) != SAMPLE:
|
||||
continue
|
||||
if prior.get("contributionId") == record.get("contributionId"):
|
||||
raise IllegalTransition(f"contribution {record['contributionId']} was already ingested")
|
||||
if prior.get("imageId") == record.get("imageId") and prior.get("labels") != record.get("labels"):
|
||||
raise CorpusError("the same derived image cannot carry two different label sets")
|
||||
|
||||
|
||||
def append_record(manifest_path: Path, record: dict) -> None:
|
||||
"""Append one record to the manifest without touching what is already there."""
|
||||
assert_admissible(manifest_path, record)
|
||||
manifest_path.parent.mkdir(parents=True, exist_ok=True)
|
||||
with manifest_path.open("a", encoding="utf-8") as manifest:
|
||||
manifest.write(json.dumps(record, separators=(",", ":"), sort_keys=False) + "\n")
|
||||
|
||||
|
||||
def load_manifest(manifest_path: Path) -> list[dict]:
|
||||
"""Read the append-only manifest in order. A missing manifest is an empty corpus."""
|
||||
if not manifest_path.exists():
|
||||
return []
|
||||
with manifest_path.open("r", encoding="utf-8") as manifest:
|
||||
return [json.loads(line) for line in manifest.read().splitlines() if line.strip()]
|
||||
|
||||
|
||||
def transition(record: dict, state: str, at: str, reason: str | None = None) -> dict:
|
||||
"""Return a copy of the record in the next lifecycle state, or refuse the move."""
|
||||
current = record.get("lifecycle", {}).get("state")
|
||||
if state not in STATES:
|
||||
raise IllegalTransition(f"unknown lifecycle state: {state!r}")
|
||||
if current not in STATES:
|
||||
raise IllegalTransition(f"record carries no legal lifecycle state: {current!r}")
|
||||
if current == state:
|
||||
raise IllegalTransition(f"record is already {state}")
|
||||
if current == REVOKED:
|
||||
raise IllegalTransition("a revoked contribution cannot return to the active dataset")
|
||||
_require_iso(at, "lifecycle timestamp")
|
||||
if state == REVOKED and (not isinstance(reason, str) or not reason.strip()):
|
||||
raise IllegalTransition("revocation needs a recorded reason")
|
||||
updated = {**record, "lifecycle": {"state": state, "updatedAt": at}}
|
||||
if state == REVOKED:
|
||||
updated["lifecycle"]["reason"] = reason.strip()
|
||||
return updated
|
||||
|
||||
|
||||
def active_records(records: list[dict]) -> list[dict]:
|
||||
"""Samples still usable for training: active, and never revoked afterwards."""
|
||||
revoked = {
|
||||
record.get("contributionId")
|
||||
for record in records
|
||||
if record.get("recordType") == TOMBSTONE or record.get("lifecycle", {}).get("state") == REVOKED
|
||||
}
|
||||
return [
|
||||
record
|
||||
for record in records
|
||||
if record.get("recordType", SAMPLE) == SAMPLE
|
||||
and record.get("lifecycle", {}).get("state") == ACTIVE
|
||||
and record.get("contributionId") not in revoked
|
||||
]
|
||||
|
||||
|
||||
def _safe_dataset_path(dataset_root: Path, relative: str) -> Path:
|
||||
path = (dataset_root / relative).resolve()
|
||||
if not path.is_relative_to(dataset_root.resolve()):
|
||||
raise CorpusError(f"refusing to touch a path outside the dataset: {relative}")
|
||||
return path
|
||||
|
||||
|
||||
def revoke(dataset_root: Path, contribution_id: str, at: str, reason: str) -> dict:
|
||||
"""Revoke one contribution: append a tombstone and delete its bytes from the dataset."""
|
||||
manifest_path = dataset_root / "manifest.jsonl"
|
||||
records = load_manifest(manifest_path)
|
||||
samples = [
|
||||
record
|
||||
for record in records
|
||||
if record.get("recordType", SAMPLE) == SAMPLE and record.get("contributionId") == contribution_id
|
||||
]
|
||||
if not isinstance(reason, str) or not reason.strip():
|
||||
raise IllegalTransition("revocation needs a recorded reason")
|
||||
if any(
|
||||
record.get("recordType") == TOMBSTONE and record.get("contributionId") == contribution_id
|
||||
for record in records
|
||||
):
|
||||
raise IllegalTransition(f"contribution {contribution_id} is already revoked")
|
||||
if not samples:
|
||||
raise IllegalTransition(f"no ingested sample carries contribution {contribution_id}")
|
||||
sample = samples[-1]
|
||||
if sample.get("lifecycle", {}).get("state") != ACTIVE:
|
||||
raise IllegalTransition(f"contribution {contribution_id} is not active")
|
||||
|
||||
deleted = []
|
||||
candidates = [(sample["relativePath"], sample["hashes"]["derived"])]
|
||||
# A raw pre-derivation copy is identified by the raw input digest, never by a user path.
|
||||
for path in sorted((dataset_root / "raw").glob(f"{sample['hashes']['rawInput']}*")):
|
||||
candidates.append((str(path.relative_to(dataset_root)), sample["hashes"]["rawInput"]))
|
||||
for relative, digest in candidates:
|
||||
target = _safe_dataset_path(dataset_root, relative)
|
||||
existed = target.is_file()
|
||||
if existed:
|
||||
target.unlink()
|
||||
deleted.append({"relativePath": relative, "sha256": digest, "deleted": existed})
|
||||
|
||||
tombstone = {
|
||||
"schemaVersion": SCHEMA_VERSION,
|
||||
"recordType": TOMBSTONE,
|
||||
"contributionId": contribution_id,
|
||||
"imageId": sample["imageId"],
|
||||
"deletedArtifacts": deleted,
|
||||
"lifecycle": {"state": REVOKED, "updatedAt": _require_iso(at, "lifecycle timestamp"), "reason": reason.strip()},
|
||||
}
|
||||
append_record(manifest_path, tombstone)
|
||||
return tombstone
|
||||
@@ -12,6 +12,8 @@ from pathlib import Path
|
||||
|
||||
from PIL import Image, ImageOps
|
||||
|
||||
from corpus_manifest import CorpusError, append_record, assert_admissible, build_record, revoke, sha256_hex
|
||||
|
||||
COLORS = ("brown", "green", "yellow", "pale", "red", "black")
|
||||
QUALITIES = ("good", "fair", "poor")
|
||||
REVIEWERS = ("user-confirmed", "clinician-reviewed")
|
||||
@@ -19,27 +21,62 @@ REVIEWERS = ("user-confirmed", "clinician-reviewed")
|
||||
|
||||
def parser() -> argparse.ArgumentParser:
|
||||
p = argparse.ArgumentParser()
|
||||
p.add_argument("--input", required=True)
|
||||
p.add_argument("--input")
|
||||
p.add_argument("--output-dir", required=True)
|
||||
p.add_argument("--subject-id", required=True)
|
||||
p.add_argument("--consent-version", required=True)
|
||||
p.add_argument("--bristol-type", required=True, type=int, choices=range(1, 8))
|
||||
p.add_argument("--color", required=True, choices=COLORS)
|
||||
p.add_argument("--quality", required=True, choices=QUALITIES)
|
||||
p.add_argument("--reviewer", required=True, choices=REVIEWERS)
|
||||
p.add_argument("--subject-id")
|
||||
p.add_argument("--consent-version")
|
||||
p.add_argument("--contribution-id")
|
||||
p.add_argument("--bristol-type", type=int, choices=range(1, 8))
|
||||
p.add_argument("--color", choices=COLORS)
|
||||
p.add_argument("--quality", choices=QUALITIES)
|
||||
p.add_argument("--reviewer", choices=REVIEWERS)
|
||||
# Revocation is a corpus operation, not an ingestion: it needs the dataset and a reason.
|
||||
p.add_argument("--revoke", metavar="CONTRIBUTION_ID")
|
||||
p.add_argument("--reason")
|
||||
return p
|
||||
|
||||
|
||||
def require_ingest_arguments(args: argparse.Namespace) -> None:
|
||||
if not args.consent_version or not args.consent_version.strip():
|
||||
raise SystemExit("consent version is required")
|
||||
if not args.reviewer:
|
||||
raise SystemExit("a human review status is required")
|
||||
missing = [
|
||||
flag
|
||||
for flag, value in (
|
||||
("--input", args.input),
|
||||
("--subject-id", args.subject_id),
|
||||
("--contribution-id", args.contribution_id),
|
||||
("--bristol-type", args.bristol_type),
|
||||
("--color", args.color),
|
||||
("--quality", args.quality),
|
||||
)
|
||||
if value is None or value == ""
|
||||
]
|
||||
if missing:
|
||||
raise SystemExit(f"ingesting a sample also needs {', '.join(missing)}")
|
||||
|
||||
|
||||
def main() -> int:
|
||||
args = parser().parse_args()
|
||||
if args.revoke:
|
||||
if not args.reason:
|
||||
raise SystemExit("revoking a contribution needs a recorded reason")
|
||||
try:
|
||||
tombstone = revoke(Path(args.output_dir), args.revoke, datetime.now(timezone.utc).isoformat(), args.reason)
|
||||
except CorpusError as exc:
|
||||
raise SystemExit(str(exc)) from exc
|
||||
print(json.dumps(tombstone))
|
||||
return 0
|
||||
|
||||
require_ingest_arguments(args)
|
||||
salt = os.environ.get("TIMMY_DATASET_SALT", "")
|
||||
if len(salt) < 8:
|
||||
raise SystemExit("TIMMY_DATASET_SALT must contain at least 8 characters")
|
||||
if not args.consent_version.strip():
|
||||
raise SystemExit("consent version is required")
|
||||
|
||||
try:
|
||||
with Image.open(args.input) as source:
|
||||
raw_bytes = Path(args.input).read_bytes()
|
||||
with Image.open(io.BytesIO(raw_bytes)) as source:
|
||||
image = ImageOps.exif_transpose(source).convert("RGB")
|
||||
image.thumbnail((1200, 1200))
|
||||
buffer = io.BytesIO()
|
||||
@@ -55,37 +92,34 @@ def main() -> int:
|
||||
|
||||
output = Path(args.output_dir)
|
||||
images = output / "images"
|
||||
images.mkdir(parents=True, exist_ok=True)
|
||||
relative_path = f"images/{image_id}.jpg"
|
||||
target = output / relative_path
|
||||
if not target.exists():
|
||||
target.write_bytes(data)
|
||||
|
||||
record = {
|
||||
"schemaVersion": 1,
|
||||
"imageId": image_id,
|
||||
"relativePath": relative_path,
|
||||
"subjectKey": subject_key,
|
||||
"split": split,
|
||||
"consentVersion": args.consent_version.strip(),
|
||||
"ingestedAt": datetime.now(timezone.utc).isoformat(),
|
||||
"labels": {
|
||||
"bristolType": args.bristol_type,
|
||||
"color": args.color,
|
||||
"quality": args.quality,
|
||||
},
|
||||
"review": {"status": args.reviewer},
|
||||
"derivation": {
|
||||
"format": "jpeg",
|
||||
"maxDimension": 1200,
|
||||
"metadataStripped": True,
|
||||
},
|
||||
}
|
||||
with (output / "manifest.jsonl").open("a", encoding="utf-8") as manifest:
|
||||
manifest.write(json.dumps(record, separators=(",", ":")) + "\n")
|
||||
now = datetime.now(timezone.utc).isoformat()
|
||||
record = build_record(
|
||||
contribution_id=args.contribution_id,
|
||||
consent_version=args.consent_version,
|
||||
subject_key=subject_key,
|
||||
split=split,
|
||||
labels={"bristolType": args.bristol_type, "color": args.color, "quality": args.quality},
|
||||
review_status=args.reviewer,
|
||||
derived_sha256=image_id,
|
||||
raw_sha256=sha256_hex(raw_bytes),
|
||||
ingested_at=now,
|
||||
)
|
||||
try:
|
||||
# Refuse a duplicate contribution before any byte lands in the active dataset.
|
||||
assert_admissible(output / "manifest.jsonl", record)
|
||||
images.mkdir(parents=True, exist_ok=True)
|
||||
if not target.exists():
|
||||
target.write_bytes(data)
|
||||
append_record(output / "manifest.jsonl", record)
|
||||
except CorpusError as exc:
|
||||
raise SystemExit(str(exc)) from exc
|
||||
print(json.dumps(record))
|
||||
return 0
|
||||
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
@@ -1,10 +1,16 @@
|
||||
import { chromium } from 'playwright';
|
||||
import { mkdir, writeFile } from 'node:fs/promises';
|
||||
import { execFile } from 'node:child_process';
|
||||
import { mkdir, mkdtemp, readFile, readdir, rm, writeFile } from 'node:fs/promises';
|
||||
import { createHash } from 'node:crypto';
|
||||
import os from 'node:os';
|
||||
import { promisify } from 'node:util';
|
||||
import path from 'node:path';
|
||||
import { fileURLToPath } from 'node:url';
|
||||
import { analyzePhoto, visionFailureResponse } from '../src/vision-service.js';
|
||||
import { loadVisionCorpus } from '../src/vision-corpus.js';
|
||||
|
||||
const execFileAsync = promisify(execFile);
|
||||
|
||||
const output = path.resolve(process.argv[2] || 'release-demo.webm');
|
||||
const version = process.env.TIMMY_RELEASE_VERSION || 'review build';
|
||||
// The release delta is supplied by the builder so the recording states, on camera, what actually
|
||||
@@ -477,6 +483,331 @@ await page.getByText(/Your poop\. Your phone\./i).waitFor();
|
||||
await caption('Every byte-bearing control the model names, in the running app: local ledger, consent-gated upload, portable export, full deletion', 2800);
|
||||
await indicate('#export');
|
||||
await caption('Export writes a plain JSON file you hold — the model records it as a data-lifetime boundary, not a server sync', 2600);
|
||||
// Issue #24 — training contribution is a second, separate consent. The recording shows the section
|
||||
// reporting nothing queued after ordinary saves, the version and receipt on screen before the
|
||||
// button can be pressed, one receipt queued on the device only, and a withdrawal tombstone that
|
||||
// names each derived artifact by contribution id.
|
||||
await caption('Training contribution is off by default: a saved log is never training data', 2600);
|
||||
await page.locator('[data-training-consent]').waitFor();
|
||||
const contributionKey = await page.evaluate(() => `timmy:${document.querySelector('meta[name="timmy-base-path"]')?.content || '/'}:training-contributions-v1`);
|
||||
const storedContributions = async () => JSON.parse(await page.evaluate(key => localStorage.getItem(key) || '[]', contributionKey));
|
||||
if ((await page.locator('[data-contribution-queued-count]').innerText()).trim() !== '0') {
|
||||
throw new Error('a journal save must not queue a training contribution');
|
||||
}
|
||||
await indicate('[data-contribute-entry="demo-wipe"]');
|
||||
await tap('[data-contribute-entry="demo-wipe"]', 600);
|
||||
await page.locator('[data-contribution-sheet]').waitFor();
|
||||
const receiptId = (await page.locator('[data-receipt-id]').innerText()).trim();
|
||||
if (!receiptId) throw new Error('the consent sheet must name the receipt before consent');
|
||||
const sheetCopy = await page.locator('[data-contribution-sheet]').innerText();
|
||||
if (!sheetCopy.includes('training-consent-v1')) throw new Error('the consent sheet must state the consent version');
|
||||
if (!(await page.locator('#contribute-confirm').isDisabled())) throw new Error('the contribute control must stay disabled until the terms are accepted');
|
||||
if ((await storedContributions()).length !== 0) throw new Error('no receipt may exist before explicit consent');
|
||||
await caption('The consent version and the receipt are on screen before the contribute button works', 3000);
|
||||
await page.locator('#training-consent-check').check();
|
||||
await tap('#contribute-confirm', 700);
|
||||
await page.locator('[data-contribution-state="queued-local"]').waitFor();
|
||||
const queuedReceipts = await storedContributions();
|
||||
if (queuedReceipts.length !== 1 || queuedReceipts[0].consentVersion !== 'training-consent-v1') {
|
||||
throw new Error('one queued receipt must carry the consent version it was accepted under');
|
||||
}
|
||||
if (JSON.stringify(queuedReceipts).includes('data:image')) throw new Error('a receipt must never copy the photo bytes');
|
||||
await caption('One confirmed log is queued on this device with a receipt you can withdraw — nothing is uploaded', 3200);
|
||||
await indicate('[data-contribution-state="queued-local"]');
|
||||
await tap(`[data-withdraw="${receiptId}"]`, 700);
|
||||
await page.locator('[data-contribution-state="withdrawn"]').waitFor();
|
||||
const withdrawnReceipts = await storedContributions();
|
||||
const tombstone = withdrawnReceipts[0];
|
||||
if (!tombstone || tombstone.state !== 'withdrawn') throw new Error('withdrawal must keep the receipt as a tombstone');
|
||||
if ((tombstone.artifacts || []).length !== 2) throw new Error('the tombstone must name every derived artifact');
|
||||
for (const artifact of tombstone.artifacts) {
|
||||
if (artifact.contributionId !== receiptId) throw new Error('every derived artifact must be addressed by contribution id');
|
||||
if (artifact.state !== 'withdrawn') throw new Error('every derived artifact must be marked withdrawn');
|
||||
}
|
||||
await caption('Withdrawing keeps a tombstone naming every derived artifact by contribution ID', 3000);
|
||||
await indicate('[data-withdrawn-artifacts]');
|
||||
|
||||
// Issue #25 — the corpus pipeline is a command-line tool, not a screen in the app. Rather than
|
||||
// inventing a UI for it, this scene runs the real ingest and revoke commands against the committed
|
||||
// synthetic fixture in a throwaway dataset and shows their actual output. Every number, hash prefix,
|
||||
// and refusal line below is read back from those commands at record time.
|
||||
async function corpusCli(args) {
|
||||
return execFileAsync('python3', args, {
|
||||
cwd: process.cwd(),
|
||||
env: { ...process.env, TIMMY_DATASET_SALT: 'demo-only-salt-not-a-secret' },
|
||||
});
|
||||
}
|
||||
async function corpusAudit() {
|
||||
const dataset = await mkdtemp(path.join(os.tmpdir(), 'timmy-corpus-demo-'));
|
||||
const fixture = 'tests/fixtures/synthetic-type4.jpg';
|
||||
const contributionId = 'demo-contrib-0001-abcd';
|
||||
const manifestPath = path.join(dataset, 'manifest.jsonl');
|
||||
const lines = async () => (await readFile(manifestPath, 'utf8'))
|
||||
.split('\n').filter(line => line.trim()).map(line => JSON.parse(line));
|
||||
const images = async () => (await readdir(path.join(dataset, 'images')).catch(() => [])).sort();
|
||||
try {
|
||||
const ingest = await corpusCli([
|
||||
'scripts/ingest_training_photo.py',
|
||||
'--input', fixture,
|
||||
'--output-dir', dataset,
|
||||
'--subject-id', 'demo-subject',
|
||||
'--consent-version', 'training-consent-v1',
|
||||
'--contribution-id', contributionId,
|
||||
'--bristol-type', '4', '--color', 'brown', '--quality', 'good',
|
||||
'--reviewer', 'user-confirmed',
|
||||
]);
|
||||
const record = JSON.parse(ingest.stdout);
|
||||
const fixtureDigest = createHash('sha256').update(await readFile(fixture)).digest('hex');
|
||||
if (record.recordType !== 'sample' || record.lifecycle?.state !== 'active') {
|
||||
throw new Error('ingest must write one active sample record');
|
||||
}
|
||||
// The record names the source by digest only: the caller's path must never be stored.
|
||||
if (record.source?.inputSha256 !== fixtureDigest || record.hashes?.rawInput !== fixtureDigest) {
|
||||
throw new Error('the record must carry the raw input digest');
|
||||
}
|
||||
if (JSON.stringify(record).includes(fixture) || 'inputPath' in record) {
|
||||
throw new Error('the record must never store the caller path');
|
||||
}
|
||||
const afterIngestImages = await images();
|
||||
if (afterIngestImages.length !== 1 || (await lines()).length !== 1) {
|
||||
throw new Error('ingest must write exactly one derived image and one manifest record');
|
||||
}
|
||||
|
||||
const revoke = await corpusCli([
|
||||
'scripts/ingest_training_photo.py', '--output-dir', dataset,
|
||||
'--revoke', contributionId, '--reason', 'participant withdrew consent',
|
||||
]);
|
||||
const tombstone = JSON.parse(revoke.stdout);
|
||||
const afterRevokeImages = await images();
|
||||
const history = await lines();
|
||||
if (tombstone.recordType !== 'tombstone' || history.length !== 2) {
|
||||
throw new Error('revocation must append exactly one tombstone to the existing history');
|
||||
}
|
||||
if (afterRevokeImages.length !== 0) throw new Error('revocation must delete the derived bytes');
|
||||
if (history[0].recordType !== 'sample' || history[0].lifecycle?.state !== 'active') {
|
||||
throw new Error('the original record must survive its own withdrawal');
|
||||
}
|
||||
if ('labels' in tombstone || 'subjectKey' in tombstone) {
|
||||
throw new Error('a tombstone must not carry the labels or subject key');
|
||||
}
|
||||
const deleted = tombstone.deletedArtifacts || [];
|
||||
if (!deleted.some(item => item.relativePath === `images/${record.imageId}.jpg` && item.deleted === true)) {
|
||||
throw new Error('the tombstone must name the derived artifact it removed');
|
||||
}
|
||||
const active = await corpusCli([
|
||||
'-c',
|
||||
'import sys;sys.path.insert(0,"scripts");import corpus_manifest as c;from pathlib import Path;'
|
||||
+ 'print(len(c.active_records(c.load_manifest(Path(sys.argv[1])/"manifest.jsonl"))))',
|
||||
dataset,
|
||||
]);
|
||||
if (active.stdout.trim() !== '0') throw new Error('a trainer reading the manifest must see zero active samples');
|
||||
|
||||
// A second revocation of the same contribution has to be refused, and refuse without writing.
|
||||
let refusal = '';
|
||||
try {
|
||||
await corpusCli([
|
||||
'scripts/ingest_training_photo.py', '--output-dir', dataset,
|
||||
'--revoke', contributionId, '--reason', 'participant withdrew consent again',
|
||||
]);
|
||||
throw new Error('a second revocation must be refused');
|
||||
} catch (error) {
|
||||
if (error.message === 'a second revocation must be refused') throw error;
|
||||
refusal = String(error.stderr || error.stdout || '').trim().split('\n').filter(Boolean).pop() || '';
|
||||
}
|
||||
if (!/already revoked/.test(refusal)) throw new Error(`second revocation refusal was not legible: ${refusal}`);
|
||||
if ((await lines()).length !== 2) throw new Error('a refused revocation must append nothing');
|
||||
return { record, tombstone, deleted, refusal, derived: record.imageId, fixtureDigest };
|
||||
} finally {
|
||||
await rm(dataset, { recursive: true, force: true });
|
||||
}
|
||||
}
|
||||
const audit = await corpusAudit();
|
||||
const short = value => String(value).slice(0, 12);
|
||||
const deletedName = audit.deleted[0].relativePath.split('/').pop().replace(/\.jpg$/, '');
|
||||
await tap('[data-view="home"]', 500);
|
||||
// The card is drawn from the values above, so a run that stops writing provenance or stops deleting
|
||||
// bytes fails here instead of recording a caption that claims it.
|
||||
const auditRows = [
|
||||
['command', 'python3 scripts/ingest_training_photo.py --input <synthetic fixture>'],
|
||||
['record', `sample · schemaVersion ${audit.record.schemaVersion}`],
|
||||
['consent', audit.record.consent.version],
|
||||
['source', `sha256 ${short(audit.record.source.inputSha256)}… (path never stored)`],
|
||||
['hashes', `raw ${short(audit.record.hashes.rawInput)}… · derived ${short(audit.record.hashes.derived)}…`],
|
||||
['derived', audit.record.derivation.pipeline + ' · jpeg · ≤1200px · metadata stripped'],
|
||||
['review', audit.record.review.status],
|
||||
['lifecycle', audit.record.lifecycle.state],
|
||||
['—', ''],
|
||||
['command', `--revoke ${audit.record.contributionId} --reason "participant withdrew consent"`],
|
||||
['deleted', `images/${short(deletedName)}….jpg → gone from disk`],
|
||||
['tombstone', 'appended · keeps id + digests · drops labels + subject key'],
|
||||
['history', '2 lines: the original record is still there'],
|
||||
['trainer', 'active samples: 0'],
|
||||
['—', ''],
|
||||
['command', '--revoke again'],
|
||||
['refused', audit.refusal],
|
||||
['manifest', 'unchanged at 2 lines'],
|
||||
];
|
||||
const panelOk = await page.evaluate(rows => {
|
||||
document.querySelector('#corpus-audit')?.remove();
|
||||
const panel = document.createElement('div');
|
||||
panel.id = 'corpus-audit';
|
||||
Object.assign(panel.style, {
|
||||
position: 'fixed', inset: '96px 14px 40px 14px', zIndex: '15000',
|
||||
background: '#181412', color: '#f6f1e6', borderRadius: '18px',
|
||||
border: '1px solid rgba(245,201,91,.45)', padding: '13px 13px 11px',
|
||||
font: '600 10.5px/1.5 ui-monospace, SFMono-Regular, Menlo, monospace',
|
||||
display: 'flex', flexDirection: 'column', gap: '1px', overflow: 'hidden',
|
||||
boxShadow: '0 18px 40px rgba(0,0,0,.42)',
|
||||
});
|
||||
const head = document.createElement('div');
|
||||
head.textContent = 'CORPUS AUDIT';
|
||||
Object.assign(head.style, { font: '800 14px/1.2 system-ui', letterSpacing: '.14em', color: '#f5c95b', marginBottom: '2px' });
|
||||
const sub = document.createElement('div');
|
||||
sub.textContent = 'command line, not app UI — real run, synthetic fixture';
|
||||
Object.assign(sub.style, { font: '700 9.5px/1.3 system-ui', color: '#c9bfae', marginBottom: '9px' });
|
||||
panel.append(head, sub);
|
||||
for (const [key, value] of rows) {
|
||||
const row = document.createElement('div');
|
||||
if (key === '—') { row.style.height = '7px'; panel.append(row); continue; }
|
||||
Object.assign(row.style, { display: 'flex', gap: '7px', alignItems: 'baseline' });
|
||||
const k = document.createElement('span');
|
||||
k.textContent = key;
|
||||
k.style.cssText = 'flex:0 0 62px;color:#8fd7c8;text-transform:uppercase;font-size:9px;letter-spacing:.08em';
|
||||
const v = document.createElement('span');
|
||||
v.textContent = value;
|
||||
v.style.cssText = 'flex:1 1 auto;word-break:break-word;color:#f6f1e6';
|
||||
row.append(k, v);
|
||||
panel.append(row);
|
||||
}
|
||||
document.body.append(panel);
|
||||
panel.animate([{ opacity: 0, transform: 'translateY(12px)' }, { opacity: 1, transform: 'translateY(0)' }], { duration: 320, fill: 'forwards' });
|
||||
return { height: panel.clientHeight, scroll: panel.scrollHeight, text: panel.innerText };
|
||||
}, auditRows);
|
||||
await sleep(420);
|
||||
const panelProof = await page.evaluate(() => {
|
||||
const panel = document.querySelector('#corpus-audit');
|
||||
if (!panel) return { ok: false, reason: 'panel missing' };
|
||||
const rect = panel.getBoundingClientRect();
|
||||
const topmost = document.elementFromPoint(Math.round(rect.left + rect.width / 2), Math.round(rect.top + rect.height / 2));
|
||||
const background = getComputedStyle(panel).backgroundColor;
|
||||
// A translucent card lets the nav bar and body copy ghost through its empty rows, which reads as a
|
||||
// sloppy overlay on the thinnest part of the frame. The card must be fully opaque.
|
||||
const opaque = !/^rgba\(.*,\s*(0?\.\d+|0)\)$/.test(background);
|
||||
return {
|
||||
ok: opaque && rect.top >= 60 && rect.bottom <= window.innerHeight && rect.width > 300 && rect.height > 300
|
||||
&& (topmost === panel || panel.contains(topmost)) && panel.scrollHeight <= panel.clientHeight + 1,
|
||||
top: Math.round(rect.top), height: Math.round(rect.height), width: Math.round(rect.width),
|
||||
scroll: panel.scrollHeight, client: panel.clientHeight, background, opaque,
|
||||
covered: topmost === panel || panel.contains(topmost),
|
||||
};
|
||||
});
|
||||
if (!panelProof.ok) throw new Error(`Corpus audit card is not fully readable on screen: ${JSON.stringify(panelProof)}`);
|
||||
// The card is drawn from live command output; prove the values on it are the ones the run produced.
|
||||
if (!panelOk.text.includes(audit.record.imageId.slice(0, 12))) throw new Error('the card must show the derived digest it recorded');
|
||||
if (!panelOk.text.includes('active samples: 0')) throw new Error('the card must show the post-revocation active count');
|
||||
await caption('The corpus pipeline is a command-line tool, not a screen in the app — this runs the real ingest against the committed synthetic fixture', 3400);
|
||||
await caption('Every ingested sample records consent, source digest, both hashes, derivation, review, and lifecycle — the caller file path is never stored', 3600);
|
||||
await caption('Withdrawing deletes the derived image and any raw copy, keeps the original record, and appends a tombstone — the trainer sees zero active samples', 3800);
|
||||
await caption('Revoking the same contribution twice is refused and appends nothing: the manifest only ever grows', 3200);
|
||||
await page.evaluate(() => document.querySelector('#corpus-audit')?.remove());
|
||||
// Back to the privacy view for the portability scene: the privacy entry lives on the journal view.
|
||||
await tap('[data-view="calendar"]', 550);
|
||||
await tap('[data-view="privacy"]', 600);
|
||||
|
||||
// Issue #35 — a backup is the person's own record, so it carries a version and everything it is
|
||||
// claimed to hold. The recording exports the real file, imports an older version and a newer one,
|
||||
// and reopens a restored log. Fictional sample logs are used throughout; nothing here is real data.
|
||||
const exportDownload = page.waitForEvent('download');
|
||||
await tap('#export', 600);
|
||||
const exportedBackup = JSON.parse(await readFile(await (await exportDownload).path(), 'utf8'));
|
||||
if (exportedBackup.schemaVersion !== 2) throw new Error('the exported backup must declare the current schema version');
|
||||
if (!Array.isArray(exportedBackup.entries) || !Array.isArray(exportedBackup.contributions)) {
|
||||
throw new Error('a backup must carry both the confirmed logs and the contribution receipts');
|
||||
}
|
||||
const exportedReceipt = exportedBackup.contributions.find(receipt => receipt.contributionId === receiptId);
|
||||
if (!exportedReceipt || exportedReceipt.state !== 'withdrawn') {
|
||||
throw new Error('the backup must carry the withdrawn receipt as a tombstone');
|
||||
}
|
||||
if (!(exportedReceipt.artifacts || []).length) throw new Error('the backup tombstone must still name its derived artifacts');
|
||||
await page.locator('[data-portability-notice][data-portability-version="2"]').waitFor();
|
||||
await caption('A backup is versioned, and it carries the withdrawn receipt as a tombstone rather than silence', 3200);
|
||||
|
||||
const fictionalLegacyBackup = JSON.stringify({
|
||||
product: 'Timmy the Talking Turd',
|
||||
schemaVersion: 1,
|
||||
exportedAt: '2026-08-01T09:00:00.000Z',
|
||||
entries: [{
|
||||
id: 'demo-legacy-backup',
|
||||
occurredAt: new Date(Date.now() - 3 * 86400000).toISOString(),
|
||||
bristolType: 3,
|
||||
color: 'brown',
|
||||
urgency: 1,
|
||||
discomfort: 0,
|
||||
note: 'fictional version 1 backup',
|
||||
photoDataUrl: '',
|
||||
symptoms: {},
|
||||
}],
|
||||
});
|
||||
await page.locator('#import').setInputFiles({ name: 'timmy-backup-v1.json', mimeType: 'application/json', buffer: Buffer.from(fictionalLegacyBackup) });
|
||||
await page.locator('[data-portability-notice][data-portability-version="1"]').waitFor();
|
||||
const upgradeNotice = (await page.locator('[data-portability-notice]').innerText()).trim();
|
||||
if (!/upgraded/i.test(upgradeNotice)) throw new Error('an older backup must be reported as upgraded, not silently rewritten');
|
||||
await caption('An older backup is upgraded on import, and the notice says which version the file came from', 3400);
|
||||
|
||||
const ledgerBeforeFuture = await storedLedger();
|
||||
await page.locator('#import').setInputFiles({
|
||||
name: 'timmy-backup-v3.json', mimeType: 'application/json',
|
||||
buffer: Buffer.from(JSON.stringify({ product: 'Timmy the Talking Turd', schemaVersion: 3, entries: [{ id: 'demo-future', bristolType: 7 }] })),
|
||||
});
|
||||
await page.locator('[data-portability-error]').waitFor();
|
||||
if (!/newer version of Timmy/i.test(await page.locator('[data-portability-error]').innerText())) {
|
||||
throw new Error('a backup from a newer Timmy must be refused with an instruction to update');
|
||||
}
|
||||
if ((await storedLedger()).raw !== ledgerBeforeFuture.raw) {
|
||||
throw new Error('a refused import must not change the ledger it would have replaced');
|
||||
}
|
||||
await caption('A file from a newer Timmy is refused with an instruction, and the ledger it would have replaced is untouched', 3400);
|
||||
|
||||
const fictionalAssistedBackup = JSON.stringify({
|
||||
product: 'Timmy the Talking Turd',
|
||||
schemaVersion: 2,
|
||||
exportedAt: new Date().toISOString(),
|
||||
entries: [{
|
||||
id: 'demo-restored-provenance',
|
||||
occurredAt: new Date(Date.now() - 86400000).toISOString(),
|
||||
bristolType: 2,
|
||||
color: 'brown',
|
||||
urgency: 1,
|
||||
discomfort: 0,
|
||||
note: 'fictional restored log',
|
||||
photoDataUrl: '',
|
||||
symptoms: {},
|
||||
provenance: {
|
||||
source: 'ai-corrected',
|
||||
model: 'SmolVLM2-2.2B-Instruct',
|
||||
suggestedBristolType: 4,
|
||||
suggestedColor: 'brown',
|
||||
confirmedAt: new Date(Date.now() - 86400000).toISOString(),
|
||||
},
|
||||
}],
|
||||
contributions: [],
|
||||
});
|
||||
await page.locator('#import').setInputFiles({ name: 'timmy-backup-v2.json', mimeType: 'application/json', buffer: Buffer.from(fictionalAssistedBackup) });
|
||||
await page.locator('[data-portability-notice][data-portability-version="2"]').waitFor();
|
||||
await tap('[data-view="calendar"]', 550);
|
||||
await page.locator('[data-entry-open="demo-restored-provenance"]').waitFor();
|
||||
await tap('[data-entry-open="demo-restored-provenance"]', 550);
|
||||
await page.locator('[data-entry-provenance="ai-corrected"]').waitFor();
|
||||
const provenanceLine = (await page.locator('[data-entry-provenance="ai-corrected"]').innerText()).trim();
|
||||
if (!/corrected/i.test(provenanceLine) || !/SmolVLM2/.test(provenanceLine)) {
|
||||
throw new Error('a restored log must still show that it began as a corrected AI suggestion');
|
||||
}
|
||||
await caption('A restored log still says it began as an AI suggestion you corrected — provenance is part of the record', 3400);
|
||||
await indicate('[data-entry-provenance="ai-corrected"]');
|
||||
await tap('#entry-sheet-close', 450);
|
||||
await tap('[data-view="privacy"]', 550);
|
||||
await page.locator('#delete-all').waitFor();
|
||||
|
||||
await indicate('#delete-all');
|
||||
await tap('#delete-all', 650);
|
||||
await page.getByText(/Local ledger and photos deleted/).waitFor();
|
||||
@@ -485,6 +816,9 @@ if (wiped.raw !== null) throw new Error('delete-all must remove the stored ledge
|
||||
if (await page.evaluate(() => JSON.stringify(localStorage).includes('data:image'))) {
|
||||
throw new Error('no photo bytes may survive delete-all');
|
||||
}
|
||||
if (await page.evaluate(key => localStorage.getItem(key), contributionKey) !== null) {
|
||||
throw new Error('delete-all must clear the contribution receipts as well');
|
||||
}
|
||||
await caption('Delete all local data clears the ledger and every saved photo in this browser; nothing is kept on a server', 2900);
|
||||
await tap('[data-view="home"]', 500);
|
||||
// Issue #37 — a chat answer about the journal must point at the confirmed records behind it. The
|
||||
|
||||
+1
-1
@@ -1,7 +1,7 @@
|
||||
const ROOT = new URL(self.registration.scope).pathname;
|
||||
const appPath = path => `${ROOT}${String(path).replace(/^\/+/, '')}`;
|
||||
const CACHE_NAMESPACE = `timmy-shell:${ROOT}:`;
|
||||
const CACHE = `${CACHE_NAMESPACE}v5`;
|
||||
const CACHE = `${CACHE_NAMESPACE}v6`;
|
||||
const ASSETS = [
|
||||
'',
|
||||
'index.html',
|
||||
|
||||
+129
-5
@@ -111,9 +111,32 @@ export function sanitizeEntry(input = {}) {
|
||||
note: String(input.note || '').trim().slice(0, 500),
|
||||
photoDataUrl: typeof input.photoDataUrl === 'string' && input.photoDataUrl.startsWith('data:image/') ? input.photoDataUrl : '',
|
||||
symptoms,
|
||||
provenance: sanitizeProvenance(input.provenance),
|
||||
};
|
||||
}
|
||||
|
||||
// Provenance is the only record of whether a confirmed log began as an AI suggestion. It is kept to
|
||||
// an allowlist so a backup can never smuggle a credential, a prompt, or a raw model reply out of the
|
||||
// device, and it is `null` for logs that never had one — a missing record is not a manual entry.
|
||||
const PROVENANCE_SOURCES = Object.freeze(['ai-confirmed', 'ai-corrected']);
|
||||
|
||||
function sanitizeProvenance(value) {
|
||||
if (!value || typeof value !== 'object') return null;
|
||||
if (!PROVENANCE_SOURCES.includes(value.source)) return null;
|
||||
const provenance = { source: value.source };
|
||||
if (typeof value.model === 'string' && value.model.trim()) provenance.model = value.model.trim().slice(0, 80);
|
||||
const suggestedType = Number(value.suggestedBristolType);
|
||||
if (Number.isInteger(suggestedType) && suggestedType >= 1 && suggestedType <= 7) {
|
||||
provenance.suggestedBristolType = suggestedType;
|
||||
}
|
||||
if (['brown', 'green', 'yellow', 'pale', 'red', 'black'].includes(value.suggestedColor)) {
|
||||
provenance.suggestedColor = value.suggestedColor;
|
||||
}
|
||||
const confirmedAt = value.confirmedAt ? new Date(value.confirmedAt) : null;
|
||||
if (confirmedAt && !Number.isNaN(confirmedAt.valueOf())) provenance.confirmedAt = confirmedAt.toISOString();
|
||||
return provenance;
|
||||
}
|
||||
|
||||
export function photoQualityMessage({ width = 0, height = 0, brightness = 0.5 } = {}) {
|
||||
if (width < 640 || height < 480) return 'Move a little closer or use a higher-resolution photo. The image stays on this device.';
|
||||
if (brightness < 0.12) return 'Add more light before saving. Timmy only checks whether the photo is usable.';
|
||||
@@ -121,19 +144,120 @@ export function photoQualityMessage({ width = 0, height = 0, brightness = 0.5 }
|
||||
return 'Ready for your review. Choose the matching Bristol form yourself; Timmy does not interpret the picture.';
|
||||
}
|
||||
|
||||
export const LEDGER_EXPORT_VERSION = 2;
|
||||
|
||||
export function exportLedger(entries, exportedAt = new Date().toISOString()) {
|
||||
return exportLedgerBackup({ entries, exportedAt });
|
||||
}
|
||||
|
||||
// A backup is written through an allowlist, so only fields this build understands leave the device.
|
||||
// Entries are re-sanitized on the way out as well as in: an unknown key on an entry is not part of
|
||||
// the person's record, and a crafted key must never be laundered through a backup.
|
||||
export function exportLedgerBackup({ entries = [], contributions = [], exportedAt = new Date().toISOString() } = {}) {
|
||||
const list = Array.isArray(entries) ? entries.map(sanitizeEntry) : [];
|
||||
const receipts = (Array.isArray(contributions) ? contributions : []).map(sanitizeContribution).filter(Boolean);
|
||||
return JSON.stringify({
|
||||
product: 'Timmy the Talking Turd',
|
||||
schemaVersion: 1,
|
||||
schemaVersion: LEDGER_EXPORT_VERSION,
|
||||
exportedAt,
|
||||
entries: Array.isArray(entries) ? entries : [],
|
||||
entries: list,
|
||||
contributions: receipts,
|
||||
}, null, 2);
|
||||
}
|
||||
|
||||
const CONTRIBUTION_STATES = Object.freeze(['queued-local', 'withdrawn']);
|
||||
const CONTRIBUTION_ARTIFACTS = Object.freeze(['raw-image', 'confirmed-label']);
|
||||
|
||||
function isoOrNull(value) {
|
||||
if (!value) return null;
|
||||
const parsed = new Date(value);
|
||||
return Number.isNaN(parsed.valueOf()) ? null : parsed.toISOString();
|
||||
}
|
||||
|
||||
export function sanitizeContribution(input = {}) {
|
||||
const contributionId = String(input?.contributionId || '').trim().slice(0, 120);
|
||||
if (!contributionId) return null;
|
||||
const state = CONTRIBUTION_STATES.includes(input.state) ? input.state : 'queued-local';
|
||||
const receipt = {
|
||||
contributionId,
|
||||
entryId: String(input.entryId || '').trim().slice(0, 120),
|
||||
consentVersion: String(input.consentVersion || '').trim().slice(0, 60),
|
||||
consentedAt: isoOrNull(input.consentedAt),
|
||||
labels: {
|
||||
bristolType: Math.min(7, Math.max(1, Number(input.labels?.bristolType) || 4)),
|
||||
color: ['brown', 'green', 'yellow', 'pale', 'red', 'black'].includes(input.labels?.color) ? input.labels.color : 'brown',
|
||||
},
|
||||
state,
|
||||
};
|
||||
const withdrawnAt = isoOrNull(input.withdrawnAt);
|
||||
if (state === 'withdrawn' && withdrawnAt) receipt.withdrawnAt = withdrawnAt;
|
||||
if (state === 'withdrawn') {
|
||||
receipt.artifacts = (Array.isArray(input.artifacts) ? input.artifacts : [])
|
||||
.filter(artifact => CONTRIBUTION_ARTIFACTS.includes(artifact?.artifact))
|
||||
.map(artifact => ({
|
||||
artifact: artifact.artifact,
|
||||
contributionId: String(artifact.contributionId || contributionId).slice(0, 120),
|
||||
state: artifact.state === 'withdrawn' ? 'withdrawn' : 'active',
|
||||
}));
|
||||
}
|
||||
return receipt;
|
||||
}
|
||||
|
||||
export function importLedger(text) {
|
||||
const parsed = JSON.parse(text);
|
||||
if (parsed?.schemaVersion !== 1 || !Array.isArray(parsed.entries)) throw new Error('This is not a supported Timmy export.');
|
||||
return parsed.entries.map(sanitizeEntry);
|
||||
return importLedgerBackup(text).entries;
|
||||
}
|
||||
|
||||
// A backup can be older than this build. Version 1 files record no provenance for their entries, so
|
||||
// the migration leaves that field empty instead of guessing a source, and the caller is told which
|
||||
// version the file came from.
|
||||
export const LEDGER_IMPORT_LIMITS = Object.freeze({ maxTextLength: 16 * 1024 * 1024, maxEntries: 5000 });
|
||||
|
||||
export function importLedgerBackup(text) {
|
||||
const raw = String(text ?? '');
|
||||
if (raw.length > LEDGER_IMPORT_LIMITS.maxTextLength) {
|
||||
throw new Error('That backup is too large for Timmy to read safely. Nothing was imported.');
|
||||
}
|
||||
let parsed;
|
||||
try {
|
||||
parsed = JSON.parse(raw);
|
||||
} catch {
|
||||
throw new Error('That file is not readable JSON, so nothing was imported.');
|
||||
}
|
||||
if (!parsed || typeof parsed !== 'object' || !Array.isArray(parsed.entries)) {
|
||||
throw new Error('This is not a supported Timmy backup.');
|
||||
}
|
||||
const fromVersion = Number(parsed.schemaVersion);
|
||||
if (Number.isInteger(fromVersion) && fromVersion > LEDGER_EXPORT_VERSION) {
|
||||
throw new Error(`This backup was written by a newer version of Timmy (version ${fromVersion}). Update Timmy before importing it; nothing was imported.`);
|
||||
}
|
||||
if (!Number.isInteger(fromVersion) || fromVersion < 1) {
|
||||
throw new Error('This is not a supported Timmy backup.');
|
||||
}
|
||||
if (parsed.entries.length > LEDGER_IMPORT_LIMITS.maxEntries) {
|
||||
throw new Error('That backup holds more logs than Timmy will import at once. Nothing was imported.');
|
||||
}
|
||||
const entries = parsed.entries.map(sanitizeEntry);
|
||||
const rawContributions = Array.isArray(parsed.contributions) ? parsed.contributions : [];
|
||||
const contributions = rawContributions.map(sanitizeContribution).filter(Boolean);
|
||||
const migrated = fromVersion < LEDGER_EXPORT_VERSION;
|
||||
// The caller already says what it restored, so this notice only reports the upgrade. Restating the
|
||||
// restored count here made the on-screen notice read as two stacked sentences saying one thing.
|
||||
const notices = migrated
|
||||
? [`Upgraded from version ${fromVersion} to version ${LEDGER_EXPORT_VERSION}; fields the old file did not record are left empty.`]
|
||||
: [];
|
||||
// Skipping an unreadable receipt silently would tell someone their opt-in vanished. Say it.
|
||||
const skipped = rawContributions.length - contributions.length;
|
||||
if (skipped > 0) {
|
||||
notices.push(`${skipped} training contribution ${skipped === 1 ? 'receipt' : 'receipts'} could not be read and ${skipped === 1 ? 'was' : 'were'} skipped.`);
|
||||
}
|
||||
return {
|
||||
entries,
|
||||
contributions,
|
||||
fromVersion,
|
||||
migrated,
|
||||
notices,
|
||||
exportedAt: typeof parsed.exportedAt === 'string' ? parsed.exportedAt : null,
|
||||
};
|
||||
}
|
||||
|
||||
export const urgentSymptomKeys = Object.freeze([...URGENT_KEYS]);
|
||||
@@ -0,0 +1,103 @@
|
||||
// Issue #24 — contributing a confirmed photo to Timmy's training corpus is a separate decision from
|
||||
// saving a log. A journal save records nothing here; a contribution exists only after someone reads
|
||||
// the consent terms and accepts them, and it exists as a receipt they can point a withdrawal at.
|
||||
// Nothing is transmitted: this build queues the receipt on the device so the corpus pipeline (#25)
|
||||
// has something auditable to consume later.
|
||||
export const TRAINING_CONSENT_VERSION = 'training-consent-v1';
|
||||
|
||||
const IMAGE_DATA_URL = /^data:image\/[a-z0-9.+-]+(?:;base64)?,[A-Za-z0-9+/=%.-]+$/i;
|
||||
const CONTRIBUTED_ARTIFACTS = ['raw-image', 'confirmed-label'];
|
||||
|
||||
export function consentTerms() {
|
||||
return {
|
||||
version: TRAINING_CONSENT_VERSION,
|
||||
includes: [
|
||||
'The saved photo bytes for this one log',
|
||||
'The confirmed Bristol form, broad color, and image quality',
|
||||
],
|
||||
excludes: [
|
||||
'Your note text',
|
||||
'Your symptom answers',
|
||||
'Urgency and discomfort ratings',
|
||||
'Anything identifying you or this device',
|
||||
],
|
||||
transport: 'Queued on this device only — nothing is uploaded in this build.',
|
||||
};
|
||||
}
|
||||
|
||||
export function defaultContributionState() {
|
||||
return { optedIn: false, receipt: null };
|
||||
}
|
||||
|
||||
export function contributionEligibility(entry) {
|
||||
if (!entry || !entry.id) return { eligible: false, reason: 'This log has no identifier to attach a receipt to.' };
|
||||
if (!IMAGE_DATA_URL.test(String(entry.photoDataUrl || ''))) {
|
||||
return { eligible: false, reason: 'This log has no saved photo to contribute.' };
|
||||
}
|
||||
if (!Number.isInteger(entry.bristolType) || entry.bristolType < 1 || entry.bristolType > 7) {
|
||||
return { eligible: false, reason: 'This log has no confirmed Bristol form to contribute.' };
|
||||
}
|
||||
if (!entry.color) return { eligible: false, reason: 'This log has no confirmed color to contribute.' };
|
||||
return { eligible: true, reason: '' };
|
||||
}
|
||||
|
||||
export function receiptPreview(entry, { contributionId, consentedAt } = {}) {
|
||||
if (!contributionId) throw new Error('A contribution receipt needs its own identifier.');
|
||||
if (!consentedAt) throw new Error('A contribution receipt needs the moment of consent.');
|
||||
const eligibility = contributionEligibility(entry);
|
||||
if (!eligibility.eligible) throw new Error(eligibility.reason);
|
||||
return {
|
||||
contributionId,
|
||||
entryId: entry.id,
|
||||
consentVersion: TRAINING_CONSENT_VERSION,
|
||||
consentedAt,
|
||||
labels: { bristolType: entry.bristolType, color: entry.color },
|
||||
state: 'queued-local',
|
||||
};
|
||||
}
|
||||
|
||||
export function contributionForEntry(contributions, entryId) {
|
||||
if (!Array.isArray(contributions)) return null;
|
||||
return contributions.find(item => item.entryId === entryId && item.state !== 'withdrawn') || null;
|
||||
}
|
||||
|
||||
export function addContribution(contributions, receipt) {
|
||||
const list = Array.isArray(contributions) ? contributions : [];
|
||||
if (!receipt || receipt.consentVersion !== TRAINING_CONSENT_VERSION) {
|
||||
throw new Error('A contribution needs the current consent version.');
|
||||
}
|
||||
if (contributionForEntry(list, receipt.entryId)) return list;
|
||||
return [...list, receipt];
|
||||
}
|
||||
|
||||
export function derivedArtifacts(receipt) {
|
||||
const state = receipt?.state === 'withdrawn' ? 'withdrawn' : 'active';
|
||||
return CONTRIBUTED_ARTIFACTS.map(artifact => ({
|
||||
artifact,
|
||||
contributionId: receipt?.contributionId || '',
|
||||
state,
|
||||
}));
|
||||
}
|
||||
|
||||
export function withdrawContribution(contributions, contributionId, withdrawnAt) {
|
||||
const list = Array.isArray(contributions) ? contributions : [];
|
||||
const receipt = list.find(item => item.contributionId === contributionId);
|
||||
if (!receipt) return { contributions: list, tombstone: null };
|
||||
const withdrawn = {
|
||||
...receipt,
|
||||
state: 'withdrawn',
|
||||
withdrawnAt,
|
||||
artifacts: derivedArtifacts({ ...receipt, state: 'withdrawn' }),
|
||||
};
|
||||
return {
|
||||
contributions: list.map(item => (item.contributionId === contributionId ? withdrawn : item)),
|
||||
tombstone: {
|
||||
contributionId: receipt.contributionId,
|
||||
entryId: receipt.entryId,
|
||||
consentVersion: receipt.consentVersion,
|
||||
consentedAt: receipt.consentedAt,
|
||||
withdrawnAt,
|
||||
artifacts: withdrawn.artifacts,
|
||||
},
|
||||
};
|
||||
}
|
||||
+16
@@ -59,3 +59,19 @@ main{display:block}.eyebrow{font-size:11px;font-weight:800;letter-spacing:.1em;t
|
||||
.chat-citation{min-height:32px;padding:5px 10px;border:1px solid #bcdfd4;border-radius:999px;background:var(--surface);color:var(--teal);font-weight:800;font-size:11px;cursor:pointer}
|
||||
.chat-citation:active{background:#e9f5f0}
|
||||
.chat-unverified{margin:9px 0 0;padding-top:8px;border-top:1px solid rgba(55,40,31,.09);font-size:11px;line-height:1.4;font-weight:700;color:#8a5a12}
|
||||
|
||||
/* Issue #24 — an opt-in receipt and its tombstone must read as separate facts, not one run-on line. */
|
||||
.contribution-list{display:flex;flex-direction:column;margin-top:10px}
|
||||
.training-consent h3{font-size:13px;margin:16px 0 2px}
|
||||
.contribution-row{display:flex;align-items:center;justify-content:space-between;gap:12px;padding:11px 0;border-top:1px solid var(--line)}
|
||||
.contribution-row:first-child{border-top:0}
|
||||
.contribution-row>div{display:flex;flex-direction:column;gap:3px;min-width:0}
|
||||
.contribution-row strong{font-size:13px;line-height:1.3}
|
||||
.contribution-row span{font-size:11px;line-height:1.4;color:var(--muted);overflow-wrap:anywhere}
|
||||
.contribution-row .btn{min-height:40px;padding:0 14px;font-size:12px;flex:0 0 auto}
|
||||
.contribution-row.withdrawn strong{color:var(--muted)}
|
||||
|
||||
/* Issue #35 — a backup says which version it came from, and a refused file says so in place. */
|
||||
.portability-notice{margin:0 0 12px;padding:12px 14px;border-radius:15px;font-size:12.5px;line-height:1.45;font-weight:700;background:var(--teal-soft);color:#155c4f;border:1px solid #bcdfd4}
|
||||
.portability-notice.error{background:var(--red-soft);border-color:#eec1ba;color:#75261f}
|
||||
.entry-provenance{margin:10px 0 0;padding-top:9px;border-top:1px solid rgba(55,40,31,.09)}
|
||||
@@ -0,0 +1,273 @@
|
||||
#!/usr/bin/env python3
|
||||
"""Tests for the auditable corpus manifest: provenance, tombstones, and lifecycle rules.
|
||||
|
||||
Issue #25 promotes the ingest script into a corpus pipeline with an append-only manifest,
|
||||
revocation tombstones, and lifecycle transitions that cannot be walked backwards. Every
|
||||
fixture here is synthetic; no real photo bytes are read or written.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import hashlib
|
||||
import importlib.util
|
||||
import json
|
||||
import os
|
||||
import re
|
||||
import subprocess
|
||||
import sys
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
import unittest
|
||||
|
||||
from PIL import Image
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
INGEST = ROOT / "scripts" / "ingest_training_photo.py"
|
||||
FIXTURE = ROOT / "tests" / "fixtures" / "synthetic-type4.jpg"
|
||||
CONTRIBUTION_ID = "6f1d0c9e-2c4a-4f3b-9d1e-8a7b6c5d4e3f"
|
||||
ISO_UTC = re.compile(r"^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(?:\.\d+)?\+00:00$")
|
||||
|
||||
|
||||
def load_structures():
|
||||
spec = importlib.util.spec_from_file_location("corpus_manifest", ROOT / "scripts" / "corpus_manifest.py")
|
||||
assert spec and spec.loader
|
||||
module = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(module)
|
||||
return module
|
||||
|
||||
|
||||
structures = load_structures()
|
||||
|
||||
|
||||
def active_image_paths(out: Path) -> list[str]:
|
||||
return [record["relativePath"] for record in structures.active_records(structures.load_manifest(out / "manifest.jsonl"))]
|
||||
|
||||
|
||||
|
||||
def ingest(args: list[str], env: dict[str, str] | None = None) -> subprocess.CompletedProcess:
|
||||
return subprocess.run(
|
||||
[sys.executable, str(INGEST), *args],
|
||||
cwd=ROOT,
|
||||
capture_output=True,
|
||||
text=True,
|
||||
env={**os.environ, "TIMMY_DATASET_SALT": "test-only-salt", **(env or {})},
|
||||
)
|
||||
|
||||
|
||||
def ingest_default(out: Path, **overrides: str) -> subprocess.CompletedProcess:
|
||||
args = [
|
||||
"--input", str(FIXTURE),
|
||||
"--output-dir", str(out),
|
||||
"--subject-id", "subject-123",
|
||||
"--consent-version", "research-v1",
|
||||
"--contribution-id", CONTRIBUTION_ID,
|
||||
"--bristol-type", "4",
|
||||
"--color", "brown",
|
||||
"--quality", "good",
|
||||
"--reviewer", "user-confirmed",
|
||||
]
|
||||
for key, value in overrides.items():
|
||||
flag = "--" + key.replace("_", "-")
|
||||
if value is None:
|
||||
index = args.index(flag)
|
||||
del args[index:index + 2]
|
||||
continue
|
||||
args[args.index(flag) + 1] = value
|
||||
return ingest(args)
|
||||
|
||||
|
||||
def manifest_lines(out: Path) -> list[dict]:
|
||||
text = (out / "manifest.jsonl").read_text(encoding="utf-8")
|
||||
return [json.loads(line) for line in text.splitlines() if line.strip()]
|
||||
|
||||
|
||||
class IngestProvenanceTests(unittest.TestCase):
|
||||
def test_ingest_records_consent_source_hashes_derivation_review_split_and_lifecycle(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
run = ingest_default(out)
|
||||
self.assertEqual(run.returncode, 0, run.stderr)
|
||||
record = json.loads(run.stdout)
|
||||
raw_bytes = FIXTURE.read_bytes()
|
||||
|
||||
self.assertEqual(record["schemaVersion"], 2)
|
||||
self.assertEqual(record["contributionId"], CONTRIBUTION_ID)
|
||||
self.assertEqual(record["consentVersion"], "research-v1")
|
||||
self.assertEqual(record["consent"], {"version": "research-v1", "recordedAt": record["ingestedAt"]})
|
||||
self.assertRegex(record["consent"]["recordedAt"], ISO_UTC)
|
||||
|
||||
# Source is named, and the raw input only ever appears as a digest.
|
||||
self.assertEqual(record["source"], {
|
||||
"kind": "cli-ingest",
|
||||
"inputSha256": hashlib.sha256(raw_bytes).hexdigest(),
|
||||
})
|
||||
self.assertEqual(record["hashes"]["rawInput"], hashlib.sha256(raw_bytes).hexdigest())
|
||||
self.assertEqual(record["hashes"]["derived"], record["imageId"])
|
||||
|
||||
self.assertEqual(record["derivation"], {
|
||||
"format": "jpeg",
|
||||
"maxDimension": 1200,
|
||||
"metadataStripped": True,
|
||||
"pipeline": "timmy-ingest/2",
|
||||
})
|
||||
self.assertEqual(record["review"], {"status": "user-confirmed", "reviewedAt": record["ingestedAt"]})
|
||||
self.assertIn(record["split"], ("train", "validation", "test"))
|
||||
self.assertEqual(record["lifecycle"], {"state": "active", "updatedAt": record["ingestedAt"]})
|
||||
self.assertEqual(record["recordType"], "sample")
|
||||
|
||||
# Provenance never leaks the caller's path or the source bytes.
|
||||
self.assertNotIn("inputPath", record)
|
||||
on_disk = (out / "manifest.jsonl").read_text(encoding="utf-8")
|
||||
self.assertNotIn(str(FIXTURE), on_disk)
|
||||
self.assertNotIn(str(out), on_disk)
|
||||
self.assertEqual(manifest_lines(out), [record])
|
||||
self.assertTrue((out / record["relativePath"]).is_file())
|
||||
|
||||
|
||||
class RevocationTests(unittest.TestCase):
|
||||
def test_revocation_appends_a_tombstone_and_removes_the_bytes_from_active_datasets(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
sample = manifest_lines(out)[0]
|
||||
derived = out / sample["relativePath"]
|
||||
self.assertTrue(derived.is_file())
|
||||
# Some pipelines keep the pre-derivation copy; revocation must clear that too.
|
||||
raw_dir = out / "raw"
|
||||
raw_dir.mkdir()
|
||||
raw_copy = raw_dir / f"{sample['hashes']['rawInput']}.jpg"
|
||||
raw_copy.write_bytes(FIXTURE.read_bytes())
|
||||
|
||||
run = ingest(["--revoke", CONTRIBUTION_ID, "--output-dir", str(out), "--reason", "subject withdrawal"])
|
||||
self.assertEqual(run.returncode, 0, run.stderr)
|
||||
tombstone = json.loads(run.stdout)
|
||||
|
||||
self.assertEqual(tombstone["schemaVersion"], 2)
|
||||
self.assertEqual(tombstone["recordType"], "tombstone")
|
||||
self.assertEqual(tombstone["contributionId"], CONTRIBUTION_ID)
|
||||
self.assertEqual(tombstone["imageId"], sample["imageId"])
|
||||
self.assertEqual(tombstone["lifecycle"]["state"], "revoked")
|
||||
self.assertRegex(tombstone["lifecycle"]["updatedAt"], ISO_UTC)
|
||||
self.assertEqual(tombstone["lifecycle"]["reason"], "subject withdrawal")
|
||||
|
||||
# The tombstone addresses every derived artifact by contribution id, and says what went.
|
||||
self.assertEqual(tombstone["deletedArtifacts"], [
|
||||
{"relativePath": sample["relativePath"], "sha256": sample["hashes"]["derived"], "deleted": True},
|
||||
{"relativePath": f"raw/{sample['hashes']['rawInput']}.jpg", "sha256": sample["hashes"]["rawInput"], "deleted": True},
|
||||
])
|
||||
self.assertEqual(tombstone["contributionId"], CONTRIBUTION_ID)
|
||||
|
||||
# No byte-bearing copy survives anywhere in the dataset tree.
|
||||
self.assertFalse(derived.exists())
|
||||
self.assertFalse(raw_copy.exists())
|
||||
survivors = []
|
||||
for path in out.rglob("*"):
|
||||
if path.is_file() and path.name != "manifest.jsonl":
|
||||
survivors.append((str(path.relative_to(out)), hashlib.sha256(path.read_bytes()).hexdigest()))
|
||||
self.assertEqual(survivors, [])
|
||||
|
||||
# History is append-only: the sample record is untouched, the tombstone follows it.
|
||||
history = manifest_lines(out)
|
||||
self.assertEqual(len(history), 2)
|
||||
self.assertEqual(history[0], sample)
|
||||
self.assertEqual(history[1], tombstone)
|
||||
|
||||
# A deletion receipt keeps identifiers and hashes, never the label or subject key.
|
||||
self.assertNotIn("labels", tombstone)
|
||||
self.assertNotIn("subjectKey", tombstone)
|
||||
self.assertNotIn("relativePath", tombstone)
|
||||
|
||||
|
||||
class ActiveRecordTests(unittest.TestCase):
|
||||
def test_only_unrevoked_samples_are_active(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
self.assertEqual(active_image_paths(out), [f"images/{manifest_lines(out)[0]['imageId']}.jpg"])
|
||||
self.assertEqual(ingest(["--revoke", CONTRIBUTION_ID, "--output-dir", str(out), "--reason", "gone"]).returncode, 0)
|
||||
self.assertEqual(active_image_paths(out), [])
|
||||
|
||||
|
||||
class IllegalTransitionTests(unittest.TestCase):
|
||||
def test_a_second_revocation_is_refused_and_appends_nothing(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
self.assertEqual(ingest(["--revoke", CONTRIBUTION_ID, "--output-dir", str(out), "--reason", "first"]).returncode, 0)
|
||||
history = manifest_lines(out)
|
||||
self.assertEqual(len(history), 2)
|
||||
|
||||
again = ingest(["--revoke", CONTRIBUTION_ID, "--output-dir", str(out), "--reason", "again"])
|
||||
self.assertNotEqual(again.returncode, 0)
|
||||
self.assertRegex(again.stderr, "already revoked")
|
||||
self.assertEqual(manifest_lines(out), history)
|
||||
|
||||
def test_revoking_an_unknown_contribution_is_refused(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
history = manifest_lines(out)
|
||||
|
||||
unknown = ingest(["--revoke", "11111111-2222-3333-4444-555555555555", "--output-dir", str(out), "--reason", "nope"])
|
||||
self.assertNotEqual(unknown.returncode, 0)
|
||||
self.assertRegex(unknown.stderr, "no ingested sample carries contribution")
|
||||
self.assertEqual(manifest_lines(out), history)
|
||||
self.assertTrue((out / history[0]["relativePath"]).is_file())
|
||||
|
||||
def test_a_contribution_cannot_be_ingested_twice(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
history = manifest_lines(out)
|
||||
|
||||
duplicate = ingest_default(out, color="green")
|
||||
self.assertNotEqual(duplicate.returncode, 0)
|
||||
self.assertRegex(duplicate.stderr, "already ingested")
|
||||
self.assertEqual(manifest_lines(out), history)
|
||||
|
||||
def test_a_refused_duplicate_leaves_no_orphan_image_behind(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
history = manifest_lines(out)
|
||||
|
||||
# Same contribution id, different pixels: the derived digest differs, so a guard that
|
||||
# runs after the write would strand a second image in the active dataset.
|
||||
variant = out.parent / "variant-type4.jpg"
|
||||
with Image.open(FIXTURE) as source:
|
||||
changed = source.convert("RGB")
|
||||
changed.putpixel((4, 4), (255, 0, 0))
|
||||
changed.save(variant, "JPEG", quality=95)
|
||||
duplicate = ingest_default(out, input=str(variant))
|
||||
self.assertNotEqual(duplicate.returncode, 0)
|
||||
self.assertRegex(duplicate.stderr, "already ingested")
|
||||
|
||||
self.assertEqual(manifest_lines(out), history)
|
||||
images = sorted(path.name for path in (out / "images").iterdir())
|
||||
self.assertEqual(images, [f"{history[0]['imageId']}.jpg"])
|
||||
|
||||
|
||||
def test_lifecycle_transitions_cannot_walk_backwards(self):
|
||||
with tempfile.TemporaryDirectory() as raw:
|
||||
out = Path(raw)
|
||||
self.assertEqual(ingest_default(out).returncode, 0)
|
||||
sample = manifest_lines(out)[0]
|
||||
at = sample["ingestedAt"]
|
||||
|
||||
revoked = structures.transition(sample, "revoked", at, "withdrawal")
|
||||
self.assertEqual(revoked["lifecycle"]["state"], "revoked")
|
||||
self.assertEqual(revoked["lifecycle"]["reason"], "withdrawal")
|
||||
self.assertEqual(sample["lifecycle"]["state"], "active", "transition must not mutate its input")
|
||||
|
||||
for args, expected in (
|
||||
((revoked, "active", at), "cannot return to the active dataset"),
|
||||
((sample, "revoked", at, " "), "recorded reason"),
|
||||
((sample, "archived", at), "unknown lifecycle state"),
|
||||
(({**sample, "lifecycle": {"state": "active", "updatedAt": at}}, "active", at), "already active"),
|
||||
):
|
||||
with self.assertRaises(structures.IllegalTransition) as raised:
|
||||
structures.transition(*args)
|
||||
self.assertRegex(str(raised.exception), expected)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
unittest.main(verbosity=2)
|
||||
@@ -8,6 +8,7 @@ import {
|
||||
detectUrgentText,
|
||||
exportLedger,
|
||||
hasUrgentLedgerContext,
|
||||
LEDGER_EXPORT_VERSION,
|
||||
photoQualityMessage,
|
||||
sanitizeEntry,
|
||||
} from '../src/domain.js';
|
||||
@@ -113,9 +114,10 @@ test('sanitizes a user entry to the MVP data contract', () => {
|
||||
});
|
||||
assert.deepEqual(Object.keys(entry).sort(), [
|
||||
'bristolType', 'color', 'discomfort', 'id', 'note', 'occurredAt',
|
||||
'photoDataUrl', 'symptoms', 'urgency'
|
||||
'photoDataUrl', 'provenance', 'symptoms', 'urgency'
|
||||
].sort());
|
||||
assert.equal(entry.unexpected, undefined);
|
||||
assert.equal(entry.provenance, null, 'a manual entry records no AI provenance rather than an invented one');
|
||||
});
|
||||
|
||||
test('photo quality guidance is deterministic and does not claim visual diagnosis', () => {
|
||||
@@ -125,10 +127,11 @@ test('photo quality guidance is deterministic and does not claim visual diagnosi
|
||||
assert.doesNotMatch(photoQualityMessage({ width: 1200, height: 900, brightness: 0.5 }), /type [1-7]|disease|diagnos/i);
|
||||
});
|
||||
|
||||
test('export ledger is portable JSON with version and entries', () => {
|
||||
test('export ledger is portable JSON with the current version and entries', () => {
|
||||
const text = exportLedger([{ id: 'a', bristolType: 4 }], '2026-08-18T00:00:00.000Z');
|
||||
const parsed = JSON.parse(text);
|
||||
assert.equal(parsed.schemaVersion, 1);
|
||||
assert.equal(parsed.schemaVersion, LEDGER_EXPORT_VERSION);
|
||||
assert.equal(parsed.schemaVersion, 2);
|
||||
assert.equal(parsed.exportedAt, '2026-08-18T00:00:00.000Z');
|
||||
assert.equal(parsed.entries.length, 1);
|
||||
});
|
||||
@@ -0,0 +1,131 @@
|
||||
import { chromium } from 'playwright';
|
||||
import assert from 'node:assert/strict';
|
||||
import { readFile } from 'node:fs/promises';
|
||||
|
||||
// Issue #35 — a backup is the person's own record, and it has to keep working as the app's AI
|
||||
// provenance fields evolve. This drives the real app in a browser: a version 1 file is upgraded and
|
||||
// says so, a file from a newer Timmy is refused without touching the ledger, the export carries the
|
||||
// contribution receipts, and a log saved from a confirmed AI suggestion comes back saying that.
|
||||
//
|
||||
// The image used below is the committed synthetic Type 4 fixture; no real photo is involved.
|
||||
const browser = await chromium.launch({ headless: true });
|
||||
const context = await browser.newContext({ viewport: { width: 390, height: 844 }, deviceScaleFactor: 2, serviceWorkers: 'block' });
|
||||
const page = await context.newPage();
|
||||
const errors = [];
|
||||
page.on('console', message => { if (message.type() === 'error') errors.push(message.text()); });
|
||||
page.on('pageerror', error => errors.push(error.message));
|
||||
page.on('dialog', dialog => dialog.accept());
|
||||
|
||||
const suggestionBody = {
|
||||
status: 'suggestion', isStool: true, bristolType: 4, color: 'brown', confidence: 0.83,
|
||||
imageQuality: 'good', observations: 'Smooth, formed appearance.',
|
||||
warning: 'Visual suggestion only. Confirm it yourself; this is not a diagnosis.',
|
||||
};
|
||||
await page.route('**/api/vision-status', route => route.fulfill({
|
||||
status: 200, contentType: 'application/json',
|
||||
body: JSON.stringify({ enabled: true, profile: 'selfhost', processor: 'self-hosted', model: 'SmolVLM2-2.2B-Instruct', providerReady: true, modelSeen: true }),
|
||||
}));
|
||||
await page.route('**/api/analyze', route => route.fulfill({ status: 200, contentType: 'application/json', body: JSON.stringify(suggestionBody) }));
|
||||
await page.route('**/api/agent/status', route => route.fulfill({
|
||||
status: 200, contentType: 'application/json',
|
||||
body: JSON.stringify({ enabled: true, configured: false, authenticated: false, mode: 'local-fallback' }),
|
||||
}));
|
||||
|
||||
await page.goto('http://127.0.0.1:4173', { waitUntil: 'networkidle' });
|
||||
await page.evaluate(() => localStorage.clear());
|
||||
await page.reload({ waitUntil: 'networkidle' });
|
||||
|
||||
const basePath = () => page.evaluate(() => document.querySelector('meta[name="timmy-base-path"]')?.content || '/');
|
||||
const storeKey = async suffix => `timmy:${await basePath()}:${suffix}`;
|
||||
const readStore = async suffix => {
|
||||
const raw = await page.evaluate(key => localStorage.getItem(key), await storeKey(suffix));
|
||||
return raw === null ? null : JSON.parse(raw);
|
||||
};
|
||||
// The privacy view sits behind the journal's settings row, exactly as a person reaches it.
|
||||
const openPrivacy = async () => {
|
||||
await page.locator('[data-view="calendar"]').first().click();
|
||||
await page.locator('.settings-row[data-view="privacy"]').first().click();
|
||||
await page.locator('#export').waitFor();
|
||||
};
|
||||
const importBackup = async (name, text) => {
|
||||
await page.locator('#import').setInputFiles({ name, mimeType: 'application/json', buffer: Buffer.from(text) });
|
||||
await page.waitForTimeout(350);
|
||||
};
|
||||
|
||||
const legacyBackup = JSON.stringify({
|
||||
product: 'Timmy the Talking Turd',
|
||||
schemaVersion: 1,
|
||||
exportedAt: '2026-08-01T09:00:00.000Z',
|
||||
entries: [
|
||||
{ id: 'legacy-1', occurredAt: '2026-08-01T08:00:00.000Z', bristolType: 3, color: 'brown', urgency: 1, discomfort: 0, note: 'synthetic', photoDataUrl: '', symptoms: {} },
|
||||
{ id: 'legacy-2', occurredAt: '2026-08-02T08:00:00.000Z', bristolType: 6, color: 'brown', urgency: 2, discomfort: 1, note: '', photoDataUrl: '', symptoms: {} },
|
||||
],
|
||||
});
|
||||
|
||||
// 1. A version 1 backup is imported, upgraded, and says which version it came from.
|
||||
await openPrivacy();
|
||||
await importBackup('timmy-backup-v1.json', legacyBackup);
|
||||
const upgraded = await readStore('ledger-v1');
|
||||
assert.equal(upgraded.length, 2, 'the version 1 backup must restore both logs');
|
||||
await page.locator('[data-portability-notice]').waitFor();
|
||||
const noticeText = (await page.locator('[data-portability-notice]').innerText()).trim();
|
||||
assert.match(noticeText, /version 1/i, 'the notice must name the version the file came from');
|
||||
assert.match(noticeText, /upgraded/i, 'the notice must say the backup was upgraded');
|
||||
assert.equal(await page.locator('[data-portability-notice]').getAttribute('data-portability-version'), '1');
|
||||
assert.equal(upgraded[0].provenance, null, 'a pre-provenance backup must not acquire a source it never recorded');
|
||||
assert.equal(upgraded[0].bristolType, 3, 'the confirmed form must survive the upgrade');
|
||||
|
||||
// 2. A file from a newer Timmy is refused, and the ledger it would have replaced stays exactly as it was.
|
||||
const before = JSON.stringify(await readStore('ledger-v1'));
|
||||
await importBackup('timmy-backup-v3.json', JSON.stringify({ product: 'Timmy the Talking Turd', schemaVersion: 3, entries: [{ id: 'future', bristolType: 7 }] }));
|
||||
await page.locator('[data-portability-error]').waitFor();
|
||||
const errorText = (await page.locator('[data-portability-error]').innerText()).trim();
|
||||
assert.match(errorText, /newer version of Timmy/i);
|
||||
assert.equal(JSON.stringify(await readStore('ledger-v1')), before, 'a refused import must not change the ledger');
|
||||
|
||||
// 3. A log saved from a confirmed AI suggestion records that provenance, and the export states it.
|
||||
await page.locator('[data-view="home"]').first().click();
|
||||
await page.locator('[data-scan]').first().click();
|
||||
await page.getByText(/Self-hosted model ready/i).waitFor();
|
||||
await page.locator('#gallery-photo').setInputFiles('tests/fixtures/synthetic-type4.jpg');
|
||||
await page.locator('#ai-consent').check();
|
||||
await page.locator('#analyze-photo').click();
|
||||
await page.locator('#use-suggestion').waitFor();
|
||||
await page.locator('#use-suggestion').click();
|
||||
await page.locator('[data-provenance="confirmed"]').waitFor();
|
||||
await page.locator('#next').click();
|
||||
await page.locator('#next').click();
|
||||
await page.locator('#save').click();
|
||||
await page.getByText(/Private log saved|Saved/).waitFor();
|
||||
const savedLedger = await readStore('ledger-v1');
|
||||
const assisted = savedLedger.find(entry => entry.id !== 'legacy-1' && entry.id !== 'legacy-2');
|
||||
assert.ok(assisted, 'the saved log must be in the ledger');
|
||||
assert.equal(assisted.provenance?.source, 'ai-confirmed', 'a confirmed AI suggestion must be recorded on the saved log');
|
||||
assert.equal(assisted.provenance?.suggestedBristolType, 4);
|
||||
assert.equal(assisted.provenance?.model, 'SmolVLM2-2.2B-Instruct');
|
||||
|
||||
// 4. Export carries the current version, the entries, and the contribution receipts — and nothing else.
|
||||
await openPrivacy();
|
||||
const [download] = await Promise.all([page.waitForEvent('download'), page.locator('#export').click()]);
|
||||
const exported = JSON.parse(await readFile(await download.path(), 'utf8'));
|
||||
assert.equal(exported.schemaVersion, 2);
|
||||
assert.equal(exported.entries.length, 3);
|
||||
assert.deepEqual(exported.contributions, [], 'nothing was contributed, so no receipt may appear');
|
||||
assert.equal(exported.entries.find(entry => entry.id === assisted.id).provenance.source, 'ai-confirmed');
|
||||
|
||||
// 5. Round trip: the export restores into a cleared browser with provenance intact.
|
||||
const exportedText = JSON.stringify(exported);
|
||||
await page.evaluate(() => localStorage.clear());
|
||||
await page.reload({ waitUntil: 'networkidle' });
|
||||
await openPrivacy();
|
||||
await importBackup('timmy-backup-v2.json', exportedText);
|
||||
const roundTripped = await readStore('ledger-v1');
|
||||
assert.equal(roundTripped.length, 3);
|
||||
const restoredAssisted = roundTripped.find(entry => entry.id === assisted.id);
|
||||
assert.deepEqual(restoredAssisted.provenance, assisted.provenance, 'provenance must survive a round trip');
|
||||
await page.locator('[data-portability-notice]').waitFor();
|
||||
assert.match((await page.locator('[data-portability-notice]').innerText()).trim(), /version 2/i);
|
||||
|
||||
assert.deepEqual(errors, [], `browser errors: ${errors.join(' | ')}`);
|
||||
await browser.close();
|
||||
console.log(JSON.stringify({ ok: true, scenes: ['v1-upgrade', 'future-refused', 'provenance-recorded', 'export-v2', 'round-trip'] }));
|
||||
@@ -0,0 +1,152 @@
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
|
||||
import { LEDGER_EXPORT_VERSION, LEDGER_IMPORT_LIMITS, exportLedger, exportLedgerBackup, importLedger, importLedgerBackup } from '../src/domain.js';
|
||||
|
||||
// Issue #35 — a backup is the person's own record. Provenance is part of what they own: a log that
|
||||
// was saved from a confirmed or corrected AI suggestion has to come back out of the export saying
|
||||
// exactly that, instead of silently reverting to looking like a manual entry.
|
||||
const confirmedByUser = {
|
||||
id: 'demo-corrected',
|
||||
occurredAt: '2026-08-18T10:00:00.000Z',
|
||||
bristolType: 2,
|
||||
color: 'brown',
|
||||
urgency: 1,
|
||||
discomfort: 0,
|
||||
note: 'synthetic',
|
||||
photoDataUrl: '',
|
||||
symptoms: {},
|
||||
provenance: {
|
||||
source: 'ai-corrected',
|
||||
model: 'SmolVLM2-2.2B-Instruct',
|
||||
suggestedBristolType: 4,
|
||||
suggestedColor: 'brown',
|
||||
confirmedAt: '2026-08-18T09:59:00.000Z',
|
||||
},
|
||||
};
|
||||
|
||||
test('an export stamps the current schema version and keeps confirmed AI provenance', () => {
|
||||
const parsed = JSON.parse(exportLedger([confirmedByUser], '2026-08-18T11:00:00.000Z'));
|
||||
|
||||
assert.equal(LEDGER_EXPORT_VERSION, 2);
|
||||
assert.equal(parsed.schemaVersion, 2);
|
||||
assert.equal(parsed.entries.length, 1);
|
||||
assert.deepEqual(parsed.entries[0].provenance, confirmedByUser.provenance);
|
||||
assert.equal(parsed.entries[0].bristolType, 2, 'the corrected value stays the saved value');
|
||||
});
|
||||
|
||||
// A version 1 file was written before entries recorded provenance. Importing it must restore the
|
||||
// confirmed values and say plainly that this backup predates provenance, rather than inventing a
|
||||
// source for logs that never had one.
|
||||
const legacyBackup = JSON.stringify({
|
||||
product: 'Timmy the Talking Turd',
|
||||
schemaVersion: 1,
|
||||
exportedAt: '2026-08-01T09:00:00.000Z',
|
||||
entries: [
|
||||
{
|
||||
id: 'legacy-entry',
|
||||
occurredAt: '2026-08-01T08:00:00.000Z',
|
||||
bristolType: 4,
|
||||
color: 'brown',
|
||||
urgency: 2,
|
||||
discomfort: 1,
|
||||
note: '',
|
||||
photoDataUrl: '',
|
||||
symptoms: { blood: false },
|
||||
},
|
||||
],
|
||||
});
|
||||
|
||||
test('a version 1 backup imports its confirmed values and reports the upgrade', () => {
|
||||
const result = importLedgerBackup(legacyBackup);
|
||||
|
||||
assert.equal(result.fromVersion, 1);
|
||||
assert.equal(result.migrated, true);
|
||||
assert.equal(result.entries.length, 1);
|
||||
assert.equal(result.entries[0].id, 'legacy-entry');
|
||||
assert.equal(result.entries[0].bristolType, 4);
|
||||
assert.equal(result.entries[0].provenance, null, 'a pre-provenance backup must not be given a source it never recorded');
|
||||
assert.match(result.notices.join(' '), /version 1/i);
|
||||
assert.match(result.notices.join(' '), /upgraded/i);
|
||||
// The import screen already reports what was restored; a notice that restates the count renders as
|
||||
// a duplicated sentence on screen, so the upgrade notice must only describe the upgrade.
|
||||
assert.doesNotMatch(result.notices.join(' '), /Restored \d+ logs?/);
|
||||
assert.equal(importLedger(legacyBackup).length, 1, 'the plain entry import still works');
|
||||
});
|
||||
|
||||
// A training contribution receipt is user-owned data too. A backup that restored the journal but
|
||||
// dropped the receipts would tell someone their opt-in never happened, so version 2 carries them —
|
||||
// with the withdrawal tombstone intact and nothing else copied out of the device.
|
||||
const withdrawnReceipt = {
|
||||
contributionId: 'contrib-1',
|
||||
entryId: 'demo-corrected',
|
||||
consentVersion: 'training-consent-v1',
|
||||
consentedAt: '2026-08-18T10:05:00.000Z',
|
||||
labels: { bristolType: 2, color: 'brown' },
|
||||
state: 'withdrawn',
|
||||
withdrawnAt: '2026-08-18T10:30:00.000Z',
|
||||
artifacts: [
|
||||
{ artifact: 'raw-image', contributionId: 'contrib-1', state: 'withdrawn' },
|
||||
{ artifact: 'confirmed-label', contributionId: 'contrib-1', state: 'withdrawn' },
|
||||
],
|
||||
// A crafted file must not be able to hand a credential back to the app.
|
||||
agentAccessCode: 'leak-me-please',
|
||||
};
|
||||
|
||||
test('a backup carries contribution receipts and their tombstones without copying secrets', () => {
|
||||
const text = exportLedgerBackup({
|
||||
entries: [{ ...confirmedByUser, agentAccessCode: 'leak-me-please' }],
|
||||
contributions: [withdrawnReceipt],
|
||||
exportedAt: '2026-08-18T12:00:00.000Z',
|
||||
});
|
||||
const parsed = JSON.parse(text);
|
||||
|
||||
assert.equal(parsed.schemaVersion, 2);
|
||||
assert.equal(parsed.contributions.length, 1);
|
||||
assert.equal(parsed.contributions[0].state, 'withdrawn');
|
||||
assert.deepEqual(parsed.contributions[0].artifacts, withdrawnReceipt.artifacts);
|
||||
assert.equal(parsed.entries[0].agentAccessCode, undefined);
|
||||
assert.doesNotMatch(text, /leak-me-please/);
|
||||
|
||||
const restored = importLedgerBackup(text);
|
||||
assert.equal(restored.migrated, false);
|
||||
assert.equal(restored.fromVersion, 2);
|
||||
assert.equal(restored.contributions.length, 1);
|
||||
assert.equal(restored.contributions[0].contributionId, 'contrib-1');
|
||||
assert.equal(restored.contributions[0].state, 'withdrawn');
|
||||
assert.deepEqual(restored.contributions[0].artifacts, withdrawnReceipt.artifacts);
|
||||
assert.equal(restored.contributions[0].agentAccessCode, undefined);
|
||||
assert.deepEqual(restored.entries[0].provenance, confirmedByUser.provenance);
|
||||
});
|
||||
|
||||
test('a backup from a newer Timmy is refused with an instruction instead of a guess', () => {
|
||||
const future = JSON.stringify({ product: 'Timmy the Talking Turd', schemaVersion: 3, entries: [], contributions: [] });
|
||||
|
||||
assert.throws(() => importLedgerBackup(future), /newer version of Timmy/i);
|
||||
});
|
||||
|
||||
test('a file that is not a readable Timmy backup is refused', () => {
|
||||
assert.throws(() => importLedgerBackup('{not json'), /not readable JSON/i);
|
||||
assert.throws(() => importLedgerBackup(JSON.stringify({ hello: 'world' })), /not a supported Timmy backup/i);
|
||||
assert.throws(() => importLedgerBackup(JSON.stringify({ schemaVersion: 0, entries: [] })), /not a supported Timmy backup/i);
|
||||
});
|
||||
|
||||
test('an oversized backup or one with too many logs is refused before anything is imported', () => {
|
||||
const huge = `{"schemaVersion":2,"entries":[]}${' '.repeat(LEDGER_IMPORT_LIMITS.maxTextLength)}`;
|
||||
assert.throws(() => importLedgerBackup(huge), /too large/i);
|
||||
|
||||
const many = { schemaVersion: 2, entries: Array.from({ length: LEDGER_IMPORT_LIMITS.maxEntries + 1 }, () => ({ id: 'x', bristolType: 4 })) };
|
||||
assert.throws(() => importLedgerBackup(JSON.stringify(many)), /more logs than Timmy will import/i);
|
||||
});
|
||||
|
||||
test('an unreadable contribution receipt is skipped and reported, never silently dropped', () => {
|
||||
const text = JSON.stringify({
|
||||
schemaVersion: 2,
|
||||
entries: [{ id: 'kept', bristolType: 4 }],
|
||||
contributions: [{ entryId: 'kept', state: 'queued-local' }],
|
||||
});
|
||||
const result = importLedgerBackup(text);
|
||||
|
||||
assert.equal(result.contributions.length, 0);
|
||||
assert.match(result.notices.join(' '), /could not be read and was skipped/i);
|
||||
});
|
||||
@@ -21,6 +21,15 @@ test('product decision record fixes the AI boundary and release authority', asyn
|
||||
assert.match(decision, /\.\.\/research\/SELF-HOSTED-STOOL-VISION\.md/);
|
||||
});
|
||||
|
||||
test('the decision record keeps training contribution as its own versioned, withdrawable consent', async () => {
|
||||
const decision = await readFile(decisionPath, 'utf8');
|
||||
|
||||
assert.match(decision, /### Training contribution consent/);
|
||||
assert.match(decision, /never a training contribution/i);
|
||||
assert.match(decision, /withdrawal keeps a tombstone naming every derived artifact by contribution id/i);
|
||||
assert.match(decision, /does not transmit a contribution until the corpus pipeline and privacy copy are reviewed/i);
|
||||
});
|
||||
|
||||
test('Hermes deployment installs a checked-in non-diagnostic workspace policy', async () => {
|
||||
const [policy, readme] = await Promise.all([readFile(policyPath, 'utf8'), readFile(readmePath, 'utf8')]);
|
||||
assert.match(policy, /never diagnose/i);
|
||||
@@ -28,3 +37,16 @@ test('Hermes deployment installs a checked-in non-diagnostic workspace policy',
|
||||
assert.match(policy, /explicit user intent and confirmation/i);
|
||||
assert.match(readme, /install -m 600 docs\/TIMMY-AGENT-POLICY\.md/);
|
||||
});
|
||||
|
||||
test('the decision record keeps a backup versioned and refuses files it cannot read', async () => {
|
||||
const decision = await readFile(decisionPath, 'utf8');
|
||||
const readme = await readFile(readmePath, 'utf8');
|
||||
|
||||
assert.match(decision, /### Backup portability and entry provenance/);
|
||||
assert.match(decision, /schema version/i);
|
||||
assert.match(decision, /upgraded on import/i);
|
||||
assert.match(decision, /newer version is refused/i);
|
||||
assert.match(decision, /a refused import leaves the ledger unchanged/i);
|
||||
assert.match(decision, /provenance is stored on the confirmed log/i);
|
||||
assert.match(readme, /versioned JSON backup/i);
|
||||
});
|
||||
@@ -308,3 +308,84 @@ test('release demo shows readiness waiting for the loaded pinned model before AI
|
||||
// The caption is a required release gate, so the scene cannot be dropped silently.
|
||||
assert.match(builder, /Reachable is not loaded: no AI control, no consent, and no upload until the pinned model is resident/);
|
||||
});
|
||||
|
||||
test('release demo shows the training contribution as a separate opt-in receipt that can be withdrawn', async () => {
|
||||
const demo = await readFile(demoPath, 'utf8');
|
||||
const builder = await readFile(builderPath, 'utf8');
|
||||
const app = await readFile(new URL('../app.js', import.meta.url), 'utf8');
|
||||
|
||||
// Issue #24: the recording must show the opt-in section, the consent gate, and the withdrawal.
|
||||
assert.match(demo, /\[data-training-consent\]/);
|
||||
assert.match(demo, /\[data-contribute-entry="demo-wipe"\]/);
|
||||
assert.match(demo, /#training-consent-check/);
|
||||
assert.match(demo, /#contribute-confirm/);
|
||||
assert.match(demo, /\[data-contribution-state="queued-local"\]/);
|
||||
assert.match(demo, /data-withdraw=/);
|
||||
assert.match(demo, /\[data-withdrawn-artifacts\]/);
|
||||
assert.match(demo, /training-consent-v1/);
|
||||
// Every claim is measured in the browser before the caption that makes it.
|
||||
assert.match(demo, /a journal save must not queue a training contribution/);
|
||||
assert.match(demo, /the contribute control must stay disabled until the terms are accepted/);
|
||||
assert.match(demo, /no receipt may exist before explicit consent/);
|
||||
assert.match(demo, /a receipt must never copy the photo bytes/);
|
||||
assert.match(demo, /every derived artifact must be addressed by contribution id/);
|
||||
assert.match(demo, /delete-all must clear the contribution receipts as well/);
|
||||
// The controls are the app's own, not demo-only scaffolding.
|
||||
assert.match(app, /data-training-consent/);
|
||||
assert.match(app, /data-contribution-queued-count/);
|
||||
assert.match(app, /id="training-consent-check"/);
|
||||
assert.match(app, /id="contribute-confirm" disabled/);
|
||||
assert.match(app, /data-withdraw=/);
|
||||
// The captions and the gate key are required, so a later release cannot drop the scenes silently.
|
||||
assert.match(builder, /Training contribution is off by default: a saved log is never training data/);
|
||||
assert.match(builder, /The consent version and the receipt are on screen before the contribute button works/);
|
||||
assert.match(builder, /Withdrawing keeps a tombstone naming every derived artifact by contribution ID/);
|
||||
assert.match(builder, /"training_contribution_consent": "passed"/);
|
||||
assert.match(builder, /"test:training-contribution"/);
|
||||
});
|
||||
|
||||
test('release demo shows a versioned backup, an upgraded older file, and a refused newer one', async () => {
|
||||
const demo = await readFile(demoPath, 'utf8');
|
||||
const builder = await readFile(builderPath, 'utf8');
|
||||
const app = await readFile(new URL('../app.js', import.meta.url), 'utf8');
|
||||
|
||||
// Issue #35: the recording must export the real file, import an older version, refuse a newer one,
|
||||
// and reopen a restored log so its provenance is on screen — not merely described.
|
||||
assert.match(demo, /waitForEvent\('download'\)/);
|
||||
assert.match(demo, /exportedBackup\.schemaVersion !== 2/);
|
||||
assert.match(demo, /the backup must carry the withdrawn receipt as a tombstone/);
|
||||
assert.match(demo, /\[data-portability-notice\]\[data-portability-version="1"\]/);
|
||||
assert.match(demo, /\[data-portability-error\]/);
|
||||
assert.match(demo, /\[data-entry-provenance="ai-corrected"\]/);
|
||||
// Every claim is measured before the caption that makes it.
|
||||
assert.match(demo, /an older backup must be reported as upgraded/);
|
||||
assert.match(demo, /a refused import must not change the ledger it would have replaced/);
|
||||
assert.match(demo, /a restored log must still show that it began as a corrected AI suggestion/);
|
||||
// The controls belong to the app, and the provenance line is its own rendering.
|
||||
assert.match(app, /id="export"/);
|
||||
assert.match(app, /data-portability-notice/);
|
||||
assert.match(app, /data-entry-provenance=/);
|
||||
// Captions and the gate key are required, so a later release cannot drop the scenes silently.
|
||||
assert.match(builder, /A backup is versioned, and it carries the withdrawn receipt as a tombstone rather than silence/);
|
||||
assert.match(builder, /An older backup is upgraded on import, and the notice says which version the file came from/);
|
||||
assert.match(builder, /A file from a newer Timmy is refused with an instruction, and the ledger it would have replaced is untouched/);
|
||||
assert.match(builder, /A restored log still says it began as an AI suggestion you corrected — provenance is part of the record/);
|
||||
assert.match(builder, /"portable_backup_restore": "passed"/);
|
||||
assert.match(builder, /"test:portability"/);
|
||||
});
|
||||
|
||||
test('the builder refuses to gate or record a release against a foreign server', async () => {
|
||||
const builder = await readFile(builderPath, 'utf8');
|
||||
|
||||
// A leftover checkout answering on the acceptance port once satisfied every flow and the demo,
|
||||
// so the release described a tree that was not the commit under test. The builder must refuse a
|
||||
// live listener before it starts, then prove the served bytes are this tree's before any gate.
|
||||
assert.match(builder, /def assert_port_free/);
|
||||
assert.match(builder, /assert_port_free\("127\.0\.0\.1", 4173\)/);
|
||||
assert.match(builder, /def assert_served_tree/);
|
||||
assert.match(builder, /assert_served_tree\(tree, "127\.0\.0\.1", 4173\)/);
|
||||
const identityCheck = builder.indexOf('assert_served_tree(tree, "127.0.0.1", 4173)');
|
||||
const firstFlow = builder.indexOf('run(["npm", "run", "test:ui"]');
|
||||
assert.ok(identityCheck > 0, 'the served-tree check must be present');
|
||||
assert.ok(firstFlow > identityCheck, 'the served-tree check must run before the first acceptance flow');
|
||||
});
|
||||
@@ -44,11 +44,14 @@ async function dispatchFetch(handler, request) {
|
||||
}
|
||||
|
||||
test('root activation deletes only its obsolete Timmy caches including the legacy v4 cache', async () => {
|
||||
// The backup/provenance release (issue #35) changes app.js and src/domain.js, so the shell cache
|
||||
// must advance or an installed client keeps serving the old ledger code indefinitely.
|
||||
const { listeners, deleted } = loadWorker({
|
||||
cacheKeys: [
|
||||
'timmy-shell-v4',
|
||||
'timmy-shell:/:v4',
|
||||
'timmy-shell:/:v5',
|
||||
'timmy-shell:/:v6',
|
||||
'timmy-shell:/timmy-staging/:v4',
|
||||
'sibling-shared-origin-cache',
|
||||
],
|
||||
@@ -56,7 +59,7 @@ test('root activation deletes only its obsolete Timmy caches including the legac
|
||||
|
||||
await dispatchExtendable(listeners.get('activate'));
|
||||
|
||||
assert.deepEqual(deleted.sort(), ['timmy-shell-v4', 'timmy-shell:/:v4']);
|
||||
assert.deepEqual(deleted.sort(), ['timmy-shell-v4', 'timmy-shell:/:v4', 'timmy-shell:/:v5']);
|
||||
});
|
||||
|
||||
test('offline shell lookup uses only the current named cache', async () => {
|
||||
|
||||
@@ -0,0 +1,120 @@
|
||||
import { chromium } from 'playwright';
|
||||
import assert from 'node:assert/strict';
|
||||
import { mkdir } from 'node:fs/promises';
|
||||
|
||||
// Issue #24 — contributing a confirmed photo to training is a separate opt-in. This runs the real
|
||||
// app in a browser: a journal save must record nothing, the consent sheet must show the version and
|
||||
// the receipt before the button works, and a withdrawal must leave a tombstone naming every derived
|
||||
// artifact. The photo is a synthetic 1x1 PNG constant; no real photo is loaded.
|
||||
const SYNTHETIC_PHOTO = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+ip1sAAAAASUVORK5CYII=';
|
||||
const CONSENT_VERSION = 'training-consent-v1';
|
||||
|
||||
await mkdir('artifacts', { recursive: true });
|
||||
const browser = await chromium.launch({ headless: true });
|
||||
const context = await browser.newContext({ viewport: { width: 390, height: 844 }, deviceScaleFactor: 2, serviceWorkers: 'block' });
|
||||
const page = await context.newPage();
|
||||
const errors = [];
|
||||
page.on('console', message => { if (message.type() === 'error') errors.push(message.text()); });
|
||||
page.on('pageerror', error => errors.push(error.message));
|
||||
page.on('dialog', dialog => dialog.accept());
|
||||
await page.goto('http://127.0.0.1:4173', { waitUntil: 'networkidle' });
|
||||
await page.evaluate(() => localStorage.clear());
|
||||
await page.reload({ waitUntil: 'networkidle' });
|
||||
|
||||
const basePath = () => page.evaluate(() => document.querySelector('meta[name="timmy-base-path"]')?.content || '/');
|
||||
const storeKey = async suffix => `timmy:${await basePath()}:${suffix}`;
|
||||
const readStore = async suffix => {
|
||||
const key = await storeKey(suffix);
|
||||
const raw = await page.evaluate(storeKeys => localStorage.getItem(storeKeys), key);
|
||||
return raw === null ? null : JSON.parse(raw);
|
||||
};
|
||||
const writeStore = async (suffix, value) => {
|
||||
const key = await storeKey(suffix);
|
||||
await page.evaluate(({ storeKey: k, payload }) => localStorage.setItem(k, payload), { storeKey: key, payload: JSON.stringify(value) });
|
||||
};
|
||||
|
||||
// 1. Saving a log through the app's own flow contributes nothing.
|
||||
await page.locator('[data-log]').first().click();
|
||||
await page.locator('[data-type="4"]').click();
|
||||
await page.locator('#next').click();
|
||||
await page.locator('#note').fill('Synthetic test entry');
|
||||
await page.locator('#next').click();
|
||||
await page.locator('#save').click();
|
||||
await page.getByText(/Private log saved/).waitFor();
|
||||
assert.equal(await readStore('training-contributions-v1'), null, 'a journal save must not record a training contribution');
|
||||
|
||||
// 2. Seed one photo-bearing log and one text-only log for the privacy section.
|
||||
const seeded = [
|
||||
{
|
||||
id: 'demo-photo', occurredAt: new Date(Date.now() - 86400000).toISOString(), bristolType: 4,
|
||||
color: 'brown', urgency: 1, discomfort: 0, note: 'synthetic', photoDataUrl: SYNTHETIC_PHOTO, symptoms: {},
|
||||
},
|
||||
{
|
||||
id: 'demo-text', occurredAt: new Date(Date.now() - 2 * 86400000).toISOString(), bristolType: 3,
|
||||
color: 'brown', urgency: 2, discomfort: 1, note: 'no photo here', photoDataUrl: '', symptoms: {},
|
||||
},
|
||||
];
|
||||
await writeStore('ledger-v1', seeded);
|
||||
await page.reload({ waitUntil: 'networkidle' });
|
||||
await page.locator('[data-view="calendar"]').first().click();
|
||||
await page.locator('[data-view="privacy"]').first().click();
|
||||
await page.getByText(/Your poop\. Your phone\./i).waitFor();
|
||||
|
||||
const section = page.locator('[data-training-consent]');
|
||||
assert.equal(await section.count(), 1, 'the privacy page must offer the training contribution section');
|
||||
assert.match(await section.innerText(), /off by default/i);
|
||||
assert.match(await section.innerText(), /nothing is uploaded/i);
|
||||
assert.equal((await page.locator('[data-contribution-consent-version]').innerText()).trim(), CONSENT_VERSION);
|
||||
assert.equal((await page.locator('[data-contribution-queued-count]').innerText()).trim(), '0');
|
||||
assert.equal(await page.locator('[data-contribute-entry="demo-photo"]').count(), 1, 'a saved photo may be contributed');
|
||||
assert.equal(await page.locator('[data-contribute-entry="demo-text"]').count(), 0, 'a log without photo bytes cannot be contributed');
|
||||
|
||||
// 3. The receipt and the consent version are on screen before the confirm control works.
|
||||
await page.locator('[data-contribute-entry="demo-photo"]').click();
|
||||
const sheet = page.locator('[data-contribution-sheet]');
|
||||
await sheet.waitFor();
|
||||
assert.match(await sheet.innerText(), new RegExp(CONSENT_VERSION));
|
||||
const receiptId = (await page.locator('[data-receipt-id]').innerText()).trim();
|
||||
assert.ok(receiptId.length > 0, 'the receipt shown before consent must name its own id');
|
||||
assert.match(await sheet.innerText(), /photo bytes/i);
|
||||
assert.match(await sheet.innerText(), /note text/i);
|
||||
assert.equal(await page.locator('#contribute-confirm').isDisabled(), true, 'the contribution button stays disabled until the terms are accepted');
|
||||
assert.equal(await readStore('training-contributions-v1'), null, 'no receipt may be written before explicit consent');
|
||||
await page.screenshot({ path: 'artifacts/training-contribution-consent-mobile.png' });
|
||||
|
||||
// 4. Consent records exactly one queued-on-device receipt.
|
||||
await page.locator('#training-consent-check').check();
|
||||
await page.locator('#contribute-confirm').click();
|
||||
await page.getByText(/Queued on this device/i).first().waitFor();
|
||||
const queued = await readStore('training-contributions-v1');
|
||||
assert.equal(queued.length, 1);
|
||||
assert.equal(queued[0].entryId, 'demo-photo');
|
||||
assert.equal(queued[0].consentVersion, CONSENT_VERSION);
|
||||
assert.equal(queued[0].contributionId, receiptId);
|
||||
assert.equal(queued[0].state, 'queued-local');
|
||||
assert.equal(JSON.stringify(queued).includes('data:image'), false, 'the receipt must not copy photo bytes');
|
||||
assert.equal(JSON.stringify(queued).includes('synthetic'), false, 'the receipt must not copy note text');
|
||||
await page.locator('[data-contribution-state="queued-local"]').waitFor();
|
||||
assert.equal((await page.locator('[data-contribution-queued-count]').innerText()).trim(), '1');
|
||||
await page.screenshot({ path: 'artifacts/training-contribution-queued-mobile.png' });
|
||||
|
||||
// 5. Withdrawal leaves a tombstone that addresses every derived artifact by contribution id.
|
||||
await page.locator(`[data-withdraw="${receiptId}"]`).click();
|
||||
await page.locator('[data-contribution-state="withdrawn"]').waitFor();
|
||||
const withdrawn = await readStore('training-contributions-v1');
|
||||
assert.equal(withdrawn.length, 1, 'the withdrawn receipt is kept as a tombstone, not silently erased');
|
||||
assert.equal(withdrawn[0].state, 'withdrawn');
|
||||
assert.ok(withdrawn[0].withdrawnAt, 'the tombstone records when the withdrawal happened');
|
||||
assert.deepEqual(withdrawn[0].artifacts.map(artifact => artifact.artifact).sort(), ['confirmed-label', 'raw-image']);
|
||||
for (const artifact of withdrawn[0].artifacts) {
|
||||
assert.equal(artifact.contributionId, receiptId);
|
||||
assert.equal(artifact.state, 'withdrawn');
|
||||
}
|
||||
assert.match(await page.locator('[data-withdrawn-artifacts]').innerText(), /raw image/i);
|
||||
assert.equal((await page.locator('[data-contribution-queued-count]').innerText()).trim(), '0');
|
||||
await page.screenshot({ path: 'artifacts/training-contribution-withdrawn-mobile.png' });
|
||||
|
||||
assert.deepEqual(errors, []);
|
||||
await context.close();
|
||||
await browser.close();
|
||||
console.log('PASS training contribution stays opt-in, shows its consent version before commit, and withdrawal names every derived artifact');
|
||||
@@ -0,0 +1,161 @@
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import {
|
||||
TRAINING_CONSENT_VERSION,
|
||||
addContribution,
|
||||
consentTerms,
|
||||
contributionEligibility,
|
||||
contributionForEntry,
|
||||
defaultContributionState,
|
||||
derivedArtifacts,
|
||||
receiptPreview,
|
||||
withdrawContribution,
|
||||
} from '../src/training-contribution.js';
|
||||
|
||||
// Issue #24 — contributing a photo to Timmy's training corpus is a separate decision from saving
|
||||
// a log. Nothing here is transmitted: the receipt is what a person could carry to a corpus pipeline
|
||||
// later, and the withdrawal tombstone is what names the artifacts a deletion has to reach.
|
||||
|
||||
const PHOTO = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+ip1sAAAAASUVORK5CYII=';
|
||||
const entry = (overrides = {}) => ({
|
||||
id: 'log-1',
|
||||
occurredAt: '2026-10-14T07:20:00.000Z',
|
||||
bristolType: 4,
|
||||
color: 'brown',
|
||||
urgency: 1,
|
||||
discomfort: 0,
|
||||
note: 'after lunch',
|
||||
photoDataUrl: PHOTO,
|
||||
symptoms: { blood: false },
|
||||
...overrides,
|
||||
});
|
||||
const preview = (target = entry(), id = 'contrib-1') => receiptPreview(target, {
|
||||
contributionId: id,
|
||||
consentedAt: '2026-10-21T10:00:00.000Z',
|
||||
});
|
||||
|
||||
test('saving a journal entry contributes nothing by default', () => {
|
||||
assert.deepEqual(defaultContributionState(), { optedIn: false, receipt: null });
|
||||
});
|
||||
|
||||
test('an entry with no saved photo bytes cannot be contributed', () => {
|
||||
const unavailable = contributionEligibility(entry({ photoDataUrl: '' }));
|
||||
assert.equal(unavailable.eligible, false);
|
||||
assert.match(unavailable.reason, /no saved photo/i);
|
||||
assert.equal(contributionEligibility(entry()).eligible, true);
|
||||
});
|
||||
|
||||
test('the consent terms name the version and what is never shared', () => {
|
||||
const terms = consentTerms();
|
||||
|
||||
assert.equal(terms.version, TRAINING_CONSENT_VERSION);
|
||||
assert.match(terms.version, /^training-consent-/);
|
||||
assert.ok(terms.includes.some(item => /photo/i.test(item)));
|
||||
assert.ok(terms.excludes.some(item => /note/i.test(item)));
|
||||
assert.ok(terms.excludes.some(item => /symptom/i.test(item)));
|
||||
// This build is honest about transport: a receipt is queued on the device, not uploaded.
|
||||
assert.match(terms.transport, /nothing is uploaded/i);
|
||||
});
|
||||
|
||||
test('the receipt shown before consent carries the version, the id, and no free text from the log', () => {
|
||||
const receipt = preview();
|
||||
|
||||
assert.equal(receipt.contributionId, 'contrib-1');
|
||||
assert.equal(receipt.consentVersion, TRAINING_CONSENT_VERSION);
|
||||
assert.equal(receipt.consentedAt, '2026-10-21T10:00:00.000Z');
|
||||
assert.deepEqual(receipt.labels, { bristolType: 4, color: 'brown' });
|
||||
assert.equal(receipt.state, 'queued-local');
|
||||
// The confirmed note and symptom flags stay in the journal; they are not part of a contribution.
|
||||
const serialized = JSON.stringify(receipt);
|
||||
assert.equal(serialized.includes('after lunch'), false);
|
||||
assert.equal(serialized.includes('"blood"'), false);
|
||||
assert.equal(serialized.includes('data:image'), false);
|
||||
});
|
||||
|
||||
test('a receipt cannot be recorded without the current consent version', () => {
|
||||
assert.throws(
|
||||
() => addContribution([], { ...preview(), consentVersion: 'training-consent-v0' }),
|
||||
/consent version/i,
|
||||
);
|
||||
});
|
||||
|
||||
test('recording a contribution returns a new list and leaves the ledger it was given alone', () => {
|
||||
const before = [];
|
||||
const after = addContribution(before, preview());
|
||||
|
||||
assert.equal(before.length, 0);
|
||||
assert.equal(after.length, 1);
|
||||
assert.equal(after[0].contributionId, 'contrib-1');
|
||||
assert.equal(contributionForEntry(after, 'log-1')?.contributionId, 'contrib-1');
|
||||
});
|
||||
|
||||
test('the same log cannot be contributed twice while its receipt is still active', () => {
|
||||
const first = addContribution([], preview());
|
||||
const second = addContribution(first, preview(entry(), 'contrib-2'));
|
||||
|
||||
assert.equal(second.length, 1);
|
||||
assert.equal(second[0].contributionId, 'contrib-1');
|
||||
});
|
||||
|
||||
test('withdrawal keeps a tombstone that names every derived artifact by contribution id', () => {
|
||||
const contributions = addContribution([], preview());
|
||||
const artifacts = derivedArtifacts(contributions[0]);
|
||||
|
||||
const { contributions: after, tombstone } = withdrawContribution(
|
||||
contributions, 'contrib-1', '2026-10-21T11:00:00.000Z',
|
||||
);
|
||||
|
||||
assert.equal(after[0].state, 'withdrawn');
|
||||
assert.equal(after[0].withdrawnAt, '2026-10-21T11:00:00.000Z');
|
||||
assert.equal(tombstone.contributionId, 'contrib-1');
|
||||
assert.deepEqual(
|
||||
tombstone.artifacts.map(artifact => artifact.artifact).sort(),
|
||||
artifacts.map(artifact => artifact.artifact).sort(),
|
||||
);
|
||||
for (const artifact of tombstone.artifacts) {
|
||||
assert.equal(artifact.contributionId, 'contrib-1');
|
||||
assert.equal(artifact.state, 'withdrawn');
|
||||
}
|
||||
});
|
||||
|
||||
test('the derived artifacts are the image bytes and the confirmed label, addressed by contribution id', () => {
|
||||
const artifacts = derivedArtifacts(preview());
|
||||
|
||||
assert.deepEqual(artifacts.map(artifact => artifact.artifact).sort(), ['confirmed-label', 'raw-image']);
|
||||
for (const artifact of artifacts) {
|
||||
assert.equal(artifact.contributionId, 'contrib-1');
|
||||
assert.equal(artifact.state, 'active');
|
||||
}
|
||||
});
|
||||
|
||||
test('withdrawing one contribution never touches another receipt', () => {
|
||||
const list = [
|
||||
...addContribution([], preview()),
|
||||
...addContribution([], preview(entry({ id: 'log-2' }), 'contrib-2')),
|
||||
];
|
||||
|
||||
const { contributions: after } = withdrawContribution(list, 'contrib-1', '2026-10-21T11:00:00.000Z');
|
||||
|
||||
assert.equal(after.find(item => item.contributionId === 'contrib-1').state, 'withdrawn');
|
||||
assert.equal(after.find(item => item.contributionId === 'contrib-2').state, 'queued-local');
|
||||
});
|
||||
|
||||
test('withdrawing an unknown contribution id changes nothing and reports no tombstone', () => {
|
||||
const list = addContribution([], preview());
|
||||
const { contributions: after, tombstone } = withdrawContribution(list, 'missing', '2026-10-21T11:00:00.000Z');
|
||||
|
||||
assert.equal(after, list);
|
||||
assert.equal(tombstone, null);
|
||||
});
|
||||
|
||||
test('a withdrawn log can be contributed again under a fresh receipt', () => {
|
||||
const { contributions: withdrawn } = withdrawContribution(
|
||||
addContribution([], preview()), 'contrib-1', '2026-10-21T11:00:00.000Z',
|
||||
);
|
||||
|
||||
const again = addContribution(withdrawn, preview(entry(), 'contrib-2'));
|
||||
|
||||
assert.equal(again.length, 2);
|
||||
assert.equal(contributionForEntry(again, 'log-1').contributionId, 'contrib-2');
|
||||
assert.equal(contributionForEntry(again, 'log-1').state, 'queued-local');
|
||||
});
|
||||
@@ -14,6 +14,7 @@ test('training ingest strips metadata, derives a pseudonymous split, and writes
|
||||
'--output-dir', out,
|
||||
'--subject-id', 'subject-123',
|
||||
'--consent-version', 'research-v1',
|
||||
'--contribution-id', '6f1d0c9e-2c4a-4f3b-9d1e-8a7b6c5d4e3f',
|
||||
'--bristol-type', '4',
|
||||
'--color', 'brown',
|
||||
'--quality', 'good',
|
||||
@@ -45,10 +46,11 @@ test('training ingest rejects records without explicit consent or human review',
|
||||
'--input', 'tests/fixtures/synthetic-type4.jpg',
|
||||
'--output-dir', '/tmp/should-not-exist-timmy',
|
||||
'--subject-id', 'subject-123',
|
||||
'--contribution-id', '6f1d0c9e-2c4a-4f3b-9d1e-8a7b6c5d4e3f',
|
||||
'--bristol-type', '4',
|
||||
'--color', 'brown',
|
||||
'--quality', 'good',
|
||||
], { encoding: 'utf8', env: { ...process.env, TIMMY_DATASET_SALT: 'test-only-salt' } });
|
||||
assert.notEqual(run.status, 0);
|
||||
assert.match(run.stderr, /consent|reviewer/i);
|
||||
assert.match(run.stderr, /consent/i);
|
||||
});
|
||||
Reference in new issue
Block a user