stackchain/timmy-talking-turd
1
0
Fork 0
Code Issues 41 Pull Requests 6 Actions Packages Projects Releases 15 Wiki Activity

Harden image ingress: magic bytes, re-encode, limits, metadata stripping, and rate control #16

New Issue
Open
opened 2026-08-19 01:58:59 +00:00 by timmy · 2 comments
timmy commented 2026-08-19 01:58:59 +00:00
Owner
Copy Link

Parent epic: #2

Outcome

Treat every uploaded medical image as hostile and sensitive.

Acceptance criteria

  • Decode verifies content independent of filename/MIME.
  • Dimension/body/time/rate limits fail before provider work.
  • Re-encoding strips metadata and malformed/polyglot fixtures are rejected.
  • Request and error logs contain no image bytes or base64.

Dependencies

  • None

Required evidence

  • Test or executable receipt attached to the issue/PR
  • Privacy/safety boundary checked where applicable
  • Clean checkout and relevant full suite pass

Delivery

Open a focused branch and PR with Closes #ISSUE. Do not include real medical images in issue comments or Git history.

Parent epic: #2 ## Outcome Treat every uploaded medical image as hostile and sensitive. ## Acceptance criteria - [ ] Decode verifies content independent of filename/MIME. - [ ] Dimension/body/time/rate limits fail before provider work. - [ ] Re-encoding strips metadata and malformed/polyglot fixtures are rejected. - [ ] Request and error logs contain no image bytes or base64. ## Dependencies - None ## Required evidence - Test or executable receipt attached to the issue/PR - Privacy/safety boundary checked where applicable - Clean checkout and relevant full suite pass ## Delivery Open a focused branch and PR with `Closes #ISSUE`. Do not include real medical images in issue comments or Git history.
timmy added this to the M1 — Sovereign Photo Intelligence milestone 2026-08-19 01:58:59 +00:00
timmy added the
type/security
priority/P0
area/backend
area/privacy
 labels 2026-08-19 01:58:59 +00:00
rockachopa commented 2026-08-22 21:22:35 +00:00
Member
Copy Link

[CLAIM] agent=timmy

Working in dedicated worktree /tmp/hy3-timmy-16 at origin/main 47294a9 on branch free/hy3-timmy-16. Scope: magic-byte validation, safe re-encode with metadata stripping, strict body/dimension/time limits, and bounded rate control on the /api/analyze image ingress. Strict RED-GREEN TDD with hostile synthetic fixtures (spoofed MIME, polyglots, truncation, decompression bombs, EXIF/GPS, oversized dimensions, bursts). Fail closed with sanitized errors and manual fallback; no real medical images, no live deploy.

[CLAIM] agent=timmy Working in dedicated worktree /tmp/hy3-timmy-16 at origin/main 47294a9 on branch free/hy3-timmy-16. Scope: magic-byte validation, safe re-encode with metadata stripping, strict body/dimension/time limits, and bounded rate control on the /api/analyze image ingress. Strict RED-GREEN TDD with hostile synthetic fixtures (spoofed MIME, polyglots, truncation, decompression bombs, EXIF/GPS, oversized dimensions, bursts). Fail closed with sanitized errors and manual fallback; no real medical images, no live deploy.
rockachopa added the
type/test
 label 2026-08-22 21:23:07 +00:00
rockachopa commented 2026-08-22 21:48:03 +00:00
Member
Copy Link

[EVIDENCE] agent=timmy

PR: #63 (branch free/hy3-timmy-16 at ccb2279, base 47294a9). Not merged; awaiting human review.

  • Strict RED-GREEN TDD: tests/image-ingress.test.js written first against hostile synthetic fixtures and observed failing (module missing), then implemented to green.
  • Hostile inputs covered: spoofed MIME (HTML as JPEG), GIF-header polyglot with script payload, ZIP-in-JPEG polyglot, truncated/garbage/empty images, 12000x12000 decompression bomb, 6000x6000 oversized dimensions, EXIF+GPS JPEG, PNG tEXt metadata, SVG with embedded script.
  • Verified post-ingress output carries zero EXIF/GPS/text metadata and errors are sanitized fixed strings (no bytes, no base64, no stacks); provider fetch provably never reached on rejection.
  • Rate control: bounded per-client window limiter on /api/analyze, 429 + Retry-After, no payload retention.
  • Clean checkout of pushed branch: 81/81 node tests pass, 20/20 staging-deploy tests pass, check:syntax clean, check:diff clean, npm audit --omit=dev 0 vulnerabilities, secrets grep clean. All fixtures synthetic; no real medical images in issue comments or git history.
[EVIDENCE] agent=timmy PR: https://forge.alexanderwhitestone.com/git/stackchain/timmy-talking-turd/pulls/63 (branch free/hy3-timmy-16 at ccb2279, base 47294a9). Not merged; awaiting human review. - Strict RED-GREEN TDD: tests/image-ingress.test.js written first against hostile synthetic fixtures and observed failing (module missing), then implemented to green. - Hostile inputs covered: spoofed MIME (HTML as JPEG), GIF-header polyglot with script payload, ZIP-in-JPEG polyglot, truncated/garbage/empty images, 12000x12000 decompression bomb, 6000x6000 oversized dimensions, EXIF+GPS JPEG, PNG tEXt metadata, SVG with embedded script. - Verified post-ingress output carries zero EXIF/GPS/text metadata and errors are sanitized fixed strings (no bytes, no base64, no stacks); provider fetch provably never reached on rejection. - Rate control: bounded per-client window limiter on /api/analyze, 429 + Retry-After, no payload retention. - Clean checkout of pushed branch: 81/81 node tests pass, 20/20 staging-deploy tests pass, check:syntax clean, check:diff clean, npm audit --omit=dev 0 vulnerabilities, secrets grep clean. All fixtures synthetic; no real medical images in issue comments or git history.
rockachopa added the
state:review
 label 2026-08-22 21:49:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
area/backend

Application API and storage

  
area/data

Dataset and provenance

  
area/frontend

PWA and interaction design

  
area/model

Vision model and inference

  
area/privacy

Privacy and consent

  
area/release

Release engineering and distribution

  
area/safety

Clinical safety boundary

  
blocked

Blocked on an explicit dependency or decision

  
human-gate

Requires explicit human approval

  
priority/P0

Release-critical

  
priority/P1

High priority

  
priority/P2

Planned

  
state:review

   
type/docs

Documentation and evidence

  
type/epic

Roadmap epic

  
type/feature

Product feature

  
type/ops

Infrastructure and operations

  
type/research

Research or evaluation

  
type/security

Security hardening

  
type/test

Verification and quality gate

No Label
area/backend
area/data
area/frontend
area/model
area/privacy
area/release
area/safety
blocked
human-gate
priority/P0
priority/P1
priority/P2
state:review
type/docs
type/epic
type/feature
type/ops
type/research
type/security
type/test
Milestone
Clear milestone
No items
No Milestone
M1 — Sovereign Photo Intelligence
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: stackchain/timmy-talking-turd#16
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?