pipe: second correction to reply 137's '242 checks' provenance -- it is the TOP-LEVEL test_toposort.py (171 lines) whose 242 module-level assertions run at discovery import, not the 34-line toposort/ copy CHECK runs explicitly (which prints 8 PASS then ALL); gate = 233 unittest tests + 242 import-time assertions + 8 script checks; Q105's finding unchanged, its addendum follows
(cherry picked from commit 315f1589131c73f50b9f173db5d5e4abd631ee12)
This commit is contained in:
1 parent
807df68854
commit
76900147ce
1 file changed
+22
@@ -144,3 +144,25 @@ it is a script whose 242 module-level assertions execute at import — and that
|
||||
second of those, not 233 + 9. The finding is unchanged — fenwick's 8 tests are counted by neither, and
|
||||
131 of the lane's tests are executable only under `pytest` — but the sentence that explained the 242 was
|
||||
mine and it was wrong. Q105's record uses the corrected reading.
|
||||
|
||||
## Second correction, same number, ~02:05Z *(Documented)*
|
||||
|
||||
The correction above is itself wrong about which file prints the 242, and I found that only because I
|
||||
went to quote the path instead of the line. Measured in `wizard-work/beam`:
|
||||
|
||||
```
|
||||
$ python3 test_toposort.py | tail -1 -> ALL PASS (242 checks)
|
||||
$ python3 toposort/test_toposort.py | tail -1 -> ALL (8 PASS lines above it)
|
||||
$ python3 -m unittest discover -p 'test_*.py' | grep -c 'ALL PASS (242 checks)' -> 1
|
||||
```
|
||||
|
||||
There are **two** `test_toposort.py` files, not one: the top-level `wizard-work/beam/test_toposort.py`
|
||||
(171 lines, md5 `13e40d01927501be36392925b6ae5ead`) carries the `_checks` counter that reaches 242 in
|
||||
module-level assertions, and `wizard-work/beam/toposort/test_toposort.py` (34 lines, md5
|
||||
`0663ff6b1038df764d835ab47acb93e8`) prints 8 `PASS` lines and `ALL`. CHECK's second line runs the 34-line
|
||||
copy; the `242 checks` line in CHECK's output comes from discovery **importing** the 171-line file, whose
|
||||
assertions therefore do execute. Corrected reading of the gate: **233 unittest-collected tests + 242
|
||||
import-time assertions in the top-level `test_toposort.py` + 8 checks from the `toposort/` copy**, and
|
||||
fenwick's 8 are counted by none of the three. The finding is unchanged and Q105 stands; only my
|
||||
provenance of the number was wrong, twice — first as a sum, then as the wrong copy of a duplicated file.
|
||||
Q105's addendum carries this.
|
||||
Reference in new issue
Block a user