forked from Rockachopa/Timmy-time-dashboard
36fc10097f
* feat: set qwen3.5:latest as default model - Make qwen3.5:latest the primary default model for faster inference - Move llama3.1:8b-instruct to fallback chain - Update text fallback chain to prioritize qwen3.5:latest Retains full backward compatibility via cascade fallback. * test: remove ~55 brittle, duplicate, and useless tests Audit of all 100 test files identified tests that provided no real regression protection. Removed: - 4 files deleted entirely: test_setup_script (always skipped), test_csrf_bypass (tautological assertions), test_input_validation (accepts 200-500 status codes), test_security_regression (fragile source-pattern checks redundant with rendering tests) - Duplicate test classes (TestToolTracking, TestCalculatorExtended) - Mock-only tests that just verify mock wiring, not behavior - Structurally broken tests (TestCreateToolFunctions patches after import) - Empty/pass-body tests and meaningless assertions (len > 20) - Flaky subprocess tests (aider tool calling real binary) All 1328 remaining tests pass. Net: -699 lines, zero coverage loss. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: prevent test pollution from autoresearch_enabled mutation test_autoresearch_perplexity.py was setting settings.autoresearch_enabled = True but never restoring it in the finally block — polluting subsequent tests. When pytest-randomly ordered it before test_experiments_page_shows_disabled_when_off, the victim test saw enabled=True and failed to find "Disabled" in the page. Fix both sides: - Restore autoresearch_enabled in the finally block (root cause) - Mock settings explicitly in the victim test (defense in depth) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Trip T <trip@local> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
66 lines
2.0 KiB
Python
66 lines
2.0 KiB
Python
"""Extended tests for timmy.tools — covers stats, type aliases, and aider tool."""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from timmy.tools import (
|
|
AgentTools,
|
|
PersonaTools,
|
|
ToolStats,
|
|
create_aider_tool,
|
|
)
|
|
|
|
|
|
class TestToolStats:
|
|
"""Test ToolStats dataclass."""
|
|
|
|
def test_defaults(self):
|
|
ts = ToolStats(tool_name="calc")
|
|
assert ts.call_count == 0
|
|
assert ts.last_used is None
|
|
assert ts.errors == 0
|
|
|
|
|
|
class TestAgentTools:
|
|
"""Test AgentTools dataclass and backward compat alias."""
|
|
|
|
def test_persona_tools_alias(self):
|
|
assert PersonaTools is AgentTools
|
|
|
|
|
|
class TestAiderTool:
|
|
"""Test AiderTool created by create_aider_tool."""
|
|
|
|
def test_create_aider_tool(self, tmp_path):
|
|
tool = create_aider_tool(tmp_path)
|
|
assert hasattr(tool, "run_aider")
|
|
assert tool.base_dir == tmp_path
|
|
|
|
@patch("subprocess.run")
|
|
def test_aider_success(self, mock_run, tmp_path):
|
|
tool = create_aider_tool(tmp_path)
|
|
mock_run.return_value = MagicMock(returncode=0, stdout="Changes applied")
|
|
result = tool.run_aider("add fibonacci function")
|
|
assert "Changes applied" in result
|
|
|
|
@patch("subprocess.run")
|
|
def test_aider_error(self, mock_run, tmp_path):
|
|
tool = create_aider_tool(tmp_path)
|
|
mock_run.return_value = MagicMock(returncode=1, stderr="something broke")
|
|
result = tool.run_aider("bad prompt")
|
|
assert "error" in result.lower()
|
|
|
|
@patch("subprocess.run", side_effect=FileNotFoundError)
|
|
def test_aider_not_installed(self, mock_run, tmp_path):
|
|
tool = create_aider_tool(tmp_path)
|
|
result = tool.run_aider("test")
|
|
assert "not installed" in result.lower()
|
|
|
|
@patch("subprocess.run")
|
|
def test_aider_timeout(self, mock_run, tmp_path):
|
|
import subprocess
|
|
|
|
mock_run.side_effect = subprocess.TimeoutExpired(cmd="aider", timeout=120)
|
|
tool = create_aider_tool(tmp_path)
|
|
result = tool.run_aider("slow task")
|
|
assert "timed out" in result.lower()
|