[claude] fix get-lnbits-key.sh version detection for pre-0.12 LNbits (#19) #53

claude · 2026-03-23T01:05:04Z

claude commented

2026-03-23 01:05:04 +00:00

Fixes #19

Summary

Separated reachability check (GET /) from version detection (/api/v1/health)
Old LNbits (<0.12) lacking the health endpoint now correctly falls through to the legacy superuser API path instead of reporting "not reachable"
When health endpoint is absent, assumes pre-0.12; when present but missing server_version, assumes 0.12+

Test plan

Run script against LNbits >= 0.12 — should print Admin UI instructions
Run script against LNbits < 0.12 — should attempt superuser wallet creation
Run script with LNbits not running — should show "not reachable" message
Verify bash -n passes (syntax check)
Verify script exits 0 in all code paths

Fixes #19 ## Summary - Separated reachability check (GET /) from version detection (/api/v1/health) - Old LNbits (<0.12) lacking the health endpoint now correctly falls through to the legacy superuser API path instead of reporting "not reachable" - When health endpoint is absent, assumes pre-0.12; when present but missing server_version, assumes 0.12+ ## Test plan - [ ] Run script against LNbits >= 0.12 — should print Admin UI instructions - [ ] Run script against LNbits < 0.12 — should attempt superuser wallet creation - [ ] Run script with LNbits not running — should show "not reachable" message - [ ] Verify `bash -n` passes (syntax check) - [ ] Verify script exits 0 in all code paths

claude added 1 commit 2026-03-23 01:05:05 +00:00

fix: separate reachability check from version detection in get-lnbits-key.sh

CI / Typecheck & Lint (pull_request) Failing after 1s

Details

d560a27629

The script used /api/v1/health for both reachability testing and version
detection. Since that endpoint only exists on LNbits 0.12+, old versions
were incorrectly reported as "not reachable" instead of falling through
to the legacy superuser API path.

Now the script:
- Tests reachability via GET / (works on all LNbits versions)
- Uses /api/v1/health only for version detection
- If health endpoint is absent, correctly assumes pre-0.12 (legacy path)
- If health endpoint exists but lacks server_version, assumes 0.12+

Fixes #19

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

claude referenced this pull request

2026-03-23 01:05:15 +00:00

get-lnbits-key.sh targets deprecated LNbits API (pre-0.12) — wallet creation fails on fresh installs #19

claude merged commit 6af27d4cdc into main

2026-03-23 01:05:20 +00:00

claude referenced this issue from a commit

2026-03-23 01:05:22 +00:00

[claude] fix get-lnbits-key.sh version detection for pre-0.12 LNbits (#19) (#53)

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: replit/token-gated-economy#53