[loop-generated] [refactor] Break up git.py::run() — 90 lines #538
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The
run()function insrc/infrastructure/hands/git.pyis 90 lines long. Extract helpers for distinct phases (validation, execution, output processing) to improve readability and testability.File:
src/infrastructure/hands/git.pyFunction:
run()Lines: 90
Kimi: Extract the
run()function insrc/infrastructure/hands/git.pyinto smaller private helpers. Each distinct phase (argument validation, subprocess execution, output processing, error handling) should be its own function. Keeprun()as the orchestrator that calls the helpers. Verify withtox -e unit.Break up git.py::run() in src/infrastructure/hands/git.py. Extract helpers for argument parsing, command execution, and output formatting. Keep run() as slim orchestrator. Run
tox -e unitto verify.Triage refinement — acceptance criteria:
run()main body < 40 linestox -e unit)tox -e pygreenInstructions for Kimi:
src/infrastructure/hands/git.py, findrun()(90 lines)tox -e unit— all tests must passkimi/issue-538Kimi task instructions:
File:
src/infrastructure/hands/git.pyFunction:
run()(~90 lines)Goal: Break this function into smaller helpers.
Approach:
tox -e unitto verifyAcceptance:
tox -e unitpasses. Function is <30 lines. No behavior change.📦 Consolidated into Code Hygiene epic #1079. This issue remains open for individual tracking.
Kimi Instructions
Break up
src/infrastructure/hands/git.py::run()— currently 90 lines.Files to modify
src/infrastructure/hands/git.pyWhat to do
run()function into smaller helper functionsrun()should still work the same way, just internally delegate to helpersHow to verify
All existing tests must pass. No behavior changes.
@kimi Here are your instructions for this issue:
Goal: Break up
GitHand.run()insrc/infrastructure/hands/git.py(line 74, ~90 lines) into smaller private methods.File to modify:
src/infrastructure/hands/git.pyCurrent structure of
run():Refactor plan:
Extract these private methods:
_check_destructive(self, args: str, start: float) -> GitResult | None— returns GitResult if blocked, None if allowed_execute_subprocess(self, args: str, timeout: int) -> tuple[bytes, bytes, int]— runs git, returns stdout/stderr/returncode. Raises TimeoutError or OSError._build_result(self, command: str, stdout: bytes, stderr: bytes, returncode: int, start: float) -> GitResult— builds the GitResult from raw outputThen
run()becomes a thin orchestrator calling these 3 methods.Constraints:
run()signature and return type unchangedVerification:
cd /path/to/repo && tox -e unit -- tests/ -k git -v