Rockachopa/Timmy-time-dashboard
1
0
Fork 2
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[loop-cycle] refactor: break up git.py::run() into helpers (#538) #1204

Merged
Timmy merged 1 commits from refactor/break-up-git-run into main 2026-03-23 22:07:30 +00:00
Conversation 0 Commits 1 Files Changed 1 +59 -34
Timmy commented 2026-03-23 22:07:26 +00:00
Owner
Copy Link

Closes #538

Extracts two helpers from run() (90 lines → 35 lines):

  • _exec_subprocess() — subprocess creation, timeout handling, cleanup
  • _parse_output() — decode bytes, build GitResult

run() now reads as a clear sequence: validate → execute → parse, with flat error handling.

All 343 tests pass.

Closes #538 Extracts two helpers from `run()` (90 lines → 35 lines): - `_exec_subprocess()` — subprocess creation, timeout handling, cleanup - `_parse_output()` — decode bytes, build GitResult `run()` now reads as a clear sequence: validate → execute → parse, with flat error handling. All 343 tests pass.
Timmy added 1 commit 2026-03-23 22:07:27 +00:00
refactor: break up git.py::run() into helpers (#538)
Some checks failed
Tests / lint (pull_request) Failing after 10s
Details
Tests / test (pull_request) Has been skipped
Details
b6fafac604
Timmy merged commit 3ed2bbab02 into main 2026-03-23 22:07:30 +00:00
Timmy deleted branch refactor/break-up-git-run 2026-03-23 22:07:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
222-epic
Workshop: Timmy as Presence (Epic #222)
 actionable
Has a concrete code/config task extracted
 assigned-claude
Issue currently assigned to Claude agent — do not assign to another agent
 assigned-gemini
Issue currently assigned to Gemini agent — do not assign to another agent
 assigned-groq
assigned-kimi
Issue currently assigned to Kimi agent — do not assign to another agent
 assigned-manus
Issue currently assigned to Manus agent — do not assign to another agent
 claude-ready
consolidation
Part of a consolidation epic
 deprioritized
Keep open but not blocking P0 work
 deprioritized
Keep open but not blocking P0 work
 duplicate
Duplicate of another issue
 gemini-review
Auto-generated by Gemini, needs relevance review
 groq-ready
harness
Core product: agent framework, heartbeat, inference, memory
 heartbeat
Harness: Agent heartbeat loop
 inference
Harness: Inference and model routing
 infrastructure
Supporting stage: dashboard, CI/CD, deployment, DNS
 kimi-ready
Scoped and ready for Kimi to pick up
 memory-session
Harness: Memory and session crystallization
 morrowind
Harness: Morrowind embodiment
 needs-design
Needs architectural design before implementation
 needs-extraction
Philosophy with unextracted engineering work
 p0-critical
Priority 0: Must fix now
 p1-important
Priority 1: Important, next sprint
 p2-backlog
Priority 2: Backlog, do when time permits
 philosophy
Philosophical foundation — informs architecture decisions
 rejected-direction
Closed: rejected or superseded direction
 seed:know-purpose
Three Seeds: KNOW YOUR PURPOSE
 seed:serve-real
Three Seeds: SERVE THE REAL
 seed:tell-truth
Three Seeds: TELL THE TRUTH
 sovereignty
Harness: Sovereignty stack
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Timmy claude grok groq kimi manus perplexity Rockachopa
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Rockachopa/Timmy-time-dashboard#1204
Delete Branch "refactor/break-up-git-run"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?