feat: Add parser tests (closes #177)

scripts/dead_code_detector.py

@@ -1,282 +0,0 @@
-#!/usr/bin/env python3
-"""
-Dead Code Detector for Python Codebases
-
-AST-based analysis to find defined but never-called functions and classes.
-Excludes entry points, plugin hooks, __init__ exports.
-
-Usage:
-  python3 scripts/dead_code_detector.py /path/to/repo/
-  python3 scripts/dead_code_detector.py hermes-agent/ --format json
-  python3 scripts/dead_code_detector.py . --exclude tests/,venv/
-
-Output: file:line, function/class name, last git author (if available)
-"""
-
-import argparse
-import ast
-import json
-import os
-import subprocess
-import sys
-from collections import defaultdict
-from pathlib import Path
-from typing import Optional
-
-
-# Names that are expected to be unused (entry points, protocol methods, etc.)
-SAFE_UNUSED_PATTERNS = {
-    # Python dunders
-    "__init__", "__str__", "__repr__", "__eq__", "__hash__", "__len__",
-    "__getitem__", "__setitem__", "__contains__", "__iter__", "__next__",
-    "__enter__", "__exit__", "__call__", "__bool__", "__del__",
-    "__post_init__", "__class_getitem__",
-    # Common entry points
-    "main", "app", "handler", "setup", "teardown", "fixture",
-    # pytest
-    "conftest", "test_", "pytest_",  # prefix patterns
-    # Protocols / abstract
-    "abstractmethod", "abc_",
-}
-
-
-def is_safe_unused(name: str, filepath: str) -> bool:
-    """Check if an unused name is expected to be unused."""
-    # Test files are exempt
-    if "test" in filepath.lower():
-        return True
-
-    # Known patterns
-    for pattern in SAFE_UNUSED_PATTERNS:
-        if name.startswith(pattern) or name == pattern:
-            return True
-
-    # __init__.py exports are often unused internally
-    if filepath.endswith("__init__.py"):
-        return True
-
-    return False
-
-
-def get_git_blame(filepath: str, lineno: int) -> Optional[str]:
-    """Get last author of a line via git blame."""
-    try:
-        result = subprocess.run(
-            ["git", "blame", "-L", f"{lineno},{lineno}", "--porcelain", filepath],
-            capture_output=True, text=True, timeout=5
-        )
-        for line in result.stdout.split("\n"):
-            if line.startswith("author "):
-                return line[7:]
-    except:
-        pass
-    return None
-
-
-class DefinitionCollector(ast.NodeVisitor):
-    """Collect all function and class definitions."""
-
-    def __init__(self):
-        self.definitions = []  # (name, type, lineno, filepath)
-
-    def visit_FunctionDef(self, node):
-        self.definitions.append((node.name, "function", node.lineno))
-        self.generic_visit(node)
-
-    def visit_AsyncFunctionDef(self, node):
-        self.definitions.append((node.name, "async_function", node.lineno))
-        self.generic_visit(node)
-
-    def visit_ClassDef(self, node):
-        self.definitions.append((node.name, "class", node.lineno))
-        self.generic_visit(node)
-
-
-class NameUsageCollector(ast.NodeVisitor):
-    """Collect all name references (calls, imports, attribute access)."""
-
-    def __init__(self):
-        self.names = set()
-        self.calls = set()
-        self.imports = set()
-
-    def visit_Name(self, node):
-        self.names.add(node.id)
-        self.generic_visit(node)
-
-    def visit_Attribute(self, node):
-        if isinstance(node.value, ast.Name):
-            self.names.add(node.value.id)
-        self.generic_visit(node)
-
-    def visit_Call(self, node):
-        if isinstance(node.func, ast.Name):
-            self.calls.add(node.func.id)
-        elif isinstance(node.func, ast.Attribute):
-            if isinstance(node.func.value, ast.Name):
-                self.names.add(node.func.value.id)
-            self.calls.add(node.func.attr)
-        self.generic_visit(node)
-
-    def visit_Import(self, node):
-        for alias in node.names:
-            self.imports.add(alias.asname or alias.name)
-        self.generic_visit(node)
-
-    def visit_ImportFrom(self, node):
-        for alias in node.names:
-            self.imports.add(alias.asname or alias.name)
-        self.generic_visit(node)
-
-
-def analyze_file(filepath: str) -> dict:
-    """Analyze a single Python file for dead code."""
-    path = Path(filepath)
-    try:
-        content = path.read_text()
-        tree = ast.parse(content, filename=str(filepath))
-    except (SyntaxError, UnicodeDecodeError):
-        return {"error": f"Could not parse {filepath}"}
-
-    # Collect definitions
-    def_collector = DefinitionCollector()
-    def_collector.visit(tree)
-    definitions = def_collector.definitions
-
-    # Collect usage
-    usage_collector = NameUsageCollector()
-    usage_collector.visit(tree)
-    used_names = usage_collector.names | usage_collector.calls | usage_collector.imports
-
-    # Also scan the entire repo for references to this file's definitions
-    # (this is done at the repo level, not file level)
-
-    dead = []
-    for name, def_type, lineno in definitions:
-        if name.startswith("_") and not name.startswith("__"):
-            # Private functions — might be used externally, less likely dead
-            pass
-
-        if name not in used_names:
-            if not is_safe_unused(name, filepath):
-                dead.append({
-                    "name": name,
-                    "type": def_type,
-                    "file": filepath,
-                    "line": lineno,
-                })
-
-    return {"definitions": len(definitions), "dead": dead}
-
-
-def scan_repo(repo_path: str, exclude_patterns: list = None) -> dict:
-    """Scan an entire repo for dead code."""
-    path = Path(repo_path)
-    exclude = exclude_patterns or ["venv", ".venv", "node_modules", "__pycache__",
-                                    ".git", "dist", "build", ".tox", "vendor"]
-
-    all_definitions = {}  # name -> [{file, line, type}]
-    all_files = []
-    dead_code = []
-
-    # First pass: collect all definitions across repo
-    for fpath in path.rglob("*.py"):
-        parts = fpath.parts
-        if any(ex in parts for ex in exclude):
-            continue
-        if fpath.name.startswith("."):
-            continue
-
-        try:
-            content = fpath.read_text(errors="ignore")
-            tree = ast.parse(content, filename=str(fpath))
-        except:
-            continue
-
-        all_files.append(str(fpath))
-        collector = DefinitionCollector()
-        collector.visit(tree)
-
-        for name, def_type, lineno in collector.definitions:
-            rel_path = str(fpath.relative_to(path))
-            if name not in all_definitions:
-                all_definitions[name] = []
-            all_definitions[name].append({
-                "file": rel_path,
-                "line": lineno,
-                "type": def_type,
-            })
-
-    # Second pass: check each name for usage across entire repo
-    all_used_names = set()
-    for fpath_str in all_files:
-        try:
-            content = Path(fpath_str).read_text(errors="ignore")
-            tree = ast.parse(content)
-        except:
-            continue
-        usage = NameUsageCollector()
-        usage.visit(tree)
-        all_used_names.update(usage.names)
-        all_used_names.update(usage.calls)
-        all_used_names.update(usage.imports)
-
-    # Find dead code
-    for name, locations in all_definitions.items():
-        if name not in all_used_names:
-            for loc in locations:
-                if not is_safe_unused(name, loc["file"]):
-                    dead_code.append({
-                        "name": name,
-                        "type": loc["type"],
-                        "file": loc["file"],
-                        "line": loc["line"],
-                    })
-
-    return {
-        "repo": path.name,
-        "files_scanned": len(all_files),
-        "total_definitions": sum(len(v) for v in all_definitions.values()),
-        "dead_code_count": len(dead_code),
-        "dead_code": sorted(dead_code, key=lambda x: (x["file"], x["line"])),
-    }
-
-
-def main():
-    parser = argparse.ArgumentParser(description="Find dead code in Python codebases")
-    parser.add_argument("repo", help="Repository path to scan")
-    parser.add_argument("--format", choices=["text", "json"], default="text")
-    parser.add_argument("--exclude", help="Comma-separated patterns to exclude")
-    parser.add_argument("--git-blame", action="store_true", help="Include git blame info")
-    args = parser.parse_args()
-
-    exclude = args.exclude.split(",") if args.exclude else None
-    result = scan_repo(args.repo, exclude)
-
-    if args.format == "json":
-        print(json.dumps(result, indent=2))
-    else:
-        print(f"Dead Code Report: {result['repo']}")
-        print(f"Files scanned: {result['files_scanned']}")
-        print(f"Total definitions: {result['total_definitions']}")
-        print(f"Dead code found: {result['dead_code_count']}")
-        print()
-
-        if result["dead_code"]:
-            print(f"{'File':<45} {'Line':>4} {'Type':<10} {'Name'}")
-            print("-" * 85)
-            for item in result["dead_code"]:
-                author = ""
-                if args.git_blame:
-                    author = get_git_blame(
-                        os.path.join(args.repo, item["file"]),
-                        item["line"]
-                    ) or ""
-                    author = f" ({author})" if author else ""
-                print(f"{item['file']:<45} {item['line']:>4} {item['type']:<10} {item['name']}{author}")
-        else:
-            print("No dead code detected!")
-
-
-if __name__ == "__main__":
-    main()

scripts/gitea_issue_parser.py

@@ -0,0 +1,131 @@
+#!/usr/bin/env python3
+"""
+Gitea Issue Body Parser — Extract structured data from markdown issue bodies.
+
+Usage:
+    cat issue_body.txt | python3 scripts/gitea_issue_parser.py --stdin --pretty
+    python3 scripts/gitea_issue_parser.py --url https://forge.../api/v1/repos/.../issues/123 --pretty
+    python3 scripts/gitea_issue_parser.py body.txt --title "Fix thing (#42)" --labels pipeline extraction
+"""
+
+import argparse
+import json
+import re
+import sys
+from typing import Dict, List, Any, Optional
+
+
+def parse_issue_body(body: str, title: str = "", labels: List[str] = None) -> Dict[str, Any]:
+    """Parse a Gitea issue markdown body into structured JSON.
+    
+    Extracted fields:
+    - title: Issue title
+    - context: Background/description section
+    - criteria[]: Acceptance criteria (checkboxes or numbered lists)
+    - labels[]: Issue labels
+    - epic_ref: Parent/epic issue reference (from "Closes #N" or title)
+    - sections{}: All ## sections as key-value pairs
+    """
+    result = {
+        "title": title,
+        "context": "",
+        "criteria": [],
+        "labels": labels or [],
+        "epic_ref": None,
+        "sections": {},
+    }
+    
+    if not body:
+        return result
+    
+    # Extract epic reference from title or body
+    epic_patterns = [
+        r"(?:closes|fixes|addresses|refs?)\s+#(\d+)",
+        r"#(\d+)",
+    ]
+    for pattern in epic_patterns:
+        match = re.search(pattern, (title + " " + body).lower())
+        if match:
+            result["epic_ref"] = int(match.group(1))
+            break
+    
+    # Parse ## sections
+    section_pattern = r"^##\s+(.+?)$\n((?:^(?!##\s).*$\n?)*)"
+    for match in re.finditer(section_pattern, body, re.MULTILINE):
+        section_name = match.group(1).strip().lower().replace(" ", "_")
+        section_content = match.group(2).strip()
+        result["sections"][section_name] = section_content
+    
+    # Extract acceptance criteria (checkboxes)
+    checkbox_pattern = r"^\s*-\s*\[([ xX])\]\s*(.+)$"
+    for match in re.finditer(checkbox_pattern, body, re.MULTILINE):
+        checked = match.group(1).lower() == "x"
+        text = match.group(2).strip()
+        result["criteria"].append({"text": text, "checked": checked})
+    
+    # If no checkboxes, try numbered lists in "Acceptance Criteria" or "Criteria" section
+    if not result["criteria"]:
+        for section_name in ["acceptance_criteria", "criteria", "acceptance criteria"]:
+            if section_name in result["sections"]:
+                numbered = r"^\s*\d+\.\s*(.+)$"
+                for match in re.finditer(numbered, result["sections"][section_name], re.MULTILINE):
+                    result["criteria"].append({"text": match.group(1).strip(), "checked": False})
+                break
+    
+    # Extract context (first section or first paragraph before any ## heading)
+    first_heading = body.find("## ")
+    if first_heading > 0:
+        context_text = body[:first_heading].strip()
+    else:
+        context_text = body.split("\n\n")[0].strip()
+    # Clean up: remove "## Context" or "## Problem" header if present
+    context_text = re.sub(r"^#+\s*\w+\s*\n?", "", context_text).strip()
+    result["context"] = context_text[:500]  # Cap at 500 chars
+    
+    return result
+
+
+def fetch_issue_from_url(url: str) -> Dict[str, Any]:
+    """Fetch an issue from a Gitea API URL and parse it."""
+    import urllib.request
+    req = urllib.request.Request(url, headers={"Accept": "application/json"})
+    with urllib.request.urlopen(req) as resp:
+        data = json.loads(resp.read())
+    
+    return parse_issue_body(
+        body=data.get("body", ""),
+        title=data.get("title", ""),
+        labels=[l["name"] for l in data.get("labels", [])]
+    )
+
+
+def main():
+    parser = argparse.ArgumentParser(description="Parse Gitea issue markdown into structured JSON")
+    parser.add_argument("file", nargs="?", help="Issue body file (or use --stdin)")
+    parser.add_argument("--stdin", action="store_true", help="Read from stdin")
+    parser.add_argument("--url", help="Gitea API URL to fetch issue from")
+    parser.add_argument("--title", default="", help="Issue title")
+    parser.add_argument("--labels", nargs="*", default=[], help="Issue labels")
+    parser.add_argument("--pretty", action="store_true", help="Pretty-print JSON output")
+    
+    args = parser.parse_args()
+    
+    if args.url:
+        result = fetch_issue_from_url(args.url)
+    elif args.stdin:
+        body = sys.stdin.read()
+        result = parse_issue_body(body, args.title, args.labels)
+    elif args.file:
+        with open(args.file) as f:
+            body = f.read()
+        result = parse_issue_body(body, args.title, args.labels)
+    else:
+        parser.print_help()
+        sys.exit(1)
+    
+    indent = 2 if args.pretty else None
+    print(json.dumps(result, indent=indent))
+
+
+if __name__ == "__main__":
+    main()

scripts/test_gitea_issue_parser.py

@@ -0,0 +1,109 @@
+#!/usr/bin/env python3
+"""Tests for scripts/gitea_issue_parser.py"""
+
+import sys
+import os
+sys.path.insert(0, os.path.dirname(__file__) or ".")
+
+# Import from sibling
+import importlib.util
+spec = importlib.util.spec_from_file_location("parser", os.path.join(os.path.dirname(__file__) or ".", "gitea_issue_parser.py"))
+mod = importlib.util.module_from_spec(spec)
+spec.loader.exec_module(mod)
+parse_issue_body = mod.parse_issue_body
+
+
+def test_basic_parsing():
+    body = """## Context
+
+This is the background info.
+
+## Acceptance Criteria
+
+- [ ] First criterion
+- [x] Second criterion (done)
+
+## What to build
+
+Some description.
+"""
+    result = parse_issue_body(body, title="Test (#42)", labels=["bug"])
+    assert result["title"] == "Test (#42)"
+    assert result["labels"] == ["bug"]
+    assert result["epic_ref"] == 42
+    assert len(result["criteria"]) == 2
+    assert result["criteria"][0]["text"] == "First criterion"
+    assert result["criteria"][0]["checked"] == False
+    assert result["criteria"][1]["checked"] == True
+    assert "context" in result["sections"]
+    print("PASS: test_basic_parsing")
+
+
+def test_numbered_criteria():
+    body = """## Acceptance Criteria
+
+1. First item
+2. Second item
+3. Third item
+"""
+    result = parse_issue_body(body)
+    assert len(result["criteria"]) == 3
+    assert result["criteria"][0]["text"] == "First item"
+    print("PASS: test_numbered_criteria")
+
+
+def test_epic_ref_from_body():
+    body = "Closes #123\n\nSome description."
+    result = parse_issue_body(body)
+    assert result["epic_ref"] == 123
+    print("PASS: test_epic_ref_from_body")
+
+
+def test_empty_body():
+    result = parse_issue_body("")
+    assert result["criteria"] == []
+    assert result["context"] == ""
+    assert result["sections"] == {}
+    print("PASS: test_empty_body")
+
+
+def test_no_sections():
+    body = "Just a plain issue body with no headings."
+    result = parse_issue_body(body)
+    assert result["context"] == "Just a plain issue body with no headings."
+    print("PASS: test_no_sections")
+
+
+def test_multiple_sections():
+    body = """## Problem
+
+Something is broken.
+
+## Fix
+
+Do this instead.
+
+## Notes
+
+Additional info.
+"""
+    result = parse_issue_body(body)
+    assert "problem" in result["sections"]
+    assert "fix" in result["sections"]
+    assert "notes" in result["sections"]
+    assert "Something is broken" in result["sections"]["problem"]
+    print("PASS: test_multiple_sections")
+
+
+def run_all():
+    test_basic_parsing()
+    test_numbered_criteria()
+    test_epic_ref_from_body()
+    test_empty_body()
+    test_no_sections()
+    test_multiple_sections()
+    print("\nAll 6 tests passed!")
+
+
+if __name__ == "__main__":
+    run_all()