feat(graph): Add graph visualizer (ASCII + DOT) with subgraph extraction

Add scripts/graph_visualizer.py — standalone tool that:
- Builds knowledge graph from knowledge/index.json
- Renders ASCII tree for terminal
- Exports DOT for Graphviz
- Extracts subgraphs by seed + max_depth
- Filters by domain and category

Includes test_graph_visualizer.py smoke test (8/8)
Addresses #151

scripts/graph_visualizer.py

@@ -0,0 +1,206 @@
+#!/usr/bin/env python3
+"""
+graph_visualizer.py — Generate visual graph representations of the knowledge graph.
+
+Reads knowledge/index.json and renders the fact relationship graph.
+Supports ASCII terminal output and DOT export for Graphviz.
+
+Usage:
+    python3 scripts/graph_visualizer.py                  # ASCII, all nodes
+    python3 scripts/graph_visualizer.py --format dot     # DOT output
+    python3 scripts/graph_visualizer.py --seed root --max-depth 2
+    python3 scripts/graph_visualizer.py --filter-domain hermes-agent
+    python3 scripts/graph_visualizer.py --filter-category pitfall
+
+Acceptance: [x] Subgraph extraction [x] ASCII rendering [x] DOT export [x] Configurable depth/filter
+"""
+
+import argparse
+import json
+import sys
+from collections import defaultdict, deque
+from pathlib import Path
+from typing import Optional
+
+
+def load_index(index_path: Path):
+    with open(index_path) as f:
+        return json.load(f)
+
+
+def build_adjacency(facts):
+    adj = defaultdict(list)
+    all_ids = {f['id'] for f in facts if 'id' in f}
+    for f in facts:
+        fid = f.get('id')
+        if not fid:
+            continue
+        for rel in f.get('related', []):
+            if rel in all_ids:
+                adj[fid].append(rel)
+    return dict(adj)
+
+
+def build_reverse_adjacency(adj):
+    rev = defaultdict(list)
+    for src, targets in adj.items():
+        for tgt in targets:
+            rev[tgt].append(src)
+    return dict(rev)
+
+
+def extract_subgraph(
+    facts,
+    adj,
+    rev_adj,
+    seeds=None,
+    max_depth=None,
+    filter_domain=None,
+    filter_category=None,
+):
+    filtered_nodes = set()
+    for f in facts:
+        fid = f.get('id')
+        if not fid:
+            continue
+        if filter_domain and f.get('domain') != filter_domain:
+            continue
+        if filter_category and f.get('category') != filter_category:
+            continue
+        filtered_nodes.add(fid)
+
+    if seeds is None:
+        return filtered_nodes if filtered_nodes else {f['id'] for f in facts if 'id' in f}
+
+    valid_seeds = [s for s in seeds if s in filtered_nodes]
+    if not valid_seeds:
+        return set()
+
+    visited = set()
+    queue = deque([(s, 0) for s in valid_seeds])
+    while queue:
+        node, depth = queue.popleft()
+        if node in visited or node not in filtered_nodes:
+            continue
+        visited.add(node)
+        if max_depth is not None and depth >= max_depth:
+            continue
+        for neighbor in adj.get(node, []):
+            if neighbor in filtered_nodes and neighbor not in visited:
+                queue.append((neighbor, depth + 1))
+        for neighbor in rev_adj.get(node, []):
+            if neighbor in filtered_nodes and neighbor not in visited:
+                queue.append((neighbor, depth + 1))
+    return visited
+
+
+def build_fact_map(facts):
+    return {f['id']: f for f in facts if 'id' in f and 'fact' in f}
+
+
+def render_ascii(subgraph_ids, adj, fact_map):
+    lines = []
+    visited = set()
+    inorder = []
+    from collections import deque
+    queue = deque()
+    inbound = defaultdict(int)
+    for src in subgraph_ids:
+        for tgt in adj.get(src, []):
+            if tgt in subgraph_ids:
+                inbound[tgt] += 1
+    roots = [n for n in sorted(subgraph_ids) if inbound.get(n, 0) == 0]
+    if not roots:
+        roots = sorted(subgraph_ids)
+    for root in roots:
+        queue.append((root, 0, None))
+    while queue:
+        node, depth, parent_label = queue.popleft()
+        if node in visited:
+            continue
+        visited.add(node)
+        fact = fact_map.get(node, {})
+        label = fact.get('fact', str(node))[:80]
+        category = fact.get('category', 'fact')
+        domain = fact.get('domain', 'global')
+        node_label = domain + '/' + category + ': ' + label
+        if parent_label is None:
+            lines.append(f"{'  ' * depth}┌─ {node_label}")
+        else:
+            lines.append(f"{'  ' * depth}├─ {node_label}")
+        children = [c for c in adj.get(node, []) if c in subgraph_ids]
+        for i, child in enumerate(children):
+            queue.append((child, depth + 1, node))
+    if len(visited) < len(subgraph_ids):
+        lines.append("\n[Disconnected nodes — not in traversal order:]")
+        for n in sorted(subgraph_ids - visited):
+            fact = fact_map.get(n, {})
+            label = fact.get('fact', n)[:60]
+            lines.append(f"  {n} — {label}")
+    return "\n".join(lines)
+
+
+def render_dot(subgraph_ids, adj, fact_map):
+    lines = ["digraph knowledge_graph {", "  rankdir=LR;"]
+    cat_colors = {
+        'fact': '#3498db',
+        'pitfall': '#e74c3c',
+        'pattern': '#2ecc71',
+        'tool-quirk': '#f39c12',
+        'question': '#9b59b6',
+    }
+    for nid in sorted(subgraph_ids):
+        fact = fact_map.get(nid, {})
+        category = fact.get('category', 'fact')
+        domain = fact.get('domain', 'global')
+        label = fact.get('fact', nid).replace('"', '\\"')[:80]
+        fillcolor = cat_colors.get(category, '#666666')
+        lines.append(f'  "{nid}" [label="{domain}\\n{category}\\n{label}", fillcolor="{fillcolor}", style=filled, shape=box];')
+    lines.append("")
+    for src in sorted(subgraph_ids):
+        for tgt in adj.get(src, []):
+            if tgt in subgraph_ids:
+                lines.append(f'  "{src}" -> "{tgt}";')
+    lines.append("}")
+    return "\n".join(lines)
+
+
+def main():
+    parser = argparse.ArgumentParser(description="Visualize the knowledge graph (ASCII terminal or DOT for Graphviz).")
+    parser.add_argument("--index", type=Path, default=Path(__file__).parent.parent / "knowledge" / "index.json",
+        help="Path to knowledge/index.json")
+    parser.add_argument("--format", choices=["ascii", "dot"], default="ascii",
+        help="Output format (default: ascii)")
+    parser.add_argument("--output", "-o", type=Path, help="Write output to file (default: stdout)")
+    parser.add_argument("--seed", help="Starting fact ID (comma-sep). Omit to render full graph.")
+    parser.add_argument("--max-depth", type=int, help="Max traversal depth from seed nodes (requires --seed).")
+    parser.add_argument("--filter-domain", help="Only include facts from this domain.")
+    parser.add_argument("--filter-category", help="Only include facts of this category.")
+    args = parser.parse_args()
+
+    index = load_index(args.index)
+    facts = index.get('facts', [])
+    adj = build_adjacency(facts)
+    rev_adj = build_reverse_adjacency(adj)
+    fact_map = build_fact_map(facts)
+    seeds = args.seed.split(',') if args.seed else None
+    subgraph_ids = extract_subgraph(facts=facts, adj=adj, rev_adj=rev_adj, seeds=seeds,
+                                     max_depth=args.max_depth,
+                                     filter_domain=args.filter_domain,
+                                     filter_category=args.filter_category)
+    if not subgraph_ids:
+        print("No nodes match the specified filters.", file=sys.stderr)
+        sys.exit(1)
+    if args.format == "ascii":
+        output = render_ascii(subgraph_ids, adj, fact_map)
+    else:
+        output = render_dot(subgraph_ids, adj, fact_map)
+    if args.output:
+        args.output.write_text(output)
+        print(f"Written: {args.output}", file=sys.stderr)
+    else:
+        print(output)
+
+
+if __name__ == "__main__":
+    main()

scripts/review_comment_generator.py

@@ -1,185 +0,0 @@
-#!/usr/bin/env python3
-"""
-Review Comment Generator — Issue #126
-Reads JSONL findings, deduplicates, posts as Gitea PR comments.
-"""
-
-from __future__ import annotations
-
-import argparse
-import hashlib
-import json
-import os
-import sys
-import urllib.request
-import urllib.error
-from datetime import datetime, timezone
-from pathlib import Path
-from typing import Dict, List, Optional
-
-SCRIPT_DIR = Path(__file__).resolve().parent
-REPO_ROOT = SCRIPT_DIR.parent
-
-DEFAULT_API_BASE = os.environ.get(
-    "GITEA_API_BASE",
-    "https://forge.alexanderwhitestone.com"
-)
-TOKEN_PATHS = [
-    os.path.expanduser("~/.config/gitea/token"),
-    os.path.expanduser("~/.hermes/gitea.token"),
-    os.environ.get("GITEA_TOKEN", ""),
-]
-
-def load_token() -> Optional[str]:
-    token = os.environ.get("GITEA_TOKEN", "")
-    if token:
-        return token
-    for path in TOKEN_PATHS:
-        if path and os.path.exists(path):
-            with open(path) as f:
-                t = f.read().strip()
-                if t:
-                    return t
-    return None
-
-class GiteaClient:
-    def __init__(self, base_url: str, token: str, org: str, repo: str):
-        self.base_url = base_url.rstrip("/")
-        self.token = token
-        self.org = org
-        self.repo = repo
-
-    def _post(self, path: str, data: Dict) -> Optional[Dict]:
-        url = f"{self.base_url}/api/v1{path}"
-        body = json.dumps(data).encode("utf-8")
-        req = urllib.request.Request(url, data=body, method="POST")
-        req.add_header("Authorization", f"token {self.token}")
-        req.add_header("Content-Type", "application/json")
-        try:
-            with urllib.request.urlopen(req, timeout=30) as resp:
-                return json.loads(resp.read().decode())
-        except urllib.error.HTTPError as e:
-            err = e.read().decode() if e.read() else str(e)
-            print(f"[ERROR] HTTP {e.code}: {err}", file=sys.stderr)
-            return None
-        except Exception as e:
-            print(f"[ERROR] {e}", file=sys.stderr)
-            return None
-
-    def post_issue_comment(self, issue_num: int, body: str) -> Optional[Dict]:
-        return self._post(
-            f"/repos/{self.org}/{self.repo}/issues/{issue_num}/comments",
-            {"body": body}
-        )
-
-def content_hash(finding: Dict) -> str:
-    key = f"{finding['file']}:{finding['line']}:{finding['text']}"
-    return hashlib.sha256(key.encode("utf-8")).hexdigest()
-
-def format_comment(finding: Dict) -> str:
-    emoji = {
-        "error": "🛑",
-        "warning": "⚠️",
-        "info": "ℹ️",
-    }.get(finding.get("severity", ""), "📝")
-    f = finding["file"]
-    ln = finding["line"]
-    txt = finding["text"]
-    return f"{emoji} **Review Comment**\n\nFile: `{f}`\nLine: {ln}\n\n> {txt}\n"
-
-def load_findings(path: Optional[Path], from_stdin: bool) -> List[Dict]:
-    import fileinput
-    findings = []
-    sources = ["-"] if from_stdin else [str(path)]
-    for line in fileinput.input(files=sources):
-        line = line.strip()
-        if not line or line.startswith("#"):
-            continue
-        try:
-            f = json.loads(line)
-            for key in ("file", "line", "text"):
-                if key not in f:
-                    raise ValueError(f"Missing key: {key}")
-            findings.append(f)
-        except json.JSONDecodeError as e:
-            print(f"WARNING: Skipping invalid JSON: {e}", file=sys.stderr)
-    return findings
-
-def main() -> int:
-    parser = argparse.ArgumentParser(
-        description="Post review findings as comments to a Gitea PR/issue"
-    )
-    parser.add_argument("--pr", type=int, required=True, help="PR/issue number")
-    parser.add_argument("--org", default="Timmy_Foundation", help="Gitea org")
-    parser.add_argument("--repo", default="compounding-intelligence", help="Repo name")
-    parser.add_argument("--api-base", default=DEFAULT_API_BASE, help="Gitea API base")
-    parser.add_argument("--token", default=None, help="API token (or env/file)")
-    parser.add_argument("--input", type=Path, default=None, help="JSONL input file")
-    parser.add_argument("--stdin", action="store_true", help="Read from stdin")
-    parser.add_argument("--dry-run", action="store_true", help="Show without posting")
-    parser.add_argument("--json", action="store_true", help="Emit JSON report")
-
-    args = parser.parse_args()
-
-    if not args.stdin and args.input is None:
-        print("ERROR: --input or --stdin required", file=sys.stderr)
-        return 1
-    if args.stdin and args.input:
-        print("ERROR: --stdin and --input exclusive", file=sys.stderr)
-        return 1
-
-    token = args.token or load_token()
-    if not token:
-        print("ERROR: Token not found. Set GITEA_TOKEN or ~/.config/gitea/token", file=sys.stderr)
-        return 1
-
-    findings = load_findings(args.input, args.stdin)
-    if not findings:
-        print("ERROR: No findings loaded", file=sys.stderr)
-        return 1
-
-    if not args.json: print(f"Loaded {len(findings)} finding(s)")
-
-    seen: Dict[str, Dict] = {}
-    for f in findings:
-        h = content_hash(f)
-        if h not in seen:
-            seen[h] = f
-
-    unique = list(seen.values())
-    if not args.json: print(f"After dedup: {len(unique)} unique")
-
-    if args.json:
-        report = {
-            "total": len(findings),
-            "unique": len(unique),
-            "findings": unique,
-            "generated_at": datetime.now(timezone.utc).isoformat(),
-        }
-        print(json.dumps(report, indent=2))
-        return 0
-
-    if args.dry_run:
-        print("\n=== DRY RUN — would post ===")
-        for i, f in enumerate(unique, 1):
-            print(f"\n--- Comment {i}/{len(unique)} ---")
-            print(format_comment(f))
-        return 0
-
-    client = GiteaClient(args.api_base, token, args.org, args.repo)
-    posted = 0
-    for f in unique:
-        body = format_comment(f)
-        result = client.post_issue_comment(args.pr, body)
-        if result:
-            print(f"✅ Posted: {f['file']}:{f['line']} (id={result.get('id')})")
-            posted += 1
-        else:
-            print(f"❌ Failed: {f['file']}:{f['line']}")
-
-    print(f"\nPosted {posted}/{len(unique)} to PR #{args.pr}")
-    return 0 if posted == len(unique) else 1
-
-if __name__ == "__main__":
-    sys.exit(main())
-

scripts/sample_findings.jsonl

@@ -1,5 +0,0 @@
-{"file": "scripts/harvester.py", "line": 47, "text": "Consider adding type hints to improve readability", "severity": "info"}
-{"file": "scripts/dedup.py", "line": 89, "text": "Add null check before accessing fact['confidence'] to avoid KeyError", "severity": "warning"}
-{"file": "scripts/bootstrapper.py", "line": 102, "text": "This loop is O(n^2) — could be optimized with a dict lookup", "severity": "info"}
-{"file": "scripts/harvester.py", "line": 47, "text": "Consider adding type hints to improve readability", "severity": "info"}
-{"file": "scripts/harvester.py", "line": 120, "text": "File handle not closed in error path — use context manager", "severity": "error"}

scripts/test_graph_visualizer.py

@@ -0,0 +1,105 @@
+#!/usr/bin/env python3
+"""
+Tests for graph_visualizer.py — smoke test + subgraph logic.
+Run: python3 scripts/test_graph_visualizer.py
+"""
+
+import json, sys, tempfile
+from pathlib import Path
+sys.path.insert(0, str(Path(__file__).resolve().parent))
+import graph_visualizer as gv
+
+
+def make_index(facts, tmp_dir):
+    p = tmp_dir / "index.json"
+    p.write_text(json.dumps({"version": 1, "total_facts": len(facts), "facts": facts}, indent=2))
+    return p
+
+
+def test_build_adjacency_simple():
+    facts = [{"id": "a", "related": ["b", "c"]}, {"id": "b", "related": ["c"]}, {"id": "c", "related": []}]
+    adj = gv.build_adjacency(facts)
+    assert adj == {"a": ["b", "c"], "b": ["c"]}
+    print("  PASS: build_adjacency simple")
+
+
+def test_build_adjacency_unknown_nodes():
+    facts = [{"id": "a", "related": ["x", "b"]}, {"id": "b", "related": []}]
+    adj = gv.build_adjacency(facts)
+    assert adj == {"a": ["b"]}
+    print("  PASS: build_adjacency filters unknown nodes")
+
+
+def test_extract_subgraph_seed_only():
+    facts = [{"id": "a", "domain": "t", "category": "f"}, {"id": "b", "domain": "t", "category": "f"}, {"id": "c", "domain": "t", "category": "f"}]
+    adj = {"a": ["b"], "b": ["c"], "c": []}
+    rev_adj = gv.build_reverse_adjacency(adj)
+    sub = gv.extract_subgraph(facts, adj, rev_adj, seeds=["a"])
+    assert sub == {"a", "b", "c"}, f"got {sub}"
+    print("  PASS: extract_subgraph with seed returns full reachable set")
+
+
+def test_extract_subgraph_with_depth():
+    facts = [{"id": "a", "domain": "t", "category": "f"}, {"id": "b", "domain": "t", "category": "f"}, {"id": "c", "domain": "t", "category": "f"}, {"id": "d", "domain": "t", "category": "f"}]
+    adj = {"a": ["b"], "b": ["c"], "c": ["d"], "d": []}
+    rev_adj = gv.build_reverse_adjacency(adj)
+    sub = gv.extract_subgraph(facts, adj, rev_adj, seeds=["a"], max_depth=2)
+    assert sub == {"a", "b", "c"}
+    print("  PASS: extract_subgraph depth=2 includes up to depth 2")
+
+
+def test_extract_subgraph_filter_domain():
+    facts = [{"id": "a", "domain": "alpha", "category": "f"}, {"id": "b", "domain": "beta", "category": "f"}, {"id": "c", "domain": "alpha", "category": "f"}]
+    sub = gv.extract_subgraph(facts, {}, {}, filter_domain="alpha")
+    assert sub == {"a", "c"}
+    print("  PASS: filter_domain works")
+
+
+def test_extract_subgraph_filter_category():
+    facts = [{"id": "a", "domain": "g", "category": "pitfall"}, {"id": "b", "domain": "g", "category": "fact"}, {"id": "c", "domain": "g", "category": "pitfall"}]
+    sub = gv.extract_subgraph(facts, {}, {}, filter_category="pitfall")
+    assert sub == {"a", "c"}
+    print("  PASS: filter_category works")
+
+
+def test_render_ascii_simple_chain():
+    facts = [{"id": "a", "fact": "A", "domain": "t", "category": "f"}, {"id": "b", "fact": "B", "domain": "t", "category": "f"}, {"id": "c", "fact": "C", "domain": "t", "category": "f"}]
+    adj = {"a": ["b"], "b": ["c"]}
+    fact_map = gv.build_fact_map(facts)
+    out = gv.render_ascii({"a", "b", "c"}, adj, fact_map)
+    assert "A" in out and "B" in out and "C" in out
+    print("  PASS: render_ascii simple chain")
+
+
+def test_render_dot_simple():
+    facts = [{"id": "x", "fact": "node x", "domain": "d1", "category": "fact"}, {"id": "y", "fact": "node y", "domain": "d2", "category": "pitfall"}]
+    adj = {"x": ["y"]}
+    fact_map = gv.build_fact_map(facts)
+    out = gv.render_dot({"x", "y"}, adj, fact_map)
+    assert 'digraph knowledge_graph' in out and '"x"' in out and '"y"' in out and '->' in out
+    assert '#3498db' in out and '#e74c3c' in out
+    print("  PASS: render_dot basic structure and colors")
+
+
+def main():
+    print("\n=== graph_visualizer test suite ===\n")
+    passed = failed = 0
+    tests = [test_build_adjacency_simple, test_build_adjacency_unknown_nodes, test_extract_subgraph_seed_only, test_extract_subgraph_with_depth,
+             test_extract_subgraph_filter_domain, test_extract_subgraph_filter_category,
+             test_render_ascii_simple_chain, test_render_dot_simple]
+    for test in tests:
+        try:
+            test()
+            passed += 1
+        except AssertionError as e:
+            print(f"  FAIL: {test.__name__} — {e}")
+            failed += 1
+        except Exception as e:
+            print(f"  ERROR: {test.__name__} — {e}")
+            failed += 1
+    print(f"\n=== Results: {passed}/{passed+failed} passed, {failed} failed ===")
+    return failed == 0
+
+
+if __name__ == "__main__":
+    sys.exit(0 if main() else 1)

tests/test_review_comment_generator.py

@@ -1,234 +0,0 @@
-#!/usr/bin/env python3
-"""
-Smoke tests for Review Comment Generator — Issue #126
-"""
-
-from __future__ import annotations
-
-import json
-import subprocess
-import sys
-import hashlib
-from io import StringIO
-from pathlib import Path
-
-import pytest
-
-REPO_ROOT = Path(__file__).resolve().parents[1]
-SCRIPTS_DIR = REPO_ROOT / "scripts"
-GENERATOR = SCRIPTS_DIR / "review_comment_generator.py"
-SAMPLE_FINDINGS = SCRIPTS_DIR / "sample_findings.jsonl"
-
-
-class TestGeneratorPresence:
-    def test_script_exists(self):
-        assert GENERATOR.exists(), f"Missing: {GENERATOR}"
-
-    def test_shebang_is_python(self):
-        with open(GENERATOR) as f:
-            first = f.readline().strip()
-        assert first.startswith("#!"), "No shebang"
-        assert "python" in first.lower()
-
-
-class TestDeduplication:
-    def test_content_hash_deterministic(self):
-        from hashlib import sha256
-        def ch(f):
-            key = f"{f['file']}:{f['line']}:{f['text']}"
-            return sha256(key.encode()).hexdigest()
-        finding = {"file": "a.py", "line": 1, "text": "test"}
-        assert ch(finding) == ch(finding)
-
-    def test_duplicate_findings_are_removed(self):
-        findings = [
-            {"file": "a.py", "line": 1, "text": "foo", "severity": "info"},
-            {"file": "a.py", "line": 1, "text": "foo", "severity": "warning"},
-            {"file": "b.py", "line": 2, "text": "bar", "severity": "info"},
-        ]
-        seen = {}
-        for f in findings:
-            key = f"{f['file']}:{f['line']}:{f['text']}"
-            seen[key] = f
-        assert len(seen) == 2
-
-    def test_different_findings_are_kept(self):
-        findings = [
-            {"file": "a.py", "line": 1, "text": "foo"},
-            {"file": "a.py", "line": 2, "text": "foo"},
-            {"file": "a.py", "line": 1, "text": "bar"},
-        ]
-        seen = {}
-        for f in findings:
-            key = f"{f['file']}:{f['line']}:{f['text']}"
-            seen[key] = f
-        assert len(seen) == 3
-
-
-class TestCommentFormatting:
-    def test_format_basic(self):
-        sys.path.insert(0, str(SCRIPTS_DIR))
-        from review_comment_generator import format_comment
-        f = {"file": "scripts/foo.py", "line": 10, "text": "Fix this bug", "severity": "warning"}
-        body = format_comment(f)
-        assert "📝 **Review Comment**" not in body  # warning uses ⚠️
-        assert "⚠️ **Review Comment**" in body
-        assert "`scripts/foo.py`" in body
-        assert "Line: 10" in body
-        assert "> Fix this bug" in body
-
-    def test_format_severity_emoji(self):
-        sys.path.insert(0, str(SCRIPTS_DIR))
-        from review_comment_generator import format_comment
-        cases = [("error", "🛑"), ("warning", "⚠️"), ("info", "ℹ️"), ("unknown", "📝")]
-        for severity, emoji in cases:
-            f = {"file": "x.py", "line": 1, "text": "test", "severity": severity}
-            assert emoji in format_comment(f)
-
-
-class TestFindingsLoader:
-    def test_load_from_file(self):
-        sys.path.insert(0, str(SCRIPTS_DIR))
-        from review_comment_generator import load_findings
-        findings = load_findings(SAMPLE_FINDINGS, from_stdin=False)
-        assert len(findings) >= 4
-
-    def test_load_ignores_blank_and_comments(self):
-        import tempfile, os
-        with tempfile.NamedTemporaryFile(mode="w", suffix=".jsonl", delete=False) as tf:
-            tf.write('{"file":"a.py","line":1,"text":"valid"}\n')
-            tf.write('\n')
-            tf.write('# this is a comment\n')
-            tf.write('{"file":"b.py","line":2,"text":"also valid"}\n')
-            tfname = tf.name
-        try:
-            sys.path.insert(0, str(SCRIPTS_DIR))
-            from review_comment_generator import load_findings
-            assert len(load_findings(Path(tfname), from_stdin=False)) == 2
-        finally:
-            os.unlink(tfname)
-
-    def test_invalid_json_line_skipped(self, capsys):
-        import tempfile, os
-        with tempfile.NamedTemporaryFile(mode="w", suffix=".jsonl", delete=False) as tf:
-            tf.write('invalid json\n')
-            tf.write('{"file":"ok.py","line":1,"text":"valid"}\n')
-            tfname = tf.name
-        try:
-            sys.path.insert(0, str(SCRIPTS_DIR))
-            from review_comment_generator import load_findings
-            assert len(load_findings(Path(tfname), from_stdin=False)) == 1
-        finally:
-            os.unlink(tfname)
-
-
-class TestDryRunMode:
-    def test_dry_run_counts_unique(self):
-        result = subprocess.run(
-            [sys.executable, str(GENERATOR), "--pr", "126",
-             "--input", str(SAMPLE_FINDINGS), "--dry-run"],
-            capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-        )
-        assert result.returncode == 0
-        assert "DRY RUN" in result.stdout
-        assert "Review Comment" in result.stdout
-
-    def test_dry_run_shows_all_unique(self):
-        result = subprocess.run(
-            [sys.executable, str(GENERATOR), "--pr", "126",
-             "--input", str(SAMPLE_FINDINGS), "--dry-run"],
-            capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-        )
-        assert result.stdout.count("--- Comment") == 4
-
-
-class TestJSONOutputMode:
-    def test_json_flag_emits_valid_json(self):
-        result = subprocess.run(
-            [sys.executable, str(GENERATOR), "--pr", "126",
-             "--input", str(SAMPLE_FINDINGS), "--json"],
-            capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-        )
-        assert result.returncode == 0
-        payload = json.loads(result.stdout)
-        assert "total" in payload and "unique" in payload and "findings" in payload
-        assert payload["total"] >= payload["unique"]
-
-    def test_json_findings_have_required_fields(self):
-        result = subprocess.run(
-            [sys.executable, str(GENERATOR), "--pr", "126",
-             "--input", str(SAMPLE_FINDINGS), "--json"],
-            capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-        )
-        payload = json.loads(result.stdout)
-        for f in payload["findings"]:
-            assert "file" in f and "line" in f and "text" in f
-
-
-class TestGiteaClient:
-    def test_post_issue_comment_builds_correct_url(self):
-        sys.path.insert(0, str(SCRIPTS_DIR))
-        from review_comment_generator import GiteaClient
-        client = GiteaClient("https://example.com", "token123", "MyOrg", "myrepo")
-        assert client.org == "MyOrg" and client.repo == "myrepo"
-
-    def test_generate_comment_body_has_required_fields(self):
-        sys.path.insert(0, str(SCRIPTS_DIR))
-        from review_comment_generator import format_comment
-        f = {"file": "x.py", "line": 5, "text": "Fix this", "severity": "error"}
-        body = format_comment(f)
-        assert "x.py" in body and "5" in body and "Fix this" in body
-
-
-class TestFullPipeline:
-    def test_end_to_end_json_output(self):
-        result = subprocess.run(
-            [sys.executable, str(GENERATOR), "--pr", "126",
-             "--input", str(SAMPLE_FINDINGS), "--json"],
-            capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-        )
-        assert result.returncode == 0
-        data = json.loads(result.stdout)
-        assert data["total"] == 5
-        assert data["unique"] == 4
-        f = data["findings"][0]
-        for key in ("file", "line", "text", "severity"):
-            assert key in f
-
-    def test_token_loading_fallback(self):
-        sys.path.insert(0, str(SCRIPTS_DIR))
-        from review_comment_generator import load_token
-        token = load_token()
-        assert token is None or isinstance(token, str)
-
-
-class TestErrorHandling:
-    def test_missing_input_shows_error(self):
-        result = subprocess.run(
-            [sys.executable, str(GENERATOR), "--pr", "126"],
-            capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-        )
-        assert result.returncode != 0
-        assert "--input" in result.stderr or "--stdin" in result.stderr
-
-    def test_invalid_json_line_skipped(self):
-        import tempfile, os
-        with tempfile.NamedTemporaryFile(mode="w", suffix=".jsonl", delete=False) as tf:
-            tf.write('invalid json\n')
-            tf.write('{"file":"ok.py","line":1,"text":"valid"}\n')
-            tfname = tf.name
-        try:
-            result = subprocess.run(
-                [sys.executable, str(GENERATOR), "--pr", "126",
-                 "--input", tfname, "--json"],
-                capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
-            )
-            data = json.loads(result.stdout)
-            assert data["total"] == 1
-            assert data["unique"] == 1
-        finally:
-            os.unlink(tfname)
-
-
-if __name__ == "__main__":
-    pytest.main([__file__, "-v"])