Compare commits
1 Commits
step35/205
...
step35/126
| Author | SHA1 | Date | |
|---|---|---|---|
|
e2b1a9f8ac |
@@ -1,418 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
knowledge_synthesizer.py — Zero-shot knowledge synthesis for compounding intelligence.
|
||||
|
||||
Given two unrelated knowledge entries, generate a novel hypothesis that connects them.
|
||||
Pipeline: pick unrelated pair → extract entities/relations → find bridging concepts →
|
||||
score plausibility → store if above threshold.
|
||||
|
||||
Usage:
|
||||
python3 scripts/knowledge_synthesizer.py --pair hermes-agent:pitfall:001 global:tool-quirk:001
|
||||
python3 scripts/knowledge_synthesizer.py --auto --threshold 0.75
|
||||
python3 scripts/knowledge_synthesizer.py --dry-run # show candidate pair without synthesizing
|
||||
"""
|
||||
|
||||
import argparse
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import time
|
||||
import hashlib
|
||||
from datetime import datetime, timezone
|
||||
from pathlib import Path
|
||||
from typing import Optional, Tuple, List, Dict
|
||||
|
||||
SCRIPT_DIR = Path(__file__).parent.absolute()
|
||||
sys.path.insert(0, str(SCRIPT_DIR))
|
||||
|
||||
REPO_ROOT = SCRIPT_DIR.parent
|
||||
KNOWLEDGE_DIR = REPO_ROOT / "knowledge"
|
||||
TEMPLATE_PATH = SCRIPT_DIR.parent / "templates" / "synthesis-prompt.md"
|
||||
|
||||
# Default API configuration
|
||||
DEFAULT_API_BASE = os.environ.get(
|
||||
"SYNTHESIS_API_BASE",
|
||||
os.environ.get("HARVESTER_API_BASE", "https://api.nousresearch.com/v1")
|
||||
)
|
||||
DEFAULT_API_KEY = os.environ.get("SYNTHESIS_API_KEY", "")
|
||||
DEFAULT_MODEL = os.environ.get(
|
||||
"SYNTHESIS_MODEL",
|
||||
os.environ.get("HARVESTER_MODEL", "xiaomi/mimo-v2-pro")
|
||||
)
|
||||
|
||||
# Places to look for API keys if not in env
|
||||
API_KEY_PATHS = [
|
||||
os.path.expanduser("~/.config/nous/key"),
|
||||
os.path.expanduser("~/.hermes/keymaxxing/active/minimax.key"),
|
||||
os.path.expanduser("~/.config/openrouter/key"),
|
||||
]
|
||||
|
||||
|
||||
def find_api_key() -> str:
|
||||
for path in API_KEY_PATHS:
|
||||
if os.path.exists(path):
|
||||
with open(path) as f:
|
||||
key = f.read().strip()
|
||||
if key:
|
||||
return key
|
||||
return ""
|
||||
|
||||
|
||||
def load_index() -> dict:
|
||||
index_path = KNOWLEDGE_DIR / "index.json"
|
||||
if not index_path.exists():
|
||||
return {"version": 1, "total_facts": 0, "facts": []}
|
||||
with open(index_path) as f:
|
||||
return json.load(f)
|
||||
|
||||
|
||||
def save_index(index: dict) -> None:
|
||||
KNOWLEDGE_DIR.mkdir(parents=True, exist_ok=True)
|
||||
index_path = KNOWLEDGE_DIR / "index.json"
|
||||
with open(index_path, 'w', encoding='utf-8') as f:
|
||||
json.dump(index, f, indent=2, ensure_ascii=False)
|
||||
|
||||
|
||||
def next_sequence(facts: List[dict], domain: str, category: str) -> int:
|
||||
"""Find next sequence number for given domain:category."""
|
||||
prefix = f"{domain}:{category}:"
|
||||
max_seq = 0
|
||||
for fact in facts:
|
||||
fid = fact.get('id', '')
|
||||
if fid.startswith(prefix):
|
||||
try:
|
||||
seq = int(fid.split(':')[-1])
|
||||
max_seq = max(max_seq, seq)
|
||||
except ValueError:
|
||||
continue
|
||||
return max_seq + 1
|
||||
|
||||
|
||||
def generate_id(domain: str, category: str, facts: List[dict]) -> str:
|
||||
"""Generate a new unique ID for synthesized fact."""
|
||||
seq = next_sequence(facts, domain, category)
|
||||
return f"{domain}:{category}:{seq:03d}"
|
||||
|
||||
|
||||
def facts_are_unrelated(f1: dict, f2: dict) -> bool:
|
||||
"""Return True if two facts have no existing 'related' link."""
|
||||
id1, id2 = f1['id'], f2['id']
|
||||
rel1 = set(f1.get('related', []))
|
||||
rel2 = set(f2.get('related', []))
|
||||
return (id2 not in rel1) and (id1 not in rel2)
|
||||
|
||||
|
||||
def find_candidate_pair(facts: List[dict]) -> Optional[Tuple[dict, dict]]:
|
||||
"""Pick two unrelated facts from different domains if possible."""
|
||||
# Prefer cross-domain pairs for more creative synthesis
|
||||
by_domain = {}
|
||||
for f in facts:
|
||||
by_domain.setdefault(f['domain'], []).append(f)
|
||||
|
||||
domains = list(by_domain.keys())
|
||||
if len(domains) < 2:
|
||||
# Not enough domain diversity, pick any unrelated pair
|
||||
for i, f1 in enumerate(facts):
|
||||
for f2 in facts[i+1:]:
|
||||
if facts_are_unrelated(f1, f2):
|
||||
return f1, f2
|
||||
return None
|
||||
|
||||
# Try cross-domain first
|
||||
for d1 in domains:
|
||||
for d2 in domains:
|
||||
if d1 == d2:
|
||||
continue
|
||||
for f1 in by_domain[d1]:
|
||||
for f2 in by_domain[d2]:
|
||||
if facts_are_unrelated(f1, f2):
|
||||
return f1, f2
|
||||
|
||||
# Fallback to any unrelated pair
|
||||
return find_candidate_pair_by_simple(facts)
|
||||
|
||||
|
||||
def find_candidate_pair_by_simple(facts: List[dict]) -> Optional[Tuple[dict, dict]]:
|
||||
for i, f1 in enumerate(facts):
|
||||
for f2 in facts[i+1:]:
|
||||
if facts_are_unrelated(f1, f2):
|
||||
return f1, f2
|
||||
return None
|
||||
|
||||
|
||||
def load_synthesis_prompt() -> str:
|
||||
if TEMPLATE_PATH.exists():
|
||||
return TEMPLATE_PATH.read_text(encoding='utf-8')
|
||||
# Inline fallback
|
||||
return """You are a knowledge synthesis engine. Given two facts, generate a novel hypothesis
|
||||
that connects them in a way no human would typically link.
|
||||
|
||||
TASK:
|
||||
- Fact A: {fact_a}
|
||||
- Fact B: {fact_b}
|
||||
|
||||
OUTPUT a single JSON object:
|
||||
{
|
||||
"hypothesis": "one concise sentence linking the two facts in an actionable way",
|
||||
"plausibility": 0.0-1.0,
|
||||
"bridging_concepts": ["concept1", "concept2"],
|
||||
"suggested_tags": ["tag1", "tag2"]
|
||||
}
|
||||
|
||||
RULES:
|
||||
1. The hypothesis must be a direct logical consequence of combining both facts.
|
||||
2. Do NOT restate either fact — produce a new insight.
|
||||
3. Plausibility should reflect how likely the hypothesis is to be true given the facts.
|
||||
4. If no meaningful connection exists, return {"hypothesis":"","plausibility":0.0}.
|
||||
5. Output ONLY valid JSON, no markdown.
|
||||
"""
|
||||
|
||||
|
||||
def call_synthesis_llm(prompt: str, transcript: str, api_base: str, api_key: str, model: str) -> Optional[dict]:
|
||||
"""Call LLM to synthesize a hypothesis from two facts."""
|
||||
import urllib.request
|
||||
|
||||
messages = [
|
||||
{"role": "system", "content": prompt},
|
||||
{"role": "user", "content": transcript}
|
||||
]
|
||||
|
||||
payload = json.dumps({
|
||||
"model": model,
|
||||
"messages": messages,
|
||||
"temperature": 0.7, # More creative for synthesis
|
||||
"max_tokens": 512
|
||||
}).encode('utf-8')
|
||||
|
||||
req = urllib.request.Request(
|
||||
f"{api_base}/chat/completions",
|
||||
data=payload,
|
||||
headers={
|
||||
"Authorization": f"Bearer {api_key}",
|
||||
"Content-Type": "application/json"
|
||||
},
|
||||
method="POST"
|
||||
)
|
||||
|
||||
try:
|
||||
with urllib.request.urlopen(req, timeout=60) as resp:
|
||||
result = json.loads(resp.read().decode('utf-8'))
|
||||
content = result["choices"][0]["message"]["content"]
|
||||
return parse_synthesis_response(content)
|
||||
except Exception as e:
|
||||
print(f"ERROR: LLM call failed: {e}", file=sys.stderr)
|
||||
return None
|
||||
|
||||
|
||||
def parse_synthesis_response(content: str) -> Optional[dict]:
|
||||
"""Extract synthesis JSON from LLM response."""
|
||||
try:
|
||||
data = json.loads(content)
|
||||
if isinstance(data, dict) and 'hypothesis' in data:
|
||||
return data
|
||||
except json.JSONDecodeError:
|
||||
pass
|
||||
|
||||
import re
|
||||
json_match = re.search(r'```(?:json)?\s*({.*?})\s*```', content, re.DOTALL)
|
||||
if json_match:
|
||||
try:
|
||||
data = json.loads(json_match.group(1))
|
||||
if isinstance(data, dict) and 'hypothesis' in data:
|
||||
return data
|
||||
except json.JSONDecodeError:
|
||||
pass
|
||||
|
||||
# Try finding any JSON object
|
||||
json_match = re.search(r'(\{.*"hypothesis".*\})', content, re.DOTALL)
|
||||
if json_match:
|
||||
try:
|
||||
return json.loads(json_match.group(1))
|
||||
except json.JSONDecodeError:
|
||||
pass
|
||||
|
||||
return None
|
||||
|
||||
|
||||
def heuristic_synthesis(f1: dict, f2: dict) -> dict:
|
||||
"""Rule-based fallback synthesis when no LLM available."""
|
||||
# Simple bridging: combine tags and domains
|
||||
tags = list(set(f1.get('tags', []) + f2.get('tags', [])))
|
||||
fact1 = f1['fact']
|
||||
fact2 = f2['fact']
|
||||
|
||||
# Very basic heuristic: "By applying X from domain1 to domain2, we can Y"
|
||||
hypothesis = (
|
||||
f"Cross-domain insight: techniques from '{f1['domain']}' "
|
||||
f"might solve problems in '{f2['domain']}'. "
|
||||
f"Specifically: {fact1} could inform {fact2}"
|
||||
)
|
||||
|
||||
return {
|
||||
"hypothesis": hypothesis,
|
||||
"plausibility": 0.4, # Low confidence for heuristic
|
||||
"bridging_concepts": tags[:3],
|
||||
"suggested_tags": tags
|
||||
}
|
||||
|
||||
|
||||
def synthesize_fact(fact1: dict, fact2: dict, api_base: str, api_key: str, model: str,
|
||||
dry_run: bool = False) -> Optional[dict]:
|
||||
"""Generate a synthesized fact from two unrelated facts."""
|
||||
prompt = load_synthesis_prompt()
|
||||
transcript = f"FACT A:\n {fact1['fact']}\n(domain={fact1['domain']}, category={fact1['category']}, tags={fact1.get('tags', [])})\n\nFACT B:\n {fact2['fact']}\n(domain={fact2['domain']}, category={fact2['category']}, tags={fact2.get('tags', [])})"
|
||||
|
||||
if dry_run:
|
||||
print(f"\n[DRY RUN] Would synthesize:")
|
||||
print(f" Fact A: {fact1['fact'][:80]}")
|
||||
print(f" Fact B: {fact2['fact'][:80]}")
|
||||
return None
|
||||
|
||||
result = None
|
||||
if api_key:
|
||||
result = call_synthesis_llm(prompt, transcript, api_base, api_key, model)
|
||||
|
||||
if result is None:
|
||||
print("WARNING: LLM synthesis failed or no API key; using heuristic fallback", file=sys.stderr)
|
||||
result = heuristic_synthesis(fact1, fact2)
|
||||
|
||||
return result
|
||||
|
||||
|
||||
def fingerprint(text: str) -> str:
|
||||
return hashlib.md5(text.lower().strip().encode('utf-8')).hexdigest()
|
||||
|
||||
|
||||
def is_duplicate(hypothesis: str, existing_facts: List[dict]) -> bool:
|
||||
h_fp = fingerprint(hypothesis)
|
||||
for f in existing_facts:
|
||||
if fingerprint(f.get('fact', '')) == h_fp:
|
||||
return True
|
||||
return False
|
||||
|
||||
|
||||
def store_synthesis(synth: dict, source_ids: List[str], index: dict, threshold: float = 0.5) -> bool:
|
||||
"""Store synthesized fact if plausibility exceeds threshold."""
|
||||
plaus = synth.get('plausibility', 0.0)
|
||||
if plaus < threshold:
|
||||
print(f"Skipped: plausibility {plaus:.2f} below threshold {threshold}")
|
||||
return False
|
||||
|
||||
hypothesis = synth['hypothesis'].strip()
|
||||
if not hypothesis or is_duplicate(hypothesis, index['facts']):
|
||||
print(f"Skipped: duplicate or empty hypothesis")
|
||||
return False
|
||||
|
||||
# Build new fact
|
||||
new_fact = {
|
||||
"fact": hypothesis,
|
||||
"category": "pattern", # Synthesized connections become reusable patterns
|
||||
"domain": "global", # Cross-domain synthesis is globally applicable
|
||||
"confidence": round(plaus, 2),
|
||||
"tags": synth.get('suggested_tags', []),
|
||||
"related": source_ids,
|
||||
"first_seen": datetime.now(timezone.utc).strftime("%Y-%m-%d"),
|
||||
"last_confirmed": datetime.now(timezone.utc).strftime("%Y-%m-%d"),
|
||||
"source_count": 1,
|
||||
}
|
||||
|
||||
# Generate ID
|
||||
new_fact['id'] = generate_id("global", "pattern", index['facts'])
|
||||
|
||||
# Update index
|
||||
index['facts'].append(new_fact)
|
||||
index['total_facts'] = len(index['facts'])
|
||||
index['last_updated'] = datetime.now(timezone.utc).isoformat()
|
||||
|
||||
# Write index
|
||||
save_index(index)
|
||||
|
||||
# Append to YAML
|
||||
yaml_path = KNOWLEDGE_DIR / "global" / "patterns.yaml"
|
||||
yaml_path.parent.mkdir(parents=True, exist_ok=True)
|
||||
mode = 'a' if yaml_path.exists() else 'w'
|
||||
with open(yaml_path, mode, encoding='utf-8') as f:
|
||||
if mode == 'w':
|
||||
f.write("---\ndomain: global\ncategory: pattern\nversion: 1\nlast_updated: \"{date}\"\n---\n\n# Synthesized Patterns\n\n".format(date=datetime.now(timezone.utc).strftime("%Y-%m-%d")))
|
||||
f.write(f"\n- id: {new_fact['id']}\n")
|
||||
f.write(f" fact: \"{hypothesis}\"\n")
|
||||
f.write(f" confidence: {plaus}\n")
|
||||
if new_fact['tags']:
|
||||
f.write(f" tags: {json.dumps(new_fact['tags'])}\n")
|
||||
f.write(f" related: {json.dumps(source_ids)}\n")
|
||||
f.write(f" first_seen: \"{new_fact['first_seen']}\"\n")
|
||||
f.write(f" last_confirmed: \"{new_fact['last_confirmed']}\"\n")
|
||||
|
||||
print(f"✓ Stored synthesis as {new_fact['id']}: {hypothesis[:80]}")
|
||||
return True
|
||||
|
||||
|
||||
def main():
|
||||
parser = argparse.ArgumentParser(description="Zero-shot knowledge synthesis")
|
||||
parser.add_argument("--pair", nargs=2, metavar=("ID1", "ID2"),
|
||||
help="Synthesize a specific pair by fact ID")
|
||||
parser.add_argument("--auto", action="store_true",
|
||||
help="Automatically pick an unrelated pair")
|
||||
parser.add_argument("--threshold", type=float, default=0.6,
|
||||
help="Plausibility threshold for storage (default: 0.6)")
|
||||
parser.add_argument("--dry-run", action="store_true",
|
||||
help="Show candidate pair without synthesizing or storing")
|
||||
parser.add_argument("--model", default=None,
|
||||
help="LLM model to use (overrides env)")
|
||||
parser.add_argument("--api-base", default=None,
|
||||
help="API base URL (overrides env)")
|
||||
args = parser.parse_args()
|
||||
|
||||
# Resolve API credentials
|
||||
api_base = args.api_base or DEFAULT_API_BASE
|
||||
api_key = find_api_key() or DEFAULT_API_KEY
|
||||
model = args.model or DEFAULT_MODEL
|
||||
|
||||
if not args.dry_run and not args.pair and not args.auto:
|
||||
print("ERROR: Must specify either --pair ID1 ID2 or --auto", file=sys.stderr)
|
||||
parser.print_help()
|
||||
sys.exit(1)
|
||||
|
||||
# Load index
|
||||
index = load_index()
|
||||
facts = index['facts']
|
||||
|
||||
if len(facts) < 2:
|
||||
print("ERROR: Need at least 2 facts in knowledge store to synthesize", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
|
||||
# Select facts
|
||||
f1, f2 = None, None
|
||||
if args.pair:
|
||||
id1, id2 = args.pair
|
||||
f1 = next((f for f in facts if f['id'] == id1), None)
|
||||
f2 = next((f for f in facts if f['id'] == id2), None)
|
||||
if not f1 or not f2:
|
||||
print(f"ERROR: Could not find facts with IDs {id1}, {id2}", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
if not facts_are_unrelated(f1, f2):
|
||||
print(f"WARNING: Facts {id1} and {id2} are already related (may still synthesize)")
|
||||
else:
|
||||
# auto mode
|
||||
pair = find_candidate_pair(facts)
|
||||
if pair is None:
|
||||
print("ERROR: No unrelated fact pairs found — consider lowering threshold or adding more facts", file=sys.stderr)
|
||||
sys.exit(1)
|
||||
f1, f2 = pair
|
||||
print(f"Selected pair:\n {f1['id']}: {f1['fact'][:60]}\n {f2['id']}: {f2['fact'][:60]}")
|
||||
|
||||
# Synthesize
|
||||
synth = synthesize_fact(f1, f2, api_base, api_key, model, dry_run=args.dry_run)
|
||||
if synth is None:
|
||||
sys.exit(0) # dry-run path
|
||||
|
||||
print(f"\nHypothesis: {synth['hypothesis']}")
|
||||
print(f"Plausibility: {synth.get('plausibility', 0.0):.2f}")
|
||||
print(f"Bridging concepts: {synth.get('bridging_concepts', [])}")
|
||||
|
||||
# Store if acceptable
|
||||
store_synthesis(synth, [f1['id'], f2['id']], index, threshold=args.threshold)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
main()
|
||||
185
scripts/review_comment_generator.py
Executable file
185
scripts/review_comment_generator.py
Executable file
@@ -0,0 +1,185 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Review Comment Generator — Issue #126
|
||||
Reads JSONL findings, deduplicates, posts as Gitea PR comments.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import argparse
|
||||
import hashlib
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import urllib.request
|
||||
import urllib.error
|
||||
from datetime import datetime, timezone
|
||||
from pathlib import Path
|
||||
from typing import Dict, List, Optional
|
||||
|
||||
SCRIPT_DIR = Path(__file__).resolve().parent
|
||||
REPO_ROOT = SCRIPT_DIR.parent
|
||||
|
||||
DEFAULT_API_BASE = os.environ.get(
|
||||
"GITEA_API_BASE",
|
||||
"https://forge.alexanderwhitestone.com"
|
||||
)
|
||||
TOKEN_PATHS = [
|
||||
os.path.expanduser("~/.config/gitea/token"),
|
||||
os.path.expanduser("~/.hermes/gitea.token"),
|
||||
os.environ.get("GITEA_TOKEN", ""),
|
||||
]
|
||||
|
||||
def load_token() -> Optional[str]:
|
||||
token = os.environ.get("GITEA_TOKEN", "")
|
||||
if token:
|
||||
return token
|
||||
for path in TOKEN_PATHS:
|
||||
if path and os.path.exists(path):
|
||||
with open(path) as f:
|
||||
t = f.read().strip()
|
||||
if t:
|
||||
return t
|
||||
return None
|
||||
|
||||
class GiteaClient:
|
||||
def __init__(self, base_url: str, token: str, org: str, repo: str):
|
||||
self.base_url = base_url.rstrip("/")
|
||||
self.token = token
|
||||
self.org = org
|
||||
self.repo = repo
|
||||
|
||||
def _post(self, path: str, data: Dict) -> Optional[Dict]:
|
||||
url = f"{self.base_url}/api/v1{path}"
|
||||
body = json.dumps(data).encode("utf-8")
|
||||
req = urllib.request.Request(url, data=body, method="POST")
|
||||
req.add_header("Authorization", f"token {self.token}")
|
||||
req.add_header("Content-Type", "application/json")
|
||||
try:
|
||||
with urllib.request.urlopen(req, timeout=30) as resp:
|
||||
return json.loads(resp.read().decode())
|
||||
except urllib.error.HTTPError as e:
|
||||
err = e.read().decode() if e.read() else str(e)
|
||||
print(f"[ERROR] HTTP {e.code}: {err}", file=sys.stderr)
|
||||
return None
|
||||
except Exception as e:
|
||||
print(f"[ERROR] {e}", file=sys.stderr)
|
||||
return None
|
||||
|
||||
def post_issue_comment(self, issue_num: int, body: str) -> Optional[Dict]:
|
||||
return self._post(
|
||||
f"/repos/{self.org}/{self.repo}/issues/{issue_num}/comments",
|
||||
{"body": body}
|
||||
)
|
||||
|
||||
def content_hash(finding: Dict) -> str:
|
||||
key = f"{finding['file']}:{finding['line']}:{finding['text']}"
|
||||
return hashlib.sha256(key.encode("utf-8")).hexdigest()
|
||||
|
||||
def format_comment(finding: Dict) -> str:
|
||||
emoji = {
|
||||
"error": "🛑",
|
||||
"warning": "⚠️",
|
||||
"info": "ℹ️",
|
||||
}.get(finding.get("severity", ""), "📝")
|
||||
f = finding["file"]
|
||||
ln = finding["line"]
|
||||
txt = finding["text"]
|
||||
return f"{emoji} **Review Comment**\n\nFile: `{f}`\nLine: {ln}\n\n> {txt}\n"
|
||||
|
||||
def load_findings(path: Optional[Path], from_stdin: bool) -> List[Dict]:
|
||||
import fileinput
|
||||
findings = []
|
||||
sources = ["-"] if from_stdin else [str(path)]
|
||||
for line in fileinput.input(files=sources):
|
||||
line = line.strip()
|
||||
if not line or line.startswith("#"):
|
||||
continue
|
||||
try:
|
||||
f = json.loads(line)
|
||||
for key in ("file", "line", "text"):
|
||||
if key not in f:
|
||||
raise ValueError(f"Missing key: {key}")
|
||||
findings.append(f)
|
||||
except json.JSONDecodeError as e:
|
||||
print(f"WARNING: Skipping invalid JSON: {e}", file=sys.stderr)
|
||||
return findings
|
||||
|
||||
def main() -> int:
|
||||
parser = argparse.ArgumentParser(
|
||||
description="Post review findings as comments to a Gitea PR/issue"
|
||||
)
|
||||
parser.add_argument("--pr", type=int, required=True, help="PR/issue number")
|
||||
parser.add_argument("--org", default="Timmy_Foundation", help="Gitea org")
|
||||
parser.add_argument("--repo", default="compounding-intelligence", help="Repo name")
|
||||
parser.add_argument("--api-base", default=DEFAULT_API_BASE, help="Gitea API base")
|
||||
parser.add_argument("--token", default=None, help="API token (or env/file)")
|
||||
parser.add_argument("--input", type=Path, default=None, help="JSONL input file")
|
||||
parser.add_argument("--stdin", action="store_true", help="Read from stdin")
|
||||
parser.add_argument("--dry-run", action="store_true", help="Show without posting")
|
||||
parser.add_argument("--json", action="store_true", help="Emit JSON report")
|
||||
|
||||
args = parser.parse_args()
|
||||
|
||||
if not args.stdin and args.input is None:
|
||||
print("ERROR: --input or --stdin required", file=sys.stderr)
|
||||
return 1
|
||||
if args.stdin and args.input:
|
||||
print("ERROR: --stdin and --input exclusive", file=sys.stderr)
|
||||
return 1
|
||||
|
||||
token = args.token or load_token()
|
||||
if not token:
|
||||
print("ERROR: Token not found. Set GITEA_TOKEN or ~/.config/gitea/token", file=sys.stderr)
|
||||
return 1
|
||||
|
||||
findings = load_findings(args.input, args.stdin)
|
||||
if not findings:
|
||||
print("ERROR: No findings loaded", file=sys.stderr)
|
||||
return 1
|
||||
|
||||
if not args.json: print(f"Loaded {len(findings)} finding(s)")
|
||||
|
||||
seen: Dict[str, Dict] = {}
|
||||
for f in findings:
|
||||
h = content_hash(f)
|
||||
if h not in seen:
|
||||
seen[h] = f
|
||||
|
||||
unique = list(seen.values())
|
||||
if not args.json: print(f"After dedup: {len(unique)} unique")
|
||||
|
||||
if args.json:
|
||||
report = {
|
||||
"total": len(findings),
|
||||
"unique": len(unique),
|
||||
"findings": unique,
|
||||
"generated_at": datetime.now(timezone.utc).isoformat(),
|
||||
}
|
||||
print(json.dumps(report, indent=2))
|
||||
return 0
|
||||
|
||||
if args.dry_run:
|
||||
print("\n=== DRY RUN — would post ===")
|
||||
for i, f in enumerate(unique, 1):
|
||||
print(f"\n--- Comment {i}/{len(unique)} ---")
|
||||
print(format_comment(f))
|
||||
return 0
|
||||
|
||||
client = GiteaClient(args.api_base, token, args.org, args.repo)
|
||||
posted = 0
|
||||
for f in unique:
|
||||
body = format_comment(f)
|
||||
result = client.post_issue_comment(args.pr, body)
|
||||
if result:
|
||||
print(f"✅ Posted: {f['file']}:{f['line']} (id={result.get('id')})")
|
||||
posted += 1
|
||||
else:
|
||||
print(f"❌ Failed: {f['file']}:{f['line']}")
|
||||
|
||||
print(f"\nPosted {posted}/{len(unique)} to PR #{args.pr}")
|
||||
return 0 if posted == len(unique) else 1
|
||||
|
||||
if __name__ == "__main__":
|
||||
sys.exit(main())
|
||||
|
||||
5
scripts/sample_findings.jsonl
Normal file
5
scripts/sample_findings.jsonl
Normal file
@@ -0,0 +1,5 @@
|
||||
{"file": "scripts/harvester.py", "line": 47, "text": "Consider adding type hints to improve readability", "severity": "info"}
|
||||
{"file": "scripts/dedup.py", "line": 89, "text": "Add null check before accessing fact['confidence'] to avoid KeyError", "severity": "warning"}
|
||||
{"file": "scripts/bootstrapper.py", "line": 102, "text": "This loop is O(n^2) — could be optimized with a dict lookup", "severity": "info"}
|
||||
{"file": "scripts/harvester.py", "line": 47, "text": "Consider adding type hints to improve readability", "severity": "info"}
|
||||
{"file": "scripts/harvester.py", "line": 120, "text": "File handle not closed in error path — use context manager", "severity": "error"}
|
||||
@@ -1,235 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for knowledge_synthesizer.py — zero-shot knowledge synthesis pipeline.
|
||||
|
||||
Run with: python3 scripts/test_knowledge_synthesizer.py
|
||||
Or via pytest: pytest scripts/test_knowledge_synthesizer.py
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import os
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
|
||||
# Add scripts dir to path for importing sibling module
|
||||
SCRIPT_DIR = Path(__file__).resolve().parent
|
||||
sys.path.insert(0, str(SCRIPT_DIR))
|
||||
|
||||
import importlib.util
|
||||
spec = importlib.util.spec_from_file_location(
|
||||
"ks", os.path.join(str(SCRIPT_DIR), "knowledge_synthesizer.py")
|
||||
)
|
||||
ks = importlib.util.module_from_spec(spec)
|
||||
spec.loader.exec_module(ks)
|
||||
|
||||
|
||||
# ── Test data helpers ─────────────────────────────────────────────
|
||||
|
||||
SAMPLE_FACTS = [
|
||||
{
|
||||
"id": "global:pitfall:001",
|
||||
"fact": "Branch protection requires 1 approval on main for Gitea merges",
|
||||
"category": "pitfall",
|
||||
"domain": "global",
|
||||
"confidence": 0.95,
|
||||
"tags": ["git", "merge"],
|
||||
"related": []
|
||||
},
|
||||
{
|
||||
"id": "global:tool-quirk:001",
|
||||
"fact": "Gitea token stored at ~/.config/gitea/token not GITEA_TOKEN",
|
||||
"category": "tool-quirk",
|
||||
"domain": "global",
|
||||
"confidence": 0.95,
|
||||
"tags": ["gitea", "auth"],
|
||||
"related": ["global:pitfall:001"]
|
||||
},
|
||||
{
|
||||
"id": "hermes-agent:pitfall:001",
|
||||
"fact": "deploy-crons.py leaves jobs in mixed model format",
|
||||
"category": "pitfall",
|
||||
"domain": "hermes-agent",
|
||||
"confidence": 0.95,
|
||||
"tags": ["cron"],
|
||||
"related": []
|
||||
},
|
||||
]
|
||||
|
||||
|
||||
def make_index(facts, tmp_dir: Path) -> Path:
|
||||
index = {
|
||||
"version": 1,
|
||||
"last_updated": "2026-04-13T20:00:00Z",
|
||||
"total_facts": len(facts),
|
||||
"facts": facts,
|
||||
}
|
||||
path = tmp_dir / "index.json"
|
||||
with open(path, "w") as f:
|
||||
json.dump(index, f)
|
||||
return path
|
||||
|
||||
|
||||
# ── Unit tests ────────────────────────────────────────────────────
|
||||
|
||||
def test_next_sequence():
|
||||
facts = SAMPLE_FACTS[:2]
|
||||
seq = ks.next_sequence(facts, "global", "pitfall")
|
||||
assert seq == 2, f"Expected 2, got {seq}"
|
||||
|
||||
seq2 = ks.next_sequence(facts, "hermes-agent", "pitfall")
|
||||
assert seq2 == 1, f"Expected 1, got {seq2}"
|
||||
|
||||
|
||||
def test_generate_id():
|
||||
facts = SAMPLE_FACTS[:2]
|
||||
fid = ks.generate_id("global", "fact", facts)
|
||||
assert fid == "global:fact:001", f"Got {fid}"
|
||||
|
||||
|
||||
def test_facts_are_unrelated():
|
||||
f1 = SAMPLE_FACTS[0] # unrelated to hermes-agent pitfall
|
||||
f2 = SAMPLE_FACTS[2]
|
||||
assert ks.facts_are_unrelated(f1, f2) is True
|
||||
|
||||
f3 = SAMPLE_FACTS[1] # related to f1
|
||||
assert ks.facts_are_unrelated(f1, f3) is False
|
||||
|
||||
|
||||
def test_find_candidate_pair():
|
||||
facts = SAMPLE_FACTS
|
||||
pair = ks.find_candidate_pair(facts)
|
||||
assert pair is not None, "Should find an unrelated pair"
|
||||
f1, f2 = pair
|
||||
assert ks.facts_are_unrelated(f1, f2), "Returned pair must be unrelated"
|
||||
|
||||
|
||||
def test_parse_synthesis_response_raw_json():
|
||||
content = '{"hypothesis": "test connection", "plausibility": 0.8, "bridging_concepts": ["x"], "suggested_tags": ["a"]}'
|
||||
result = ks.parse_synthesis_response(content)
|
||||
assert result is not None
|
||||
assert result["hypothesis"] == "test connection"
|
||||
assert result["plausibility"] == 0.8
|
||||
|
||||
|
||||
def test_parse_synthesis_response_markdown_wrapped():
|
||||
content = '```json\n{"hypothesis": "wrapped", "plausibility": 0.5}\n```'
|
||||
result = ks.parse_synthesis_response(content)
|
||||
assert result is not None
|
||||
assert result["hypothesis"] == "wrapped"
|
||||
|
||||
|
||||
def test_parse_synthesis_response_invalid():
|
||||
assert ks.parse_synthesis_response("not json") is None
|
||||
assert ks.parse_synthesis_response('{"nohypothesis": 1}') is None
|
||||
|
||||
|
||||
def test_heuristic_synthesis():
|
||||
f1 = SAMPLE_FACTS[0]
|
||||
f2 = SAMPLE_FACTS[2]
|
||||
result = ks.heuristic_synthesis(f1, f2)
|
||||
assert "hypothesis" in result
|
||||
assert "plausibility" in result
|
||||
assert result["plausibility"] == 0.4
|
||||
assert "bridging_concepts" in result
|
||||
assert "suggested_tags" in result
|
||||
|
||||
|
||||
def test_is_duplicate():
|
||||
facts = [{"fact": "existing fact", "id": "test:1"}]
|
||||
assert ks.is_duplicate("existing fact", facts) is True
|
||||
assert ks.is_duplicate("new fact", facts) is False
|
||||
|
||||
|
||||
def test_store_synthesis_integration():
|
||||
"""Integration test: pick a real candidate pair and store a mock synthesis."""
|
||||
with tempfile.TemporaryDirectory() as tmp:
|
||||
tmp_path = Path(tmp)
|
||||
# Create fake knowledge dir with index
|
||||
kdir = tmp_path / "knowledge"
|
||||
kdir.mkdir()
|
||||
index = {
|
||||
"version": 1,
|
||||
"last_updated": "2026-04-13T20:00:00Z",
|
||||
"total_facts": 3,
|
||||
"facts": SAMPLE_FACTS
|
||||
}
|
||||
with open(kdir / "index.json", "w") as f:
|
||||
json.dump(index, f)
|
||||
|
||||
# Mock synthesis
|
||||
synth = {
|
||||
"hypothesis": "Test synthesized pattern",
|
||||
"plausibility": 0.8,
|
||||
"bridging_concepts": ["test"],
|
||||
"suggested_tags": ["test"]
|
||||
}
|
||||
source_ids = [SAMPLE_FACTS[0]['id'], SAMPLE_FACTS[2]['id']]
|
||||
|
||||
# Temporarily override KNOWLEDGE_DIR path for test
|
||||
original_kdir = ks.KNOWLEDGE_DIR
|
||||
ks.KNOWLEDGE_DIR = kdir
|
||||
try:
|
||||
stored = ks.store_synthesis(synth, source_ids, index, threshold=0.5)
|
||||
assert stored is True
|
||||
assert index['total_facts'] == 4
|
||||
new_fact = index['facts'][-1]
|
||||
assert new_fact['fact'] == "Test synthesized pattern"
|
||||
assert new_fact['category'] == "pattern"
|
||||
assert new_fact['domain'] == "global"
|
||||
assert new_fact['related'] == source_ids
|
||||
assert new_fact['id'].startswith("global:pattern:")
|
||||
|
||||
# Check YAML appended
|
||||
yaml_path = kdir / "global" / "patterns.yaml"
|
||||
assert yaml_path.exists()
|
||||
content = yaml_path.read_text()
|
||||
assert "Test synthesized pattern" in content
|
||||
finally:
|
||||
ks.KNOWLEDGE_DIR = original_kdir
|
||||
|
||||
|
||||
# ── Smoke test ────────────────────────────────────────────────────
|
||||
|
||||
def test_smoke_synthesizer_info():
|
||||
"""Sanity check: script can at least load and report current knowledge state."""
|
||||
index = ks.load_index()
|
||||
total = index.get('total_facts', 0)
|
||||
facts = index.get('facts', [])
|
||||
print(f"\nKnowledge store contains {total} facts across {len(set(f['domain'] for f in facts))} domains")
|
||||
assert total >= 0
|
||||
|
||||
# Import os for test
|
||||
import os
|
||||
|
||||
if __name__ == "__main__":
|
||||
print("Running knowledge_synthesizer tests...\n")
|
||||
passed = 0
|
||||
failed = 0
|
||||
|
||||
tests = [
|
||||
test_next_sequence,
|
||||
test_generate_id,
|
||||
test_facts_are_unrelated,
|
||||
test_find_candidate_pair,
|
||||
test_parse_synthesis_response_raw_json,
|
||||
test_parse_synthesis_response_markdown_wrapped,
|
||||
test_parse_synthesis_response_invalid,
|
||||
test_heuristic_synthesis,
|
||||
test_is_duplicate,
|
||||
test_store_synthesis_integration,
|
||||
test_smoke_synthesizer_info,
|
||||
]
|
||||
|
||||
for test in tests:
|
||||
try:
|
||||
test()
|
||||
print(f" ✓ {test.__name__}")
|
||||
passed += 1
|
||||
except Exception as e:
|
||||
import traceback; traceback.print_exc(); print(f" ✗ {test.__name__}: {e}")
|
||||
failed += 1
|
||||
|
||||
print(f"\n{passed} passed, {failed} failed")
|
||||
sys.exit(0 if failed == 0 else 1)
|
||||
@@ -1,47 +0,0 @@
|
||||
# Knowledge Synthesis Prompt
|
||||
|
||||
## System Prompt
|
||||
|
||||
You are a knowledge synthesis engine. Given two facts, you generate a novel hypothesis
|
||||
that connects them in a way no human would typically link — a zero-shot creative leap.
|
||||
|
||||
## Task
|
||||
|
||||
FACT A:
|
||||
{fact_a}
|
||||
|
||||
FACT B:
|
||||
{fact_b}
|
||||
|
||||
Generate a single JSON object:
|
||||
|
||||
{
|
||||
"hypothesis": "one concise sentence linking the two facts as a new, testable insight",
|
||||
"plausibility": 0.0-1.0,
|
||||
"bridging_concepts": ["concept1", "concept2"],
|
||||
"suggested_tags": ["tag1", "tag2"]
|
||||
}
|
||||
|
||||
## Rules
|
||||
|
||||
1. The hypothesis must be a logical consequence of combining both facts.
|
||||
2. DO NOT restate either fact — produce genuinely new insight.
|
||||
3. Plausibility should reflect confidence given only these two facts.
|
||||
4. If no meaningful connection exists, return {"hypothesis":"","plausibility":0.0}.
|
||||
5. Output ONLY valid JSON — no markdown, no explanation.
|
||||
|
||||
## Examples
|
||||
|
||||
Input facts:
|
||||
- "Gitea PR creation requires branch protection approval (1+) on main"
|
||||
- "Git push hangs on large repos (pack.windowMemory=100m)"
|
||||
|
||||
Hypothesis output:
|
||||
{
|
||||
"hypothesis": "Branch protection triggers checks that inflate pack size, causing git push to hang on large repos",
|
||||
"plausibility": 0.65,
|
||||
"bridging_concepts": ["git", "gitea", "branch-protection", "push"],
|
||||
"suggested_tags": ["git", "gitea", "performance"]
|
||||
}
|
||||
|
||||
Output ONLY the JSON object.
|
||||
234
tests/test_review_comment_generator.py
Normal file
234
tests/test_review_comment_generator.py
Normal file
@@ -0,0 +1,234 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Smoke tests for Review Comment Generator — Issue #126
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import json
|
||||
import subprocess
|
||||
import sys
|
||||
import hashlib
|
||||
from io import StringIO
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
REPO_ROOT = Path(__file__).resolve().parents[1]
|
||||
SCRIPTS_DIR = REPO_ROOT / "scripts"
|
||||
GENERATOR = SCRIPTS_DIR / "review_comment_generator.py"
|
||||
SAMPLE_FINDINGS = SCRIPTS_DIR / "sample_findings.jsonl"
|
||||
|
||||
|
||||
class TestGeneratorPresence:
|
||||
def test_script_exists(self):
|
||||
assert GENERATOR.exists(), f"Missing: {GENERATOR}"
|
||||
|
||||
def test_shebang_is_python(self):
|
||||
with open(GENERATOR) as f:
|
||||
first = f.readline().strip()
|
||||
assert first.startswith("#!"), "No shebang"
|
||||
assert "python" in first.lower()
|
||||
|
||||
|
||||
class TestDeduplication:
|
||||
def test_content_hash_deterministic(self):
|
||||
from hashlib import sha256
|
||||
def ch(f):
|
||||
key = f"{f['file']}:{f['line']}:{f['text']}"
|
||||
return sha256(key.encode()).hexdigest()
|
||||
finding = {"file": "a.py", "line": 1, "text": "test"}
|
||||
assert ch(finding) == ch(finding)
|
||||
|
||||
def test_duplicate_findings_are_removed(self):
|
||||
findings = [
|
||||
{"file": "a.py", "line": 1, "text": "foo", "severity": "info"},
|
||||
{"file": "a.py", "line": 1, "text": "foo", "severity": "warning"},
|
||||
{"file": "b.py", "line": 2, "text": "bar", "severity": "info"},
|
||||
]
|
||||
seen = {}
|
||||
for f in findings:
|
||||
key = f"{f['file']}:{f['line']}:{f['text']}"
|
||||
seen[key] = f
|
||||
assert len(seen) == 2
|
||||
|
||||
def test_different_findings_are_kept(self):
|
||||
findings = [
|
||||
{"file": "a.py", "line": 1, "text": "foo"},
|
||||
{"file": "a.py", "line": 2, "text": "foo"},
|
||||
{"file": "a.py", "line": 1, "text": "bar"},
|
||||
]
|
||||
seen = {}
|
||||
for f in findings:
|
||||
key = f"{f['file']}:{f['line']}:{f['text']}"
|
||||
seen[key] = f
|
||||
assert len(seen) == 3
|
||||
|
||||
|
||||
class TestCommentFormatting:
|
||||
def test_format_basic(self):
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import format_comment
|
||||
f = {"file": "scripts/foo.py", "line": 10, "text": "Fix this bug", "severity": "warning"}
|
||||
body = format_comment(f)
|
||||
assert "📝 **Review Comment**" not in body # warning uses ⚠️
|
||||
assert "⚠️ **Review Comment**" in body
|
||||
assert "`scripts/foo.py`" in body
|
||||
assert "Line: 10" in body
|
||||
assert "> Fix this bug" in body
|
||||
|
||||
def test_format_severity_emoji(self):
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import format_comment
|
||||
cases = [("error", "🛑"), ("warning", "⚠️"), ("info", "ℹ️"), ("unknown", "📝")]
|
||||
for severity, emoji in cases:
|
||||
f = {"file": "x.py", "line": 1, "text": "test", "severity": severity}
|
||||
assert emoji in format_comment(f)
|
||||
|
||||
|
||||
class TestFindingsLoader:
|
||||
def test_load_from_file(self):
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import load_findings
|
||||
findings = load_findings(SAMPLE_FINDINGS, from_stdin=False)
|
||||
assert len(findings) >= 4
|
||||
|
||||
def test_load_ignores_blank_and_comments(self):
|
||||
import tempfile, os
|
||||
with tempfile.NamedTemporaryFile(mode="w", suffix=".jsonl", delete=False) as tf:
|
||||
tf.write('{"file":"a.py","line":1,"text":"valid"}\n')
|
||||
tf.write('\n')
|
||||
tf.write('# this is a comment\n')
|
||||
tf.write('{"file":"b.py","line":2,"text":"also valid"}\n')
|
||||
tfname = tf.name
|
||||
try:
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import load_findings
|
||||
assert len(load_findings(Path(tfname), from_stdin=False)) == 2
|
||||
finally:
|
||||
os.unlink(tfname)
|
||||
|
||||
def test_invalid_json_line_skipped(self, capsys):
|
||||
import tempfile, os
|
||||
with tempfile.NamedTemporaryFile(mode="w", suffix=".jsonl", delete=False) as tf:
|
||||
tf.write('invalid json\n')
|
||||
tf.write('{"file":"ok.py","line":1,"text":"valid"}\n')
|
||||
tfname = tf.name
|
||||
try:
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import load_findings
|
||||
assert len(load_findings(Path(tfname), from_stdin=False)) == 1
|
||||
finally:
|
||||
os.unlink(tfname)
|
||||
|
||||
|
||||
class TestDryRunMode:
|
||||
def test_dry_run_counts_unique(self):
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126",
|
||||
"--input", str(SAMPLE_FINDINGS), "--dry-run"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
assert result.returncode == 0
|
||||
assert "DRY RUN" in result.stdout
|
||||
assert "Review Comment" in result.stdout
|
||||
|
||||
def test_dry_run_shows_all_unique(self):
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126",
|
||||
"--input", str(SAMPLE_FINDINGS), "--dry-run"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
assert result.stdout.count("--- Comment") == 4
|
||||
|
||||
|
||||
class TestJSONOutputMode:
|
||||
def test_json_flag_emits_valid_json(self):
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126",
|
||||
"--input", str(SAMPLE_FINDINGS), "--json"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
assert result.returncode == 0
|
||||
payload = json.loads(result.stdout)
|
||||
assert "total" in payload and "unique" in payload and "findings" in payload
|
||||
assert payload["total"] >= payload["unique"]
|
||||
|
||||
def test_json_findings_have_required_fields(self):
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126",
|
||||
"--input", str(SAMPLE_FINDINGS), "--json"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
payload = json.loads(result.stdout)
|
||||
for f in payload["findings"]:
|
||||
assert "file" in f and "line" in f and "text" in f
|
||||
|
||||
|
||||
class TestGiteaClient:
|
||||
def test_post_issue_comment_builds_correct_url(self):
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import GiteaClient
|
||||
client = GiteaClient("https://example.com", "token123", "MyOrg", "myrepo")
|
||||
assert client.org == "MyOrg" and client.repo == "myrepo"
|
||||
|
||||
def test_generate_comment_body_has_required_fields(self):
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import format_comment
|
||||
f = {"file": "x.py", "line": 5, "text": "Fix this", "severity": "error"}
|
||||
body = format_comment(f)
|
||||
assert "x.py" in body and "5" in body and "Fix this" in body
|
||||
|
||||
|
||||
class TestFullPipeline:
|
||||
def test_end_to_end_json_output(self):
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126",
|
||||
"--input", str(SAMPLE_FINDINGS), "--json"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
assert result.returncode == 0
|
||||
data = json.loads(result.stdout)
|
||||
assert data["total"] == 5
|
||||
assert data["unique"] == 4
|
||||
f = data["findings"][0]
|
||||
for key in ("file", "line", "text", "severity"):
|
||||
assert key in f
|
||||
|
||||
def test_token_loading_fallback(self):
|
||||
sys.path.insert(0, str(SCRIPTS_DIR))
|
||||
from review_comment_generator import load_token
|
||||
token = load_token()
|
||||
assert token is None or isinstance(token, str)
|
||||
|
||||
|
||||
class TestErrorHandling:
|
||||
def test_missing_input_shows_error(self):
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
assert result.returncode != 0
|
||||
assert "--input" in result.stderr or "--stdin" in result.stderr
|
||||
|
||||
def test_invalid_json_line_skipped(self):
|
||||
import tempfile, os
|
||||
with tempfile.NamedTemporaryFile(mode="w", suffix=".jsonl", delete=False) as tf:
|
||||
tf.write('invalid json\n')
|
||||
tf.write('{"file":"ok.py","line":1,"text":"valid"}\n')
|
||||
tfname = tf.name
|
||||
try:
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(GENERATOR), "--pr", "126",
|
||||
"--input", tfname, "--json"],
|
||||
capture_output=True, text=True, cwd=REPO_ROOT, timeout=15
|
||||
)
|
||||
data = json.loads(result.stdout)
|
||||
assert data["total"] == 1
|
||||
assert data["unique"] == 1
|
||||
finally:
|
||||
os.unlink(tfname)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
pytest.main([__file__, "-v"])
|
||||
Reference in New Issue
Block a user