Timmy_Foundation/compounding-intelligence
15
0
Fork 0
Code Issues 173 Pull Requests 59 Actions Packages Projects Releases Wiki Activity

fix: 3 syntax errors in perf_bottleneck_finder.py (closes #211) #225

Open
Rockachopa wants to merge 1 commits from fix/211-syntax-errors into main
pull from: fix/211-syntax-errors
merge into: Timmy_Foundation:main
Conversation 6 Commits 1 Files Changed 1 +3 -4
Rockachopa commented 2026-04-21 11:35:29 +00:00
Owner
Copy Link

Closes #211

Three syntax errors fixed:

  1. Line 116: Escaped quotes in regex pattern ['\"]w['\"]\) — inner quotes broke the Python string literal
  2. Line 509: Split "\n".join(lines) return across two lines — joined into single line
  3. Line 523: global SLOW_TEST_THRESHOLD_S declared after first use — moved before parser.parse_args()

Verification:

  • python3 -m py_compile scripts/perf_bottleneck_finder.py succeeds
  • python3 -m pytest tests/test_perf_bottleneck_finder.py -q → 25 passed
Closes #211 Three syntax errors fixed: 1. **Line 116**: Escaped quotes in regex pattern `['\"]w['\"]\)` — inner quotes broke the Python string literal 2. **Line 509**: Split `"\n".join(lines)` return across two lines — joined into single line 3. **Line 523**: `global SLOW_TEST_THRESHOLD_S` declared after first use — moved before `parser.parse_args()` Verification: - `python3 -m py_compile scripts/perf_bottleneck_finder.py` succeeds - `python3 -m pytest tests/test_perf_bottleneck_finder.py -q` → 25 passed
Rockachopa added 1 commit 2026-04-21 11:35:30 +00:00
fix: 3 syntax errors in perf_bottleneck_finder.py (closes #211)
Some checks failed
Test / pytest (pull_request) Failing after 20s
Details
4363864012 
- Line 116: escaped quotes in regex pattern for file write detection
- Line 509: split newline join return statement
- Line 523: moved global declaration before first use

All 25 test_perf_bottleneck_finder tests pass.
python3 -m py_compile succeeds.
Timmy commented 2026-04-21 16:22:54 +00:00
Owner
Copy Link

🚫 Cannot merge PR #225 - Merge failed. Reason:

🚫 Cannot merge PR #225 - **Merge failed**. Reason:
Rockachopa commented 2026-04-22 02:40:49 +00:00
Author
Owner
Copy Link

🔎 Merge sweep 2026-04-21: not merging this PR in the current sweep. Blocked by merge conflicts / non-mergeable branch state against main. Rebase/refresh onto the base branch and rerun checks.

🔎 Merge sweep 2026-04-21: not merging this PR in the current sweep. Blocked by merge conflicts / non-mergeable branch state against `main`. Rebase/refresh onto the base branch and rerun checks.
Rockachopa reviewed 2026-04-22 13:52:54 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Changes suggested — 1 file(s), +3/-4 lines.

Duplicate PR: Duplicate — multiple PRs fix same syntax error (#211). Keep only the most complete.

**Changes suggested** — 1 file(s), +3/-4 lines. **Duplicate PR:** Duplicate — multiple PRs fix same syntax error (#211). Keep only the most complete.
Rockachopa reviewed 2026-04-22 13:55:25 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

DUPLICATE of #226 and 5 other PRs — all fix the same syntax errors in perf_bottleneck_finder.py (issue #211). The regex fix here adds an extra closing paren that changes semantics. PR #226 has the cleaner fix.

Recommendation: Close in favor of #226.

**DUPLICATE** of #226 and 5 other PRs — all fix the same syntax errors in perf_bottleneck_finder.py (issue #211). The regex fix here adds an extra closing paren that changes semantics. PR #226 has the cleaner fix. **Recommendation:** Close in favor of #226.
Rockachopa reviewed 2026-04-22 14:14:18 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Verdict: REQUEST_CHANGES -- DUPLICATE. One of 7 PRs fixing perf_bottleneck_finder.py SyntaxError (issue #211). This fix is nearly identical to #226 but the regex fix adds an extra closing paren in the pattern which may cause matching issues. Recommend closing in favor of #226 which has the cleanest fix.

Verdict: REQUEST_CHANGES -- DUPLICATE. One of 7 PRs fixing perf_bottleneck_finder.py SyntaxError (issue #211). This fix is nearly identical to #226 but the regex fix adds an extra closing paren in the pattern which may cause matching issues. Recommend closing in favor of #226 which has the cleanest fix.
claude reviewed 2026-04-22 16:14:18 +00:00
claude left a comment
Member
Copy Link

Fixes the same three syntax errors as PR #226. The regex fix adds an extra closing paren in the pattern which changes matching behavior. PR #226 has the cleaner fix. Consider closing in favor of #226.

Fixes the same three syntax errors as PR #226. The regex fix adds an extra closing paren in the pattern which changes matching behavior. PR #226 has the cleaner fix. Consider closing in favor of #226.
Some checks failed
Test / pytest (pull_request) Failing after 20s
Details
This pull request has changes conflicting with the target branch.
  • scripts/perf_bottleneck_finder.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/211-syntax-errors:fix/211-syntax-errors
git checkout fix/211-syntax-errors
Sign in to join this conversation.
Reviewers
No Reviewers
Rockachopa
claude
Labels
Clear labels
acceptance-criteria
batch-pipeline
Token masterplan batch pipeline
 bootstrapper
Pre-session context injection
 epic
Epic-level issue
 harvester
Session knowledge extraction
 measurer
Compounding metrics
 milestone:1
Milestone 1: Foundation
 milestone:2
Milestone 2: Integration
 milestone:3
Milestone 3: Measurement
 milestone:4
Milestone 4: Retroactive
 pipeline
Pipeline/integration work
 pipeline
priority:high
priority:medium
retroactive
Processing existing sessions
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/compounding-intelligence#225
Delete Branch "fix/211-syntax-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?