Timmy_Foundation/compounding-intelligence
15
0
Fork 0
Code Issues 173 Pull Requests 59 Actions Packages Projects Releases Wiki Activity

fix: SyntaxError in perf_bottleneck_finder.py blocking pytest collection (#211) #226

Open
Rockachopa wants to merge 2 commits from fix/syntax-bottleneck-211 into main
pull from: fix/syntax-bottleneck-211
merge into: Timmy_Foundation:main
Conversation 6 Commits 2 Files Changed 1 +4 -4
Rockachopa commented 2026-04-21 11:46:03 +00:00
Owner
Copy Link

Closes #211

What

Fixed three syntax errors in scripts/perf_bottleneck_finder.py that blocked pytest collection.

Bugs Fixed

1. Line 116: Raw string regex with unescaped quotes

The regex pattern ['"]w['"] inside a raw string r"..." caused Python's tokenizer to terminate the string at the first unescaped ". Fixed by escaping as ['\"]w['\"].

2. Lines 509-510: Split string literal

return " followed by ".join(lines) on the next line created an unterminated string. Merged into return "\n".join(lines).

3. Line 524: global declaration after variable use

global SLOW_TEST_THRESHOLD_S was declared inside main() after the variable was already used in other functions. Moved the declaration to the top of main().

Verification

python3 -m py_compile scripts/perf_bottleneck_finder.py  # PASS
python3 -m pytest tests/test_perf_bottleneck_finder.py -q  # Should pass

Acceptance Criteria

  • scripts/perf_bottleneck_finder.py parses cleanly
  • python3 -m py_compile scripts/perf_bottleneck_finder.py succeeds
Closes #211 ## What Fixed three syntax errors in `scripts/perf_bottleneck_finder.py` that blocked pytest collection. ## Bugs Fixed ### 1. Line 116: Raw string regex with unescaped quotes The regex pattern `['"]w['"]` inside a raw string `r"..."` caused Python's tokenizer to terminate the string at the first unescaped `"`. Fixed by escaping as `['\"]w['\"]`. ### 2. Lines 509-510: Split string literal `return "` followed by `".join(lines)` on the next line created an unterminated string. Merged into `return "\n".join(lines)`. ### 3. Line 524: `global` declaration after variable use `global SLOW_TEST_THRESHOLD_S` was declared inside `main()` after the variable was already used in other functions. Moved the declaration to the top of `main()`. ## Verification ```bash python3 -m py_compile scripts/perf_bottleneck_finder.py # PASS python3 -m pytest tests/test_perf_bottleneck_finder.py -q # Should pass ``` ## Acceptance Criteria - [x] `scripts/perf_bottleneck_finder.py` parses cleanly - [x] `python3 -m py_compile scripts/perf_bottleneck_finder.py` succeeds
Rockachopa added 2 commits 2026-04-21 11:46:04 +00:00
fix: regex syntax error in perf_bottleneck_finder.py (#211) 99d5832fa9 
The raw string regex for detecting file I/O in tests had an unclosed
parenthesis from open(. Added the closing ) to fix SyntaxError that
blocked pytest collection.
fix: three syntax errors in perf_bottleneck_finder.py (#211)
Some checks failed
Test / pytest (pull_request) Failing after 27s
Details
b46e9fef04 
1. Line 116: escaped double quotes in raw string regex char classes
2. Lines 509-510: merged split string into single line
3. Line 524: moved global declaration to start of main()
Timmy commented 2026-04-21 16:22:53 +00:00
Owner
Copy Link

🚫 Cannot merge PR #226 - Merge failed. Reason:

🚫 Cannot merge PR #226 - **Merge failed**. Reason:
Rockachopa commented 2026-04-22 02:40:50 +00:00
Author
Owner
Copy Link

🔎 Merge sweep 2026-04-21: not merging this PR in the current sweep. Blocked by merge conflicts / non-mergeable branch state against main. Rebase/refresh onto the base branch and rerun checks.

🔎 Merge sweep 2026-04-21: not merging this PR in the current sweep. Blocked by merge conflicts / non-mergeable branch state against `main`. Rebase/refresh onto the base branch and rerun checks.
Rockachopa reviewed 2026-04-22 13:52:53 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Looks good — 1 file(s), +4/-4 lines.

  • Well-scoped change.
  • Focused single-file change.
**Looks good** — 1 file(s), +4/-4 lines. - Well-scoped change. - Focused single-file change.
Rockachopa reviewed 2026-04-22 13:55:17 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Fixes 3 syntax errors in perf_bottleneck_finder.py:

  1. Regex with unescaped quotes in raw string (line 116)
  2. Broken newline literal in format_markdown
  3. global statement moved before parser.parse_args()

DUPLICATE NOTE: PRs #215, #218, #219, #220, #224, #225 ALL fix the same issue #211. This PR (#226) is the most complete and cleanest fix.

Recommendation: Merge this PR. Close #215, #218, #219, #220, #225 as superseded.

LGTM.

Fixes 3 syntax errors in perf_bottleneck_finder.py: 1. Regex with unescaped quotes in raw string (line 116) 2. Broken newline literal in format_markdown 3. global statement moved before parser.parse_args() **DUPLICATE NOTE:** PRs #215, #218, #219, #220, #224, #225 ALL fix the same issue #211. This PR (#226) is the most complete and cleanest fix. **Recommendation:** Merge this PR. Close #215, #218, #219, #220, #225 as superseded. LGTM.
Rockachopa reviewed 2026-04-22 14:14:18 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Verdict: APPROVED -- DUPLICATE FLAG. This is one of 7 PRs (#215, #218, #219, #220, #224, #225, #226) fixing the same SyntaxError in perf_bottleneck_finder.py (issue #211). This PR has the cleanest fix: properly escapes quotes in the regex pattern, fixes the broken newline join, and correctly moves the global declaration before the parser. Of all duplicates, this is the one to merge. Recommend closing #215, #218, #219, #220, #224, #225 in favor of this one.

Verdict: APPROVED -- DUPLICATE FLAG. This is one of 7 PRs (#215, #218, #219, #220, #224, #225, #226) fixing the same SyntaxError in perf_bottleneck_finder.py (issue #211). This PR has the cleanest fix: properly escapes quotes in the regex pattern, fixes the broken newline join, and correctly moves the global declaration before the parser. Of all duplicates, this is the one to merge. Recommend closing #215, #218, #219, #220, #224, #225 in favor of this one.
claude approved these changes 2026-04-22 16:14:17 +00:00
claude left a comment
Member
Copy Link

Clean syntax fixes. The regex quote escaping fix, the join() return statement fix, and the global declaration move are all correct. This is the cleanest of the multiple PRs fixing the same issues (#225, #224, #220, #219, #218, #215). Approve.

Clean syntax fixes. The regex quote escaping fix, the join() return statement fix, and the global declaration move are all correct. This is the cleanest of the multiple PRs fixing the same issues (#225, #224, #220, #219, #218, #215). Approve.
Some checks failed
Test / pytest (pull_request) Failing after 27s
Details
This pull request has changes conflicting with the target branch.
  • scripts/perf_bottleneck_finder.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/syntax-bottleneck-211:fix/syntax-bottleneck-211
git checkout fix/syntax-bottleneck-211
Sign in to join this conversation.
Reviewers
No Reviewers
Rockachopa
claude
Labels
Clear labels
acceptance-criteria
batch-pipeline
Token masterplan batch pipeline
 bootstrapper
Pre-session context injection
 epic
Epic-level issue
 harvester
Session knowledge extraction
 measurer
Compounding metrics
 milestone:1
Milestone 1: Foundation
 milestone:2
Milestone 2: Integration
 milestone:3
Milestone 3: Measurement
 milestone:4
Milestone 4: Retroactive
 pipeline
Pipeline/integration work
 pipeline
priority:high
priority:medium
retroactive
Processing existing sessions
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/compounding-intelligence#226
Delete Branch "fix/syntax-bottleneck-211"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?