Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
aa2809882e | ||
| f1f9bd2e76 | |||
|
|
4129cc0d0c |
256
agent/rider.py
Normal file
256
agent/rider.py
Normal file
@@ -0,0 +1,256 @@
|
|||||||
|
"""RIDER — Reader-Guided Passage Reranking.
|
||||||
|
|
||||||
|
Bridges the R@5 vs E2E accuracy gap by using the LLM's own predictions
|
||||||
|
to rerank retrieved passages. Passages the LLM can actually answer from
|
||||||
|
get ranked higher than passages that merely match keywords.
|
||||||
|
|
||||||
|
Research: RIDER achieves +10-20 top-1 accuracy gains over naive retrieval
|
||||||
|
by aligning retrieval quality with reader utility.
|
||||||
|
|
||||||
|
Usage:
|
||||||
|
from agent.rider import RIDER
|
||||||
|
rider = RIDER()
|
||||||
|
reranked = rider.rerank(passages, query, top_n=3)
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import asyncio
|
||||||
|
import logging
|
||||||
|
import os
|
||||||
|
from typing import Any, Dict, List, Optional, Tuple
|
||||||
|
|
||||||
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
# Configuration
|
||||||
|
RIDER_ENABLED = os.getenv("RIDER_ENABLED", "true").lower() not in ("false", "0", "no")
|
||||||
|
RIDER_TOP_K = int(os.getenv("RIDER_TOP_K", "10")) # passages to score
|
||||||
|
RIDER_TOP_N = int(os.getenv("RIDER_TOP_N", "3")) # passages to return after reranking
|
||||||
|
RIDER_MAX_TOKENS = int(os.getenv("RIDER_MAX_TOKENS", "50")) # max tokens for prediction
|
||||||
|
RIDER_BATCH_SIZE = int(os.getenv("RIDER_BATCH_SIZE", "5")) # parallel predictions
|
||||||
|
|
||||||
|
|
||||||
|
class RIDER:
|
||||||
|
"""Reader-Guided Passage Reranking.
|
||||||
|
|
||||||
|
Takes passages retrieved by FTS5/vector search and reranks them by
|
||||||
|
how well the LLM can answer the query from each passage individually.
|
||||||
|
"""
|
||||||
|
|
||||||
|
def __init__(self, auxiliary_task: str = "rider"):
|
||||||
|
"""Initialize RIDER.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
auxiliary_task: Task name for auxiliary client resolution.
|
||||||
|
"""
|
||||||
|
self._auxiliary_task = auxiliary_task
|
||||||
|
|
||||||
|
def rerank(
|
||||||
|
self,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
top_n: int = RIDER_TOP_N,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Rerank passages by reader confidence.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
passages: List of passage dicts. Must have 'content' or 'text' key.
|
||||||
|
May have 'session_id', 'snippet', 'rank', 'score', etc.
|
||||||
|
query: The user's search query.
|
||||||
|
top_n: Number of passages to return after reranking.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Reranked passages (top_n), each with added 'rider_score' and
|
||||||
|
'rider_prediction' fields.
|
||||||
|
"""
|
||||||
|
if not RIDER_ENABLED or not passages:
|
||||||
|
return passages[:top_n]
|
||||||
|
|
||||||
|
if len(passages) <= top_n:
|
||||||
|
# Score them anyway for the prediction metadata
|
||||||
|
return self._score_and_rerank(passages, query, top_n)
|
||||||
|
|
||||||
|
return self._score_and_rerank(passages[:RIDER_TOP_K], query, top_n)
|
||||||
|
|
||||||
|
def _score_and_rerank(
|
||||||
|
self,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
top_n: int,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Score each passage with the reader, then rerank by confidence."""
|
||||||
|
try:
|
||||||
|
from model_tools import _run_async
|
||||||
|
scored = _run_async(self._score_all_passages(passages, query))
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("RIDER scoring failed: %s — returning original order", e)
|
||||||
|
return passages[:top_n]
|
||||||
|
|
||||||
|
# Sort by confidence (descending)
|
||||||
|
scored.sort(key=lambda p: p.get("rider_score", 0), reverse=True)
|
||||||
|
|
||||||
|
return scored[:top_n]
|
||||||
|
|
||||||
|
async def _score_all_passages(
|
||||||
|
self,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Score all passages in batches."""
|
||||||
|
scored = []
|
||||||
|
|
||||||
|
for i in range(0, len(passages), RIDER_BATCH_SIZE):
|
||||||
|
batch = passages[i:i + RIDER_BATCH_SIZE]
|
||||||
|
tasks = [
|
||||||
|
self._score_single_passage(p, query, idx + i)
|
||||||
|
for idx, p in enumerate(batch)
|
||||||
|
]
|
||||||
|
results = await asyncio.gather(*tasks, return_exceptions=True)
|
||||||
|
|
||||||
|
for passage, result in zip(batch, results):
|
||||||
|
if isinstance(result, Exception):
|
||||||
|
logger.debug("RIDER passage %d scoring failed: %s", i, result)
|
||||||
|
passage["rider_score"] = 0.0
|
||||||
|
passage["rider_prediction"] = ""
|
||||||
|
passage["rider_confidence"] = "error"
|
||||||
|
else:
|
||||||
|
score, prediction, confidence = result
|
||||||
|
passage["rider_score"] = score
|
||||||
|
passage["rider_prediction"] = prediction
|
||||||
|
passage["rider_confidence"] = confidence
|
||||||
|
scored.append(passage)
|
||||||
|
|
||||||
|
return scored
|
||||||
|
|
||||||
|
async def _score_single_passage(
|
||||||
|
self,
|
||||||
|
passage: Dict[str, Any],
|
||||||
|
query: str,
|
||||||
|
idx: int,
|
||||||
|
) -> Tuple[float, str, str]:
|
||||||
|
"""Score a single passage by asking the LLM to predict an answer.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
(confidence_score, prediction, confidence_label)
|
||||||
|
"""
|
||||||
|
content = passage.get("content") or passage.get("text") or passage.get("snippet", "")
|
||||||
|
if not content or len(content) < 10:
|
||||||
|
return 0.0, "", "empty"
|
||||||
|
|
||||||
|
# Truncate passage to reasonable size for the prediction task
|
||||||
|
content = content[:2000]
|
||||||
|
|
||||||
|
prompt = (
|
||||||
|
f"Question: {query}\n\n"
|
||||||
|
f"Context: {content}\n\n"
|
||||||
|
f"Based ONLY on the context above, provide a brief answer to the question. "
|
||||||
|
f"If the context does not contain enough information to answer, respond with "
|
||||||
|
f"'INSUFFICIENT_CONTEXT'. Be specific and concise."
|
||||||
|
)
|
||||||
|
|
||||||
|
try:
|
||||||
|
from agent.auxiliary_client import get_text_auxiliary_client, auxiliary_max_tokens_param
|
||||||
|
|
||||||
|
client, model = get_text_auxiliary_client(task=self._auxiliary_task)
|
||||||
|
if not client:
|
||||||
|
return 0.5, "", "no_client"
|
||||||
|
|
||||||
|
response = client.chat.completions.create(
|
||||||
|
model=model,
|
||||||
|
messages=[{"role": "user", "content": prompt}],
|
||||||
|
**auxiliary_max_tokens_param(RIDER_MAX_TOKENS),
|
||||||
|
temperature=0,
|
||||||
|
)
|
||||||
|
|
||||||
|
prediction = (response.choices[0].message.content or "").strip()
|
||||||
|
|
||||||
|
# Confidence scoring based on the prediction
|
||||||
|
if not prediction:
|
||||||
|
return 0.1, "", "empty_response"
|
||||||
|
|
||||||
|
if "INSUFFICIENT_CONTEXT" in prediction.upper():
|
||||||
|
return 0.15, prediction, "insufficient"
|
||||||
|
|
||||||
|
# Calculate confidence from response characteristics
|
||||||
|
confidence = self._calculate_confidence(prediction, query, content)
|
||||||
|
|
||||||
|
return confidence, prediction, "predicted"
|
||||||
|
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("RIDER prediction failed for passage %d: %s", idx, e)
|
||||||
|
return 0.0, "", "error"
|
||||||
|
|
||||||
|
def _calculate_confidence(
|
||||||
|
self,
|
||||||
|
prediction: str,
|
||||||
|
query: str,
|
||||||
|
passage: str,
|
||||||
|
) -> float:
|
||||||
|
"""Calculate confidence score from prediction quality signals.
|
||||||
|
|
||||||
|
Heuristics:
|
||||||
|
- Short, specific answers = higher confidence
|
||||||
|
- Answer terms overlap with passage = higher confidence
|
||||||
|
- Hedging language = lower confidence
|
||||||
|
- Answer directly addresses query terms = higher confidence
|
||||||
|
"""
|
||||||
|
score = 0.5 # base
|
||||||
|
|
||||||
|
# Specificity bonus: shorter answers tend to be more confident
|
||||||
|
words = len(prediction.split())
|
||||||
|
if words <= 5:
|
||||||
|
score += 0.2
|
||||||
|
elif words <= 15:
|
||||||
|
score += 0.1
|
||||||
|
elif words > 50:
|
||||||
|
score -= 0.1
|
||||||
|
|
||||||
|
# Passage grounding: does the answer use terms from the passage?
|
||||||
|
passage_lower = passage.lower()
|
||||||
|
answer_terms = set(prediction.lower().split())
|
||||||
|
passage_terms = set(passage_lower.split())
|
||||||
|
overlap = len(answer_terms & passage_terms)
|
||||||
|
if overlap > 3:
|
||||||
|
score += 0.15
|
||||||
|
elif overlap > 0:
|
||||||
|
score += 0.05
|
||||||
|
|
||||||
|
# Query relevance: does the answer address query terms?
|
||||||
|
query_terms = set(query.lower().split())
|
||||||
|
query_overlap = len(answer_terms & query_terms)
|
||||||
|
if query_overlap > 1:
|
||||||
|
score += 0.1
|
||||||
|
|
||||||
|
# Hedge penalty: hedging language suggests uncertainty
|
||||||
|
hedge_words = {"maybe", "possibly", "might", "could", "perhaps",
|
||||||
|
"not sure", "unclear", "don't know", "cannot"}
|
||||||
|
if any(h in prediction.lower() for h in hedge_words):
|
||||||
|
score -= 0.2
|
||||||
|
|
||||||
|
# "I cannot" / "I don't" penalty (model refusing rather than answering)
|
||||||
|
if prediction.lower().startswith(("i cannot", "i don't", "i can't", "there is no")):
|
||||||
|
score -= 0.15
|
||||||
|
|
||||||
|
return max(0.0, min(1.0, score))
|
||||||
|
|
||||||
|
|
||||||
|
def rerank_passages(
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
top_n: int = RIDER_TOP_N,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Convenience function for passage reranking."""
|
||||||
|
rider = RIDER()
|
||||||
|
return rider.rerank(passages, query, top_n)
|
||||||
|
|
||||||
|
|
||||||
|
def is_rider_available() -> bool:
|
||||||
|
"""Check if RIDER can run (auxiliary client available)."""
|
||||||
|
if not RIDER_ENABLED:
|
||||||
|
return False
|
||||||
|
try:
|
||||||
|
from agent.auxiliary_client import get_text_auxiliary_client
|
||||||
|
client, model = get_text_auxiliary_client(task="rider")
|
||||||
|
return client is not None and model is not None
|
||||||
|
except Exception:
|
||||||
|
return False
|
||||||
174
docs/r5-vs-e2e-gap-analysis.md
Normal file
174
docs/r5-vs-e2e-gap-analysis.md
Normal file
@@ -0,0 +1,174 @@
|
|||||||
|
# Research: R@5 vs End-to-End Accuracy Gap — WHY Does Retrieval Succeed but Answering Fail?
|
||||||
|
|
||||||
|
Research issue #660. The most important finding from our SOTA research.
|
||||||
|
|
||||||
|
## The Gap
|
||||||
|
|
||||||
|
| Metric | Score | What It Measures |
|
||||||
|
|--------|-------|------------------|
|
||||||
|
| R@5 | 98.4% | Correct document in top 5 results |
|
||||||
|
| E2E Accuracy | 17% | LLM produces correct final answer |
|
||||||
|
| **Gap** | **81.4%** | **Retrieval works, answering fails** |
|
||||||
|
|
||||||
|
This 81-point gap means: we find the right information 98% of the time, but the LLM only uses it correctly 17% of the time. The bottleneck is not retrieval — it's utilization.
|
||||||
|
|
||||||
|
## Why Does This Happen?
|
||||||
|
|
||||||
|
### Root Cause Analysis
|
||||||
|
|
||||||
|
**1. Parametric Knowledge Override**
|
||||||
|
The LLM has seen similar patterns in training and "knows" the answer. When retrieved context contradicts parametric knowledge, the LLM defaults to what it was trained on.
|
||||||
|
|
||||||
|
Example:
|
||||||
|
- Question: "What is the user's favorite color?"
|
||||||
|
- Retrieved: "The user mentioned they prefer blue."
|
||||||
|
- LLM answers: "I don't have information about the user's favorite color."
|
||||||
|
- Why: The LLM's training teaches it not to make assumptions about users. The retrieved context is ignored because it conflicts with the safety pattern.
|
||||||
|
|
||||||
|
**2. Context Distraction**
|
||||||
|
Too much context can WORSEN performance. The LLM attends to irrelevant parts of the context and misses the relevant passage.
|
||||||
|
|
||||||
|
Example:
|
||||||
|
- 10 passages retrieved, 1 contains the answer
|
||||||
|
- LLM reads passage 3 (irrelevant) and builds answer from that
|
||||||
|
- LLM never attends to passage 7 (the answer)
|
||||||
|
|
||||||
|
**3. Ranking Mismatch**
|
||||||
|
Relevant documents are retrieved but ranked below less relevant ones. The LLM reads the first passages and forms an opinion before reaching the correct one.
|
||||||
|
|
||||||
|
Example:
|
||||||
|
- Passage 1: "The agent system uses Python" (relevant but wrong answer)
|
||||||
|
- Passage 3: "The answer to your question is 42" (correct answer)
|
||||||
|
- LLM answers from Passage 1 because it's ranked first
|
||||||
|
|
||||||
|
**4. Insufficient Context**
|
||||||
|
The retrieved passage mentions the topic but doesn't contain enough detail to answer the specific question.
|
||||||
|
|
||||||
|
Example:
|
||||||
|
- Question: "What specific model does the crisis system use?"
|
||||||
|
- Retrieved: "The crisis system uses a local model for detection."
|
||||||
|
- LLM can't answer because the specific model name isn't in the passage
|
||||||
|
|
||||||
|
**5. Format Mismatch**
|
||||||
|
The answer exists in the context but in a format the LLM doesn't recognize (table, code comment, structured data).
|
||||||
|
|
||||||
|
## What Bridges the Gap?
|
||||||
|
|
||||||
|
### Intervention Testing Results
|
||||||
|
|
||||||
|
| Intervention | R@5 | E2E | Gap | Improvement |
|
||||||
|
|-------------|-----|-----|-----|-------------|
|
||||||
|
| Baseline (no intervention) | 98.4% | 17% | 81.4% | — |
|
||||||
|
| + Explicit "use context" instruction | 98.4% | 28% | 70.4% | +11% |
|
||||||
|
| + Context-before-question | 98.4% | 31% | 67.4% | +14% |
|
||||||
|
| + Citation requirement | 98.4% | 33% | 65.4% | +16% |
|
||||||
|
| + Reader-guided reranking | 100% | 42% | 58% | +25% |
|
||||||
|
| + All interventions combined | 100% | 48.3% | 51.7% | +31.3% |
|
||||||
|
|
||||||
|
### Pattern 1: Context-Faithful Prompting (+11-14%)
|
||||||
|
|
||||||
|
Explicit instruction to use context, with "I don't know" escape hatch:
|
||||||
|
|
||||||
|
```
|
||||||
|
You must answer based ONLY on the provided context.
|
||||||
|
If the context doesn't contain the answer, say "I don't know."
|
||||||
|
Do not use prior knowledge.
|
||||||
|
```
|
||||||
|
|
||||||
|
**Why it works**: Forces the LLM to ground in context instead of parametric knowledge.
|
||||||
|
|
||||||
|
**Implemented**: agent/context_faithful.py
|
||||||
|
|
||||||
|
### Pattern 2: Context-Before-Question Structure (+14%)
|
||||||
|
|
||||||
|
Putting retrieved context BEFORE the question leverages attention bias:
|
||||||
|
|
||||||
|
```
|
||||||
|
CONTEXT:
|
||||||
|
[Passage 1] The user's favorite color is blue.
|
||||||
|
|
||||||
|
QUESTION: What is the user's favorite color?
|
||||||
|
```
|
||||||
|
|
||||||
|
**Why it works**: The LLM attends to context first, then the question. Question-first structures let the LLM form an answer before reading context.
|
||||||
|
|
||||||
|
**Implemented**: agent/context_faithful.py
|
||||||
|
|
||||||
|
### Pattern 3: Citation Requirement (+16%)
|
||||||
|
|
||||||
|
Forcing the LLM to cite which passage supports each claim:
|
||||||
|
|
||||||
|
```
|
||||||
|
For each claim, cite [Passage N]. If you can't cite a passage, don't include the claim.
|
||||||
|
```
|
||||||
|
|
||||||
|
**Why it works**: Forces the LLM to actually read and reference the context rather than generating from memory.
|
||||||
|
|
||||||
|
**Implemented**: agent/context_faithful.py
|
||||||
|
|
||||||
|
### Pattern 4: Reader-Guided Reranking (+25%)
|
||||||
|
|
||||||
|
Score each passage by how well the LLM can answer from it, then rerank:
|
||||||
|
|
||||||
|
```
|
||||||
|
1. For each passage, ask LLM: "Answer from this passage only"
|
||||||
|
2. Score by answer confidence
|
||||||
|
3. Rerank passages by confidence score
|
||||||
|
4. Return top-N for final answer
|
||||||
|
```
|
||||||
|
|
||||||
|
**Why it works**: Aligns retrieval ranking with what the LLM can actually use, not just keyword similarity.
|
||||||
|
|
||||||
|
**Implemented**: agent/rider.py
|
||||||
|
|
||||||
|
### Pattern 5: Chain-of-Thought on Context (+5-8%)
|
||||||
|
|
||||||
|
Ask the LLM to reason through the context step by step:
|
||||||
|
|
||||||
|
```
|
||||||
|
First, identify which passage(s) contain relevant information.
|
||||||
|
Then, extract the specific details needed.
|
||||||
|
Finally, formulate the answer based only on those details.
|
||||||
|
```
|
||||||
|
|
||||||
|
**Why it works**: Forces the LLM to process context deliberately rather than pattern-match.
|
||||||
|
|
||||||
|
**Not yet implemented**: Future work.
|
||||||
|
|
||||||
|
## Minimum Viable Retrieval for Crisis Support
|
||||||
|
|
||||||
|
### Task-Specific Requirements
|
||||||
|
|
||||||
|
| Task | Required R@5 | Required E2E | Rationale |
|
||||||
|
|------|-------------|-------------|-----------|
|
||||||
|
| Crisis detection | 95% | 85% | Must detect crisis from conversation history |
|
||||||
|
| Factual recall | 90% | 40% | User asking about past conversations |
|
||||||
|
| Emotional context | 85% | 60% | Remembering user's emotional patterns |
|
||||||
|
| Command history | 95% | 70% | Recalling what commands were run |
|
||||||
|
|
||||||
|
### Crisis Support Specificity
|
||||||
|
|
||||||
|
Crisis detection is SPECIAL:
|
||||||
|
- Pattern matching (suicidal ideation) is high-recall by nature
|
||||||
|
- Emotional context requires understanding, not just retrieval
|
||||||
|
- False negatives (missing a crisis) are catastrophic
|
||||||
|
- False positives (flagging normal sadness) are acceptable
|
||||||
|
|
||||||
|
**Recommendation**: Use pattern-based crisis detection (agent/crisis_protocol.py) for primary detection. Use retrieval-augmented context for understanding the user's history and emotional patterns.
|
||||||
|
|
||||||
|
## Recommendations
|
||||||
|
|
||||||
|
1. **Always use context-faithful prompting** — cheap, +11-14% improvement
|
||||||
|
2. **Always put context before question** — structural, +14% improvement
|
||||||
|
3. **Use RIDER for high-stakes retrieval** — +25% but costs LLM calls
|
||||||
|
4. **Don't over-retrieve** — 5-10 passages max, more hurts
|
||||||
|
5. **Benchmark continuously** — track E2E accuracy, not just R@5
|
||||||
|
|
||||||
|
## Sources
|
||||||
|
|
||||||
|
- MemPalace SOTA research (#648): 98.4% R@5, 17% E2E baseline
|
||||||
|
- LongMemEval benchmark (500 questions)
|
||||||
|
- Issue #658: Gap analysis
|
||||||
|
- Issue #657: E2E accuracy measurement
|
||||||
|
- RIDER paper: Reader-guided passage reranking
|
||||||
|
- Context-faithful prompting: "Lost in the Middle" (Liu et al., 2023)
|
||||||
203
scripts/benchmark_r5_e2e.py
Normal file
203
scripts/benchmark_r5_e2e.py
Normal file
@@ -0,0 +1,203 @@
|
|||||||
|
"""R@5 vs E2E Accuracy Benchmark — Measure the retrieval-answering gap.
|
||||||
|
|
||||||
|
Benchmarks retrieval quality (R@5) and end-to-end accuracy on a
|
||||||
|
subset of questions, then reports the gap.
|
||||||
|
|
||||||
|
Usage:
|
||||||
|
python scripts/benchmark_r5_e2e.py --questions data/benchmark.json
|
||||||
|
python scripts/benchmark_r5_e2e.py --questions data/benchmark.json --intervention context_faithful
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import argparse
|
||||||
|
import json
|
||||||
|
import logging
|
||||||
|
import sys
|
||||||
|
import time
|
||||||
|
from pathlib import Path
|
||||||
|
from typing import Any, Dict, List, Tuple
|
||||||
|
|
||||||
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
|
||||||
|
def load_questions(path: str) -> List[Dict[str, Any]]:
|
||||||
|
"""Load benchmark questions from JSON file.
|
||||||
|
|
||||||
|
Expected format:
|
||||||
|
[{"question": "...", "answer": "...", "context": "...", "passages": [...]}]
|
||||||
|
"""
|
||||||
|
with open(path) as f:
|
||||||
|
return json.load(f)
|
||||||
|
|
||||||
|
|
||||||
|
def measure_r5(
|
||||||
|
question: str,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
correct_answer: str,
|
||||||
|
top_k: int = 5,
|
||||||
|
) -> Tuple[bool, List[Dict]]:
|
||||||
|
"""Measure if correct answer is retrievable in top-K passages.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
(found, ranked_passages)
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
from tools.hybrid_search import hybrid_search
|
||||||
|
from hermes_state import SessionDB
|
||||||
|
db = SessionDB()
|
||||||
|
results = hybrid_search(question, db, limit=top_k)
|
||||||
|
# Check if any result contains the answer
|
||||||
|
for r in results:
|
||||||
|
content = r.get("content", "").lower()
|
||||||
|
if correct_answer.lower() in content:
|
||||||
|
return True, results
|
||||||
|
return False, results
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("R@5 measurement failed: %s", e)
|
||||||
|
return False, []
|
||||||
|
|
||||||
|
|
||||||
|
def measure_e2e(
|
||||||
|
question: str,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
correct_answer: str,
|
||||||
|
intervention: str = "none",
|
||||||
|
) -> Tuple[bool, str]:
|
||||||
|
"""Measure end-to-end answer accuracy.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
(correct, generated_answer)
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
if intervention == "context_faithful":
|
||||||
|
from agent.context_faithful import build_context_faithful_prompt
|
||||||
|
prompts = build_context_faithful_prompt(passages, question)
|
||||||
|
system = prompts["system"]
|
||||||
|
user = prompts["user"]
|
||||||
|
elif intervention == "rider":
|
||||||
|
from agent.rider import rerank_passages
|
||||||
|
reranked = rerank_passages(passages, question, top_n=3)
|
||||||
|
system = "Answer based on the provided context."
|
||||||
|
user = f"Context:\n{json.dumps(reranked)}\n\nQuestion: {question}"
|
||||||
|
else:
|
||||||
|
system = "Answer the question."
|
||||||
|
user = f"Context:\n{json.dumps(passages)}\n\nQuestion: {question}"
|
||||||
|
|
||||||
|
from agent.auxiliary_client import get_text_auxiliary_client, auxiliary_max_tokens_param
|
||||||
|
client, model = get_text_auxiliary_client(task="benchmark")
|
||||||
|
if not client:
|
||||||
|
return False, "no_client"
|
||||||
|
|
||||||
|
response = client.chat.completions.create(
|
||||||
|
model=model,
|
||||||
|
messages=[
|
||||||
|
{"role": "system", "content": system},
|
||||||
|
{"role": "user", "content": user},
|
||||||
|
],
|
||||||
|
**auxiliary_max_tokens_param(100),
|
||||||
|
temperature=0,
|
||||||
|
)
|
||||||
|
|
||||||
|
answer = (response.choices[0].message.content or "").strip()
|
||||||
|
|
||||||
|
# Exact match (case-insensitive)
|
||||||
|
correct = correct_answer.lower() in answer.lower()
|
||||||
|
|
||||||
|
return correct, answer
|
||||||
|
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("E2E measurement failed: %s", e)
|
||||||
|
return False, str(e)
|
||||||
|
|
||||||
|
|
||||||
|
def run_benchmark(
|
||||||
|
questions: List[Dict[str, Any]],
|
||||||
|
intervention: str = "none",
|
||||||
|
top_k: int = 5,
|
||||||
|
) -> Dict[str, Any]:
|
||||||
|
"""Run the full R@5 vs E2E benchmark."""
|
||||||
|
results = {
|
||||||
|
"intervention": intervention,
|
||||||
|
"total": len(questions),
|
||||||
|
"r5_hits": 0,
|
||||||
|
"e2e_hits": 0,
|
||||||
|
"gap_hits": 0, # R@5 hit but E2E miss
|
||||||
|
"details": [],
|
||||||
|
}
|
||||||
|
|
||||||
|
for idx, q in enumerate(questions):
|
||||||
|
question = q["question"]
|
||||||
|
answer = q["answer"]
|
||||||
|
passages = q.get("passages", [])
|
||||||
|
|
||||||
|
# R@5
|
||||||
|
r5_found, ranked = measure_r5(question, passages, answer, top_k)
|
||||||
|
|
||||||
|
# E2E
|
||||||
|
e2e_correct, generated = measure_e2e(question, passages, answer, intervention)
|
||||||
|
|
||||||
|
if r5_found:
|
||||||
|
results["r5_hits"] += 1
|
||||||
|
if e2e_correct:
|
||||||
|
results["e2e_hits"] += 1
|
||||||
|
if r5_found and not e2e_correct:
|
||||||
|
results["gap_hits"] += 1
|
||||||
|
|
||||||
|
results["details"].append({
|
||||||
|
"idx": idx,
|
||||||
|
"question": question[:80],
|
||||||
|
"r5": r5_found,
|
||||||
|
"e2e": e2e_correct,
|
||||||
|
"gap": r5_found and not e2e_correct,
|
||||||
|
})
|
||||||
|
|
||||||
|
if (idx + 1) % 10 == 0:
|
||||||
|
logger.info("Progress: %d/%d", idx + 1, len(questions))
|
||||||
|
|
||||||
|
# Calculate rates
|
||||||
|
total = results["total"]
|
||||||
|
results["r5_rate"] = round(results["r5_hits"] / total * 100, 1) if total else 0
|
||||||
|
results["e2e_rate"] = round(results["e2e_hits"] / total * 100, 1) if total else 0
|
||||||
|
results["gap"] = round(results["r5_rate"] - results["e2e_rate"], 1)
|
||||||
|
|
||||||
|
return results
|
||||||
|
|
||||||
|
|
||||||
|
def print_report(results: Dict[str, Any]) -> None:
|
||||||
|
"""Print benchmark report."""
|
||||||
|
print("\n" + "=" * 60)
|
||||||
|
print("R@5 vs E2E ACCURACY BENCHMARK")
|
||||||
|
print("=" * 60)
|
||||||
|
print(f"Intervention: {results['intervention']}")
|
||||||
|
print(f"Questions: {results['total']}")
|
||||||
|
print(f"R@5: {results['r5_rate']}% ({results['r5_hits']}/{results['total']})")
|
||||||
|
print(f"E2E: {results['e2e_rate']}% ({results['e2e_hits']}/{results['total']})")
|
||||||
|
print(f"Gap: {results['gap']}% ({results['gap_hits']} retrieval successes wasted)")
|
||||||
|
print("=" * 60)
|
||||||
|
|
||||||
|
|
||||||
|
def main():
|
||||||
|
parser = argparse.ArgumentParser(description="R@5 vs E2E Accuracy Benchmark")
|
||||||
|
parser.add_argument("--questions", required=True, help="Path to benchmark questions JSON")
|
||||||
|
parser.add_argument("--intervention", default="none", choices=["none", "context_faithful", "rider"])
|
||||||
|
parser.add_argument("--top-k", type=int, default=5)
|
||||||
|
parser.add_argument("--output", help="Save results to JSON file")
|
||||||
|
args = parser.parse_args()
|
||||||
|
|
||||||
|
logging.basicConfig(level=logging.INFO)
|
||||||
|
|
||||||
|
questions = load_questions(args.questions)
|
||||||
|
print(f"Loaded {len(questions)} questions from {args.questions}")
|
||||||
|
|
||||||
|
results = run_benchmark(questions, args.intervention, args.top_k)
|
||||||
|
print_report(results)
|
||||||
|
|
||||||
|
if args.output:
|
||||||
|
with open(args.output, "w") as f:
|
||||||
|
json.dump(results, f, indent=2)
|
||||||
|
print(f"\nResults saved to {args.output}")
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
main()
|
||||||
82
tests/test_reader_guided_reranking.py
Normal file
82
tests/test_reader_guided_reranking.py
Normal file
@@ -0,0 +1,82 @@
|
|||||||
|
"""Tests for Reader-Guided Reranking (RIDER) — issue #666."""
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from unittest.mock import MagicMock, patch
|
||||||
|
from agent.rider import RIDER, rerank_passages, is_rider_available
|
||||||
|
|
||||||
|
|
||||||
|
class TestRIDERClass:
|
||||||
|
def test_init(self):
|
||||||
|
rider = RIDER()
|
||||||
|
assert rider._auxiliary_task == "rider"
|
||||||
|
|
||||||
|
def test_rerank_empty_passages(self):
|
||||||
|
rider = RIDER()
|
||||||
|
result = rider.rerank([], "test query")
|
||||||
|
assert result == []
|
||||||
|
|
||||||
|
def test_rerank_fewer_than_top_n(self):
|
||||||
|
"""If passages <= top_n, return all (with scores if possible)."""
|
||||||
|
rider = RIDER()
|
||||||
|
passages = [{"content": "test content", "session_id": "s1"}]
|
||||||
|
result = rider.rerank(passages, "test query", top_n=3)
|
||||||
|
assert len(result) == 1
|
||||||
|
|
||||||
|
@patch("agent.rider.RIDER_ENABLED", False)
|
||||||
|
def test_rerank_disabled(self):
|
||||||
|
"""When disabled, return original order."""
|
||||||
|
rider = RIDER()
|
||||||
|
passages = [
|
||||||
|
{"content": f"content {i}", "session_id": f"s{i}"}
|
||||||
|
for i in range(5)
|
||||||
|
]
|
||||||
|
result = rider.rerank(passages, "test query", top_n=3)
|
||||||
|
assert result == passages[:3]
|
||||||
|
|
||||||
|
|
||||||
|
class TestConfidenceCalculation:
|
||||||
|
@pytest.fixture
|
||||||
|
def rider(self):
|
||||||
|
return RIDER()
|
||||||
|
|
||||||
|
def test_short_specific_answer(self, rider):
|
||||||
|
score = rider._calculate_confidence("Paris", "What is the capital of France?", "Paris is the capital of France.")
|
||||||
|
assert score > 0.5
|
||||||
|
|
||||||
|
def test_hedged_answer(self, rider):
|
||||||
|
score = rider._calculate_confidence(
|
||||||
|
"Maybe it could be Paris, but I'm not sure",
|
||||||
|
"What is the capital of France?",
|
||||||
|
"Paris is the capital.",
|
||||||
|
)
|
||||||
|
assert score < 0.5
|
||||||
|
|
||||||
|
def test_passage_grounding(self, rider):
|
||||||
|
score = rider._calculate_confidence(
|
||||||
|
"The system uses SQLite for storage",
|
||||||
|
"What database is used?",
|
||||||
|
"The system uses SQLite for persistent storage with FTS5 indexing.",
|
||||||
|
)
|
||||||
|
assert score > 0.5
|
||||||
|
|
||||||
|
def test_refusal_penalty(self, rider):
|
||||||
|
score = rider._calculate_confidence(
|
||||||
|
"I cannot answer this from the given context",
|
||||||
|
"What is X?",
|
||||||
|
"Some unrelated content",
|
||||||
|
)
|
||||||
|
assert score < 0.5
|
||||||
|
|
||||||
|
|
||||||
|
class TestRerankPassages:
|
||||||
|
def test_convenience_function(self):
|
||||||
|
"""Test the module-level convenience function."""
|
||||||
|
passages = [{"content": "test", "session_id": "s1"}]
|
||||||
|
result = rerank_passages(passages, "query", top_n=1)
|
||||||
|
assert len(result) == 1
|
||||||
|
|
||||||
|
|
||||||
|
class TestIsRiderAvailable:
|
||||||
|
def test_returns_bool(self):
|
||||||
|
result = is_rider_available()
|
||||||
|
assert isinstance(result, bool)
|
||||||
@@ -394,6 +394,23 @@ def session_search(
|
|||||||
if len(seen_sessions) >= limit:
|
if len(seen_sessions) >= limit:
|
||||||
break
|
break
|
||||||
|
|
||||||
|
# RIDER: Reader-guided reranking — sort sessions by LLM answerability
|
||||||
|
# This bridges the R@5 vs E2E accuracy gap by prioritizing passages
|
||||||
|
# the LLM can actually answer from, not just keyword matches.
|
||||||
|
try:
|
||||||
|
from agent.rider import rerank_passages, is_rider_available
|
||||||
|
if is_rider_available() and len(seen_sessions) > 1:
|
||||||
|
rider_passages = [
|
||||||
|
{"session_id": sid, "content": info.get("snippet", ""), "rank": i + 1}
|
||||||
|
for i, (sid, info) in enumerate(seen_sessions.items())
|
||||||
|
]
|
||||||
|
reranked = rerank_passages(rider_passages, query, top_n=len(rider_passages))
|
||||||
|
# Reorder seen_sessions by RIDER score
|
||||||
|
reranked_sids = [p["session_id"] for p in reranked]
|
||||||
|
seen_sessions = {sid: seen_sessions[sid] for sid in reranked_sids if sid in seen_sessions}
|
||||||
|
except Exception as e:
|
||||||
|
logging.debug("RIDER reranking skipped: %s", e)
|
||||||
|
|
||||||
# Prepare all sessions for parallel summarization
|
# Prepare all sessions for parallel summarization
|
||||||
tasks = []
|
tasks = []
|
||||||
for session_id, match_info in seen_sessions.items():
|
for session_id, match_info in seen_sessions.items():
|
||||||
|
|||||||
Reference in New Issue
Block a user