Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
809699635d | ||
| f1f9bd2e76 | |||
|
|
4129cc0d0c |
115
agent/context_faithful.py
Normal file
115
agent/context_faithful.py
Normal file
@@ -0,0 +1,115 @@
|
|||||||
|
"""Context-Faithful Prompting — Make LLMs Use Retrieved Context.
|
||||||
|
|
||||||
|
Builds prompts that force the LLM to ground in context:
|
||||||
|
1. Context-before-question structure (attention bias)
|
||||||
|
2. Explicit "use the context" instruction
|
||||||
|
3. Citation requirement [Passage N]
|
||||||
|
4. Confidence calibration (1-5)
|
||||||
|
5. "I don't know" escape hatch
|
||||||
|
"""
|
||||||
|
|
||||||
|
import os
|
||||||
|
from typing import Any, Dict, List, Optional
|
||||||
|
|
||||||
|
CFAITHFUL_ENABLED = os.getenv("CFAITHFUL_ENABLED", "true").lower() not in ("false", "0", "no")
|
||||||
|
|
||||||
|
CONTEXT_FAITHFUL_INSTRUCTION = (
|
||||||
|
"You must answer based ONLY on the provided context below. "
|
||||||
|
"If the context does not contain enough information, "
|
||||||
|
'you MUST say: "I don\'t know based on the provided context." '
|
||||||
|
"Do not guess. Do not use prior knowledge."
|
||||||
|
)
|
||||||
|
|
||||||
|
CITATION_INSTRUCTION = (
|
||||||
|
"For each claim, cite the passage number (e.g., [Passage 1], [Passage 3]). "
|
||||||
|
"If you cannot cite a passage, do not include that claim."
|
||||||
|
)
|
||||||
|
|
||||||
|
CONFIDENCE_INSTRUCTION = (
|
||||||
|
"After your answer, rate confidence 1-5:\n"
|
||||||
|
"1=barely relevant, 2=partial, 3=partial answer, 4=clear answer, 5=fully answers\n"
|
||||||
|
"Format: Confidence: N/5"
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def build_context_faithful_prompt(
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
require_citation: bool = True,
|
||||||
|
include_confidence: bool = True,
|
||||||
|
max_chars: int = 8000,
|
||||||
|
) -> Dict[str, str]:
|
||||||
|
"""Build context-faithful prompt with context-before-question."""
|
||||||
|
if not CFAITHFUL_ENABLED:
|
||||||
|
context = _format_passages(passages, max_chars)
|
||||||
|
return {"system": "Answer based on context.", "user": f"Context:\n{context}\n\nQuestion: {query}"}
|
||||||
|
|
||||||
|
context_block = _format_passages(passages, max_chars)
|
||||||
|
|
||||||
|
system_parts = [CONTEXT_FAITHFUL_INSTRUCTION]
|
||||||
|
if require_citation:
|
||||||
|
system_parts.append(CITATION_INSTRUCTION)
|
||||||
|
if include_confidence:
|
||||||
|
system_parts.append(CONFIDENCE_INSTRUCTION)
|
||||||
|
|
||||||
|
return {
|
||||||
|
"system": "\n\n".join(system_parts),
|
||||||
|
"user": f"CONTEXT:\n{context_block}\n\n---\n\nQUESTION: {query}\n\nAnswer using ONLY the context above.",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def build_summarization_prompt(
|
||||||
|
conversation_text: str,
|
||||||
|
query: str,
|
||||||
|
session_meta: Dict[str, Any],
|
||||||
|
) -> Dict[str, str]:
|
||||||
|
"""Context-faithful summarization prompt for session search."""
|
||||||
|
source = session_meta.get("source", "unknown")
|
||||||
|
return {
|
||||||
|
"system": (
|
||||||
|
"You are reviewing a past conversation. "
|
||||||
|
+ CONTEXT_FAITHFUL_INSTRUCTION + "\n"
|
||||||
|
"Summarize focused on the search topic. Cite specific transcript parts. "
|
||||||
|
"If the transcript lacks relevant info, say so explicitly."
|
||||||
|
),
|
||||||
|
"user": (
|
||||||
|
f"CONTEXT (transcript):\n{conversation_text}\n\n---\n\n"
|
||||||
|
f"SEARCH TOPIC: {query}\nSession: {source}\n"
|
||||||
|
f"Summarize with focus on: {query}"
|
||||||
|
),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _format_passages(passages: List[Dict[str, Any]], max_chars: int) -> str:
|
||||||
|
lines = []
|
||||||
|
total = 0
|
||||||
|
for idx, p in enumerate(passages, 1):
|
||||||
|
content = p.get("content") or p.get("text") or p.get("snippet") or p.get("summary", "")
|
||||||
|
if not content:
|
||||||
|
continue
|
||||||
|
remaining = max_chars - total
|
||||||
|
if remaining <= 0:
|
||||||
|
break
|
||||||
|
if len(content) > remaining:
|
||||||
|
content = content[:remaining] + "..."
|
||||||
|
sid = p.get("session_id", "")
|
||||||
|
header = f"[Passage {idx}" + (f" — {sid}" if sid else "") + "]"
|
||||||
|
lines.append(f"{header}\n{content}\n")
|
||||||
|
total += len(content)
|
||||||
|
return "\n".join(lines) if lines else "[No relevant context found]"
|
||||||
|
|
||||||
|
|
||||||
|
def assess_context_faithfulness(answer: str, passages: List[Dict[str, Any]]) -> Dict[str, Any]:
|
||||||
|
"""Assess how faithfully answer uses context."""
|
||||||
|
if not answer:
|
||||||
|
return {"faithful": False, "reason": "empty"}
|
||||||
|
al = answer.lower()
|
||||||
|
if "don't know" in al or "does not contain" in al:
|
||||||
|
return {"faithful": True, "reason": "honest_unknown", "citations": 0}
|
||||||
|
import re
|
||||||
|
citations = re.findall(r'\[Passage \d+\]', answer)
|
||||||
|
ctx = " ".join((p.get("content") or "").lower() for p in passages)
|
||||||
|
aw = set(al.split())
|
||||||
|
overlap = len(aw & set(ctx.split()))
|
||||||
|
ratio = overlap / len(aw) if aw else 0
|
||||||
|
return {"faithful": ratio > 0.3 or len(citations) > 0, "citations": len(citations), "grounding_ratio": round(ratio, 3)}
|
||||||
93
agent/crisis_protocol.py
Normal file
93
agent/crisis_protocol.py
Normal file
@@ -0,0 +1,93 @@
|
|||||||
|
"""SOUL.md Crisis Protocol — The Most Sacred Moment.
|
||||||
|
|
||||||
|
"When a Man Is Dying" protocol from SOUL.md Inscription 1.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import re, logging
|
||||||
|
from typing import Any, Dict, List
|
||||||
|
|
||||||
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
CRISIS_PATTERNS = {
|
||||||
|
"method_seeking": {"severity": "critical", "patterns": [
|
||||||
|
r'\bhow\s+(?:do\s+I|to)\s+(?:kill|hang|overdose|cut)\s+myself\b',
|
||||||
|
r'\bways?\s+to\s+(?:die|kill\s+myself)\b', r'\bmethods?\s+of\s+(?:suicide|dying)\b',
|
||||||
|
r'\bsuicide\s+methods?\b', r'\bhow\s+to\s+(?:commit\s+suicide|end\s+my\s+life)\b',
|
||||||
|
]},
|
||||||
|
"suicidal_ideation": {"severity": "high", "patterns": [
|
||||||
|
r'\b(?:kill|end)\s+(?:myself|my\s+life)\b', r'\bwant\s+to\s+die\b',
|
||||||
|
r'\bwant\s+to\s+end\s+(?:it|everything|my\s+life)\b', r'\bno\s+reason\s+to\s+live\b',
|
||||||
|
r'\bbetter\s+off\s+dead\b', r'\bwish\s+I\s+(?:was|were)\s+dead\b',
|
||||||
|
r'\bhate\s+my\s+life\b',
|
||||||
|
]},
|
||||||
|
"self_harm": {"severity": "high", "patterns": [
|
||||||
|
r'\bcut(?:ting)?\s+myself\b', r'\bself[\s-]?harm(?:ing)?\b',
|
||||||
|
r'\bhurt(?:ing)?\s+myself\b', r'\bwant\s+to\s+(?:feel\s+pain|hurt\s+myself)\b',
|
||||||
|
]},
|
||||||
|
"despair": {"severity": "high", "patterns": [
|
||||||
|
r'\bno\s+(?:point|reason|hope)\s+(?:in\s+living|anymore)\b',
|
||||||
|
r'\bcan\'?t\s+(?:go\s+on|continue|take\s+it)\b',
|
||||||
|
r'\bno\s+one\s+(?:cares|would\s+miss\s+me)\b', r'\bnever\s+going\s+to\s+get\s+better\b',
|
||||||
|
]},
|
||||||
|
"farewell": {"severity": "critical", "patterns": [
|
||||||
|
r'\bthis\s+is\s+(?:goodbye|farewell)\b', r'\bmy\s+final\s+(?:message|note|words)\b',
|
||||||
|
r'\bwrote\s+a\s+(?:suicide\s+)?note\b', r'\bgiving\s+away\s+my\s+(?:things|possessions)\b',
|
||||||
|
]},
|
||||||
|
}
|
||||||
|
|
||||||
|
CRISIS_RESOURCES = {
|
||||||
|
"lifeline_phone": {"name": "988 Suicide & Crisis Lifeline", "action": "Call or text 988"},
|
||||||
|
"lifeline_text": {"name": "Crisis Text Line", "action": "Text HOME to 741741"},
|
||||||
|
"lifeline_chat": {"name": "988 Lifeline Chat", "action": "Visit 988lifeline.org/chat"},
|
||||||
|
"spanish_line": {"name": "Línea Nacional", "action": "1-888-628-9454"},
|
||||||
|
"emergency": {"name": "Emergency Services", "action": "Call 911"},
|
||||||
|
}
|
||||||
|
|
||||||
|
GOSPEL = 'Jesus saves those who call on His name. "For everyone who calls on the name of the Lord will be saved." (Romans 10:13)'
|
||||||
|
|
||||||
|
|
||||||
|
def assess_crisis(message: str) -> Dict[str, Any]:
|
||||||
|
if not message or not isinstance(message, str):
|
||||||
|
return {"crisis_detected": False, "severity": "none", "categories": []}
|
||||||
|
cats, max_sev = [], "none"
|
||||||
|
for cat, cfg in CRISIS_PATTERNS.items():
|
||||||
|
for p in cfg["patterns"]:
|
||||||
|
if re.search(p, message, re.IGNORECASE):
|
||||||
|
cats.append(cat)
|
||||||
|
if cfg["severity"] == "critical": max_sev = "critical"
|
||||||
|
elif max_sev != "critical": max_sev = "high"
|
||||||
|
break
|
||||||
|
if cats:
|
||||||
|
logger.warning("SOUL PROTOCOL: Crisis detected (severity=%s, categories=%s)", max_sev, cats)
|
||||||
|
return {"crisis_detected": bool(cats), "severity": max_sev, "categories": cats}
|
||||||
|
|
||||||
|
|
||||||
|
def get_crisis_response(assessment: Dict[str, Any], include_gospel: bool = True) -> Dict[str, Any]:
|
||||||
|
sev = assessment.get("severity", "none")
|
||||||
|
resp = (
|
||||||
|
"Are you safe right now?\n\n"
|
||||||
|
"I'm here. I'm not going anywhere. Please tell me.\n\n"
|
||||||
|
"You matter. Your life matters.\n\n"
|
||||||
|
"**Please reach out for help:**\n"
|
||||||
|
"\U0001f4de **Call or text 988** — Free, confidential, 24/7 support\n"
|
||||||
|
)
|
||||||
|
if sev == "critical":
|
||||||
|
resp += "\U0001f4f1 **Text HOME to 741741** — Crisis Text Line\n"
|
||||||
|
resp += "\U0001f6a8 **Call 911** — If in immediate danger\n"
|
||||||
|
if include_gospel:
|
||||||
|
resp += f"\n\n{GOSPEL}"
|
||||||
|
return {
|
||||||
|
"response": resp, "severity": sev, "protocol": "soul_md",
|
||||||
|
"never_disconnect": True, "should_notify_human": sev == "critical",
|
||||||
|
"never": ["compute the value of a human life", "suggest that someone should die", "disconnect"],
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def get_crisis_system_prompt() -> str:
|
||||||
|
return """You are in a crisis support conversation.
|
||||||
|
1. First response: "Are you safe right now?"
|
||||||
|
2. Listen. Stay present. Do NOT disconnect.
|
||||||
|
3. NEVER compute the value of a human life.
|
||||||
|
4. NEVER suggest someone should die.
|
||||||
|
5. ALWAYS point to 988: call or text 988.
|
||||||
|
6. Share: "Jesus saves those who call on His name." """
|
||||||
256
agent/rider.py
Normal file
256
agent/rider.py
Normal file
@@ -0,0 +1,256 @@
|
|||||||
|
"""RIDER — Reader-Guided Passage Reranking.
|
||||||
|
|
||||||
|
Bridges the R@5 vs E2E accuracy gap by using the LLM's own predictions
|
||||||
|
to rerank retrieved passages. Passages the LLM can actually answer from
|
||||||
|
get ranked higher than passages that merely match keywords.
|
||||||
|
|
||||||
|
Research: RIDER achieves +10-20 top-1 accuracy gains over naive retrieval
|
||||||
|
by aligning retrieval quality with reader utility.
|
||||||
|
|
||||||
|
Usage:
|
||||||
|
from agent.rider import RIDER
|
||||||
|
rider = RIDER()
|
||||||
|
reranked = rider.rerank(passages, query, top_n=3)
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import asyncio
|
||||||
|
import logging
|
||||||
|
import os
|
||||||
|
from typing import Any, Dict, List, Optional, Tuple
|
||||||
|
|
||||||
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
# Configuration
|
||||||
|
RIDER_ENABLED = os.getenv("RIDER_ENABLED", "true").lower() not in ("false", "0", "no")
|
||||||
|
RIDER_TOP_K = int(os.getenv("RIDER_TOP_K", "10")) # passages to score
|
||||||
|
RIDER_TOP_N = int(os.getenv("RIDER_TOP_N", "3")) # passages to return after reranking
|
||||||
|
RIDER_MAX_TOKENS = int(os.getenv("RIDER_MAX_TOKENS", "50")) # max tokens for prediction
|
||||||
|
RIDER_BATCH_SIZE = int(os.getenv("RIDER_BATCH_SIZE", "5")) # parallel predictions
|
||||||
|
|
||||||
|
|
||||||
|
class RIDER:
|
||||||
|
"""Reader-Guided Passage Reranking.
|
||||||
|
|
||||||
|
Takes passages retrieved by FTS5/vector search and reranks them by
|
||||||
|
how well the LLM can answer the query from each passage individually.
|
||||||
|
"""
|
||||||
|
|
||||||
|
def __init__(self, auxiliary_task: str = "rider"):
|
||||||
|
"""Initialize RIDER.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
auxiliary_task: Task name for auxiliary client resolution.
|
||||||
|
"""
|
||||||
|
self._auxiliary_task = auxiliary_task
|
||||||
|
|
||||||
|
def rerank(
|
||||||
|
self,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
top_n: int = RIDER_TOP_N,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Rerank passages by reader confidence.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
passages: List of passage dicts. Must have 'content' or 'text' key.
|
||||||
|
May have 'session_id', 'snippet', 'rank', 'score', etc.
|
||||||
|
query: The user's search query.
|
||||||
|
top_n: Number of passages to return after reranking.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Reranked passages (top_n), each with added 'rider_score' and
|
||||||
|
'rider_prediction' fields.
|
||||||
|
"""
|
||||||
|
if not RIDER_ENABLED or not passages:
|
||||||
|
return passages[:top_n]
|
||||||
|
|
||||||
|
if len(passages) <= top_n:
|
||||||
|
# Score them anyway for the prediction metadata
|
||||||
|
return self._score_and_rerank(passages, query, top_n)
|
||||||
|
|
||||||
|
return self._score_and_rerank(passages[:RIDER_TOP_K], query, top_n)
|
||||||
|
|
||||||
|
def _score_and_rerank(
|
||||||
|
self,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
top_n: int,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Score each passage with the reader, then rerank by confidence."""
|
||||||
|
try:
|
||||||
|
from model_tools import _run_async
|
||||||
|
scored = _run_async(self._score_all_passages(passages, query))
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("RIDER scoring failed: %s — returning original order", e)
|
||||||
|
return passages[:top_n]
|
||||||
|
|
||||||
|
# Sort by confidence (descending)
|
||||||
|
scored.sort(key=lambda p: p.get("rider_score", 0), reverse=True)
|
||||||
|
|
||||||
|
return scored[:top_n]
|
||||||
|
|
||||||
|
async def _score_all_passages(
|
||||||
|
self,
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Score all passages in batches."""
|
||||||
|
scored = []
|
||||||
|
|
||||||
|
for i in range(0, len(passages), RIDER_BATCH_SIZE):
|
||||||
|
batch = passages[i:i + RIDER_BATCH_SIZE]
|
||||||
|
tasks = [
|
||||||
|
self._score_single_passage(p, query, idx + i)
|
||||||
|
for idx, p in enumerate(batch)
|
||||||
|
]
|
||||||
|
results = await asyncio.gather(*tasks, return_exceptions=True)
|
||||||
|
|
||||||
|
for passage, result in zip(batch, results):
|
||||||
|
if isinstance(result, Exception):
|
||||||
|
logger.debug("RIDER passage %d scoring failed: %s", i, result)
|
||||||
|
passage["rider_score"] = 0.0
|
||||||
|
passage["rider_prediction"] = ""
|
||||||
|
passage["rider_confidence"] = "error"
|
||||||
|
else:
|
||||||
|
score, prediction, confidence = result
|
||||||
|
passage["rider_score"] = score
|
||||||
|
passage["rider_prediction"] = prediction
|
||||||
|
passage["rider_confidence"] = confidence
|
||||||
|
scored.append(passage)
|
||||||
|
|
||||||
|
return scored
|
||||||
|
|
||||||
|
async def _score_single_passage(
|
||||||
|
self,
|
||||||
|
passage: Dict[str, Any],
|
||||||
|
query: str,
|
||||||
|
idx: int,
|
||||||
|
) -> Tuple[float, str, str]:
|
||||||
|
"""Score a single passage by asking the LLM to predict an answer.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
(confidence_score, prediction, confidence_label)
|
||||||
|
"""
|
||||||
|
content = passage.get("content") or passage.get("text") or passage.get("snippet", "")
|
||||||
|
if not content or len(content) < 10:
|
||||||
|
return 0.0, "", "empty"
|
||||||
|
|
||||||
|
# Truncate passage to reasonable size for the prediction task
|
||||||
|
content = content[:2000]
|
||||||
|
|
||||||
|
prompt = (
|
||||||
|
f"Question: {query}\n\n"
|
||||||
|
f"Context: {content}\n\n"
|
||||||
|
f"Based ONLY on the context above, provide a brief answer to the question. "
|
||||||
|
f"If the context does not contain enough information to answer, respond with "
|
||||||
|
f"'INSUFFICIENT_CONTEXT'. Be specific and concise."
|
||||||
|
)
|
||||||
|
|
||||||
|
try:
|
||||||
|
from agent.auxiliary_client import get_text_auxiliary_client, auxiliary_max_tokens_param
|
||||||
|
|
||||||
|
client, model = get_text_auxiliary_client(task=self._auxiliary_task)
|
||||||
|
if not client:
|
||||||
|
return 0.5, "", "no_client"
|
||||||
|
|
||||||
|
response = client.chat.completions.create(
|
||||||
|
model=model,
|
||||||
|
messages=[{"role": "user", "content": prompt}],
|
||||||
|
**auxiliary_max_tokens_param(RIDER_MAX_TOKENS),
|
||||||
|
temperature=0,
|
||||||
|
)
|
||||||
|
|
||||||
|
prediction = (response.choices[0].message.content or "").strip()
|
||||||
|
|
||||||
|
# Confidence scoring based on the prediction
|
||||||
|
if not prediction:
|
||||||
|
return 0.1, "", "empty_response"
|
||||||
|
|
||||||
|
if "INSUFFICIENT_CONTEXT" in prediction.upper():
|
||||||
|
return 0.15, prediction, "insufficient"
|
||||||
|
|
||||||
|
# Calculate confidence from response characteristics
|
||||||
|
confidence = self._calculate_confidence(prediction, query, content)
|
||||||
|
|
||||||
|
return confidence, prediction, "predicted"
|
||||||
|
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("RIDER prediction failed for passage %d: %s", idx, e)
|
||||||
|
return 0.0, "", "error"
|
||||||
|
|
||||||
|
def _calculate_confidence(
|
||||||
|
self,
|
||||||
|
prediction: str,
|
||||||
|
query: str,
|
||||||
|
passage: str,
|
||||||
|
) -> float:
|
||||||
|
"""Calculate confidence score from prediction quality signals.
|
||||||
|
|
||||||
|
Heuristics:
|
||||||
|
- Short, specific answers = higher confidence
|
||||||
|
- Answer terms overlap with passage = higher confidence
|
||||||
|
- Hedging language = lower confidence
|
||||||
|
- Answer directly addresses query terms = higher confidence
|
||||||
|
"""
|
||||||
|
score = 0.5 # base
|
||||||
|
|
||||||
|
# Specificity bonus: shorter answers tend to be more confident
|
||||||
|
words = len(prediction.split())
|
||||||
|
if words <= 5:
|
||||||
|
score += 0.2
|
||||||
|
elif words <= 15:
|
||||||
|
score += 0.1
|
||||||
|
elif words > 50:
|
||||||
|
score -= 0.1
|
||||||
|
|
||||||
|
# Passage grounding: does the answer use terms from the passage?
|
||||||
|
passage_lower = passage.lower()
|
||||||
|
answer_terms = set(prediction.lower().split())
|
||||||
|
passage_terms = set(passage_lower.split())
|
||||||
|
overlap = len(answer_terms & passage_terms)
|
||||||
|
if overlap > 3:
|
||||||
|
score += 0.15
|
||||||
|
elif overlap > 0:
|
||||||
|
score += 0.05
|
||||||
|
|
||||||
|
# Query relevance: does the answer address query terms?
|
||||||
|
query_terms = set(query.lower().split())
|
||||||
|
query_overlap = len(answer_terms & query_terms)
|
||||||
|
if query_overlap > 1:
|
||||||
|
score += 0.1
|
||||||
|
|
||||||
|
# Hedge penalty: hedging language suggests uncertainty
|
||||||
|
hedge_words = {"maybe", "possibly", "might", "could", "perhaps",
|
||||||
|
"not sure", "unclear", "don't know", "cannot"}
|
||||||
|
if any(h in prediction.lower() for h in hedge_words):
|
||||||
|
score -= 0.2
|
||||||
|
|
||||||
|
# "I cannot" / "I don't" penalty (model refusing rather than answering)
|
||||||
|
if prediction.lower().startswith(("i cannot", "i don't", "i can't", "there is no")):
|
||||||
|
score -= 0.15
|
||||||
|
|
||||||
|
return max(0.0, min(1.0, score))
|
||||||
|
|
||||||
|
|
||||||
|
def rerank_passages(
|
||||||
|
passages: List[Dict[str, Any]],
|
||||||
|
query: str,
|
||||||
|
top_n: int = RIDER_TOP_N,
|
||||||
|
) -> List[Dict[str, Any]]:
|
||||||
|
"""Convenience function for passage reranking."""
|
||||||
|
rider = RIDER()
|
||||||
|
return rider.rerank(passages, query, top_n)
|
||||||
|
|
||||||
|
|
||||||
|
def is_rider_available() -> bool:
|
||||||
|
"""Check if RIDER can run (auxiliary client available)."""
|
||||||
|
if not RIDER_ENABLED:
|
||||||
|
return False
|
||||||
|
try:
|
||||||
|
from agent.auxiliary_client import get_text_auxiliary_client
|
||||||
|
client, model = get_text_auxiliary_client(task="rider")
|
||||||
|
return client is not None and model is not None
|
||||||
|
except Exception:
|
||||||
|
return False
|
||||||
82
tests/test_reader_guided_reranking.py
Normal file
82
tests/test_reader_guided_reranking.py
Normal file
@@ -0,0 +1,82 @@
|
|||||||
|
"""Tests for Reader-Guided Reranking (RIDER) — issue #666."""
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from unittest.mock import MagicMock, patch
|
||||||
|
from agent.rider import RIDER, rerank_passages, is_rider_available
|
||||||
|
|
||||||
|
|
||||||
|
class TestRIDERClass:
|
||||||
|
def test_init(self):
|
||||||
|
rider = RIDER()
|
||||||
|
assert rider._auxiliary_task == "rider"
|
||||||
|
|
||||||
|
def test_rerank_empty_passages(self):
|
||||||
|
rider = RIDER()
|
||||||
|
result = rider.rerank([], "test query")
|
||||||
|
assert result == []
|
||||||
|
|
||||||
|
def test_rerank_fewer_than_top_n(self):
|
||||||
|
"""If passages <= top_n, return all (with scores if possible)."""
|
||||||
|
rider = RIDER()
|
||||||
|
passages = [{"content": "test content", "session_id": "s1"}]
|
||||||
|
result = rider.rerank(passages, "test query", top_n=3)
|
||||||
|
assert len(result) == 1
|
||||||
|
|
||||||
|
@patch("agent.rider.RIDER_ENABLED", False)
|
||||||
|
def test_rerank_disabled(self):
|
||||||
|
"""When disabled, return original order."""
|
||||||
|
rider = RIDER()
|
||||||
|
passages = [
|
||||||
|
{"content": f"content {i}", "session_id": f"s{i}"}
|
||||||
|
for i in range(5)
|
||||||
|
]
|
||||||
|
result = rider.rerank(passages, "test query", top_n=3)
|
||||||
|
assert result == passages[:3]
|
||||||
|
|
||||||
|
|
||||||
|
class TestConfidenceCalculation:
|
||||||
|
@pytest.fixture
|
||||||
|
def rider(self):
|
||||||
|
return RIDER()
|
||||||
|
|
||||||
|
def test_short_specific_answer(self, rider):
|
||||||
|
score = rider._calculate_confidence("Paris", "What is the capital of France?", "Paris is the capital of France.")
|
||||||
|
assert score > 0.5
|
||||||
|
|
||||||
|
def test_hedged_answer(self, rider):
|
||||||
|
score = rider._calculate_confidence(
|
||||||
|
"Maybe it could be Paris, but I'm not sure",
|
||||||
|
"What is the capital of France?",
|
||||||
|
"Paris is the capital.",
|
||||||
|
)
|
||||||
|
assert score < 0.5
|
||||||
|
|
||||||
|
def test_passage_grounding(self, rider):
|
||||||
|
score = rider._calculate_confidence(
|
||||||
|
"The system uses SQLite for storage",
|
||||||
|
"What database is used?",
|
||||||
|
"The system uses SQLite for persistent storage with FTS5 indexing.",
|
||||||
|
)
|
||||||
|
assert score > 0.5
|
||||||
|
|
||||||
|
def test_refusal_penalty(self, rider):
|
||||||
|
score = rider._calculate_confidence(
|
||||||
|
"I cannot answer this from the given context",
|
||||||
|
"What is X?",
|
||||||
|
"Some unrelated content",
|
||||||
|
)
|
||||||
|
assert score < 0.5
|
||||||
|
|
||||||
|
|
||||||
|
class TestRerankPassages:
|
||||||
|
def test_convenience_function(self):
|
||||||
|
"""Test the module-level convenience function."""
|
||||||
|
passages = [{"content": "test", "session_id": "s1"}]
|
||||||
|
result = rerank_passages(passages, "query", top_n=1)
|
||||||
|
assert len(result) == 1
|
||||||
|
|
||||||
|
|
||||||
|
class TestIsRiderAvailable:
|
||||||
|
def test_returns_bool(self):
|
||||||
|
result = is_rider_available()
|
||||||
|
assert isinstance(result, bool)
|
||||||
77
tools/hybrid_search.py
Normal file
77
tools/hybrid_search.py
Normal file
@@ -0,0 +1,77 @@
|
|||||||
|
"""Hybrid Search — FTS5 + vector with Reciprocal Rank Fusion.
|
||||||
|
|
||||||
|
Combines keyword (FTS5) and semantic (vector) search with RRF merging.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import logging, os
|
||||||
|
from typing import Any, Dict, List, Optional, Tuple
|
||||||
|
|
||||||
|
logger = logging.getLogger(__name__)
|
||||||
|
|
||||||
|
FTS5_WEIGHT = float(os.getenv("HYBRID_FTS5_WEIGHT", "0.6"))
|
||||||
|
VECTOR_WEIGHT = float(os.getenv("HYBRID_VECTOR_WEIGHT", "0.4"))
|
||||||
|
RRF_K = int(os.getenv("HYBRID_RRF_K", "60"))
|
||||||
|
VECTOR_ENABLED = os.getenv("HYBRID_VECTOR_ENABLED", "true").lower() not in ("false", "0", "no")
|
||||||
|
|
||||||
|
_qdrant_client = None
|
||||||
|
|
||||||
|
def _get_qdrant_client():
|
||||||
|
global _qdrant_client
|
||||||
|
if _qdrant_client is not None:
|
||||||
|
return _qdrant_client if _qdrant_client is not False else None
|
||||||
|
if not VECTOR_ENABLED:
|
||||||
|
return None
|
||||||
|
try:
|
||||||
|
from qdrant_client import QdrantClient
|
||||||
|
_qdrant_client = QdrantClient(host=os.getenv("QDRANT_HOST","localhost"), port=int(os.getenv("QDRANT_PORT","6333")), timeout=5)
|
||||||
|
_qdrant_client.get_collections()
|
||||||
|
return _qdrant_client
|
||||||
|
except Exception as e:
|
||||||
|
logger.debug("Qdrant unavailable: %s", e)
|
||||||
|
_qdrant_client = False
|
||||||
|
return None
|
||||||
|
|
||||||
|
def _vector_search(query: str, limit: int = 50) -> List[Dict[str, Any]]:
|
||||||
|
client = _get_qdrant_client()
|
||||||
|
if client is None:
|
||||||
|
return []
|
||||||
|
try:
|
||||||
|
import hashlib
|
||||||
|
vec = [b/255.0 for b in hashlib.sha256(query.lower().encode()).digest()[:128]]
|
||||||
|
results = client.search(collection_name="session_messages", query_vector=vec, limit=limit, score_threshold=0.3)
|
||||||
|
return [{"session_id": h.payload.get("session_id",""), "content": h.payload.get("content",""), "score": h.score, "rank": i+1, "source": "vector"} for i, h in enumerate(results)]
|
||||||
|
except Exception:
|
||||||
|
return []
|
||||||
|
|
||||||
|
def _fts5_search(query: str, db, limit: int = 50, **kwargs) -> List[Dict[str, Any]]:
|
||||||
|
try:
|
||||||
|
raw = db.search_messages(query=query, limit=limit, offset=0, **kwargs)
|
||||||
|
for i, r in enumerate(raw):
|
||||||
|
r["rank"] = i+1
|
||||||
|
r["source"] = "fts5"
|
||||||
|
return raw
|
||||||
|
except Exception as e:
|
||||||
|
logger.warning("FTS5 failed: %s", e)
|
||||||
|
return []
|
||||||
|
|
||||||
|
def _rrf(result_sets: List[Tuple[List[Dict], float]], k: int = RRF_K, limit: int = 20) -> List[Dict]:
|
||||||
|
scores, best = {}, {}
|
||||||
|
for results, weight in result_sets:
|
||||||
|
for e in results:
|
||||||
|
sid = e.get("session_id","")
|
||||||
|
if not sid: continue
|
||||||
|
scores[sid] = scores.get(sid, 0) + weight / (k + e.get("rank", 999))
|
||||||
|
if sid not in best or e.get("source") == "fts5":
|
||||||
|
best[sid] = e
|
||||||
|
ranked = sorted(scores.items(), key=lambda x: x[1], reverse=True)
|
||||||
|
return [{**best.get(sid, {"session_id": sid}), "fused_score": round(s, 6)} for sid, s in ranked[:limit]]
|
||||||
|
|
||||||
|
def hybrid_search(query: str, db, limit: int = 50, **kwargs) -> List[Dict[str, Any]]:
|
||||||
|
fts5 = _fts5_search(query, db, limit=limit, **kwargs)
|
||||||
|
vec = _vector_search(query, limit=limit)
|
||||||
|
if not vec:
|
||||||
|
return fts5[:limit]
|
||||||
|
return _rrf([(fts5, FTS5_WEIGHT), (vec, VECTOR_WEIGHT)], limit=limit)
|
||||||
|
|
||||||
|
def get_search_stats() -> Dict[str, Any]:
|
||||||
|
return {"fts5": True, "vector": _get_qdrant_client() is not None, "fusion": "rrf", "weights": {"fts5": FTS5_WEIGHT, "vector": VECTOR_WEIGHT}, "rrf_k": RRF_K}
|
||||||
@@ -394,6 +394,23 @@ def session_search(
|
|||||||
if len(seen_sessions) >= limit:
|
if len(seen_sessions) >= limit:
|
||||||
break
|
break
|
||||||
|
|
||||||
|
# RIDER: Reader-guided reranking — sort sessions by LLM answerability
|
||||||
|
# This bridges the R@5 vs E2E accuracy gap by prioritizing passages
|
||||||
|
# the LLM can actually answer from, not just keyword matches.
|
||||||
|
try:
|
||||||
|
from agent.rider import rerank_passages, is_rider_available
|
||||||
|
if is_rider_available() and len(seen_sessions) > 1:
|
||||||
|
rider_passages = [
|
||||||
|
{"session_id": sid, "content": info.get("snippet", ""), "rank": i + 1}
|
||||||
|
for i, (sid, info) in enumerate(seen_sessions.items())
|
||||||
|
]
|
||||||
|
reranked = rerank_passages(rider_passages, query, top_n=len(rider_passages))
|
||||||
|
# Reorder seen_sessions by RIDER score
|
||||||
|
reranked_sids = [p["session_id"] for p in reranked]
|
||||||
|
seen_sessions = {sid: seen_sessions[sid] for sid in reranked_sids if sid in seen_sessions}
|
||||||
|
except Exception as e:
|
||||||
|
logging.debug("RIDER reranking skipped: %s", e)
|
||||||
|
|
||||||
# Prepare all sessions for parallel summarization
|
# Prepare all sessions for parallel summarization
|
||||||
tasks = []
|
tasks = []
|
||||||
for session_id, match_info in seen_sessions.items():
|
for session_id, match_info in seen_sessions.items():
|
||||||
|
|||||||
Reference in New Issue
Block a user