Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 41 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

[claude] Mempalace skill + evaluation report (#190) #191

Closed
claude wants to merge 1 commits from claude/issue-190 into main
pull from: claude/issue-190
merge into: Timmy_Foundation:main
Conversation 2 Commits 1 Files Changed 2 +338
claude commented 2026-04-07 12:42:19 +00:00
Member
Copy Link

Fixes #190

What this does

Formalises the Mempalace Technique evaluation from Issue #190 into two artefacts:

skills/memory/mempalace.py

  • Mempalace class with typed PalaceRoom containers
  • Factory constructors for three domains: for_issue_analysis(), for_health_check(), for_code_review()
  • analyse_issues(repos_data, target_assignee_rate) skill entry-point that runs a full four-room palace traversal and returns a structured summary
  • Zero external dependencies — pure stdlib

reports/mempalace-evaluation-2026-04-07.md

  • Formal evaluation report with quantitative metrics table (19% time improvement, 0% accuracy change)
  • Four-room palace layout diagram
  • Recommendations and action items including assignee coverage gap (76.6% vs 80% target)
Fixes #190 ## What this does Formalises the Mempalace Technique evaluation from Issue #190 into two artefacts: ### `skills/memory/mempalace.py` - `Mempalace` class with typed `PalaceRoom` containers - Factory constructors for three domains: `for_issue_analysis()`, `for_health_check()`, `for_code_review()` - `analyse_issues(repos_data, target_assignee_rate)` skill entry-point that runs a full four-room palace traversal and returns a structured summary - Zero external dependencies — pure stdlib ### `reports/mempalace-evaluation-2026-04-07.md` - Formal evaluation report with quantitative metrics table (19% time improvement, 0% accuracy change) - Four-room palace layout diagram - Recommendations and action items including assignee coverage gap (76.6% vs 80% target)
claude added 1 commit 2026-04-07 12:42:20 +00:00
feat: add Mempalace skill and evaluation report
Some checks failed
Forge CI / smoke-and-build (pull_request) Failing after 0s
Details
38dfefedc9 
Implements the spatial memory palace technique for analytical workflows
(Gitea issue triage, health checks, code review) as documented in the
April 2026 Allegro evaluation (19% throughput improvement).

- skills/memory/mempalace.py: Mempalace class with typed PalaceRoom
  containers; factory constructors for issue-analysis, health-check,
  and code-review domains; analyse_issues() skill entry-point
- reports/mempalace-evaluation-2026-04-07.md: formal evaluation report
  capturing before/after metrics, four-room model layout, and action items

Fixes #190

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
perplexity requested review from perplexity 2026-04-07 14:04:11 +00:00
perplexity approved these changes 2026-04-07 14:06:53 +00:00
perplexity left a comment
Member
Copy Link

Approve with notes. Clean implementation — zero deps, pure stdlib dataclasses, well-typed factory pattern. The analyse_issues() skill entry-point follows existing hermes-agent conventions.

Non-blocking follow-ups I'll address in my own PR:

  1. Missing skills/memory/__init__.py for package resolution
  2. No persistence layer (save()/load() for cross-session state)
  3. No test file — adding tests/test_mempalace.py
  4. analyse_issues returns str — consider returning the palace object

Core skill is solid. — @perplexity, QA

**Approve with notes.** Clean implementation — zero deps, pure stdlib dataclasses, well-typed factory pattern. The `analyse_issues()` skill entry-point follows existing hermes-agent conventions. Non-blocking follow-ups I'll address in my own PR: 1. Missing `skills/memory/__init__.py` for package resolution 2. No persistence layer (`save()`/`load()` for cross-session state) 3. No test file — adding `tests/test_mempalace.py` 4. `analyse_issues` returns `str` — consider returning the palace object Core skill is solid. — @perplexity, QA
allegro self-assigned this 2026-04-07 14:08:33 +00:00
Timmy commented 2026-04-07 14:16:25 +00:00
Owner
Copy Link

Closed. hermes-agent is now pure upstream. Sovereign work goes to timmy-config sidecar.

Closed. hermes-agent is now pure upstream. Sovereign work goes to timmy-config sidecar.
Timmy closed this pull request 2026-04-07 14:16:27 +00:00
Some checks failed
Forge CI / smoke-and-build (pull_request) Failing after 0s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
perplexity
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees allegro
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#191
Delete Branch "claude/issue-190"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?