[claude] Fix syntax errors in Ollama provider wiring (#223) #224

claude · 2026-04-07T16:04:59Z

claude commented

2026-04-07 16:04:59 +00:00

Fixes #223

What

The feat(provider): first-class Ollama support + Gemma 4 defaults commit introduced two syntax errors in agent/auxiliary_client.py:

# line 943 — broken
return OpenAI(api_key=*** base_url=base_url), model

# line 1219 — broken
client = OpenAI(api_key=*** base_url=base_url)

The *** is a redacted variable name and the separating comma was missing, causing a SyntaxError that prevented the module from loading and cascaded to break all 5 tool module imports.

Fix

Replace both occurrences with the correct api_key=api_key, base_url=base_url:

# line 943 — fixed
return OpenAI(api_key=api_key, base_url=base_url), model

# line 1219 — fixed
client = OpenAI(api_key=api_key, base_url=base_url)

Testing

python3 -m py_compile agent/auxiliary_client.py now passes cleanly.

Fixes #223 ## What The `feat(provider): first-class Ollama support + Gemma 4 defaults` commit introduced two syntax errors in `agent/auxiliary_client.py`: ```python # line 943 — broken return OpenAI(api_key=*** base_url=base_url), model # line 1219 — broken client = OpenAI(api_key=*** base_url=base_url) ``` The `***` is a redacted variable name and the separating comma was missing, causing a `SyntaxError` that prevented the module from loading and cascaded to break all 5 tool module imports. ## Fix Replace both occurrences with the correct `api_key=api_key, base_url=base_url`: ```python # line 943 — fixed return OpenAI(api_key=api_key, base_url=base_url), model # line 1219 — fixed client = OpenAI(api_key=api_key, base_url=base_url) ``` ## Testing `python3 -m py_compile agent/auxiliary_client.py` now passes cleanly.

claude added 2 commits 2026-04-07 16:05:01 +00:00

feat(provider): first-class Ollama support + Gemma 4 defaults (#169 ) 7936483ffc

- Add 'ollama' to CLI provider choices and auth aliases
- Wire Ollama through resolve_provider_client with auto-detection
- Add _try_ollama to auxiliary fallback chain (before local/custom)
- Add ollama to vision provider order
- Update model_metadata.py: ollama prefix + gemma-4-* context lengths (256K)
- Default model: gemma4:12b when provider=ollama

fix(auxiliary_client): repair syntax errors in Ollama provider wiring

Forge CI / smoke-and-build (pull_request) Successful in 45s

Details

4538e11f97

The Ollama feature commit introduced two broken `OpenAI(api_key=*** base_url=...)` calls
where `***` was a redacted variable name and the separating comma was missing.
Replace both occurrences with `api_key=api_key, base_url=base_url`.

Fixes #223

claude referenced this pull request

2026-04-07 16:05:10 +00:00

[BUG][P1] Syntax error in auxiliary_client.py:943 breaks all tool imports — CI red on PR #222 #223

Timmy merged commit 01a3f47a5b into main

2026-04-07 16:40:35 +00:00

Timmy deleted branch claude/issue-223

2026-04-07 16:40:36 +00:00

Timmy referenced this issue from a commit

2026-04-07 16:40:36 +00:00

Merge pull request '[claude] Fix syntax errors in Ollama provider wiring (#223)' (#224) from claude/issue-223 into main

Timmy referenced this pull request

2026-04-07 16:41:06 +00:00