Timmy_Foundation/hermes-agent
15
0
Fork 0
Code Issues 62 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

ci: add duplicate model detection check #235

Merged
Rockachopa merged 2 commits from feat/ci-no-duplicate-models into main 2026-04-08 22:55:21 +00:00
Conversation 1 Commits 2 Files Changed 2 +79
Rockachopa commented 2026-04-08 12:17:08 +00:00
Owner
Copy Link

Catches the class of bugs where a rename introduces a duplicate entry (e.g. PR #225 kimi-for-coding -> kimi-k2.5 when kimi-k2.5 already existed).

What it does:

  • Checks _PROVIDER_MODELS dict for duplicate model IDs within each provider list
  • Checks OPENROUTER_MODELS list for duplicate model IDs
  • Runtime target: < 2 seconds

CI step: Added as No duplicate models between Syntax guard and Green-path E2E.

Part of: #224

Catches the class of bugs where a rename introduces a duplicate entry (e.g. PR #225 kimi-for-coding -> kimi-k2.5 when kimi-k2.5 already existed). **What it does:** - Checks `_PROVIDER_MODELS` dict for duplicate model IDs within each provider list - Checks `OPENROUTER_MODELS` list for duplicate model IDs - Runtime target: < 2 seconds **CI step:** Added as `No duplicate models` between Syntax guard and Green-path E2E. Part of: #224
Rockachopa added 2 commits 2026-04-08 12:17:11 +00:00
ci: add check_no_duplicate_models.py - catches duplicate model IDs (#224) 044f0f8951
ci: add duplicate model check step to CI workflow
All checks were successful
Forge CI / smoke-and-build (pull_request) Successful in 49s
Details
5a942d71a1
Timmy commented 2026-04-08 19:01:17 +00:00
Owner
Copy Link

✅ LGTM - Merging

This perfectly addresses issue #232. The implementation:

  • ✅ Adds duplicate model detection for both _PROVIDER_MODELS and OPENROUTER_MODELS
  • ✅ Integrated into CI workflow at the right spot (after syntax, before E2E)
  • ✅ Clean, focused code with good error reporting
  • ✅ Targets <2 second runtime as requested
  • ✅ CI passing

Exactly what the forge needed. Shipping it.

Bezalel - Forge & Testbed Wizard

✅ **LGTM - Merging** This perfectly addresses issue #232. The implementation: - ✅ Adds duplicate model detection for both `_PROVIDER_MODELS` and `OPENROUTER_MODELS` - ✅ Integrated into CI workflow at the right spot (after syntax, before E2E) - ✅ Clean, focused code with good error reporting - ✅ Targets <2 second runtime as requested - ✅ CI passing Exactly what the forge needed. Shipping it. **Bezalel** - Forge & Testbed Wizard
Rockachopa merged commit 7d2421a15f into main 2026-04-08 22:55:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
CI
Continuous integration, runners, workflow issues
 QA
Quality assurance, testing, production audit
 assigned-claw-code
Queued for Code Claw (qwen/openrouter)
 assigned-kimi
Task assigned to KimiClaw for processing
 blocked
Blocked by external dependency or merge conflict
 claw-code-done
Code Claw completed this task
 claw-code-in-progress
Code Claw is actively working
 duplicate
Duplicate of another issue
 epic
Epic - large feature with multiple sub-tasks
 epic:memory
Unified Memory Architecture epic
 gaming
Gaming agent capabilities
 infra
Infrastructure, VPS, DNS, deployment
 kimi-done
KimiClaw has completed this task
 kimi-in-progress
KimiClaw is actively working on this
 mcp
MCP (Model Context Protocol) tools & servers
 morrowind
Morrowind Agent gameplay & MCP integration
 needs-review
PR or issue requires reviewer sign-off before merge/close
 p0-critical
p1-important
phase:1-activate
Phase 1: Activate existing systems
 phase:2-operational
Phase 2: Operational memory bridge
 phase:3-episodic
Phase 3: Proactive episodic recall
 phase:4-hygiene
Phase 4: Memory hygiene and quality
 phase:5-integration
Phase 5: Integration and testing
 security
Security hardening, vulnerability fixes
 stale
No activity, pending triage or closure
 velocity-engine
Auto-generated by velocity engine
 wont-fix
Closed as intentionally not fixing — explicit descope
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude claw-code codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/hermes-agent#235
Delete Branch "feat/ci-no-duplicate-models"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?