Compare commits
3 Commits
fix/192-re
...
fix/122
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
97388e2401 | ||
| d5645fea58 | |||
|
|
db08f9a478 |
16
GENOME.md
16
GENOME.md
@@ -8,24 +8,32 @@ The Beacon is a browser-based idle/incremental game inspired by Universal Paperc
|
||||
|
||||
Static HTML/JS — no build step, no dependencies, no framework. Open `index.html` in any browser.
|
||||
|
||||
**5,128 lines of JavaScript** across 10 files. **1 HTML file** with embedded CSS (~300 lines). **1 Python test file** for reckoning projects.
|
||||
**6,033 lines of JavaScript** across 11 files. **1 HTML file** with embedded CSS (~300 lines). **3 test files** (2 Node.js, 1 Python).
|
||||
|
||||
## Architecture
|
||||
|
||||
```
|
||||
index.html (UI + embedded CSS)
|
||||
index.html (UI + embedded CSS + inline JS ~5000L)
|
||||
|
|
||||
+-- js/engine.js (1590L) Core game loop, tick, resources, buildings, projects, events
|
||||
+-- js/data.js (944L) Building definitions, project trees, event tables, phase data
|
||||
+-- js/render.js (390L) DOM rendering, UI updates, resource displays
|
||||
+-- js/combat.js (359L) Boss encounters, combat mechanics
|
||||
+-- js/combat.js (359L) Canvas boid-flocking combat visualization
|
||||
+-- js/sound.js (401L) Web Audio API ambient drone, phase-aware sound
|
||||
+-- js/dismantle.js (570L) The Dismantle sequence (late-game narrative)
|
||||
+-- js/main.js (223L) Initialization, game loop start, auto-save, help overlay
|
||||
+-- js/utils.js (314L) Formatting, save/load, export/import, DOM helpers
|
||||
+-- js/tutorial.js (251L) New player tutorial, step-by-step guidance
|
||||
+-- js/strategy.js (68L) NPC strategy logic for combat
|
||||
+-- game/npc-logic.js (18L) NPC behavior stub
|
||||
+-- js/emergent-mechanics.js Emergent game mechanics from player behavior
|
||||
|
||||
CI scripts (not browser runtime):
|
||||
+-- scripts/guardrails.sh Static analysis guardrails for game logic
|
||||
+-- scripts/smoke.mjs Playwright smoke tests
|
||||
|
||||
Reference prototypes (NOT loaded by runtime):
|
||||
+-- docs/reference/npc-logic-prototype.js NPC state machine prototype
|
||||
+-- docs/reference/guardrails-prototype.js Stat validation prototype
|
||||
```
|
||||
|
||||
## Entry Points
|
||||
|
||||
@@ -3,20 +3,15 @@ _2026-04-12, Perplexity QA_
|
||||
|
||||
## Findings
|
||||
|
||||
### Potentially Unimported Files
|
||||
### Dead Code — Resolved (2026-04-15, Issue #192)
|
||||
|
||||
The following files were added by recent PRs but may not be imported
|
||||
by the main game runtime (`js/main.js` → `js/engine.js`):
|
||||
The following files were confirmed dead code — never imported by any runtime module.
|
||||
They have been moved to `docs/reference/` as prototype reference code.
|
||||
|
||||
| File | Added By | Lines | Status |
|
||||
|------|----------|-------|--------|
|
||||
| `game/npc-logic.js` | PR #79 (GOFAI NPC State Machine) | ~150 | **Verify import** |
|
||||
| `scripts/guardrails.js` | PR #80 (GOFAI Symbolic Guardrails) | ~120 | **Verify import** |
|
||||
|
||||
**Action:** Check if `js/main.js` or `js/engine.js` imports from `game/` or `scripts/`.
|
||||
If not, these files are dead code and should either be:
|
||||
1. Imported and wired into the game loop, or
|
||||
2. Moved to `docs/` as reference implementations
|
||||
| File | Original | Resolution |
|
||||
|------|----------|------------|
|
||||
| `game/npc-logic.js` | PR #79 (GOFAI NPC State Machine) | **Moved to `docs/reference/npc-logic-prototype.js`** — ES module using `export default`, incompatible with the global-script loading pattern. Concept (NPC state machine) is sound but not wired into any game system. |
|
||||
| `scripts/guardrails.js` | PR #80 (GOFAI Symbolic Guardrails) | **Moved to `docs/reference/guardrails-prototype.js`** — validates HP/MP/stats concepts that don't exist in The Beacon's resource system. The `scripts/guardrails.sh` (bash CI script) remains active. |
|
||||
|
||||
### game.js Bloat (PR #76)
|
||||
|
||||
|
||||
36
docs/issue-122-verification.md
Normal file
36
docs/issue-122-verification.md
Normal file
@@ -0,0 +1,36 @@
|
||||
# Issue #122 Verification
|
||||
|
||||
Status: already implemented on `main`
|
||||
|
||||
## Acceptance criteria check
|
||||
|
||||
1. Active or completed Unbuilding keeps the normal drift alignment UI hidden.
|
||||
- Verified in `js/render.js:41-44`, where `renderAlignment()` clears `#alignment-ui`, sets `display = 'none'`, and returns immediately when `G.dismantleActive || G.dismantleComplete`.
|
||||
2. Offered Unbuilding prompt is preserved instead of being overwritten by the normal alignment renderer.
|
||||
- Verified in `js/render.js:47-49`, where `renderAlignment()` hands control back to `Dismantle.renderChoice()` when the Unbuilding has been triggered but not yet started.
|
||||
3. Regression coverage exists and passes on a fresh clone.
|
||||
- `tests/dismantle.test.cjs:246-276` contains both:
|
||||
- `renderAlignment does not wipe the Unbuilding prompt after it is offered`
|
||||
- `active Unbuilding suppresses pending alignment event UI`
|
||||
|
||||
## Verification commands run
|
||||
|
||||
```bash
|
||||
node --test tests/dismantle.test.cjs
|
||||
```
|
||||
|
||||
Result:
|
||||
- `10` tests passed
|
||||
- includes the exact `active Unbuilding suppresses pending alignment event UI` regression named in the issue body
|
||||
|
||||
## Prior trail
|
||||
|
||||
Closed unmerged PRs already attempted to document this state:
|
||||
- PR #153 — `docs: verify #122 already fixed — alignment UI suppressed during Unbuilding`
|
||||
- PR #155 — `test(#122): Add test for completed Unbuilding suppressing alignment UI`
|
||||
|
||||
Those PRs did not merge, but the underlying fix and regression coverage are present on `main` today.
|
||||
|
||||
## Recommendation
|
||||
|
||||
Close issue #122 as already implemented on `main`.
|
||||
Reference in New Issue
Block a user