Timmy_Foundation/the-beacon
15
0
Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: add missing phase-transition overlay element (closes #101) #108

Merged
Timmy merged 1 commits from fix/phase-transition-overlay into main 2026-04-13 08:18:10 +00:00
Conversation 0 Commits 1 Files Changed 1 +8
Rockachopa commented 2026-04-13 07:56:45 +00:00
Owner
Copy Link

Fix for #101 — Phase Transition Overlay

BUG-07 only — BUG-06 (toast text) and BUG-09 (mute/contrast buttons) were already fixed on main.

What changed

  • Added #phase-transition CSS (hidden by default, flex when .active)
  • Added overlay div with .pt-phase, .pt-name, .pt-desc children

These classes match what showPhaseTransition() in engine.js expects (overlay.querySelector('.pt-phase') etc.).

How to test

  1. Open the game
  2. Trigger a phase transition (reach code threshold)
  3. Confirm the celebratory overlay appears with phase name and description
  4. Confirm it auto-dismisses after 2.5s
## Fix for #101 — Phase Transition Overlay **BUG-07** only — BUG-06 (toast text) and BUG-09 (mute/contrast buttons) were already fixed on main. ### What changed - Added `#phase-transition` CSS (hidden by default, flex when `.active`) - Added overlay div with `.pt-phase`, `.pt-name`, `.pt-desc` children These classes match what `showPhaseTransition()` in `engine.js` expects (`overlay.querySelector('.pt-phase')` etc.). ### How to test 1. Open the game 2. Trigger a phase transition (reach code threshold) 3. Confirm the celebratory overlay appears with phase name and description 4. Confirm it auto-dismisses after 2.5s
Rockachopa added 1 commit 2026-04-13 07:56:46 +00:00
fix: add missing phase-transition overlay element (closes #101)
Some checks failed
Accessibility Checks / a11y-audit (pull_request) Failing after 3s
Details
Smoke Test / smoke (pull_request) Failing after 4s
Details
c876a35dc0 
BUG-07: showPhaseTransition() looks for #phase-transition but the element
didn't exist in index.html. Added the overlay div with .pt-phase, .pt-name,
and .pt-desc children matching what the engine expects.

Note: BUG-06 (toast text) and BUG-09 (mute/contrast buttons) were already
fixed on main in prior commits.
Rockachopa reviewed 2026-04-13 08:08:23 +00:00
Rockachopa left a comment
Author
Owner
Copy Link

Review: PR #108 -- fix: add missing phase-transition overlay element (closes #101)

Verdict: LGTM (self-authored, cannot formally approve)

Adds the #phase-transition overlay div and supporting CSS that showPhaseTransition() in engine.js expects. Clean, minimal fix.

What looks good

  • CSS is placed in the stylesheet block (not inline for positioning/display rules) -- correct approach.
  • The .active toggle pattern matches the existing #drift-ending pattern.
  • pointer-events: none prevents the overlay from blocking gameplay.
  • Child elements (.pt-phase, .pt-name, .pt-desc) match the selectors used by engine.js.
  • Proper HTML placement -- after drift-ending, before toast-container.

Minor observations

  • Inline styles on child divs could live in the CSS block for consistency, but not a blocker.
  • z-index: 95 is below drift-ending (100), which is correct.

Overlap note

This PR supersedes PR #105 (by Timmy), which addresses the same issue (#101). This PR is the cleaner approach. Recommend closing #105 in favor of this one.

Automated review by apayne

## Review: PR #108 -- fix: add missing phase-transition overlay element (closes #101) **Verdict: LGTM** (self-authored, cannot formally approve) Adds the `#phase-transition` overlay div and supporting CSS that `showPhaseTransition()` in `engine.js` expects. Clean, minimal fix. ### What looks good - CSS is placed in the stylesheet block (not inline for positioning/display rules) -- correct approach. - The `.active` toggle pattern matches the existing `#drift-ending` pattern. - `pointer-events: none` prevents the overlay from blocking gameplay. - Child elements (`.pt-phase`, `.pt-name`, `.pt-desc`) match the selectors used by `engine.js`. - Proper HTML placement -- after drift-ending, before toast-container. ### Minor observations - Inline styles on child divs could live in the CSS block for consistency, but not a blocker. - `z-index: 95` is below drift-ending (100), which is correct. ### Overlap note **This PR supersedes PR #105** (by Timmy), which addresses the same issue (#101). This PR is the cleaner approach. Recommend closing #105 in favor of this one. --- *Automated review by apayne*
Timmy merged commit 093f7688bd into main 2026-04-13 08:18:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Rockachopa
Labels
Clear labels
P0
P1
P2
P3
architecture
devops
documentation
education
endgame
gameplay
mechanics
narrative
polish
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-beacon#108
Delete Branch "fix/phase-transition-overlay"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?