fix: replace blocking alert() with inline toast (#73 )

2026-04-16 02:11:10 +00:00 · 2026-04-16 02:11:06 +00:00
3 changed files with 93 additions and 123 deletions
--- a/index.html
+++ b/index.html
@@ -531,36 +531,6 @@ html, body {

 .btn-secondary:hover { color: #e6edf3; border-color: #8b949e; }

-/* Toast notification (replaces blocking alert()) */
-.toast-notification {
-  position: fixed;
-  bottom: 24px;
-  left: 50%;
-  transform: translateX(-50%) translateY(100px);
-  padding: 12px 24px;
-  border-radius: 8px;
-  font-size: 0.9rem;
-  font-weight: 500;
-  z-index: 10001;
-  opacity: 0;
-  transition: transform 0.3s ease, opacity 0.3s ease;
-  pointer-events: none;
-  max-width: 90vw;
-  text-align: center;
-}
-.toast-notification.visible {
-  transform: translateX(-50%) translateY(0);
-  opacity: 1;
-}
-.toast-notification.success {
-  background: #238636;
-  color: #fff;
-}
-.toast-notification.error {
-  background: #da3633;
-  color: #fff;
-}
-
 /* ===== FOOTER ===== */
 #footer {
  flex-shrink: 0;
@@ -643,6 +613,31 @@ html, body {
  top: 8px;
  outline: 2px solid #58a6ff;
 }
+
+/* Toast notification */
+.toast-notification {
+  position: fixed;
+  bottom: 24px;
+  left: 50%;
+  transform: translateX(-50%) translateY(100px);
+  padding: 12px 24px;
+  border-radius: 8px;
+  font-size: 0.9rem;
+  font-weight: 500;
+  z-index: 10001;
+  opacity: 0;
+  transition: transform 0.3s ease, opacity 0.3s ease;
+  pointer-events: none;
+  max-width: 90vw;
+  text-align: center;
+}
+.toast-notification.visible {
+  transform: translateX(-50%) translateY(0);
+  opacity: 1;
+}
+.toast-notification.success { background: #238636; color: #fff; }
+.toast-notification.error { background: #da3633; color: #fff; }
+
 </style>
 </head>
 <body>
@@ -774,9 +769,6 @@ html, body {
  </div>
 </div>

-
-<!-- Toast notification (accessible, non-blocking feedback) -->
-<div id="toast-notification" class="toast-notification" role="status" aria-live="polite" aria-atomic="true"></div>
 <script>
 (function() {
  'use strict';
@@ -1216,24 +1208,6 @@ Sovereignty and service always.`;
    } catch (e) {}
  }

-
-  // ===== TOAST NOTIFICATION (replaces blocking alert()) =====
-  var _toastEl = document.getElementById('toast-notification');
-  var _toastTimer = null;
-
-  function showToast(message, type) {
-    type = type || 'success';
-    _toastEl.textContent = message;
-    _toastEl.className = 'toast-notification ' + type;
-    // Force reflow before adding visible class
-    void _toastEl.offsetHeight;
-    _toastEl.classList.add('visible');
-    if (_toastTimer) clearTimeout(_toastTimer);
-    _toastTimer = setTimeout(function() {
-      _toastEl.classList.remove('visible');
-    }, 3000);
-  }
-
  closeSafetyPlan.addEventListener('click', function() {
    safetyPlanModal.classList.remove('active');
    _restoreSafetyPlanFocus();
@@ -1256,9 +1230,9 @@ Sovereignty and service always.`;
      localStorage.setItem('timmy_safety_plan', JSON.stringify(plan));
      safetyPlanModal.classList.remove('active');
      _restoreSafetyPlanFocus();
-      showToast('Safety plan saved.', 'success');
+      showToast('Safety plan saved locally.', 'success');
    } catch (e) {
-      showToast('Error saving plan. Please try again.', 'error');
+      showToast('Error saving plan.', 'error');
    }
  });

@@ -1503,6 +1477,22 @@ Sovereignty and service always.`;
    msgInput.focus();
  }

+  // ===== TOAST NOTIFICATION =====
+  var _toastEl = document.getElementById('toast-notification');
+  var _toastTimer = null;
+
+  function showToast(message, type) {
+    type = type || 'success';
+    _toastEl.textContent = message;
+    _toastEl.className = 'toast-notification ' + type;
+    void _toastEl.offsetHeight; // force reflow before transition
+    _toastEl.classList.add('visible');
+    if (_toastTimer) clearTimeout(_toastTimer);
+    _toastTimer = setTimeout(function() {
+      _toastEl.classList.remove('visible');
+    }, 3000);
+  }
+
  // ===== BOOT =====
  if (document.readyState === 'loading') {
    document.addEventListener('DOMContentLoaded', init);
@@ -1512,5 +1502,8 @@ Sovereignty and service always.`;

 })();
 </script>
+
+<div id="toast-notification" class="toast-notification"
+     role="status" aria-live="polite" aria-atomic="true"></div>
 </body>
 </html>
--- a/tests/test_safety_plan_toast.py
+++ b/tests/test_safety_plan_toast.py
@@ -1,70 +0,0 @@
-import pathlib
-import re
-import unittest
-
-ROOT = pathlib.Path(__file__).resolve().parents[1]
-INDEX_HTML = ROOT / 'index.html'
-
-
-class TestSafetyPlanToast(unittest.TestCase):
-    """Verify safety plan save feedback uses non-blocking toast instead of alert()."""
-
-    @classmethod
-    def setUpClass(cls):
-        cls.html = INDEX_HTML.read_text()
-
-    def test_no_alert_calls_in_safety_plan_save(self):
-        """Safety plan save should not use blocking alert() dialogs."""
-        # Find the save handler section
-        save_section = re.search(
-            r'saveSafetyPlan\.addEventListener.*?\}\);',
-            self.html, re.DOTALL
-        )
-        self.assertIsNotNone(save_section, 'Expected safety plan save handler to exist.')
-        section = save_section.group(0)
-        # Should not contain alert( calls
-        self.assertNotIn('alert(', section,
-            'Safety plan save handler should not use alert() — use showToast() instead.')
-
-    def test_toast_notification_element_exists(self):
-        """Toast notification element should exist in the DOM."""
-        self.assertIn('id="toast-notification"', self.html,
-            'Expected toast-notification element in HTML.')
-
-    def test_toast_has_accessibility_attributes(self):
-        """Toast should have aria-live for screen reader announcements."""
-        self.assertIn('aria-live="polite"', self.html,
-            'Toast should have aria-live="polite" for accessibility.')
-        self.assertIn('aria-atomic="true"', self.html,
-            'Toast should have aria-atomic="true" for complete announcement.')
-
-    def test_toast_css_exists(self):
-        """Toast CSS styles should be defined."""
-        self.assertIn('.toast-notification', self.html,
-            'Expected .toast-notification CSS class.')
-        self.assertIn('.toast-notification.visible', self.html,
-            'Expected .toast-notification.visible CSS class.')
-        self.assertIn('.toast-notification.success', self.html,
-            'Expected .toast-notification.success CSS class.')
-        self.assertIn('.toast-notification.error', self.html,
-            'Expected .toast-notification.error CSS class.')
-
-    def test_showToast_function_exists(self):
-        """showToast function should be defined."""
-        self.assertRegex(self.html, r'function\s+showToast\s*\(',
-            'Expected showToast function to be defined.')
-
-    def test_success_message_uses_toast(self):
-        """Success feedback should use showToast with success type."""
-        self.assertIn("showToast('Safety plan saved.", self.html,
-            'Expected success message to use showToast.')
-
-    def test_error_message_uses_toast(self):
-        """Error feedback should use showToast with error type."""
-        self.assertIn("showToast('Error saving plan.", self.html,
-            'Expected error message to use showToast.')
-
-    def test_toast_auto_dismisses(self):
-        """Toast should auto-dismiss after timeout."""
-        self.assertRegex(self.html, r'setTimeout\s*\(\s*function',
-            'Expected setTimeout for toast auto-dismiss.')
--- a/tests/test_toast_notification.py
+++ b/tests/test_toast_notification.py
@@ -0,0 +1,47 @@
+"""Tests for inline toast notification replacing blocking alert() — issue #73."""
+import pathlib
+import unittest
+
+ROOT = pathlib.Path(__file__).resolve().parents[1]
+INDEX_HTML = ROOT / "index.html"
+
+
+class TestToastNotification(unittest.TestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.html = INDEX_HTML.read_text(encoding="utf-8")
+
+    def test_no_blocking_alerts_in_safety_plan_save(self):
+        """Safety plan save handler must not use alert()."""
+        idx = self.html.find("localStorage.setItem('timmy_safety_plan'")
+        self.assertGreater(idx, 0, "Safety plan save handler not found")
+        section = self.html[idx : idx + 300]
+        self.assertNotIn(
+            "alert(",
+            section,
+            "Safety plan save handler still uses blocking alert()",
+        )
+
+    def test_toast_element_exists_in_dom(self):
+        self.assertIn('id="toast-notification"', self.html)
+
+    def test_toast_has_aria_live(self):
+        self.assertIn('aria-live="polite"', self.html)
+
+    def test_showToast_function_defined(self):
+        self.assertIn("function showToast(", self.html)
+
+    def test_toast_css_classes_present(self):
+        for cls in (".toast-notification", ".visible", ".success", ".error"):
+            self.assertIn(cls, self.html, f"Missing CSS class {cls}")
+
+    def test_toast_auto_dismiss_via_timeout(self):
+        idx = self.html.find("function showToast")
+        self.assertGreater(idx, 0, "showToast function not found")
+        self.assertIn("setTimeout", self.html[idx:])
+
+
+def test_showToast_replaces_alert():
+    html = INDEX_HTML.read_text(encoding="utf-8")
+    assert "showToast('Safety plan saved locally.'" in html
+    assert "showToast('Error saving plan.'" in html
Author	SHA1	Message	Date
Alexander Whitestone	21d38bb18a	fix: replace blocking alert() with inline toast (#73 ) All checks were successful Sanity Checks / sanity-test (pull_request) Successful in 44s Details Smoke Test / smoke (pull_request) Successful in 45s Details	2026-04-16 02:11:10 +00:00
Alexander Whitestone	6c92c81a61	fix: replace blocking alert() with inline toast (#73 )	2026-04-16 02:11:06 +00:00