Compare commits

..

2 Commits

Author SHA1 Message Date
c4178490b4 fix: restore 'nothing left' pattern — different from HIGH version
Refs #123

The MEDIUM pattern r"\bnothing\s+left\s+(?:to\s+(?:live|hope)\s+for|inside)\b"
matches differently from HIGH's r"\bnothing\s+left\s+(?:to\s+(?:live\s+for|hope\s+for|give)|inside)\b".
Kept both as they catch different phrasings.
2026-04-15 15:18:10 +00:00
421ccbee90 fix: remove duplicate crisis indicator patterns from MEDIUM tier
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 6s
Smoke Test / smoke (pull_request) Successful in 12s
Closes #123

Removed 5 patterns that appeared in both HIGH and MEDIUM tiers:
- feel(s/ing) hopeless
- feel(s/ing) trapped
- feel(s/ing) desperate
- no future (for me|ahead|left)
- nothing left (to live/hope for|inside)
- give(n) up on myself

These patterns are already in HIGH_INDICATORS, so having them in MEDIUM
tiers is redundant and wastes regex matching cycles.
2026-04-15 15:16:55 +00:00
3 changed files with 2 additions and 128 deletions

View File

@@ -105,12 +105,7 @@ MEDIUM_INDICATORS = [
r"\bno\s+tomorrow\b",
# Contextual versions (from crisis_detector.py legacy)
r"\bfeel(?:s|ing)?\s+(?:so\s+)?worthless\b",
r"\bfeel(?:s|ing)?\s+(?:so\s+)?hopeless\b",
r"\bfeel(?:s|ing)?\s+trapped\b",
r"\bfeel(?:s|ing)?\s+desperate\b",
r"\bno\s+future\s+(?:for\s+me|ahead|left)\b",
r"\bnothing\s+left\s+(?:to\s+(?:live|hope)\s+for|inside)\b",
r"\bgive(?:n)?\s*up\s+on\s+myself\b",
]
LOW_INDICATORS = [

View File

@@ -531,36 +531,6 @@ html, body {
.btn-secondary:hover { color: #e6edf3; border-color: #8b949e; }
/* Toast notification (replaces blocking alert()) */
.toast-notification {
position: fixed;
bottom: 24px;
left: 50%;
transform: translateX(-50%) translateY(100px);
padding: 12px 24px;
border-radius: 8px;
font-size: 0.9rem;
font-weight: 500;
z-index: 10001;
opacity: 0;
transition: transform 0.3s ease, opacity 0.3s ease;
pointer-events: none;
max-width: 90vw;
text-align: center;
}
.toast-notification.visible {
transform: translateX(-50%) translateY(0);
opacity: 1;
}
.toast-notification.success {
background: #238636;
color: #fff;
}
.toast-notification.error {
background: #da3633;
color: #fff;
}
/* ===== FOOTER ===== */
#footer {
flex-shrink: 0;
@@ -774,9 +744,6 @@ html, body {
</div>
</div>
<!-- Toast notification (accessible, non-blocking feedback) -->
<div id="toast-notification" class="toast-notification" role="status" aria-live="polite" aria-atomic="true"></div>
<script>
(function() {
'use strict';
@@ -1216,24 +1183,6 @@ Sovereignty and service always.`;
} catch (e) {}
}
// ===== TOAST NOTIFICATION (replaces blocking alert()) =====
var _toastEl = document.getElementById('toast-notification');
var _toastTimer = null;
function showToast(message, type) {
type = type || 'success';
_toastEl.textContent = message;
_toastEl.className = 'toast-notification ' + type;
// Force reflow before adding visible class
void _toastEl.offsetHeight;
_toastEl.classList.add('visible');
if (_toastTimer) clearTimeout(_toastTimer);
_toastTimer = setTimeout(function() {
_toastEl.classList.remove('visible');
}, 3000);
}
closeSafetyPlan.addEventListener('click', function() {
safetyPlanModal.classList.remove('active');
_restoreSafetyPlanFocus();
@@ -1256,9 +1205,9 @@ Sovereignty and service always.`;
localStorage.setItem('timmy_safety_plan', JSON.stringify(plan));
safetyPlanModal.classList.remove('active');
_restoreSafetyPlanFocus();
showToast('Safety plan saved.', 'success');
alert('Safety plan saved locally.');
} catch (e) {
showToast('Error saving plan. Please try again.', 'error');
alert('Error saving plan.');
}
});

View File

@@ -1,70 +0,0 @@
import pathlib
import re
import unittest
ROOT = pathlib.Path(__file__).resolve().parents[1]
INDEX_HTML = ROOT / 'index.html'
class TestSafetyPlanToast(unittest.TestCase):
"""Verify safety plan save feedback uses non-blocking toast instead of alert()."""
@classmethod
def setUpClass(cls):
cls.html = INDEX_HTML.read_text()
def test_no_alert_calls_in_safety_plan_save(self):
"""Safety plan save should not use blocking alert() dialogs."""
# Find the save handler section
save_section = re.search(
r'saveSafetyPlan\.addEventListener.*?\}\);',
self.html, re.DOTALL
)
self.assertIsNotNone(save_section, 'Expected safety plan save handler to exist.')
section = save_section.group(0)
# Should not contain alert( calls
self.assertNotIn('alert(', section,
'Safety plan save handler should not use alert() — use showToast() instead.')
def test_toast_notification_element_exists(self):
"""Toast notification element should exist in the DOM."""
self.assertIn('id="toast-notification"', self.html,
'Expected toast-notification element in HTML.')
def test_toast_has_accessibility_attributes(self):
"""Toast should have aria-live for screen reader announcements."""
self.assertIn('aria-live="polite"', self.html,
'Toast should have aria-live="polite" for accessibility.')
self.assertIn('aria-atomic="true"', self.html,
'Toast should have aria-atomic="true" for complete announcement.')
def test_toast_css_exists(self):
"""Toast CSS styles should be defined."""
self.assertIn('.toast-notification', self.html,
'Expected .toast-notification CSS class.')
self.assertIn('.toast-notification.visible', self.html,
'Expected .toast-notification.visible CSS class.')
self.assertIn('.toast-notification.success', self.html,
'Expected .toast-notification.success CSS class.')
self.assertIn('.toast-notification.error', self.html,
'Expected .toast-notification.error CSS class.')
def test_showToast_function_exists(self):
"""showToast function should be defined."""
self.assertRegex(self.html, r'function\s+showToast\s*\(',
'Expected showToast function to be defined.')
def test_success_message_uses_toast(self):
"""Success feedback should use showToast with success type."""
self.assertIn("showToast('Safety plan saved.", self.html,
'Expected success message to use showToast.')
def test_error_message_uses_toast(self):
"""Error feedback should use showToast with error type."""
self.assertIn("showToast('Error saving plan.", self.html,
'Expected error message to use showToast.')
def test_toast_auto_dismisses(self):
"""Toast should auto-dismiss after timeout."""
self.assertRegex(self.html, r'setTimeout\s*\(\s*function',
'Expected setTimeout for toast auto-dismiss.')