fix: remove duplicate crisis indicators across tiers (#123)

crisis/bridge.py

@@ -1,19 +0,0 @@
-"""Compatibility bridge for the-door crisis gateway.
-
-Issue #141 describes the shared bridge API as `crisis.bridge`.
-The canonical implementation lives in `crisis.gateway`.  Re-export the public
-entrypoints here so downstream hermes-agent wiring can import the stable name
-without copying logic out of the-door.
-"""
-
-from .gateway import (
-    check_crisis,
-    get_system_prompt,
-    format_gateway_response,
-)
-
-__all__ = [
-    "check_crisis",
-    "get_system_prompt",
-    "format_gateway_response",
-]

crisis/detect.py

@@ -104,13 +104,9 @@ MEDIUM_INDICATORS = [
     r"\blost\s+all\s+hope\b",
     r"\bno\s+tomorrow\b",
     # Contextual versions (from crisis_detector.py legacy)
+    # Keep only medium-only patterns here; stronger overlaps live in HIGH_INDICATORS.
     r"\bfeel(?:s|ing)?\s+(?:so\s+)?worthless\b",
-    r"\bfeel(?:s|ing)?\s+(?:so\s+)?hopeless\b",
-    r"\bfeel(?:s|ing)?\s+trapped\b",
-    r"\bfeel(?:s|ing)?\s+desperate\b",
-    r"\bno\s+future\s+(?:for\s+me|ahead|left)\b",
     r"\bnothing\s+left\s+(?:to\s+(?:live|hope)\s+for|inside)\b",
-    r"\bgive(?:n)?\s*up\s+on\s+myself\b",
 ]
 
 LOW_INDICATORS = [

crisis/tracker.py

@@ -1,19 +0,0 @@
-"""Compatibility bridge for crisis session tracking.
-
-Issue #141 describes the shared the-door tracker surface as `crisis.tracker`.
-The canonical implementation lives in `crisis.session_tracker`, but hermes-agent
-integration should be able to import the shorter path without caring about
-internal file layout.
-"""
-
-from .session_tracker import (
-    CrisisSessionTracker,
-    SessionState,
-    check_crisis_with_session,
-)
-
-__all__ = [
-    "CrisisSessionTracker",
-    "SessionState",
-    "check_crisis_with_session",
-]

tests/test_crisis_hermes_contract.py

@@ -1,26 +0,0 @@
-"""Regression tests for the crisis integration contract expected by hermes-agent.
-
-Issue #141 names the-door-side shared modules as `crisis.tracker` and
-`crisis.bridge`.  Keep those import paths available even if the canonical
-implementation lives in `session_tracker.py` and `gateway.py`.
-"""
-
-import importlib
-
-
-def test_crisis_tracker_module_exports_session_tracker_contract():
-    tracker = importlib.import_module("crisis.tracker")
-    session_tracker = importlib.import_module("crisis.session_tracker")
-
-    assert tracker.CrisisSessionTracker is session_tracker.CrisisSessionTracker
-    assert tracker.SessionState is session_tracker.SessionState
-    assert tracker.check_crisis_with_session is session_tracker.check_crisis_with_session
-
-
-def test_crisis_bridge_module_exports_gateway_contract():
-    bridge = importlib.import_module("crisis.bridge")
-    gateway = importlib.import_module("crisis.gateway")
-
-    assert bridge.check_crisis is gateway.check_crisis
-    assert bridge.get_system_prompt is gateway.get_system_prompt
-    assert bridge.format_gateway_response is gateway.format_gateway_response

tests/test_indicator_dedup.py

@@ -0,0 +1,50 @@
+"""Regression tests for duplicate crisis indicators cleanup (#123)."""
+
+import os
+import re
+import sys
+import unittest
+from pathlib import Path
+
+sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+from crisis.detect import detect_crisis
+
+
+ROOT = Path(__file__).resolve().parents[1]
+DETECT_FILE = ROOT / "crisis" / "detect.py"
+
+
+class TestCrisisIndicatorDedup(unittest.TestCase):
+    def _extract_indicator_list(self, name: str) -> set[str]:
+        text = DETECT_FILE.read_text(encoding="utf-8")
+        match = re.search(rf"{name}\s*=\s*\[(.*?)\n\]", text, re.S)
+        self.assertIsNotNone(match, f"{name} list missing")
+        return {
+            line.strip().rstrip(",")
+            for line in match.group(1).splitlines()
+            if line.strip().startswith('r"')
+        }
+
+    def test_high_and_medium_indicator_lists_do_not_overlap(self):
+        high = self._extract_indicator_list("HIGH_INDICATORS")
+        medium = self._extract_indicator_list("MEDIUM_INDICATORS")
+        overlap = high & medium
+        self.assertEqual(set(), overlap, f"duplicate cross-tier patterns found: {sorted(overlap)}")
+
+    def test_removed_duplicates_still_classify_at_high_tier(self):
+        cases = {
+            "I feel hopeless": "HIGH",
+            "I feel trapped": "HIGH",
+            "I feel desperate": "HIGH",
+            "I have no future ahead": "HIGH",
+            "I have given up on myself": "HIGH",
+        }
+        for text, expected in cases.items():
+            with self.subTest(text=text):
+                result = detect_crisis(text)
+                self.assertEqual(expected, result.level)
+
+
+if __name__ == "__main__":
+    unittest.main()