fix: remove duplicate crisis indicators across tiers (#123)

crisis/detect.py

@@ -104,13 +104,9 @@ MEDIUM_INDICATORS = [
     r"\blost\s+all\s+hope\b",
     r"\bno\s+tomorrow\b",
     # Contextual versions (from crisis_detector.py legacy)
+    # Keep only medium-only patterns here; stronger overlaps live in HIGH_INDICATORS.
     r"\bfeel(?:s|ing)?\s+(?:so\s+)?worthless\b",
-    r"\bfeel(?:s|ing)?\s+(?:so\s+)?hopeless\b",
-    r"\bfeel(?:s|ing)?\s+trapped\b",
-    r"\bfeel(?:s|ing)?\s+desperate\b",
-    r"\bno\s+future\s+(?:for\s+me|ahead|left)\b",
     r"\bnothing\s+left\s+(?:to\s+(?:live|hope)\s+for|inside)\b",
-    r"\bgive(?:n)?\s*up\s+on\s+myself\b",
 ]
 
 LOW_INDICATORS = [

docs/issue-41-verification.md

@@ -1,32 +0,0 @@
-# Issue #41 Verification
-
-Status: already implemented on main
-
-Issue:
-- #41 [P3] Service worker: cache crisis resources for offline
-
-Acceptance criteria check:
-1. Passed — offline page includes 988 call button, Crisis Text Line, and grounding techniques
-2. Passed — service worker precaches `crisis-offline.html`
-3. Passed — phone number is clickable via `href="tel:988"`
-4. Passed — navigation timeout + offline fallback support intermittent connections
-
-Evidence:
-- `sw.js` precaches `/crisis-offline.html`
-- `sw.js` contains `NAVIGATION_TIMEOUT_MS` and `AbortController`
-- `crisis-offline.html` contains:
-  - `href="tel:988"`
-  - Crisis Text Line / `741741`
-  - grounding prompts for 5-4-3-2-1
-- `tests/test_service_worker_offline.py` already exists on main and passes
-
-Verification run from fresh main clone:
-- `python3 -m pytest tests/test_service_worker_offline.py -q`
-  - `10 passed`
-
-Prior implementation trail:
-- Issue comment already states the core implementation is complete on main
-- Closed PR #122 documented the already-complete implementation and added the offline guarantees test coverage that is now present on main
-
-Recommendation:
-- Close issue #41 as already implemented on main.

tests/test_indicator_dedup.py

@@ -0,0 +1,50 @@
+"""Regression tests for duplicate crisis indicators cleanup (#123)."""
+
+import os
+import re
+import sys
+import unittest
+from pathlib import Path
+
+sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+
+from crisis.detect import detect_crisis
+
+
+ROOT = Path(__file__).resolve().parents[1]
+DETECT_FILE = ROOT / "crisis" / "detect.py"
+
+
+class TestCrisisIndicatorDedup(unittest.TestCase):
+    def _extract_indicator_list(self, name: str) -> set[str]:
+        text = DETECT_FILE.read_text(encoding="utf-8")
+        match = re.search(rf"{name}\s*=\s*\[(.*?)\n\]", text, re.S)
+        self.assertIsNotNone(match, f"{name} list missing")
+        return {
+            line.strip().rstrip(",")
+            for line in match.group(1).splitlines()
+            if line.strip().startswith('r"')
+        }
+
+    def test_high_and_medium_indicator_lists_do_not_overlap(self):
+        high = self._extract_indicator_list("HIGH_INDICATORS")
+        medium = self._extract_indicator_list("MEDIUM_INDICATORS")
+        overlap = high & medium
+        self.assertEqual(set(), overlap, f"duplicate cross-tier patterns found: {sorted(overlap)}")
+
+    def test_removed_duplicates_still_classify_at_high_tier(self):
+        cases = {
+            "I feel hopeless": "HIGH",
+            "I feel trapped": "HIGH",
+            "I feel desperate": "HIGH",
+            "I have no future ahead": "HIGH",
+            "I have given up on myself": "HIGH",
+        }
+        for text, expected in cases.items():
+            with self.subTest(text=text):
+                result = detect_crisis(text)
+                self.assertEqual(expected, result.level)
+
+
+if __name__ == "__main__":
+    unittest.main()