Timmy_Foundation/the-door
15
0
Fork 0
Code Issues 19 Pull Requests 18 Actions Packages Projects Releases Wiki Activity

fix: overlay initial focus targets enabled element (closes #90, refs #69) #107

Closed
Rockachopa wants to merge 1 commits from fix/90-overlay-focus-enabled-element into main
pull from: fix/90-overlay-focus-enabled-element
merge into: Timmy_Foundation:main
Conversation 2 Commits 1 Files Changed 2 +92 -2
Rockachopa commented 2026-04-15 03:25:49 +00:00
Owner
Copy Link

Closes #90
Refs #69

Problem

When crisis overlay opens, showOverlay():

  1. Disables the dismiss button (overlayDismissBtn.disabled = true)
  2. Calls overlayDismissBtn.focus()

Disabled buttons cannot receive focus. The overlay opens without a valid keyboard focus target.

Fix

Focus the Call 988 link (.overlay-call) instead — always enabled, most important action.

Changes

  • index.html: Focus .overlay-call link on overlay open instead of disabled dismiss button
  • tests/test_crisis_overlay_focus_trap.py: Added 2 new tests verifying focus targets enabled element

Tests

7 tests passing (all in test_crisis_overlay_focus_trap.py)

Closes #90 Refs #69 ## Problem When crisis overlay opens, `showOverlay()`: 1. Disables the dismiss button (`overlayDismissBtn.disabled = true`) 2. Calls `overlayDismissBtn.focus()` Disabled buttons cannot receive focus. The overlay opens without a valid keyboard focus target. ## Fix Focus the Call 988 link (`.overlay-call`) instead — always enabled, most important action. ## Changes - `index.html`: Focus `.overlay-call` link on overlay open instead of disabled dismiss button - `tests/test_crisis_overlay_focus_trap.py`: Added 2 new tests verifying focus targets enabled element ## Tests 7 tests passing (all in `test_crisis_overlay_focus_trap.py`)
Rockachopa added 1 commit 2026-04-15 03:25:49 +00:00
fix: overlay initial focus targets enabled element (closes #90, refs #69)
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 16s
Details
Smoke Test / smoke (pull_request) Successful in 19s
Details
b4c4919361
Timmy approved these changes 2026-04-15 04:13:42 +00:00
Timmy left a comment
Owner
Copy Link

Fix looks reasonable.

Scope: 2 file(s) changed (92+ / 2-)

Fix looks reasonable. **Scope**: 2 file(s) changed (92+ / 2-)
Rockachopa commented 2026-04-15 04:38:45 +00:00
Author
Owner
Copy Link

Superseded by PR #116, which includes all changes from this PR plus:

  • Focus recovery when focus escapes the overlay (critical for screen reader users)
  • Additional regression test for focus recovery

PR #116: #116

Superseded by PR #116, which includes all changes from this PR plus: - Focus recovery when focus escapes the overlay (critical for screen reader users) - Additional regression test for focus recovery PR #116: https://forge.alexanderwhitestone.com/Timmy_Foundation/the-door/pulls/116
Rockachopa closed this pull request 2026-04-15 04:38:46 +00:00
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 16s
Details
Smoke Test / smoke (pull_request) Successful in 19s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Timmy
Labels
Clear labels
backend
Backend / API
 batch-pipeline
batch-pipeline label
 content
Content, copy, testimony
 deploy
Deployment / go-live
 epic
Epic / parent issue
 frontend
Frontend / UI
 hardening
Resilience, fallback, security
 infra
Infrastructure, DevOps, deployment
 priority:critical
Must have for launch
 priority:high
Important for launch
 priority:medium
Nice to have at launch
 protocol
Crisis detection protocol
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-door#107
Delete Branch "fix/90-overlay-focus-enabled-element"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?