Timmy_Foundation/the-door
15
0
Fork 0
Code Issues 19 Pull Requests 18 Actions Packages Projects Releases Wiki Activity

fix(#69): crisis overlay initial focus targets enabled element #90

Closed
Rockachopa wants to merge 1 commits from burn/69-1776218206 into main
pull from: burn/69-1776218206
merge into: Timmy_Foundation:main
Conversation 2 Commits 1 Files Changed 2 +50 -1
Rockachopa commented 2026-04-15 02:18:42 +00:00
Owner
Copy Link

Closes #69.

Problem

When crisis overlay opens, showOverlay():

  1. Disables the dismiss button (overlayDismissBtn.disabled = true)
  2. Calls overlayDismissBtn.focus()

Disabled buttons can't receive focus. The overlay opens without a valid keyboard focus target.

Fix

Focus the Call 988 link (.overlay-call) instead — always enabled, most important action.

Changes

File Change
index.html Focus .overlay-call link on open, fallback to dismiss button
tests/test_crisis_overlay_focus_trap.py New test: test_overlay_initial_focus_targets_enabled_element

Tests

4 tests passing (all in test_crisis_overlay_focus_trap.py)

Closes #69

Closes #69. ## Problem When crisis overlay opens, `showOverlay()`: 1. Disables the dismiss button (`overlayDismissBtn.disabled = true`) 2. Calls `overlayDismissBtn.focus()` Disabled buttons can't receive focus. The overlay opens without a valid keyboard focus target. ## Fix Focus the Call 988 link (`.overlay-call`) instead — always enabled, most important action. ## Changes | File | Change | |------|--------| | index.html | Focus `.overlay-call` link on open, fallback to dismiss button | | tests/test_crisis_overlay_focus_trap.py | New test: `test_overlay_initial_focus_targets_enabled_element` | ## Tests 4 tests passing (all in `test_crisis_overlay_focus_trap.py`) Closes #69
Rockachopa added 1 commit 2026-04-15 02:18:43 +00:00
fix(#69): crisis overlay initial focus targets enabled element
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 10s
Details
Smoke Test / smoke (pull_request) Successful in 16s
Details
c058701b84 
Problem: showOverlay() disabled the dismiss button then called
overlayDismissBtn.focus(). Disabled buttons can't receive focus,
so the overlay opened without a valid keyboard focus target.

Fix: Focus the Call 988 link (.overlay-call) instead — it's always
enabled and is the most important action in the crisis overlay.

Changes:
- index.html: Focus .overlay-call link on overlay open
- tests/test_crisis_overlay_focus_trap.py: New test for initial focus

Refs #69
Rockachopa commented 2026-04-15 03:26:04 +00:00
Author
Owner
Copy Link

Fix submitted: PR #107

Changed showOverlay() to focus .overlay-call link instead of disabled dismiss button. Added 2 new tests.

Fix submitted: PR #107 Changed `showOverlay()` to focus `.overlay-call` link instead of disabled dismiss button. Added 2 new tests.
Rockachopa commented 2026-04-15 04:00:31 +00:00
Author
Owner
Copy Link

Closing: superseded by PR #107 which has a cleaner implementation.

Closing: superseded by PR #107 which has a cleaner implementation.
Rockachopa closed this pull request 2026-04-15 04:00:31 +00:00
All checks were successful
Sanity Checks / sanity-test (pull_request) Successful in 10s
Details
Smoke Test / smoke (pull_request) Successful in 16s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Backend / API
 batch-pipeline
batch-pipeline label
 content
Content, copy, testimony
 deploy
Deployment / go-live
 epic
Epic / parent issue
 frontend
Frontend / UI
 hardening
Resilience, fallback, security
 infra
Infrastructure, DevOps, deployment
 priority:critical
Must have for launch
 priority:high
Important for launch
 priority:medium
Nice to have at launch
 protocol
Crisis detection protocol
 throughput-10x
throughput-10x label
 token-masterplan
token-masterplan label
 velocity-engine
Auto-generated by velocity engine
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Rockachopa Timmy allegro antigravity bezalel claude codex-agent ezra gemini google grok hermes kimi manus perplexity sonnet
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Timmy_Foundation/the-door#90
Delete Branch "burn/69-1776218206"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?