Compare commits
1 Commits
burn/1474-
...
fix/1444
| Author | SHA1 | Date | |
|---|---|---|---|
|
a9f7ec6178 |
160
.gitea/workflows/auto-assign-reviewers.yml
Normal file
160
.gitea/workflows/auto-assign-reviewers.yml
Normal file
@@ -0,0 +1,160 @@
|
||||
# .gitea/workflows/auto-assign-reviewers.yml
|
||||
# Automated reviewer assignment for PRs
|
||||
# Issue #1444: policy: Implement automated reviewer assignment
|
||||
|
||||
name: Auto-Assign Reviewers
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
types: [opened, reopened, ready_for_review]
|
||||
|
||||
jobs:
|
||||
auto-assign:
|
||||
runs-on: ubuntu-latest
|
||||
if: github.event.pull_request.draft == false
|
||||
|
||||
steps:
|
||||
- name: Checkout code
|
||||
uses: actions/checkout@v3
|
||||
|
||||
- name: Auto-assign reviewers
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
REPO: ${{ github.repository }}
|
||||
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
|
||||
run: |
|
||||
echo "Auto-assigning reviewers for PR #$PR_NUMBER"
|
||||
echo "Repository: $REPO"
|
||||
echo "PR Author: $PR_AUTHOR"
|
||||
|
||||
# Get repository name
|
||||
REPO_NAME=$(basename "$REPO")
|
||||
|
||||
# Define default reviewers based on repository
|
||||
case "$REPO_NAME" in
|
||||
"hermes-agent")
|
||||
DEFAULT_REVIEWERS=("Timmy" "perplexity")
|
||||
REQUIRED_REVIEWERS=("Timmy")
|
||||
;;
|
||||
"the-nexus")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
"timmy-home")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
"timmy-config")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
*)
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
esac
|
||||
|
||||
# Combine default and required reviewers
|
||||
ALL_REVIEWERS=("${DEFAULT_REVIEWERS[@]}" "${REQUIRED_REVIEWERS[@]}")
|
||||
|
||||
# Remove duplicates
|
||||
UNIQUE_REVIEWERS=($(echo "${ALL_REVIEWERS[@]}" | tr ' ' '\n' | sort -u | tr '\n' ' '))
|
||||
|
||||
# Remove PR author from reviewers (can't review own PR)
|
||||
FINAL_REVIEWERS=()
|
||||
for reviewer in "${UNIQUE_REVIEWERS[@]}"; do
|
||||
if [ "$reviewer" != "$PR_AUTHOR" ]; then
|
||||
FINAL_REVIEWERS+=("$reviewer")
|
||||
fi
|
||||
done
|
||||
|
||||
# Check if we have any reviewers
|
||||
if [ ${#FINAL_REVIEWERS[@]} -eq 0 ]; then
|
||||
echo "⚠️ WARNING: No reviewers available (author is only reviewer)"
|
||||
echo "Adding fallback reviewer: perplexity"
|
||||
FINAL_REVIEWERS=("perplexity")
|
||||
fi
|
||||
|
||||
echo "Assigning reviewers: ${FINAL_REVIEWERS[*]}"
|
||||
|
||||
# Assign reviewers via Gitea API
|
||||
for reviewer in "${FINAL_REVIEWERS[@]}"; do
|
||||
echo "Assigning $reviewer as reviewer..."
|
||||
|
||||
# Use Gitea API to request reviewer
|
||||
RESPONSE=$(curl -s -w "%{http_code}" -X POST \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN" \
|
||||
-H "Content-Type: application/json" \
|
||||
-d "{\"reviewers\": [\"$reviewer\"]}")
|
||||
|
||||
HTTP_CODE="${RESPONSE: -3}"
|
||||
RESPONSE_BODY="${RESPONSE:0:${#RESPONSE}-3}"
|
||||
|
||||
if [ "$HTTP_CODE" -eq 201 ]; then
|
||||
echo "✅ Successfully assigned $reviewer as reviewer"
|
||||
elif [ "$HTTP_CODE" -eq 422 ]; then
|
||||
echo "⚠️ $reviewer is already a reviewer or cannot be assigned"
|
||||
else
|
||||
echo "❌ Failed to assign $reviewer (HTTP $HTTP_CODE): $RESPONSE_BODY"
|
||||
fi
|
||||
done
|
||||
|
||||
# Verify at least one reviewer was assigned
|
||||
echo ""
|
||||
echo "Checking assigned reviewers..."
|
||||
|
||||
REVIEWERS_RESPONSE=$(curl -s \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN")
|
||||
|
||||
REVIEWER_COUNT=$(echo "$REVIEWERS_RESPONSE" | jq '.users | length' 2>/dev/null || echo "0")
|
||||
|
||||
if [ "$REVIEWER_COUNT" -gt 0 ]; then
|
||||
echo "✅ PR #$PR_NUMBER has $REVIEWER_COUNT reviewer(s) assigned"
|
||||
echo "$REVIEWERS_RESPONSE" | jq '.users[].login' 2>/dev/null || echo "$REVIEWERS_RESPONSE"
|
||||
else
|
||||
echo "❌ ERROR: No reviewers assigned to PR #$PR_NUMBER"
|
||||
exit 1
|
||||
fi
|
||||
|
||||
- name: Add comment about reviewer assignment
|
||||
env:
|
||||
GITEA_TOKEN: ${{ secrets.GITEA_TOKEN }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
REPO: ${{ github.repository }}
|
||||
run: |
|
||||
# Get assigned reviewers
|
||||
REVIEWERS_RESPONSE=$(curl -s \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN")
|
||||
|
||||
REVIEWER_LIST=$(echo "$REVIEWERS_RESPONSE" | jq -r '.users[].login' 2>/dev/null | tr '\n' ', ' | sed 's/,$//')
|
||||
|
||||
if [ -n "$REVIEWER_LIST" ]; then
|
||||
COMMENT="## Automated Reviewer Assignment
|
||||
|
||||
Reviewers have been automatically assigned to this PR:
|
||||
|
||||
**Assigned Reviewers:** $REVIEWER_LIST
|
||||
|
||||
**Policy:** All PRs must have at least one reviewer assigned before merging.
|
||||
|
||||
**Next Steps:**
|
||||
1. Reviewers will be notified automatically
|
||||
2. Please review the changes within 48 hours
|
||||
3. Request changes or approve as appropriate
|
||||
|
||||
This is an automated assignment based on CODEOWNERS and repository policy.
|
||||
See issue #1444 for details."
|
||||
|
||||
# Add comment to PR
|
||||
curl -s -X POST \
|
||||
"https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/issues/$PR_NUMBER/comments" \
|
||||
-H "Authorization: token $GITEA_TOKEN" \
|
||||
-H "Content-Type: application/json" \
|
||||
-d "{\"body\": \"$COMMENT\"}" > /dev/null
|
||||
|
||||
echo "✅ Added comment about reviewer assignment"
|
||||
fi
|
||||
19
.github/CODEOWNERS
vendored
19
.github/CODEOWNERS
vendored
@@ -12,21 +12,8 @@ the-nexus/ai/ @Timmy
|
||||
timmy-home/ @perplexity
|
||||
timmy-config/ @perplexity
|
||||
|
||||
# Owner gates
|
||||
# Owner gates for critical systems
|
||||
hermes-agent/ @Timmy
|
||||
# CODEOWNERS - Mandatory Review Policy
|
||||
|
||||
# Default reviewer for all repositories
|
||||
* @perplexity
|
||||
|
||||
# Specialized component owners
|
||||
hermes-agent/ @Timmy
|
||||
hermes-agent/agent-core/ @Rockachopa
|
||||
hermes-agent/protocol/ @Timmy
|
||||
the-nexus/ @perplexity
|
||||
the-nexus/ai/ @Timmy
|
||||
timmy-home/ @perplexity
|
||||
timmy-config/ @perplexity
|
||||
|
||||
# Owner gates
|
||||
hermes-agent/ @Timmy
|
||||
# QA reviewer for all PRs
|
||||
* @perplexity
|
||||
241
bin/check_reviewers.py
Executable file
241
bin/check_reviewers.py
Executable file
@@ -0,0 +1,241 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Check for PRs without assigned reviewers.
|
||||
Issue #1444: policy: Implement automated reviewer assignment
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import urllib.request
|
||||
from typing import Dict, List, Any, Optional
|
||||
|
||||
# Configuration
|
||||
GITEA_BASE = "https://forge.alexanderwhitestone.com/api/v1"
|
||||
TOKEN_PATH = os.path.expanduser("~/.config/gitea/token")
|
||||
ORG = "Timmy_Foundation"
|
||||
|
||||
class ReviewerChecker:
|
||||
def __init__(self):
|
||||
self.token = self._load_token()
|
||||
|
||||
def _load_token(self) -> str:
|
||||
"""Load Gitea API token."""
|
||||
try:
|
||||
with open(TOKEN_PATH, "r") as f:
|
||||
return f.read().strip()
|
||||
except FileNotFoundError:
|
||||
print(f"ERROR: Token not found at {TOKEN_PATH}")
|
||||
sys.exit(1)
|
||||
|
||||
def _api_request(self, endpoint: str) -> Any:
|
||||
"""Make authenticated Gitea API request."""
|
||||
url = f"{GITEA_BASE}{endpoint}"
|
||||
headers = {"Authorization": f"token {self.token}"}
|
||||
|
||||
req = urllib.request.Request(url, headers=headers)
|
||||
|
||||
try:
|
||||
with urllib.request.urlopen(req) as resp:
|
||||
return json.loads(resp.read())
|
||||
except urllib.error.HTTPError as e:
|
||||
if e.code == 404:
|
||||
return None
|
||||
error_body = e.read().decode() if e.fp else "No error body"
|
||||
print(f"API Error {e.code}: {error_body}")
|
||||
return None
|
||||
|
||||
def get_open_prs(self, repo: str) -> List[Dict]:
|
||||
"""Get open PRs for a repository."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls?state=open"
|
||||
prs = self._api_request(endpoint)
|
||||
return prs if isinstance(prs, list) else []
|
||||
|
||||
def get_pr_reviewers(self, repo: str, pr_number: int) -> Dict:
|
||||
"""Get requested reviewers for a PR."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls/{pr_number}/requested_reviewers"
|
||||
return self._api_request(endpoint) or {}
|
||||
|
||||
def get_pr_reviews(self, repo: str, pr_number: int) -> List[Dict]:
|
||||
"""Get reviews for a PR."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls/{pr_number}/reviews"
|
||||
reviews = self._api_request(endpoint)
|
||||
return reviews if isinstance(reviews, list) else []
|
||||
|
||||
def check_prs_without_reviewers(self, repos: List[str]) -> Dict[str, Any]:
|
||||
"""Check for PRs without assigned reviewers."""
|
||||
results = {
|
||||
"repos": {},
|
||||
"summary": {
|
||||
"total_prs": 0,
|
||||
"prs_without_reviewers": 0,
|
||||
"repos_checked": len(repos)
|
||||
}
|
||||
}
|
||||
|
||||
for repo in repos:
|
||||
prs = self.get_open_prs(repo)
|
||||
results["repos"][repo] = {
|
||||
"total_prs": len(prs),
|
||||
"prs_without_reviewers": [],
|
||||
"prs_with_reviewers": []
|
||||
}
|
||||
results["summary"]["total_prs"] += len(prs)
|
||||
|
||||
for pr in prs:
|
||||
pr_number = pr["number"]
|
||||
pr_title = pr["title"]
|
||||
pr_author = pr["user"]["login"]
|
||||
|
||||
# Check for requested reviewers
|
||||
requested = self.get_pr_reviewers(repo, pr_number)
|
||||
has_requested = len(requested.get("users", [])) > 0
|
||||
|
||||
# Check for existing reviews
|
||||
reviews = self.get_pr_reviews(repo, pr_number)
|
||||
has_reviews = len(reviews) > 0
|
||||
|
||||
# Check if author is the only potential reviewer
|
||||
is_self_review = pr_author in [r.get("user", {}).get("login") for r in reviews]
|
||||
|
||||
if not has_requested and not has_reviews:
|
||||
results["repos"][repo]["prs_without_reviewers"].append({
|
||||
"number": pr_number,
|
||||
"title": pr_title,
|
||||
"author": pr_author,
|
||||
"created": pr["created_at"],
|
||||
"url": pr["html_url"]
|
||||
})
|
||||
results["summary"]["prs_without_reviewers"] += 1
|
||||
else:
|
||||
results["repos"][repo]["prs_with_reviewers"].append({
|
||||
"number": pr_number,
|
||||
"title": pr_title,
|
||||
"author": pr_author,
|
||||
"has_requested": has_requested,
|
||||
"has_reviews": has_reviews,
|
||||
"is_self_review": is_self_review
|
||||
})
|
||||
|
||||
return results
|
||||
|
||||
def generate_report(self, results: Dict[str, Any]) -> str:
|
||||
"""Generate a report of reviewer assignment status."""
|
||||
report = "# PR Reviewer Assignment Report\n\n"
|
||||
report += "## Summary\n"
|
||||
report += f"- **Repositories checked:** {results['summary']['repos_checked']}\n"
|
||||
report += f"- **Total open PRs:** {results['summary']['total_prs']}\n"
|
||||
report += f"- **PRs without reviewers:** {results['summary']['prs_without_reviewers']}\n\n"
|
||||
|
||||
if results['summary']['prs_without_reviewers'] == 0:
|
||||
report += "✅ **All PRs have assigned reviewers.**\n"
|
||||
else:
|
||||
report += "⚠️ **PRs without assigned reviewers:**\n\n"
|
||||
|
||||
for repo, data in results["repos"].items():
|
||||
if data["prs_without_reviewers"]:
|
||||
report += f"### {repo}\n"
|
||||
for pr in data["prs_without_reviewers"]:
|
||||
report += f"- **#{pr['number']}**: {pr['title']}\n"
|
||||
report += f" - Author: {pr['author']}\n"
|
||||
report += f" - Created: {pr['created']}\n"
|
||||
report += f" - URL: {pr['url']}\n"
|
||||
report += "\n"
|
||||
|
||||
report += "## Repository Details\n\n"
|
||||
for repo, data in results["repos"].items():
|
||||
report += f"### {repo}\n"
|
||||
report += f"- **Total PRs:** {data['total_prs']}\n"
|
||||
report += f"- **PRs without reviewers:** {len(data['prs_without_reviewers'])}\n"
|
||||
report += f"- **PRs with reviewers:** {len(data['prs_with_reviewers'])}\n\n"
|
||||
|
||||
if data['prs_with_reviewers']:
|
||||
report += "**PRs with reviewers:**\n"
|
||||
for pr in data['prs_with_reviewers']:
|
||||
status = "✅" if pr['has_requested'] else "⚠️"
|
||||
if pr['is_self_review']:
|
||||
status = "⚠️ (self-review)"
|
||||
report += f"- {status} #{pr['number']}: {pr['title']}\n"
|
||||
report += "\n"
|
||||
|
||||
return report
|
||||
|
||||
def assign_reviewer(self, repo: str, pr_number: int, reviewer: str) -> bool:
|
||||
"""Assign a reviewer to a PR."""
|
||||
endpoint = f"/repos/{ORG}/{repo}/pulls/{pr_number}/requested_reviewers"
|
||||
data = {"reviewers": [reviewer]}
|
||||
|
||||
url = f"{GITEA_BASE}{endpoint}"
|
||||
headers = {
|
||||
"Authorization": f"token {self.token}",
|
||||
"Content-Type": "application/json"
|
||||
}
|
||||
|
||||
req = urllib.request.Request(url, headers=headers, method="POST")
|
||||
req.data = json.dumps(data).encode()
|
||||
|
||||
try:
|
||||
with urllib.request.urlopen(req) as resp:
|
||||
return resp.status == 201
|
||||
except urllib.error.HTTPError as e:
|
||||
print(f"Failed to assign reviewer: {e.code}")
|
||||
return False
|
||||
|
||||
|
||||
def main():
|
||||
"""Main entry point for reviewer checker."""
|
||||
import argparse
|
||||
|
||||
parser = argparse.ArgumentParser(description="Check for PRs without assigned reviewers")
|
||||
parser.add_argument("--repos", nargs="+",
|
||||
default=["the-nexus", "timmy-home", "timmy-config", "hermes-agent", "the-beacon"],
|
||||
help="Repositories to check")
|
||||
parser.add_argument("--report", action="store_true", help="Generate report")
|
||||
parser.add_argument("--json", action="store_true", help="Output JSON instead of report")
|
||||
parser.add_argument("--assign", nargs=2, metavar=("REPO", "PR"),
|
||||
help="Assign a reviewer to a specific PR")
|
||||
parser.add_argument("--reviewer", help="Reviewer to assign (e.g., @perplexity)")
|
||||
|
||||
args = parser.parse_args()
|
||||
|
||||
checker = ReviewerChecker()
|
||||
|
||||
if args.assign:
|
||||
# Assign reviewer to specific PR
|
||||
repo, pr_number = args.assign
|
||||
reviewer = args.reviewer or "@perplexity"
|
||||
|
||||
if checker.assign_reviewer(repo, int(pr_number), reviewer):
|
||||
print(f"✅ Assigned {reviewer} as reviewer to {repo} #{pr_number}")
|
||||
else:
|
||||
print(f"❌ Failed to assign reviewer to {repo} #{pr_number}")
|
||||
sys.exit(1)
|
||||
else:
|
||||
# Check for PRs without reviewers
|
||||
results = checker.check_prs_without_reviewers(args.repos)
|
||||
|
||||
if args.json:
|
||||
print(json.dumps(results, indent=2))
|
||||
elif args.report:
|
||||
report = checker.generate_report(results)
|
||||
print(report)
|
||||
else:
|
||||
# Default: show summary
|
||||
print(f"Checked {results['summary']['repos_checked']} repositories")
|
||||
print(f"Total open PRs: {results['summary']['total_prs']}")
|
||||
print(f"PRs without reviewers: {results['summary']['prs_without_reviewers']}")
|
||||
|
||||
if results['summary']['prs_without_reviewers'] > 0:
|
||||
print("\nPRs without reviewers:")
|
||||
for repo, data in results["repos"].items():
|
||||
if data["prs_without_reviewers"]:
|
||||
for pr in data["prs_without_reviewers"]:
|
||||
print(f" {repo} #{pr['number']}: {pr['title']}")
|
||||
sys.exit(1)
|
||||
else:
|
||||
print("\n✅ All PRs have assigned reviewers")
|
||||
sys.exit(0)
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
227
docs/auto-reviewer-assignment.md
Normal file
227
docs/auto-reviewer-assignment.md
Normal file
@@ -0,0 +1,227 @@
|
||||
# Automated Reviewer Assignment
|
||||
|
||||
**Issue:** #1444 - policy: Implement automated reviewer assignment (from Issue #1127 triage)
|
||||
**Purpose:** Ensure all PRs have at least one reviewer assigned
|
||||
|
||||
## Problem
|
||||
|
||||
From issue #1127 triage:
|
||||
> "0 of 14 PRs had a reviewer assigned before this pass."
|
||||
|
||||
This means:
|
||||
- PRs can be created without any reviewer
|
||||
- No automated enforcement of reviewer assignment
|
||||
- PRs may sit without review for extended periods
|
||||
|
||||
## Solution
|
||||
|
||||
### 1. GitHub Actions Workflow (`.gitea/workflows/auto-assign-reviewers.yml`)
|
||||
Automatically assigns reviewers when PRs are created:
|
||||
|
||||
**When it runs:**
|
||||
- On PR open
|
||||
- On PR reopen
|
||||
- On PR ready for review (not draft)
|
||||
|
||||
**What it does:**
|
||||
1. Determines appropriate reviewers based on repository
|
||||
2. Assigns reviewers via Gitea API
|
||||
3. Adds comment about reviewer assignment
|
||||
4. Verifies at least one reviewer is assigned
|
||||
|
||||
### 2. Reviewer Check Script (`bin/check_reviewers.py`)
|
||||
Script to check for PRs without reviewers:
|
||||
|
||||
**Usage:**
|
||||
```bash
|
||||
# Check all repositories
|
||||
python bin/check_reviewers.py
|
||||
|
||||
# Check specific repositories
|
||||
python bin/check_reviewers.py --repos the-nexus timmy-home
|
||||
|
||||
# Generate report
|
||||
python bin/check_reviewers.py --report
|
||||
|
||||
# Assign reviewer to specific PR
|
||||
python bin/check_reviewers.py --assign the-nexus 123 --reviewer @perplexity
|
||||
```
|
||||
|
||||
### 3. CODEOWNERS File (`.github/CODEOWNERS`)
|
||||
Defines default reviewers for different paths:
|
||||
|
||||
```
|
||||
# Default reviewer for all repositories
|
||||
* @perplexity
|
||||
|
||||
# Specialized component owners
|
||||
hermes-agent/ @Timmy
|
||||
hermes-agent/agent-core/ @Rockachopa
|
||||
hermes-agent/protocol/ @Timmy
|
||||
the-nexus/ @perplexity
|
||||
the-nexus/ai/ @Timmy
|
||||
timmy-home/ @perplexity
|
||||
timmy-config/ @perplexity
|
||||
|
||||
# Owner gates for critical systems
|
||||
hermes-agent/ @Timmy
|
||||
```
|
||||
|
||||
## Reviewer Assignment Rules
|
||||
|
||||
### Repository-Specific Rules
|
||||
|
||||
| Repository | Default Reviewers | Required Reviewers | Notes |
|
||||
|------------|-------------------|-------------------|-------|
|
||||
| hermes-agent | @Timmy, @perplexity | @Timmy | Owner gate for critical system |
|
||||
| the-nexus | @perplexity | None | QA gate |
|
||||
| timmy-home | @perplexity | None | QA gate |
|
||||
| timmy-config | @perplexity | None | QA gate |
|
||||
| the-beacon | @perplexity | None | QA gate |
|
||||
|
||||
### Special Rules
|
||||
|
||||
1. **No self-review:** PR author cannot be assigned as reviewer
|
||||
2. **Fallback:** If no reviewers available, assign @perplexity
|
||||
3. **Critical systems:** hermes-agent requires @Timmy as reviewer
|
||||
|
||||
## How It Works
|
||||
|
||||
### Automated Assignment Flow
|
||||
|
||||
1. **PR Created** → GitHub Actions workflow triggers
|
||||
2. **Determine Reviewers** → Based on repository and CODEOWNERS
|
||||
3. **Assign Reviewers** → Via Gitea API
|
||||
4. **Add Comment** → Notify about assignment
|
||||
5. **Verify** → Ensure at least one reviewer assigned
|
||||
|
||||
### Manual Assignment
|
||||
|
||||
```bash
|
||||
# Assign specific reviewer
|
||||
python bin/check_reviewers.py --assign the-nexus 123 --reviewer @perplexity
|
||||
|
||||
# Check for PRs without reviewers
|
||||
python bin/check_reviewers.py --report
|
||||
```
|
||||
|
||||
## Configuration
|
||||
|
||||
### Environment Variables
|
||||
|
||||
- `GITEA_TOKEN`: Gitea API token for authentication
|
||||
- `REPO`: Repository name (auto-set in GitHub Actions)
|
||||
- `PR_NUMBER`: PR number (auto-set in GitHub Actions)
|
||||
|
||||
### Repository Configuration
|
||||
|
||||
Edit the workflow to customize reviewer assignment:
|
||||
|
||||
```yaml
|
||||
# Define default reviewers based on repository
|
||||
case "$REPO_NAME" in
|
||||
"hermes-agent")
|
||||
DEFAULT_REVIEWERS=("Timmy" "perplexity")
|
||||
REQUIRED_REVIEWERS=("Timmy")
|
||||
;;
|
||||
"the-nexus")
|
||||
DEFAULT_REVIEWERS=("perplexity")
|
||||
REQUIRED_REVIEWERS=()
|
||||
;;
|
||||
# Add more repositories as needed
|
||||
esac
|
||||
```
|
||||
|
||||
## Testing
|
||||
|
||||
### Test the workflow:
|
||||
|
||||
1. Create a test PR
|
||||
2. Check if reviewers are automatically assigned
|
||||
3. Verify comment is added
|
||||
|
||||
### Test the script:
|
||||
|
||||
```bash
|
||||
# Check for PRs without reviewers
|
||||
python bin/check_reviewers.py --report
|
||||
|
||||
# Assign reviewer to test PR
|
||||
python bin/check_reviewers.py --assign the-nexus 123 --reviewer @perplexity
|
||||
```
|
||||
|
||||
## Monitoring
|
||||
|
||||
### Check for PRs without reviewers:
|
||||
|
||||
```bash
|
||||
# Daily check
|
||||
python bin/check_reviewers.py --report
|
||||
|
||||
# JSON output for automation
|
||||
python bin/check_reviewers.py --json
|
||||
```
|
||||
|
||||
### Review assignment logs:
|
||||
|
||||
1. Check GitHub Actions logs for assignment details
|
||||
2. Review PR comments for assignment notifications
|
||||
3. Monitor for PRs with 0 reviewers
|
||||
|
||||
## Enforcement
|
||||
|
||||
### CI Check (Future Enhancement)
|
||||
|
||||
Add CI check to reject PRs with 0 reviewers:
|
||||
|
||||
```yaml
|
||||
# In CI workflow
|
||||
- name: Check for reviewers
|
||||
run: |
|
||||
REVIEWERS=$(curl -s "https://forge.alexanderwhitestone.com/api/v1/repos/$REPO/pulls/$PR_NUMBER/requested_reviewers" \
|
||||
-H "Authorization: token $GITEA_TOKEN" | jq '.users | length')
|
||||
|
||||
if [ "$REVIEWERS" -eq 0 ]; then
|
||||
echo "❌ ERROR: PR has no reviewers assigned"
|
||||
exit 1
|
||||
fi
|
||||
```
|
||||
|
||||
### Policy Enforcement
|
||||
|
||||
1. **All PRs must have reviewers** - No exceptions
|
||||
2. **No self-review** - PR author cannot review own PR
|
||||
3. **Critical systems require specific reviewers** - hermes-agent requires @Timmy
|
||||
|
||||
## Related Issues
|
||||
|
||||
- **Issue #1127:** Perplexity Evening Pass triage (identified missing reviewers)
|
||||
- **Issue #1444:** This implementation
|
||||
- **Issue #1336:** Merge conflicts in CODEOWNERS (fixed)
|
||||
|
||||
## Files Added/Modified
|
||||
|
||||
1. `.gitea/workflows/auto-assign-reviewers.yml` - GitHub Actions workflow
|
||||
2. `bin/check_reviewers.py` - Reviewer check script
|
||||
3. `.github/CODEOWNERS` - Cleaned up CODEOWNERS file
|
||||
4. `docs/auto-reviewer-assignment.md` - This documentation
|
||||
|
||||
## Future Enhancements
|
||||
|
||||
1. **CI check for 0 reviewers** - Reject PRs without reviewers
|
||||
2. **Slack/Telegram notifications** - Notify when PRs lack reviewers
|
||||
3. **Load balancing** - Distribute reviews evenly among team members
|
||||
4. **Auto-assign based on file changes** - Assign specialists for specific areas
|
||||
|
||||
## Conclusion
|
||||
|
||||
This implementation ensures all PRs have at least one reviewer assigned:
|
||||
- **Automated assignment** on PR creation
|
||||
- **Manual checking** for existing PRs
|
||||
- **Clear documentation** of policies and procedures
|
||||
|
||||
**Result:** No more PRs sitting without reviewers.
|
||||
|
||||
## License
|
||||
|
||||
Part of the Timmy Foundation project.
|
||||
@@ -1,137 +0,0 @@
|
||||
# Duplicate PR Prevention System
|
||||
|
||||
## Problem
|
||||
|
||||
Despite having tools to detect and clean up duplicate PRs, agents were still creating duplicate PRs for the same issue. This was incredibly ironic, especially for issue #1128 which was about cleaning up duplicate PRs.
|
||||
|
||||
## Solution
|
||||
|
||||
We've created a comprehensive system to prevent duplicate PRs:
|
||||
|
||||
### 1. Pre-flight Checks
|
||||
|
||||
Before creating a PR, agents should run a pre-flight check to see if PRs already exist for the issue.
|
||||
|
||||
#### Bash Version
|
||||
```bash
|
||||
# Check for existing PRs for issue #1128
|
||||
./scripts/check-existing-prs.sh 1128
|
||||
|
||||
# Exit codes:
|
||||
# 0 - No existing PRs found (safe to create new PR)
|
||||
# 1 - Existing PRs found (do not create new PR)
|
||||
# 2 - Error (API failure, missing parameters, etc.)
|
||||
```
|
||||
|
||||
#### Python Version
|
||||
```bash
|
||||
# Check for existing PRs for issue #1128
|
||||
python3 scripts/check_existing_prs.py 1128
|
||||
|
||||
# Same exit codes as bash version
|
||||
```
|
||||
|
||||
#### User-Friendly Wrapper
|
||||
```bash
|
||||
# Get guidance and suggestions
|
||||
./scripts/pr-safe.sh 1128
|
||||
|
||||
# With suggested branch name
|
||||
./scripts/pr-safe.sh 1128 fix/1128-my-fix
|
||||
```
|
||||
|
||||
### 2. Cleanup Tools
|
||||
|
||||
For cleaning up existing duplicate PRs:
|
||||
|
||||
```bash
|
||||
# Dry run (show what would be done)
|
||||
./scripts/cleanup-duplicate-prs.sh --dry-run
|
||||
|
||||
# Actually close duplicate PRs
|
||||
./scripts/cleanup-duplicate-prs.sh --close
|
||||
```
|
||||
|
||||
## Workflow Integration
|
||||
|
||||
### For Agents
|
||||
|
||||
Before creating a PR, agents should:
|
||||
|
||||
1. Run the check: `./scripts/check-existing-prs.sh <issue_number>`
|
||||
2. If exit code is `0`, proceed with PR creation
|
||||
3. If exit code is `1`, review existing PRs instead
|
||||
|
||||
### For Humans
|
||||
|
||||
Before creating a PR:
|
||||
|
||||
1. Run: `./scripts/pr-safe.sh <issue_number>`
|
||||
2. Follow the guidance provided
|
||||
|
||||
## Prevention Strategy
|
||||
|
||||
### 1. Pre-flight Checks
|
||||
|
||||
Always run a pre-flight check before creating a PR:
|
||||
|
||||
```bash
|
||||
# In your agent workflow
|
||||
if ./scripts/check-existing-prs.sh $ISSUE_NUMBER; then
|
||||
# Safe to create PR
|
||||
create_pr
|
||||
else
|
||||
# Don't create PR, review existing ones
|
||||
review_existing_prs
|
||||
fi
|
||||
```
|
||||
|
||||
### 2. GitHub Actions Integration
|
||||
|
||||
The existing `.github/workflows/pr-duplicate-check.yml` workflow can be enhanced to run these checks automatically.
|
||||
|
||||
### 3. Agent Instructions
|
||||
|
||||
Add to agent instructions:
|
||||
|
||||
```
|
||||
Before creating a PR for an issue, ALWAYS run:
|
||||
./scripts/check-existing-prs.sh <issue_number>
|
||||
|
||||
If PRs already exist, DO NOT create a new PR.
|
||||
Instead, review existing PRs and add comments or merge them.
|
||||
```
|
||||
|
||||
## Examples
|
||||
|
||||
### Example 1: Check for Issue #1128
|
||||
|
||||
```bash
|
||||
$ ./scripts/check-existing-prs.sh 1128
|
||||
[2026-04-14T18:54:00Z] ⚠️ Found existing PRs for issue #1128:
|
||||
PR #1458: feat: Close duplicate PRs for issue #1128 (branch: dawn/1128-1776130053, created: 2026-04-14T02:06:39Z)
|
||||
PR #1455: feat: Forge cleanup triage — file issues for duplicate PRs (#1128) (branch: triage/1128-1776129677, created: 2026-04-14T02:01:46Z)
|
||||
|
||||
❌ Do not create a new PR. Review existing PRs first.
|
||||
```
|
||||
|
||||
### Example 2: Safe to Create PR
|
||||
|
||||
```bash
|
||||
$ ./scripts/check-existing-prs.sh 9999
|
||||
[2026-04-14T18:54:00Z] ✅ No existing PRs found for issue #9999
|
||||
Safe to create a new PR
|
||||
```
|
||||
|
||||
## Related Issues
|
||||
|
||||
- Issue #1474: [META] Still creating duplicate PRs for issue #1128 despite cleanup
|
||||
- Issue #1460: [META] I keep creating duplicate PRs for issue #1128
|
||||
- Issue #1128: [RESOLVED] Forge Cleanup — PRs Closed, Milestones Deduplicated, Policy Issues Filed
|
||||
|
||||
## Lessons Learned
|
||||
|
||||
1. **Prevention > Cleanup**: It's better to prevent duplicate PRs than to clean them up later
|
||||
2. **Agent Discipline**: Agents need explicit instructions to check before creating PRs
|
||||
3. **Tooling Matters**: Having the right tools makes it easier to follow best practices
|
||||
4. **Irony Awareness**: Be aware when you're creating the problem you're trying to solve
|
||||
@@ -1,78 +0,0 @@
|
||||
#!/usr/bin/env bash
|
||||
# ═══════════════════════════════════════════════════════════════
|
||||
# check-existing-prs.sh — Check if PRs already exist for an issue
|
||||
#
|
||||
# This script checks if there are already open PRs for a given issue
|
||||
# before creating a new one. This prevents duplicate PRs.
|
||||
#
|
||||
# Usage:
|
||||
# ./scripts/check-existing-prs.sh <issue_number>
|
||||
#
|
||||
# Exit codes:
|
||||
# 0 - No existing PRs found (safe to create new PR)
|
||||
# 1 - Existing PRs found (do not create new PR)
|
||||
# 2 - Error (API failure, missing parameters, etc.)
|
||||
#
|
||||
# Designed for issue #1474: Prevent duplicate PRs
|
||||
# ═══════════════════════════════════════════════════════════════
|
||||
set -euo pipefail
|
||||
|
||||
# ─── Configuration ──────────────────────────────────────────
|
||||
GITEA_URL="${GITEA_URL:-https://forge.alexanderwhitestone.com}"
|
||||
GITEA_TOKEN="${GITEA_TOKEN:?Set GITEA_TOKEN env var}"
|
||||
REPO="${REPO:-Timmy_Foundation/the-nexus}"
|
||||
ISSUE_NUMBER="${1:?Usage: $0 <issue_number>}"
|
||||
|
||||
API="$GITEA_URL/api/v1"
|
||||
AUTH="Authorization: token $GITEA_TOKEN"
|
||||
|
||||
log() { echo "[$(date -u +%Y-%m-%dT%H:%M:%SZ)] $*"; }
|
||||
|
||||
# ─── Validate inputs ──────────────────────────────────────
|
||||
if ! [[ "$ISSUE_NUMBER" =~ ^[0-9]+$ ]]; then
|
||||
log "ERROR: Issue number must be a positive integer"
|
||||
exit 2
|
||||
fi
|
||||
|
||||
# ─── Fetch open PRs ────────────────────────────────────────
|
||||
log "Checking for existing PRs for issue #$ISSUE_NUMBER in $REPO"
|
||||
|
||||
OPEN_PRS=$(curl -s -H "$AUTH" "$API/repos/$REPO/pulls?state=open&limit=100")
|
||||
|
||||
if [ -z "$OPEN_PRS" ] || [ "$OPEN_PRS" = "null" ]; then
|
||||
log "No open PRs found or API error"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# ─── Check for PRs referencing this issue ──────────────────
|
||||
# Look for PRs that mention the issue number in title or body
|
||||
MATCHING_PRS=$(echo "$OPEN_PRS" | jq -r --arg issue "#$ISSUE_NUMBER" '
|
||||
.[] |
|
||||
select(
|
||||
(.title | test($issue; "i")) or
|
||||
(.body | test($issue; "i"))
|
||||
) |
|
||||
"PR #\(.number): \(.title) (branch: \(.head.ref), created: \(.created_at))"
|
||||
')
|
||||
|
||||
if [ -z "$MATCHING_PRS" ]; then
|
||||
log "✅ No existing PRs found for issue #$ISSUE_NUMBER"
|
||||
log "Safe to create a new PR"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
# ─── Report existing PRs ───────────────────────────────────
|
||||
log "⚠️ Found existing PRs for issue #$ISSUE_NUMBER:"
|
||||
echo "$MATCHING_PRS"
|
||||
echo ""
|
||||
log "❌ Do not create a new PR. Review existing PRs first."
|
||||
log ""
|
||||
log "Options:"
|
||||
log " 1. Review and merge an existing PR"
|
||||
log " 2. Close duplicates and keep the best one"
|
||||
log " 3. Add comments to existing PRs instead of creating new ones"
|
||||
log ""
|
||||
log "To see details of existing PRs:"
|
||||
log " curl -H \"Authorization: token \$GITEA_TOKEN\" \"$API/repos/$REPO/pulls?state=open\" | jq '.[] | select(.title | test(\"#$ISSUE_NUMBER\"; \"i\"))'"
|
||||
|
||||
exit 1
|
||||
@@ -1,148 +0,0 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Check if PRs already exist for an issue before creating a new one.
|
||||
|
||||
This script prevents duplicate PRs by checking if there are already
|
||||
open PRs for a given issue.
|
||||
|
||||
Usage:
|
||||
python3 scripts/check_existing_prs.py <issue_number>
|
||||
|
||||
Exit codes:
|
||||
0 - No existing PRs found (safe to create new PR)
|
||||
1 - Existing PRs found (do not create new PR)
|
||||
2 - Error (API failure, missing parameters, etc.)
|
||||
|
||||
Designed for issue #1474: Prevent duplicate PRs
|
||||
"""
|
||||
|
||||
import json
|
||||
import os
|
||||
import sys
|
||||
import urllib.request
|
||||
import urllib.error
|
||||
from datetime import datetime
|
||||
|
||||
|
||||
def check_existing_prs(issue_number: int, repo: str = None, token: str = None) -> int:
|
||||
"""
|
||||
Check if PRs already exist for an issue.
|
||||
|
||||
Args:
|
||||
issue_number: The issue number to check
|
||||
repo: Repository in format "owner/repo" (default: from env or "Timmy_Foundation/the-nexus")
|
||||
token: Gitea API token (default: from GITEA_TOKEN env var)
|
||||
|
||||
Returns:
|
||||
0: No existing PRs found (safe to create new PR)
|
||||
1: Existing PRs found (do not create new PR)
|
||||
2: Error (API failure, missing parameters, etc.)
|
||||
"""
|
||||
# Get configuration from environment
|
||||
gitea_url = os.environ.get('GITEA_URL', 'https://forge.alexanderwhitestone.com')
|
||||
token = token or os.environ.get('GITEA_TOKEN')
|
||||
repo = repo or os.environ.get('REPO', 'Timmy_Foundation/the-nexus')
|
||||
|
||||
if not token:
|
||||
print("ERROR: GITEA_TOKEN environment variable not set", file=sys.stderr)
|
||||
return 2
|
||||
|
||||
# Validate issue number
|
||||
if not isinstance(issue_number, int) or issue_number <= 0:
|
||||
print("ERROR: Issue number must be a positive integer", file=sys.stderr)
|
||||
return 2
|
||||
|
||||
# Build API URL
|
||||
api_url = f"{gitea_url}/api/v1/repos/{repo}/pulls?state=open&limit=100"
|
||||
|
||||
# Make API request
|
||||
try:
|
||||
req = urllib.request.Request(api_url, headers={
|
||||
'Authorization': f'token {token}',
|
||||
'Content-Type': 'application/json'
|
||||
})
|
||||
|
||||
with urllib.request.urlopen(req, timeout=30) as resp:
|
||||
prs = json.loads(resp.read())
|
||||
|
||||
except urllib.error.URLError as e:
|
||||
print(f"ERROR: Failed to fetch PRs: {e}", file=sys.stderr)
|
||||
return 2
|
||||
except json.JSONDecodeError as e:
|
||||
print(f"ERROR: Failed to parse API response: {e}", file=sys.stderr)
|
||||
return 2
|
||||
except Exception as e:
|
||||
print(f"ERROR: Unexpected error: {e}", file=sys.stderr)
|
||||
return 2
|
||||
|
||||
# Check for PRs referencing this issue
|
||||
issue_ref = f"#{issue_number}"
|
||||
matching_prs = []
|
||||
|
||||
for pr in prs:
|
||||
title = pr.get('title', '')
|
||||
body = pr.get('body', '') or ''
|
||||
|
||||
# Check if issue is referenced in title or body
|
||||
if issue_ref in title or issue_ref in body:
|
||||
matching_prs.append(pr)
|
||||
|
||||
# Report results
|
||||
timestamp = datetime.utcnow().strftime("%Y-%m-%dT%H:%M:%SZ")
|
||||
|
||||
if not matching_prs:
|
||||
print(f"[{timestamp}] ✅ No existing PRs found for issue #{issue_number}")
|
||||
print("Safe to create a new PR")
|
||||
return 0
|
||||
|
||||
# Found existing PRs
|
||||
print(f"[{timestamp}] ⚠️ Found existing PRs for issue #{issue_number}:")
|
||||
print()
|
||||
|
||||
for pr in matching_prs:
|
||||
pr_number = pr.get('number')
|
||||
pr_title = pr.get('title')
|
||||
pr_branch = pr.get('head', {}).get('ref', 'unknown')
|
||||
pr_created = pr.get('created_at', 'unknown')
|
||||
pr_url = pr.get('html_url', 'unknown')
|
||||
|
||||
print(f" PR #{pr_number}: {pr_title}")
|
||||
print(f" Branch: {pr_branch}")
|
||||
print(f" Created: {pr_created}")
|
||||
print(f" URL: {pr_url}")
|
||||
print()
|
||||
|
||||
print("❌ Do not create a new PR. Review existing PRs first.")
|
||||
print()
|
||||
print("Options:")
|
||||
print(" 1. Review and merge an existing PR")
|
||||
print(" 2. Close duplicates and keep the best one")
|
||||
print(" 3. Add comments to existing PRs instead of creating new ones")
|
||||
print()
|
||||
print("To see details of existing PRs:")
|
||||
print(f' curl -H "Authorization: token $GITEA_TOKEN" "{gitea_url}/api/v1/repos/{repo}/pulls?state=open" | jq \'.[] | select(.title | test("#{issue_number}"; "i"))\'')
|
||||
|
||||
return 1
|
||||
|
||||
|
||||
def main():
|
||||
"""Main entry point."""
|
||||
if len(sys.argv) < 2:
|
||||
print("Usage: python3 check_existing_prs.py <issue_number>", file=sys.stderr)
|
||||
print(" python3 check_existing_prs.py <issue_number> [repo] [token]", file=sys.stderr)
|
||||
return 2
|
||||
|
||||
try:
|
||||
issue_number = int(sys.argv[1])
|
||||
except ValueError:
|
||||
print("ERROR: Issue number must be an integer", file=sys.stderr)
|
||||
return 2
|
||||
|
||||
repo = sys.argv[2] if len(sys.argv) > 2 else None
|
||||
token = sys.argv[3] if len(sys.argv) > 3 else None
|
||||
|
||||
return check_existing_prs(issue_number, repo, token)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
sys.exit(main())
|
||||
@@ -35,7 +35,7 @@ for arg in "$@"; do
|
||||
done
|
||||
|
||||
API="$GITEA_URL/api/v1"
|
||||
AUTH="Authorization: token $GITEA_TOKEN"
|
||||
AUTH="token $GITEA_TOKEN"
|
||||
|
||||
log() { echo "[$(date -u +%Y-%m-%dT%H:%M:%SZ)] $*"; }
|
||||
|
||||
|
||||
@@ -1,48 +0,0 @@
|
||||
#!/usr/bin/env bash
|
||||
# ═══════════════════════════════════════════════════════════════
|
||||
# pr-safe.sh — Safe PR creation wrapper
|
||||
#
|
||||
# This script checks for existing PRs before creating a new one.
|
||||
# It's a wrapper around check-existing-prs.sh that provides
|
||||
# a user-friendly interface.
|
||||
#
|
||||
# Usage:
|
||||
# ./scripts/pr-safe.sh <issue_number> [branch_name]
|
||||
#
|
||||
# If branch_name is not provided, it will suggest one based on
|
||||
# the issue number and current timestamp.
|
||||
# ═══════════════════════════════════════════════════════════════
|
||||
set -euo pipefail
|
||||
|
||||
ISSUE_NUMBER="${1:?Usage: $0 <issue_number> [branch_name]}"
|
||||
BRANCH_NAME="${2:-}"
|
||||
|
||||
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
||||
|
||||
echo "🔍 Checking for existing PRs for issue #$ISSUE_NUMBER..."
|
||||
echo ""
|
||||
|
||||
# Run the check
|
||||
if "$SCRIPT_DIR/check-existing-prs.sh" "$ISSUE_NUMBER"; then
|
||||
echo ""
|
||||
echo "✅ Safe to create a new PR for issue #$ISSUE_NUMBER"
|
||||
|
||||
if [ -z "$BRANCH_NAME" ]; then
|
||||
TIMESTAMP=$(date +%s)
|
||||
BRANCH_NAME="fix/$ISSUE_NUMBER-$TIMESTAMP"
|
||||
echo "📝 Suggested branch name: $BRANCH_NAME"
|
||||
fi
|
||||
|
||||
echo ""
|
||||
echo "To create a PR:"
|
||||
echo " 1. Create branch: git checkout -b $BRANCH_NAME"
|
||||
echo " 2. Make your changes"
|
||||
echo " 3. Commit: git commit -m 'fix: Description (#$ISSUE_NUMBER)'"
|
||||
echo " 4. Push: git push -u origin $BRANCH_NAME"
|
||||
echo " 5. Create PR via API or web interface"
|
||||
else
|
||||
echo ""
|
||||
echo "❌ Cannot create new PR for issue #$ISSUE_NUMBER"
|
||||
echo " Existing PRs found. Review them first."
|
||||
exit 1
|
||||
fi
|
||||
Reference in New Issue
Block a user