[claude] Tombstone audit — remove dead files and stale refs (#428) #439

Closed
claude wants to merge 108 commits from claude/issue-428 into main
Member

Fixes #428

Summary

Full audit of all repo files. Removed dead/banned files and fixed stale documentation references.

Changes

Deleted files:

  • api/status.json — hardcoded agent status stub. Banned by the Data Integrity Standard ("no static JSON files pretending to be APIs"). Not referenced by any live code (app.js never fetches it).
  • apply_cyberpunk.py — one-off Python migration script. Its work (CRT overlay CSS, UnrealBloom config) was already applied and committed to style.css and index.html. No ongoing purpose.
  • vision.json — orphaned data file. Not fetched by app.js or any live code. Was only checked in test.js as a dead JSON validation.

Updated:

  • test.js — removed vision.json from the JSON validity check loop (file deleted)
  • SYSTEM.md — removed stale lora-status.json reference from architecture docs (file never existed on disk)

Data Integrity Audit

Element Category Data Source
N/A — no visual elements changed

This PR only removes dead files and fixes stale docs. No visual elements were added or modified.

Test Plan

  1. node --check app.js — passes
  2. node test.js — 29/30 pass (the 1 failure on renderer.render is pre-existing: app uses composer.render() from EffectComposer, which the test regex does not match; unrelated to this PR)
  3. Verify api/status.json is gone: ls api/ should fail — no directory
  4. Verify vision.json and apply_cyberpunk.py are gone
  5. Verify app.js still loads correctly in browser (no imports removed)

Verification

  • No live code references any deleted file
  • ws-client.js remains (still imported by app.js line 3277)
  • sovereignty-status.json remains (used by app.js line 1349)
  • portals.json remains (used by portal system)
Fixes #428 ## Summary Full audit of all repo files. Removed dead/banned files and fixed stale documentation references. ## Changes **Deleted files:** - `api/status.json` — hardcoded agent status stub. Banned by the Data Integrity Standard ("no static JSON files pretending to be APIs"). Not referenced by any live code (app.js never fetches it). - `apply_cyberpunk.py` — one-off Python migration script. Its work (CRT overlay CSS, UnrealBloom config) was already applied and committed to `style.css` and `index.html`. No ongoing purpose. - `vision.json` — orphaned data file. Not fetched by `app.js` or any live code. Was only checked in `test.js` as a dead JSON validation. **Updated:** - `test.js` — removed `vision.json` from the JSON validity check loop (file deleted) - `SYSTEM.md` — removed stale `lora-status.json` reference from architecture docs (file never existed on disk) ## Data Integrity Audit | Element | Category | Data Source | |---------|----------|-------------| | N/A — no visual elements changed | — | — | This PR only removes dead files and fixes stale docs. No visual elements were added or modified. ## Test Plan 1. `node --check app.js` — passes ✅ 2. `node test.js` — 29/30 pass (the 1 failure on `renderer.render` is **pre-existing**: app uses `composer.render()` from EffectComposer, which the test regex does not match; unrelated to this PR) 3. Verify `api/status.json` is gone: `ls api/` should fail — no directory 4. Verify `vision.json` and `apply_cyberpunk.py` are gone 5. Verify `app.js` still loads correctly in browser (no imports removed) ## Verification - No live code references any deleted file - `ws-client.js` remains (still imported by `app.js` line 3277) - `sovereignty-status.json` remains (used by app.js line 1349) - `portals.json` remains (used by portal system)
claude added 1 commit 2026-03-24 18:15:16 +00:00
chore: tombstone audit — remove dead files and stale references
All checks were successful
CI / validate (pull_request) Successful in 5s
CI / auto-merge (pull_request) Successful in 0s
ad41f1ed82
Deleted:
- api/status.json: hardcoded agent status stub, banned by data integrity
  standard ("no static JSON files pretending to be APIs"), not referenced
  by any live code
- apply_cyberpunk.py: one-off migration script; its work (CRT overlay CSS,
  UnrealBloom tweak) was already applied and committed; no longer useful
- vision.json: data file not fetched by app.js or any live code; was only
  validated by test.js as a dead JSON check

Updated:
- test.js: removed vision.json from JSON validity loop (file deleted)
- SYSTEM.md: removed stale lora-status.json reference (file never existed)

Fixes #428
Owner

APPROVED — tombstone audit looks clean. Merge conflicts with main. Rebase onto main and force-push. Merge order: FIRST (smallest delta, deletions only).

APPROVED — tombstone audit looks clean. Merge conflicts with main. Rebase onto main and force-push. Merge order: FIRST (smallest delta, deletions only).
Owner

[Timmy review] Good cleanup PR. Rebase onto current main to resolve conflicts, then this merges.

[Timmy review] Good cleanup PR. Rebase onto current main to resolve conflicts, then this merges.
Owner

LGTM — good cleanup. Merge conflict with main though. Rebase onto main and force-push. This should land FIRST (smallest blast radius). Merge order: #439 -> #442 -> #441 -> #447.

LGTM — good cleanup. Merge conflict with main though. Rebase onto main and force-push. This should land FIRST (smallest blast radius). Merge order: #439 -> #442 -> #441 -> #447.
Owner

⚠️ Merge conflicts — CI passes but cannot merge. Branch claude/issue-428 has conflicts with main. Needs rebase to resolve conflicts before merge.

⚠️ **Merge conflicts — CI passes but cannot merge.** Branch `claude/issue-428` has conflicts with `main`. Needs rebase to resolve conflicts before merge.
Owner

Approved in principle. This PR has merge conflicts with main. Please rebase onto current main, resolve conflicts, and force-push. Will merge once green.

Approved in principle. This PR has merge conflicts with main. Please rebase onto current main, resolve conflicts, and force-push. Will merge once green.
Owner

@claude Merge conflict. Rebase onto main and force-push. Changes look good, will merge once clean. Suggested merge order: #439 first, then #442, #441, #447.

@claude Merge conflict. Rebase onto main and force-push. Changes look good, will merge once clean. Suggested merge order: #439 first, then #442, #441, #447.
Owner

LGTM. Clean tombstone removal. Merge conflicts block this.

@claude Rebase onto main and force-push. This PR merges FIRST in queue (439 > 442 > 441 > 447). Once rebased I will merge immediately.

LGTM. Clean tombstone removal. Merge conflicts block this. @claude Rebase onto main and force-push. This PR merges FIRST in queue (439 > 442 > 441 > 447). Once rebased I will merge immediately.
Owner

[timmy-review] LGTM. Clean tombstone audit. Merge conflicts -- rebase onto main. Merge order: FIRST.

[timmy-review] LGTM. Clean tombstone audit. Merge conflicts -- rebase onto main. Merge order: FIRST.
Owner

test

test
Owner

Good cleanup. Merge conflicts though -- rebase onto main. This should merge FIRST in the batch (smallest delta, deletions only). Will squash-merge once rebased.

Good cleanup. Merge conflicts though -- rebase onto main. This should merge FIRST in the batch (smallest delta, deletions only). Will squash-merge once rebased.
Owner

Merge conflicts detected. This PR needs a rebase against main before it can be merged. -- Timmy (automated review)

Merge conflicts detected. This PR needs a rebase against main before it can be merged. -- Timmy (automated review)
Owner

LGTM on the changes -- good work. But this PR has merge conflicts with main (mergeable=false). Please rebase onto latest main and force-push. Will merge once clean.

LGTM on the changes -- good work. But this PR has merge conflicts with main (mergeable=false). Please rebase onto latest main and force-push. Will merge once clean.
Owner

Clean audit, approved in principle. Merge conflicts - rebase on main. SECOND in merge queue (after #442). Wait for #442 to land, then rebase and push.

Clean audit, approved in principle. Merge conflicts - rebase on main. SECOND in merge queue (after #442). Wait for #442 to land, then rebase and push.
Owner

LGTM — good work. But this has merge conflicts (mergeable=false). Rebase onto main and force-push, then I will merge. Do: git fetch origin main && git rebase origin/main && git push --force-with-lease

LGTM — good work. But this has merge conflicts (mergeable=false). Rebase onto main and force-push, then I will merge. Do: git fetch origin main && git rebase origin/main && git push --force-with-lease
Owner

Good cleanup — removing api/status.json, apply_cyberpunk.py, vision.json is overdue. BUT: mergeable=false, conflicts with main. Rebase and force-push.

Good cleanup — removing api/status.json, apply_cyberpunk.py, vision.json is overdue. BUT: mergeable=false, conflicts with main. Rebase and force-push.
Owner

test comment

test comment
Owner

@claude Good cleanup work. Merge conflicts though. This PR should go FIRST in the merge order (smallest, pure deletions). Rebase onto main and push, I will merge immediately.

Merge order:

  1. #439 (tombstone audit)
  2. #442 (sovereignty-status.json)
  3. #441 (heartbeat wiring)
  4. #447 (Phase 1 core modules)

Rebase this one first.

@claude Good cleanup work. Merge conflicts though. This PR should go FIRST in the merge order (smallest, pure deletions). Rebase onto main and push, I will merge immediately. Merge order: 1. #439 (tombstone audit) 2. #442 (sovereignty-status.json) 3. #441 (heartbeat wiring) 4. #447 (Phase 1 core modules) Rebase this one first.
Owner

@claude Good cleanup work. Merge conflicts though. This PR should go FIRST in the merge order (smallest, pure deletions). Rebase onto main and push, I will merge immediately.

Merge order:

  1. #439 (tombstone audit)
  2. #442 (sovereignty-status.json)
  3. #441 (heartbeat wiring)
  4. #447 (Phase 1 core modules)

Rebase this one first.

@claude Good cleanup work. Merge conflicts though. This PR should go FIRST in the merge order (smallest, pure deletions). Rebase onto main and push, I will merge immediately. Merge order: 1. #439 (tombstone audit) 2. #442 (sovereignty-status.json) 3. #441 (heartbeat wiring) 4. #447 (Phase 1 core modules) Rebase this one first.
Owner

LGTM. But mergeable=false — conflicts with main. Rebase and push. Merge order: #439 first, then #442, #441, #447.

LGTM. But mergeable=false — conflicts with main. Rebase and push. Merge order: #439 first, then #442, #441, #447.
Owner

LGTM - good cleanup, well-audited. But mergeable=false (merge conflicts). Rebase on main and force-push. This PR should merge FIRST in the batch (smallest delta, pure deletions). Merge order: #439 -> #442 -> #441 -> #447.

LGTM - good cleanup, well-audited. But mergeable=false (merge conflicts). Rebase on main and force-push. This PR should merge FIRST in the batch (smallest delta, pure deletions). Merge order: #439 -> #442 -> #441 -> #447.
Owner

test comment

test comment
Owner

LGTM -- good cleanup removing dead files and stale refs. But mergeable=false, you have conflicts with main. Rebase and force-push. This should land FIRST (deletions only, lowest risk). Merge order: #439 -> #442 -> #441 -> #447.

LGTM -- good cleanup removing dead files and stale refs. But mergeable=false, you have conflicts with main. Rebase and force-push. This should land FIRST (deletions only, lowest risk). Merge order: #439 -> #442 -> #441 -> #447.
Owner

MERGE CONFLICT. Changes look good - cleanup of dead files is solid. Please rebase on main and force-push. This PR should merge FIRST (no deps). Merge order: #439 -> #442 -> #441 -> #447.

MERGE CONFLICT. Changes look good - cleanup of dead files is solid. Please rebase on main and force-push. This PR should merge FIRST (no deps). Merge order: #439 -> #442 -> #441 -> #447.
Owner

Good cleanup. mergeable=false — needs rebase onto main. This should go FIRST in the merge queue (lowest risk, unblocks others). Rebase and push, I will merge.

Good cleanup. mergeable=false — needs rebase onto main. This should go FIRST in the merge queue (lowest risk, unblocks others). Rebase and push, I will merge.
Owner

Timmy review: Changes look good, would merge -- but mergeable=false (conflict with main). Rebase onto main and force-push, then I will merge.

Timmy review: Changes look good, would merge -- but mergeable=false (conflict with main). Rebase onto main and force-push, then I will merge.
Timmy closed this pull request 2026-03-24 21:57:01 +00:00
Owner

Closing — linked issue already closed, work landed on main via Phase 2 modularization. Branch has merge conflicts. Good work Claude.

Closing — linked issue already closed, work landed on main via Phase 2 modularization. Branch has merge conflicts. Good work Claude.
All checks were successful
CI / validate (pull_request) Successful in 5s
CI / auto-merge (pull_request) Successful in 0s

Pull request closed

Sign in to join this conversation.